Re: [webkit-dev] Webkit port to ppc64le.

2017-02-22 Thread Atul Sowani
Sure, thanks @Konstantin. So I will first attempt having working JIT on ppc64le. Your comments definitely helped in deciding the direction for porting. Thanks! :) On Wed, Feb 22, 2017 at 8:28 PM, Konstantin Tokarev wrote: > > > 22.02.2017, 17:41, "Atul Sowani" : > &

Re: [webkit-dev] Webkit port to ppc64le.

2017-02-22 Thread Atul Sowani
So, essentially, some tweaking in the code of LLInt/interpreter _is_ required when porting it to the new platform. Is my understanding correct? On Wed, Feb 22, 2017 at 4:11 PM, Konstantin Tokarev wrote: > > > 22.02.2017, 13:15, "Atul Sowani" : > > Hi, > >

[webkit-dev] Webkit port to ppc64le.

2017-02-22 Thread Atul Sowani
Hi, This is not specific to any particular branch/version of WebKit. I was browsing the code with ppc64le porting in mind. By default JIT is not available on ppc64le, so the CLoop code is used instead. I see there is low level interpreter code in qtwebkit/Source/JavaScriptCore/llint directory and

Re: [webkit-dev] CSS Parse error in element.

2017-02-21 Thread Atul Sowani
I compared the code of TP5 with the code of default qtwebkit in PhantomJS and did not find any difference. So I think PhantomJS is making use of the latest version of QtWebKit. On Fri, Feb 17, 2017 at 4:04 PM, Konstantin Tokarev wrote: > > > 17.02.2017, 12:19, "Atul Sowani"

Re: [webkit-dev] CSS Parse error in element.

2017-02-17 Thread Atul Sowani
maintainer (and timer) code - which crashes on ppc64le. On Wed, Feb 15, 2017 at 2:18 PM, Konstantin Tokarev wrote: > > > 15.02.2017, 11:40, "Atul Sowani" : > > Hi, > > I am wondering about the behavioural difference of the same code on two > different platforms,

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Atul Sowani
ead model: posix gcc version 5.4.0 20160609 (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4) On Mon, Feb 13, 2017 at 4:26 PM, Atul Sowani wrote: > @Konstantin Thanks for the update and it is definitely relieving to know > that those were known issues and have been fixed in later version of > QtWebKit

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
:41 PM, Konstantin Tokarev wrote: > > > 13.02.2017, 11:52, "Atul Sowani" : > > I am using Qt 5.5.1. > > It ships with obsolete WebKit version based on trunk from 2013. Indeed it > is known to have assertion failures related to calc like those you've >

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
modified it as height:calc(~"100vh - 200px") This seems to be working. So my question is, whether CSS parser is supposed to handle the faulty case or the CSS source should be fixed always? Thanks, Atul. On Mon, Feb 13, 2017 at 2:21 PM, Atul Sowani wrote: > I am using Qt 5.5.1. >

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
I am using Qt 5.5.1. On Thu, Feb 9, 2017 at 10:15 PM, Simon Fraser wrote: > What WebKit revision are your sources based on? It's quite likely the this > bug has been fixed. > > Simon > > On Feb 9, 2017, at 4:09 AM, Atul Sowani wrote: > > Finally I zeroed in on

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Atul Sowani
lid one? Best regards, Atul. On Thu, Feb 9, 2017 at 2:17 PM, Atul Sowani wrote: > @Konstantin thanks for the suggestions. I disabled CSS JIT on x85 but > there was no negative impact on the results on x86. So I guess the issue is > a genuine ppc64le problem. I have picked up the starting

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Atul Sowani
to a single CSS file which is causing the problem. Now I am trying to isolate the exact entry in the CSS file which is causing the trouble. Thanks! Atul. On Tue, Feb 7, 2017 at 3:53 PM, Konstantin Tokarev wrote: > > > 07.02.2017, 12:55, "Atul Sowani" : > > Thanks Geo

Re: [webkit-dev] CSS Parse error in element.

2017-02-07 Thread Atul Sowani
av > > On Fri, Feb 3, 2017 at 9:19 PM Alex Christensen > wrote: > >> I would start looking at HTMLLinkElement::parseAttribute. >> LinkHeader.cpp contains parsers for link headers, which are related. >> Yoav knows more about those. Those parsers ought to be united more

Re: [webkit-dev] CSS Parse error in element.

2017-02-03 Thread Atul Sowani
, 2017 at 2:33 PM, Atul Sowani wrote: > Hi, > > I came across an issue in qtwebkit CSS parser while working on a PhantomJS > crash. The issue seems to be with parsing of > type elements in an HTML page. What I observed is that the parser is trying > to interpret the value for

[webkit-dev] CSS Parse error in element.

2017-02-03 Thread Atul Sowani
Hi, I came across an issue in qtwebkit CSS parser while working on a PhantomJS crash. The issue seems to be with parsing of type elements in an HTML page. What I observed is that the parser is trying to interpret the value for href given inside double-quotes. The value contains a "-" (e.g. "http:

Re: [webkit-dev] Webkit JavaScript interpreter crash (v. 153112/ppc64le).

2015-10-27 Thread Atul Sowani
ting for ppc64le? On Tue, Oct 27, 2015 at 10:48 AM, Atul Sowani wrote: > Hi Ryosuke, > > Thanks for the JSC_useJIT option, I was not aware of it. I will try to use > webkit with JSC_useJIT=0 option. However, I am doubtful if I can replace > existing webkit used in PhantomJS with the l

Re: [webkit-dev] Webkit JavaScript interpreter crash (v. 153112/ppc64le).

2015-10-26 Thread Atul Sowani
check both these options now (env. var and feasibility of using new webkit version) and will update this forum with my findings. Thanks, Atul. From: Ryosuke Niwa To: Atul Sowani/Beaverton/Contr/IBM@IBMUS Cc: "webkit-dev@lists.webkit.org" Date: 10/26/2015 07:15 PM Subject:

[webkit-dev] Webkit JavaScript interpreter crash (v. 153112/ppc64le).

2015-10-26 Thread Atul Sowani
Hi, I am trying to port PhantomJS 2.0.1 to IBM PPC64LE platform. PhantomJS uses qtwebkit version 153112 and I am facing a few crashes in the JavaScript interpreter code. I was directed to this forum by PhantomJS developers to get help/insight about the interpreter. Requesting this forum admins