Re: [webkit-dev] Git meeting notes
On Apr 12, 2010, at 2:19 PM, William Siegrist wrote: On Apr 12, 2010, at 1:59 PM, Benjamin wrote: - Server side there is a trac plugin we can use and sounded like there wasn't I'm not sure what the last half of the above was supposed to say, but yes, there is git support for Trac. You can see it on Buildbot's trac: http://buildbot.net/trac/timeline Woops yah that was a half written sentence. Server side there is a trac plugin we can use. From the discussions it sounded like there wasn't any server side major issues. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Git meeting notes
On Apr 12, 2010, at 6:28 PM, Alexey Proskuryakov wrote: One thing that wasn't mentioned at the meeting is that git doesn't seem to have the same monotonously increasing revision numbers as svn does. It will be a problem to replace REGRESSION(r12345) with REGRESSION(96c3b0300ccf16b64efc260c21c85ba9030f2e3a). Can you clarify what you mean? Do you mean we have tools that expect a number and not a sha or something else? Similarly, it would be hard to tell if a given nightly build includes changes made in a certain commit. Each nightly would have a sha so you could list all of the sha's between the two and grep for the one you are looking for git rev-list yesterday_sha..today_sha | grep certain_sha Or more similar to svn would be to count the commits in the sha to get the increasing revision number. Each daily could include this number and so you could count the number that certain_sha would be to see if it was between yesterday and today. git rev-list sha | wc -l -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Git Familiarity (was ChangeLog)
However, not everyone on the project is comfortable with git (or is willing to give up svn), so I don't see a near-term solution at the moment other than improving the existing tools (prepare-ChangeLog, resolve-ChangeLogs, etc.). I have heard this for about a year and presumable it has gone down over the year so I am curious what percentage of developers use Git or more importantly don't know git today. Both Nokia and TorchMobile use Git completely. Gnome has switch to Git earlier this year so presumably the Gtk developers know Git (correct me if I am wrong). Can someone from Apple and Google comment on how much Git usage you guys have? I am curious how close (or far away) we are to a tipping point where most of the devs know or are familiar with Git. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Git Familiarity (was ChangeLog)
On Jul 5, 2009, at 9:00 PM, Justin Haygood wrote: - Original Message - From: Maciej Stachowiak m...@apple.com To: Benjamin Meyer b...@meyerhome.net Cc: WebKit Development webkit-dev@lists.webkit.org Sent: Sunday, July 05, 2009 8:15 PM Subject: Re: [webkit-dev] Git Familiarity (was ChangeLog) I think at some point we need to consider a change in version control system. I would like us to work on the bug tracker and patch review system first, to avoid making too many tools changes at once, and because that issue seems to be more urgent and disruptive of workflow. I'm whipping up an email on what I think are the right short-term and medium-term steps. Once we have that well in hand, then revision control and build system would probably be the next things to review for change. The one thing bad about git is for people who don't use a *nix: Subversion works quite well on Windows, including powerful GUI tools. Git just isn't the same. (For one, it won't work without Cygwin. I can currently build WebKit/Qt without having Cygwin anywhere near my computer). I'm not familiar with other DVCS, but until one has good Windows support, that would rule out a portion of developers. At least on Windows I use mysygit myself (http://code.google.com/p/msysgit/ ) From the project description: Historically, Git on Windows was only officially supported using Cygwin. To help make a native Windows version, this project was started, based on the fork. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Changes to prepare-ChangeLog
On Jul 2, 2009, at 4:07 AM, Mike Hommey wrote: On Thu, Jul 02, 2009 at 01:01:09AM -0700, Adam Barth aba...@webkit.org wrote: On Thu, Jul 2, 2009 at 12:50 AM, Mike Hommeymh +web...@glandium.org wrote: I've always wondered, in the days of atomic commits and advanced SCM, why fill changelogs at all ? Except for CVS, RCS or SCCS, any SCM already stores the log of changes. Keeping a Changelog in the SCM is both a duplication of information and a stick to beat yourself when you cherry-pick or revert changes, or merge branches. When I've ask similar questions in the past, I've been told: 1) Changelogs are easier to search / archive / fix up than commit log messages. For search and archive, nothing prevents you to generate ChangeLogs for that purpose. 2) We can review the Changelog messages using bugzilla's review system, but it's harder to review the commit log message. Not if the patch contains the commit message in its header, like git or mercurial do. Creating a script for svn, if it doesn't already exist, wouldn't be too hard, too. Indeed, I never manually fill in a changelog and always use the script to autofill it from my git patch. This means that everything in the changelog (at least for me) is a duplicate of what is already in the rcs which is a violation of the DRY principle. If we ever move off svn I will propose that we should no longer maintain the changelog. It is duplicated information and causes update/merge errors/hassle. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit / Qt
You can build with the latest Qt and with WebKit trunk. The Arora browser supports this configuration and more details about it can be found here: http://code.google.com/p/arora/wiki/source?tm=4 In particular checkout the webkittrunk.pri file in the source repository for the specifics of what is turned on/off to get it to work. -Benjamin Meyer On Feb 28, 2009, at 11:07 AM, Husam Senussi wrote: Hi, I'm not sure if this question for this group if not I do apologies. I build application with Qt WebKit and notice -webkit-box-shadow doesn't work, I can only assume the snapshot included in latest version 4.5 (last night snapshot) of Qt doesn't have -webkit-box-shadow. If thats the case would it be possible to use WebKit instead of one include in Qt, or do I have to wait for Qt guy to take recent copy of WebKit. Thanks___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Plugin is showing but not working on Webkit even its working on firefox
Are you using the Qt, Gtk or Chromium port? -Benjamin Meyer On Jan 14, 2009, at 6:39 AM, Ajay Gautam wrote: Hi All, I have doubt regarding plug-in on WebKit Browser for Linux. i am developing a sample plug-in using Netscape based API's which i tried on Webkit. But i am facing an issue when i try to execute the plug-in object in the html page which calls the native function in C++. The error is: Type Error: Result of Expression 'embed.Close()' is not a function. Here the embed.Close() calls the native code function close(). Please suggest a way to solve this particular error. NB: The same plug-in is working on Mozilla browser. Thanx Regards Ajay ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Licenses for WebKit contributions
On Jan 7, 2009, at 5:13 PM, Sam Weinig wrote: I just noticed several patches have put up for review that contain new files using the Apache license. Current WebKit policy is that code should be licensed under either a BSD license or GNU Lesser General Public License v.2.1 (mentioned explicitly when submitting patches on bugs.webkit.org). In order to change this policy, we would need to have a larger discussion as this is not a decision that can be made by any one person. If you have submitted a patch recently that is under another license, please consider re-submitting it with either of the two allowed licenses as we cannot land them as they are. I am sorry we did not notice this sooner. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev Shouldn't patches like this be reverted immediately upon notice and then having a discussion rather then the other way around? Has it been reverted or the license changed yet? -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Doubts on QNetworkAccessManager
On Nov 3, 2008, at 11:34 AM, André Pedralho wrote: Hi all, I'm using the new QNetworkAccessManager to set my QtWebkit browser cache system and realized that I can have more than one QWebPage loaded and then (I guess) more than one QNetworkAccessManager as well. What happens when I call, for example, something like page[1].networkAccessManager().cache().clear() ? That cache object that the network access manager has a pointer to is cleared. Will it clear all the cache or just the cache related the page[1]? The default NetworkCache objects do not know about each other so only one cache object is cleared. Wouldn't be better to have this kind of functionalities in the QWebView class? Maybe something like QWebSettings. Actually, IMHO we could have access to the cache settings from QWebSettings. QWebSettings is for settings, not to hold cache objects Is there any other way to clear the cache? Using the clear function on the cache is the proper way. What you are probably looking for is to share the same network access manager with all your pages. Then you only have one cache. For an example of this checkout the source code for Arora. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Webkit on Windows
I have searched this list and read the webkit.org documentation, and I just can't tell what is really possible. I know that Apple hasn't made Webkit generally available for Windows. There seems to be a Windows port using Cairo, etc., but there's no information on using it or what capabilities it supports. There is a QT port, but it's not clear that I can do what I need to do with it. There are others... Can anyone clarify this for me? I would really appreciate it. At least with the Qt port you can use QWebPage::acceptnavigationRequest and QNetworkAccessManager (http://doc.trolltech.com/4.4/qwebpage.html#acceptNavigationRequest ) to get each url and loading of data from memory (Arora loads some pages from qrc for example). The API could make it easier to do this in the future, but I think you can do it today. If you want to mess around with some code checkout Arora's codebase (arora-browser.org). The code is small and easy enough to poke around in. It should give you a feeling for what the Qt port can do and if it is good enough. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Content sniffing in WebCore
On Oct 9, 2008, at 1:38 PM, Adam Barth wrote: Currently, every WebKit port has to implement its own content sniffing algorithm. This is problematic for compatibility and security. We should implement a content sniffing algorithm in WebCore so that it can be used by every port. Yah! I was a bit surprised myself when I discovered that the browsers would sniff to such an extent and that each browser was implementing this differently. This will be a good addition to WebKit. For example, Safari and Chromium each implement their own content sniffing algorithm and I imagine (although I haven't tested) that other ports do so as well. QtWebKit doesn't have any content sniffing and so Arora also has its own crude ContentType handling. Feedback I'm sending this email to the list to get buy-in from the rest of the WebKit community on the general direction of implementing a content sniffer. I only speak for myself and not QtWebKit, but I think this is a good move for something that can be moved into WebKit. http://src.chromium.org/viewvc/chrome/trunk/src/net/base/mime_sniffer.cc?view=markup The top of that file has some comments that explain some of the guiding design choices in the algorithm and a comparison with the behavior of some other browsers. For what it is worth with Konq with its KParts system will follow the content type and just load a a text editor in the browser if there is no content-type for example. -Benjamin Meyer ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] flash player on Linux?
On Tuesday 08 July 2008 08:39:23 leslie lige wrote: Hi all, is it possible to play flash in a webkit browser under x86-Linux ? how to do that? I'm trying to use Qt 4.4.0 's demo browser, but I can't find any suitable flashplayer plugin for it. thanks with regards, Leslie Qt 4.4.0 doesn't contain support for flash, To get flash support with Qt you have to either wait for Qt 4.5 or you can use webkit trunk. The flash support in trunk is still ongoing development and not finished. An example of using webkit trunk with Qt 4.4 can be found on the Arora wiki page (and in the arora source's) http://code.google.com/p/arora/wiki/source?tm=4 -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] how to build arora with latest qtwebkit
On Tuesday 08 July 2008 11:48:22 Ye Xu wrote: hi all, sorry, this question may unrelated with webkit dev, and I had asked a similar question on arora's google group, but no body answer me. so I will try to ask it here. Hmm, I replied there, but my e-mail still hasn't posted to the mailinglist... odd at the following page, http://code.google.com/p/arora/wiki/source?tm=4 there is one short description at the bottom to tell us how to build arora with the latest webkit trunk. but I just can't get the idea $ export QT_WEBKIT=webkit_trunk $ export WEBKITHOME=/path/to/webkit what the WEBKITHOME constant should be, can somebody give me an example path, where I shall point it to, maybe the webkit lib path like /usr/ lib/ or something else ? For example I have my webkit checked out in /home/ben/dev/webkit so I point it to that location. and for constant QT_WEBKIT I shall simply point it to the webkit trunk/tarball source path, like /home/username/webkit-tarball/compilewebkithere, if I had compiled webkit at that path, right? Nope, QT_WEBKIT you simply set to 'webkit_trunk', it is a flag for qmake. You could probably merge these two defines into 1, but I wasn't sure how using qmake. You can check out the src/webkittrunk.pri in Arora for the exact details of how they are used. -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] how to build arora with latest qtwebkit
On Tuesday 08 July 2008 16:26:27 Ye Xu wrote: If you run ldd arora it will tell you which library Arora is linked against. get into the arora building path ldd arora give back the following output, it seems that it still use the system libs, so how can I solve the problem? maybe manuelly replace that /usr/lib/libqtwebkit.so.4 with the trunk compiled version? [EMAIL PROTECTED]:~/build/arora$ ldd arora linux-vdso.so.1 = (0x7fff133fe000) *libQtWebKit.so.4 = /usr/lib/libQtWebKit.so.4 (0x7f460a4c7000)* Looks like it is still using the old Makefile. Run 'make distclean' and then qmake (qmake-qt4 on Debian) and then make. You shouldn't need to replace the system libraries. -Benjamin Meyer P.S. You can join the arora room on irc.freenode for faster question turnaround :) signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Clarification on developing an embedded browser in PPCplatform
On Thursday 03 July 2008 04:47:13 [EMAIL PROTECTED] wrote: please visit the project: http://sourceforge.net/projects/safarimobile/ We had pasted a lot of HTML4/CSS compatible tests,we are fixing the JavaScript and NAPI feature. It can display normal HTML page now. We wish you can join the team with us. wormwang Did apply have any problem with you using the Safari name? -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Clarification on developing an embedded browser in PPCplatform
On Thursday 03 July 2008 12:35:18 Benjamin Meyer wrote: On Thursday 03 July 2008 04:47:13 [EMAIL PROTECTED] wrote: please visit the project: http://sourceforge.net/projects/safarimobile/ We had pasted a lot of HTML4/CSS compatible tests,we are fixing the JavaScript and NAPI feature. It can display normal HTML page now. We wish you can join the team with us. wormwang Did apply have any problem with you using the Safari name? bah ^Apple^ -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Where does WebKit end and Safari begin on Windows?
I ask because I have tried both Adobe Air's WebKit port and the latest QT QWebView widget and I just don't see the same results - they are both good, but not nearly as smooth and pretty. Why is Safari so much better, and is there any way to get that Safari experience in locked down fullscreen mode? Hi there, would you be able to share your testing methodoligy so that hopefully the problem can be found and improved? When you say you tested the latest Qt QWebView was that the one in webkit trunk or the one that was in the Qt 4.4rc1 release? -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] NPAPI Support
On Wednesday 19 March 2008 14:04:32 Nitin Mahajan wrote: Hello! Is there an NPAPI support on qt platform already implemented and whether Mozilla mplayer-plugin should work straightaway? Thanking in advance regards regards -Nitin Netscape plugin support isn't in the current Qt platform code and wont be added until Qt 4.5. -Benjamin Meyer signature.asc Description: This is a digitally signed message part. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
