Re: [webkit-dev] Plugin process

2020-07-19 Thread Brent Fulgham
We haven’t removed it from Apple builds yet, because we think there are still some WebKit clients that use them. I.e., WebKit framework users on the platform that are not Safari or one of the other web browsers. We should take another look, because it would be great to get rid of it

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Brent Fulgham
Please note that Per Arne updated the Apple ZIP files to have the correctly aligned ICU libraries, so the Windows bots should have what they need. I apologize for taking so long to complete that. Thanks, -Brent > On Apr 3, 2020, at 4:57 PM, Ryosuke Niwa wrote: > > > On Fri, Apr 3, 2020 at

Re: [webkit-dev] Proposal: add Privacy to WebKit Project Goals

2020-02-24 Thread Brent Fulgham
I think this looks great! -Brent > On Feb 23, 2020, at 5:02 PM, Maciej Stachowiak wrote: > > > V2, with stronger privacy language. > > > project-new.html > WebKit is an open source Web content engine for browsers and other > applications. > 1212 > 1313 > 14 We value real-world web

Re: [webkit-dev] Proposal: add Privacy to WebKit Project Goals

2020-02-16 Thread Brent Fulgham
> On Feb 16, 2020, at 12:39 PM, Maciej Stachowiak wrote: > > > There hasn’t been any feedback on this, so below is a proposed change (in > PrettyPatch HTML format) to >. > > In addition to adding Privacy as a goal, I also added

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Brent Fulgham
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. -Brent > On Jun 24, 2019, at 8:21 PM, Fujii Hironori wrote: > > Hi, > > I'm going to bump cmake_minimum_required version to 3.10 for > shining new

Re: [webkit-dev] New iOS versions sending bogus User-Agent build data

2018-04-27 Thread Brent Fulgham
Hi Colin, > On Apr 26, 2018, at 8:57 AM, Colin Bendell | +1.613.914.3387 > wrote: > > […] images to a device. I have a laundry list of other examples where the > server might actually know more than the client to prevent a) a broken > user experience and b) prevent cellular

Re: [webkit-dev] HSTS user tracking

2018-03-01 Thread Brent Fulgham
Sure — I’ll ask Jon to get it scheduled to post. > On Mar 1, 2018, at 11:50 AM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Mar 1, 2018, at 10:44 AM, Michael Catanzaro <mcatanz...@igalia.com> wrote: >> >> On Fri, Jan 5, 2018 at 3:11 PM

Re: [webkit-dev] HSTS user tracking

2018-01-05 Thread Brent Fulgham
together a blog-worthy document fast enough. Thanks, -Brent > On Jan 5, 2018, at 12:58 PM, Maciej Stachowiak <m...@apple.com> wrote: > > > Brent Fulgham or John Wilander would know the details. > > - Maciej > >> On Jan 5, 2018, at 8:04 AM, Michael Catanz

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

2016-11-04 Thread Brent Fulgham
EWS Hates your patch! :-) > On Nov 4, 2016, at 10:01 AM, Filip Pizlo wrote: > > Hi everyone! > > That last time we talked about this, there seemed to be a lot of agreement > that we should go with the Seconds/MonotonicTime/WallTime approach. > > I have implemented it:

Re: [webkit-dev] WebKit GPU rendering possibility

2016-11-03 Thread Brent Fulgham
I would suggest “http://browserbench.org/MotionMark ”. :-) -Brent > On Nov 3, 2016, at 12:17 PM, Rogovin, Kevin wrote: > > Hi, > > What are some good 2D UI graphics benchmarks that are cross-platform-ish? I'd > think I need to

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-10-30 Thread Brent Fulgham
I strongly support the proposal to remove this API. -Brent > On Oct 30, 2016, at 5:54 PM, Simon Fraser wrote: > > I support the proposal to remove. > > Simon > >> On Oct 30, 2016, at 5:14 PM, Brady Eidson wrote: >> >> >> There's code in the tree

Re: [webkit-dev] WinCairo Maintainers

2016-09-26 Thread Brent Fulgham
> On Sep 26, 2016, at 12:55 PM, Olmstead, Don wrote: > > @annulen I know you've mentioned conan.io before but I've never personally > used it so I'm not sure how well it would fit with everything. It's something > we can take a look at beforehand and see what it would

Re: [webkit-dev] MathML refactoring: Project Complete!

2016-07-13 Thread Brent Fulgham
Thank you for all of this work, Frédéric! I don’t think our WebML rendering has ever looked so good! :-) -Brent > On Jul 13, 2016, at 10:22 AM, Frédéric WANG wrote: > > Hi WebKit developers, > > We are happy to announce that we are done with the MathML refactoring >

[webkit-dev] Windows Bot Updates

2016-05-03 Thread Brent Fulgham
Hi Everyone, I have just reviewed the full set of Windows EWS and build bots, and updated them as follows: 1. Perl 5.18 or newer, which matches the Perl shipped with Mac OS. 2. Visual Studio 2015, Update 2. This fixes a number of C++ compatibility issues. At this point, it should not be

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
the build passes after rolling out a patch, thus > making EWS think that the patch is to blame. > > - Alexey > > > >> 30 марта 2016 г., в 9:20, Brent Fulgham <bfulg...@apple.com> написал(а): >> >> Aside from ews206 being offline for some reason, all bot see

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
> On Mar 30, 2016, at 9:04 AM, Brent Fulgham <bfulg...@apple.com> wrote: > > Looking now. > > -Brent > >> On Mar 30, 2016, at 9:02 AM, Darin Adler <da...@apple.com> wrote: >> >> Every patch I look at has a red bubble for Windows on EWS. Is som

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
Looking now. -Brent > On Mar 30, 2016, at 9:02 AM, Darin Adler wrote: > > Every patch I look at has a red bubble for Windows on EWS. Is someone > planning on fixing this? > > — Darin > ___ > webkit-dev mailing list >

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Brent Fulgham
> On Mar 9, 2016, at 5:27 PM, Anders Carlsson wrote: > > I propose that we instead start using > > #pragma once +1 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Brent Fulgham
+1. I am in favor of this as well! -Brent > On Mar 3, 2016, at 11:23 AM, Saam barati wrote: > > +1. > I like how “override” only reads. > > Saam > >> On Mar 3, 2016, at 9:54 AM, Ryosuke Niwa wrote: >> >> I think "virtual" + "override" is more of a

[webkit-dev] Crash Traces on Windows Now Functional

2015-10-15 Thread Brent Fulgham
Hi Folks! Our Windows test bots have long been unable to produce usable stack traces when crashes were encountered. I’m pleased to announce that I finally fixed this problem. Now that this is working, I would appreciate your help: 1. Please let me know if you see crashes happening on Windows,

Re: [webkit-dev] CMake on Windows

2015-09-29 Thread Brent Fulgham
om > <mailto:mital.d.v...@gmail.com>> a écrit : > Great job guys ! > > On Sep 29, 2015 4:31 AM, "Brent Fulgham" <bfulg...@apple.com > <mailto:bfulg...@apple.com>> wrote: > Yes — this is great work! > > We’re still working through a few ro

Re: [webkit-dev] CMake on Windows

2015-09-28 Thread Brent Fulgham
Yes — this is great work! We’re still working through a few rough edges, but very soon we can get rid of the whole Windows-specific build cruft, which will be a happy day. Thanks, -Brent > On Sep 28, 2015, at 3:03 PM, Michael Catanzaro wrote: > > On Mon, 2015-09-28 at

Re: [webkit-dev] WinCairo Stability

2015-08-21 Thread Brent Fulgham
Alex Christensen does keep the WinCairo port up and running, and we have a build bot that tracks that. Unfortunately, we don’t have an active WinCairo test bot, so it’s not always possible to know when something is broken in a subtle way on that port. Please let us know what you find out!

[webkit-dev] Windows Build Now on VS2015

2015-08-11 Thread Brent Fulgham
Hi Floks, We’ve finished updating the various Windows builds to VS2015. Full regression tests are now completing on these new builds, and seem to be comparable in terms of stability and correctness. Please let me know if you encounter any new issues on Windows. I know that EA encountered some

[webkit-dev] Migrating to Visual Studio 2015

2015-08-06 Thread Brent Fulgham
Hi Everyone, Now that Visual Studio 2015 Express is available for download, I would like to migrate our Windows builds over to the new compiler. This will allow us to start taking advantage of more C++14 features, as well as allowing us to remove a number of workarounds we’ve held in our code

Re: [webkit-dev] border-radius lost when applying -webkit-filter

2015-07-30 Thread Brent Fulgham
I'll see if I can reproduce this using our Apple Windows port, which also uses GraphicsLayerCA, though one based on Windows graphics primitives. The WinCairo compositor is based on the OpenGL ES backend, via the ANGLE library. Alex Christensen knows more about how that works. Thanks, -Brent

Re: [webkit-dev] Compilation issue with VS2015RC

2015-07-10 Thread Brent Fulgham
Hi Chris, We noticed the same thing. Please see https://bugs.webkit.org/show_bug.cgi?id=146579, where we are discussing how to move forward. Thanks! -Brent On Jul 10, 2015, at 4:05 PM, Vienneau, Christopher cvienn...@ea.com wrote: Hello, Recently we’ve been attempting to move our

Re: [webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Brent Fulgham
?  Brent Fulgham - Apple Inc. On Apr 1, 2015, at 2:26 PM, Maciej Stachowiak m...@apple.com wrote: Is it possible to make EWS start processing changes more promptly? On Apr 1, 2015, at 12:42 PM, Brent Fulgham bfulg...@apple.com wrote: Hi Everyone, We lost Windows EWS coverage

[webkit-dev] Please be careful with webkitpy changes!

2015-04-01 Thread Brent Fulgham
Hi Everyone, We lost Windows EWS coverage for the past 36 hours due to a very benign-appearing change to some webkitpy code. I haven’t yet figured out why this particular set of changes caused the Windows bots to start failing, but it has to do with various differences between the Cygwin

Re: [webkit-dev] Modern image formats for WebKit

2015-03-20 Thread Brent Fulgham
On Mar 20, 2015, at 2:39 PM, Darin Adler da...@apple.com wrote: Dave Hyatt originally created this when we first were planning the Apple Windows port of WebKit, but in the end we chose to not use them for the Windows port. They aren’t used in the Windows port nor in the Mac or iOS

Re: [webkit-dev] WorkQueue for Windows?

2015-03-07 Thread Brent Fulgham
Hi Antti, Take a look at https://bugs.webkit.org/show_bug.cgi?id=142432. I haven't landed this yet, because I was hoping to get some kind of test for this. However, it seems to introduce no problems, so we could go ahead and land it. Question: why do we have a separate WorkQueue implementation

Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard

2015-02-27 Thread Brent Fulgham
was pushed back on the my priority list. Thus, I agree to remove this feature if nobody(including me) submits meaningful patch until July 17th. Gyuyoung. On Wed, Jul 3, 2013 at 3:05 AM, Brent Fulgham bfulg...@apple.com mailto:bfulg...@apple.com wrote: Hi Everyone, I haven't seen

[webkit-dev] Windows Bots Are Green!

2015-02-20 Thread Brent Fulgham
Hi Everyone, Over the past few weeks I’ve spent a considerable amount of time reviewing and correcting a number of problems with the Windows testing infrastructure. We were skipping thousands of tests, including Accessibility, http tests, and large sections of forms, css, and svg tests. Some

[webkit-dev] WinCairo 64-bit Bot Failures

2015-01-25 Thread Brent Fulgham
Hi Everyone, It looks like the WinCairo 64-bit bot is having some trouble due to the dread Cygwin rebaseline requirement: Could someone with bot access please take the bot down and rebaseline it? These (annoying) failures are one of the reasons I’ve been trying to get the build to work

Re: [webkit-dev] Abandoned Tests

2015-01-22 Thread Brent Fulgham
AM, Myles C. Maxfield mmaxfi...@apple.com wrote: That's what I mean. What happens when we actually run them? On Jan 21, 2015, at 9:29 PM, Brent Fulgham bfulg...@apple.com wrote: Hi Myles, These tests don’t fail — they are all skipped on mac, win, gtk, and efl. -Brent On Jan 21

[webkit-dev] Abandoned Tests

2015-01-21 Thread Brent Fulgham
I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3.

Re: [webkit-dev] Abandoned Tests

2015-01-21 Thread Brent Fulgham
Hi Myles, These tests don’t fail — they are all skipped on mac, win, gtk, and efl. -Brent On Jan 21, 2015, at 9:24 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: On which platforms do they fail? —Myles On Jan 21, 2015, at 8:48 PM, Brent Fulgham bfulg...@apple.com wrote: I’ve been

Re: [webkit-dev] Disk cache

2014-11-03 Thread Brent Fulgham
I wonder if we could easily modify the Windows port to make use of a Network process. -Brent On Nov 3, 2014, at 8:07 AM, Anders Carlsson ander...@apple.com mailto:ander...@apple.com wrote: On Nov 3, 2014, at 12:22 AM, Benjamin Poulain benja...@webkit.org mailto:benja...@webkit.org

[webkit-dev] Fwd: Planning on Requiring Python 2.7 Soon

2014-09-15 Thread Brent Fulgham
forwarded message: From: Brent Fulgham bfulg...@apple.com Date: September 10, 2014 at 4:31:05 PM PDT To: webkit-dev webkit-dev@lists.webkit.org Subject: [webkit-dev] Planning on Requiring Python 2.7 Soon Hi Everyone, Now that I’ve worked through the minor issues that prevented us from

[webkit-dev] Planning on Requiring Python 2.7 Soon

2014-09-10 Thread Brent Fulgham
Hi Everyone, Now that I’ve worked through the minor issues that prevented us from using Python 2.7 on our Windows bots, I’d like to move the goalposts and require Python 2.7 (or newer) for our build and test machines. Will this cause anyone any problems if this becomes the new law of the land?

[webkit-dev] Windows (Temporary) Build Turmoil

2014-07-09 Thread Brent Fulgham
If you don’t care about building WebKit on Windows, you can stop reading now! Still here? Okay: I’m attempting to make the Windows build rely less on the Cygwin tool chain. There are a number of reasons for this, but one of the major benefits I hope to derive is to reduce the amount of effort

Re: [webkit-dev] help: HTML5 video Overlay with accelerated composition

2014-05-29 Thread Brent Fulgham
Can you provide specifics about your test case? 1. Are you using WebKit QT, or something else? 2. Can you provide an example showing what you are trying to do? Thanks, -Brent On May 29, 2014, at 4:11 AM, T andolsi thouraya.ando...@gmail.com wrote: Hi, Triying to use overlay for Video

[webkit-dev] Another Update: Cygwin Recommendations for Windows Builders

2014-04-23 Thread Brent Fulgham
A couple of weeks ago I reported a problem I noticed with Python 2.7 in our Cygwin-based builds: 2. Python version 2.6.8: If not, you get errors indicating “Invalid Python installation: unable to open ‘/cygdrive/c/Cygwin/include/python2.7/pyconfig.h”. This seems to be a regression since

Re: [webkit-dev] Problems building JavaScriptCore/WebKit for Windows desktop

2014-04-09 Thread Brent Fulgham
Hi Eric, I’m sorry you encountered problems building WebKit. I’ve interleaved some responses below. On Apr 1, 2014, at 4:34 AM, Eric Wing ewmail...@gmail.com wrote: I am trying to build JavaScriptCore for Windows desktop. (Ultimately, I just want a x86_64 .lib and .dll I can link against for

[webkit-dev] Update: Cygwin Recommendations for Windows Builders

2014-04-04 Thread Brent Fulgham
Hi folks, Yesterday I documented a few problems I was having with Cygwin, and asked if anyone else was encountering any issues. Since then, I’ve figured out what was going on, and I wanted to post a follow-up to document my findings. I’ll also be updating our Wiki page on the topic

[webkit-dev] Increasing Finickiness of Cygwin Installations

2014-04-03 Thread Brent Fulgham
Hi everyone, I’ve been reviewing some of the setup and reliability problems with our Windows builders, and have discovered that there are a number of challenges to getting a working Cygwin environment for building WebKit: You must use very specific versions of some Cygwin tools: 1. curl

Re: [webkit-dev] DerivedSources.make: Another try?

2014-03-19 Thread Brent Fulgham
Hi All, I’m arriving to this conversation a bit late, but had a few comments: On Mar 16, 2014, at 11:06 AM, Patrick Gansterer par...@paroga.com wrote: DerivedSources.make depends heavily on UNIX command line tools (cat, sed, sort, ...) which are not part of a clean Windows installation and

Re: [webkit-dev] Error while building webkit on windows

2014-03-05 Thread Brent Fulgham
Hi, The problem is with the processing of the CSSGrammar.y file. On Mar 5, 2014, at 1:52 AM, Baskar CV baskar...@hotmail.com wrote: 10 ./CSSGrammar.y:62.1: error: syntax error, unexpected end of file 10 open3: exec of /usr/bin/gcc -E -P -x c++ -DENABLE_3D_RENDERING

Re: [webkit-dev] WebGL backends

2014-02-10 Thread Brent Fulgham
Hi Dean, The WinCairo port uses the ANGLE library (and therefore, the “OpenGL” machinery) to do WebGL. I’m pretty sure the GTK+ port uses OpenGL directly, but Martin Robinson can probably confirm that. I think that only really leaves EFL, which may be using OpenGLES? I’m not sure. -Brent

Re: [webkit-dev] Ports relying on ICU with features omitted?

2014-02-10 Thread Brent Fulgham
Hi Darin, On Feb 10, 2014, at 9:40 AM, Darin Adler da...@apple.com wrote: I’d like to find out which ports are relying on WebKit support for ICU without certain key features. Maintaining these extra code paths creates some difficulties, and it would be helpful to remove them once no one is

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Brent Fulgham
The same is true for the WinCairo port, though I know Alex Christensen has been working towards correcting that. -Brent On Jan 28, 2014, at 7:49 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Jan 28, 2014 at 2:05 AM, Andrei Bucur abu...@adobe.com wrote: Do you happen to know if we

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Brent Fulgham
The same is true for the WinCairo port, though I know Alex Christensen has been working towards correcting that. -Brent On Jan 28, 2014, at 7:49 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Jan 28, 2014 at 2:05 AM, Andrei Bucur abu...@adobe.com wrote: Do you happen to know if we

Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?

2014-01-07 Thread Brent Fulgham
Hi, On Jan 6, 2014, at 1:53 PM, Alexey Proskuryakov a...@webkit.org wrote: 06 янв. 2014 г., в 12:51, Lucas Forschler lforsch...@apple.com написал(а): The Apple Mac EWS bots are currently running 10.8.5. I would like to see if there is any opposition (or support) for upgrading them to 10.9

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-04 Thread Brent Fulgham
Hi Alex, On Jan 4, 2014, at 12:01 PM, Alex Christensen alex.christen...@flexsim.com wrote: [...] but I like to err on the more explicit side of coding. It is hard to say does this make the code cleaner more than it removes useful information? or will this cause problems for other

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-03 Thread Brent Fulgham
Hi antti, On Jan 3, 2014, at 4:12 AM, Antti Koivisto koivi...@iki.fi wrote: If we start making rules I'd add the following: - Use auto when the type name is already mentioned on a line: +1 - Use auto when the type is irrelevant. This covers things like iterators and adapter classes: +1

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-02 Thread Brent Fulgham
On Jan 2, 2014, at 1:54 PM, Filip Pizlo fpi...@apple.com wrote: I think the goal should be that if you do introduce a temporary variable for some reason, then being explicit about its type is better. Consider that in your second example, there might be 200 lines of code between the call to

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-02 Thread Brent Fulgham
Hi Adam, On Jan 2, 2014, at 2:08 PM, Adam Roben aro...@webkit.org wrote: I found http://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ very persuasive in my thinking about when to use auto. I think this does a much better job of explaining the benefits of ‘auto’

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-02 Thread Brent Fulgham
Hi Filip, Coming back to your earlier example: auto newSize = optimalSize(); vs: CGSize newSize = optimalSize(); If I understand your argument, you feel that the explicit CGSize declaration helps the reader because it makes the return value of optimalSize() explicit. However, that

Re: [webkit-dev] Windows a Release Build Broken

2013-12-27 Thread Brent Fulgham
On Dec 27, 2013, at 9:26 AM, Joseph Pecoraro pecor...@apple.com wrote: Windows bots on build.webkit.org are now green. Thanks! Thanks for pointing me to the fixes in bugzilla comments. Sorry to disturb your holiday, but thanks for fixing it. :) -Brent

[webkit-dev] Windows a Release Build Broken

2013-12-25 Thread Brent Fulgham
The changes in Bug 126091 breaks the Windows Release build. https://bugs.webkit.org/show_bug.cgi?id=126091 -Brent Sent from my iPad ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Migration to Visual Studio 2013 Is Happening Now

2013-12-20 Thread Brent Fulgham
, It seems the Windows EWS bots should be updated too: http://webkit-queues.appspot.com/queue-status/win-ews Ossy Brent Fulgham írta: I am landing changes to switch our builds over to Visual Studio 2013. You can assume I know about any build failures on the Windows port. However, please let me

[webkit-dev] Migration to Visual Studio 2013 Is Happening Now

2013-12-13 Thread Brent Fulgham
I am landing changes to switch our builds over to Visual Studio 2013. You can assume I know about any build failures on the Windows port. However, please let me know if you encounter any problems on non-Windows platforms ASAP. Thanks, -Brent ___

[webkit-dev] Migration to Visual Studio 2013 Starts in About 12 Hours

2013-12-12 Thread Brent Fulgham
Hi floks! Last week I promised that we would be moving to Visual Studio 2013 builds this Friday (tomorrow). I plan to start this work tomorrow morning, and hope to have everything completed within a couple of hours. This should not impact non-Windows ports, so I anticipate minimal problems for

[webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-06 Thread Brent Fulgham
Hi Everyone, We are working hard to move WebKit toward stronger adoption of C++11 features, such as variadic templates, ranged for-loops, and initializer lists. Unfortunately, this effort has been hampered by the small subset of C++11 features available in Visual Studio 2010. You can get a

Re: [webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-06 Thread Brent Fulgham
: Is there any advantage of VS2013 instead of VS2012? I've been using VS2012 for a while, and it works fine. It also has the C++11 features we want to use. Staying one version behind the latest usually prevents updates from breaking things. Alex Christensen On Fri, Dec 6, 2013 at 3:53 PM, Brent

Re: [webkit-dev] C stack direction

2013-11-22 Thread Brent Fulgham
On Nov 21, 2013, at 2:14 PM, Darin Adler da...@apple.com wrote: On Nov 21, 2013, at 5:33 AM, Steven Coul (scoul) sc...@cisco.com wrote: But since it's WTF functionality that isn't being used in another component atm. I would tend to keep it. Actually, we wouldn’t do that. WTF is only

Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?

2013-10-15 Thread Brent Fulgham
On Oct 14, 2013, at 8:29 PM, Justin Haygood justin.hayg...@reaktix.com wrote: Would it be possible to use Media Foundation with a fall back? You can’t depend on Media Foundation even on Windows Vista+ anyway (N editions don’t have it), but it’s a COM API so you can detect that it is not

Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?

2013-10-14 Thread Brent Fulgham
Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since WinCairo is pretty solidly Windows-only. -Brent On Oct 14, 2013, at 10:00 AM, Brendan Long s...@brendanlong.com wrote: On 10/14/2013 10:39 AM, Mital Vora wrote: * are we considering any other

Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?

2013-10-14 Thread Brent Fulgham
The only problem with Media Foundation is that it is Vista-and-newer only. There is no Windows XP version. -Brent On Oct 14, 2013, at 10:23 AM, Brent Fulgham bfulg...@apple.com wrote: Alex, Brendan: I do think that something like Media Foundation would be a useful way to go, since

Re: [webkit-dev] Wink browser

2013-10-10 Thread Brent Fulgham
Fantastic work! I can't wait to see what you do with it. -Brent Sent from my iPad On Oct 10, 2013, at 6:08 PM, Alex Christensen alex.christen...@flexsim.com wrote: With the removal of Chromium and Qt, there are no projects of which I am aware that allow Windows users to use WebKit with

Re: [webkit-dev] Please install shellwords on the bots

2013-10-07 Thread Brent Fulgham
It appears that Shellwords is part of the standard Ruby install we use on the Cygwin-based Windows systems. -Brent On Oct 6, 2013, at 2:06 PM, Filip Pizlo fpi...@apple.com wrote: On Oct 6, 2013, at 2:00 PM, Benjamin Poulain benja...@webkit.org wrote: On 10/6/13, 1:54 PM, Filip Pizlo

Re: [webkit-dev] [WinCairo] : is ACCELERATED COMPOSITING under progress ?

2013-10-07 Thread Brent Fulgham
On Oct 7, 2013, at 11:32 AM, Urbain EGIS urbain.e...@gmail.com wrote: Expecting ACCELERATED_COMPOSITING along with WinCairo, I noticed come conflicts raised by building WebKit over MsDev 2010. Looks like ACCELERATED_COMPOSITING is sort of wired to CoreAnimation (and CoreGraphics). So

Re: [webkit-dev] Proposal: Use ICU in WebKit code

2013-10-05 Thread Brent Fulgham
The WinCairo port is as close to the AppleWin port as possible. It uses ICU and I have no intention of changing that. The WinCE port is maintained by Patrick Gangsterer. I believe that this port does not want to use ICU, preferring to use the limited subset of i18n features provided by the

Re: [webkit-dev] Announcement: CSS3_TEXT_DECORATION flag

2013-10-04 Thread Brent Fulgham
Yes, WinCairo uses the new inspector. On Oct 4, 2013, at 11:45 AM, Antonio Gomes toniki...@webkit.org wrote: All (?wincairo I'm not sure?) ports on trunk use the new Inspector, and the old one is being removed: https://bugs.webkit.org/show_bug.cgi?id=122295 On Fri, Oct 4, 2013 at 2:24 PM,

Re: [webkit-dev] WebGL :: Win32 = build successful and rendering assumed so = but white page

2013-10-03 Thread Brent Fulgham
Hi Hugo, I think most of us in the WebKit project are aware of the missing pieces on the Apple Windows port, and have plans to rectify this. However, I don’t understand what your needs are regarding WebGL and the Apple Windows port. This port is not licensed for use outside of Apple’s own

Re: [webkit-dev] PSA: WebKit2 and DrawingAreaImpl

2013-10-02 Thread Brent Fulgham
Hi Anders, On Oct 1, 2013, at 6:19 PM, Anders Carlsson ander...@apple.com wrote: I just wanted to let everyone know that we (Apple) are moving away from DrawingAreaImpl and always using our tiled drawing area. Longer term we’d like to remove DrawingAreaImpl completely since it was designed

Re: [webkit-dev] WTF::fastMalloc

2013-10-01 Thread Brent Fulgham
So are you proposing to use the system allocator on Windows? Or would we keep using the existing FastMalloc implementation? The current malloc logic has been the source of a number of mysterious crashes on Windows, so reverting to the system allocator might be a good thing for stability. I

Re: [webkit-dev] Invalid file committed on the Webkit tree for windows

2013-09-20 Thread Brent Fulgham
This appears to have been corrected in r156161. Thanks, -Brent On Sep 20, 2013, at 2:20 AM, Konstantin Tokarev annu...@yandex.ru wrote: 20.09.2013, 13:16, Van Den Berghe, Vincent vincent.vandenber...@bvdinfo.com: Hello, When doing an SVN update to get the latest WebKit tree on

Re: [webkit-dev] Loading and unloading webkit, threading, AtomicString and crashes

2013-09-15 Thread Brent Fulgham
again, (for Brent Fulgham: codeword “onion”, I repeat, codeword “onion” J) Context Consider embedding WebKit in an ASP.NET website (even though what follows is valid in other scenarios). In order to do this, you need a (managed) thread with a message loop. If you want this to work reliably

Re: [webkit-dev] Loading and unloading webkit, threading, AtomicString and crashes

2013-09-15 Thread Brent Fulgham
I realized it was easier to light a candle than curse the darkness, so I converted the original e-mail to a bug. Let's move discussion of this issue there: https://bugs.webkit.org/show_bug.cgi?id=121407 Thanks! -Brent On Sep 15, 2013, at 10:52 AM, Alexey Proskuryakov a...@webkit.org wrote:

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Brent Fulgham
Hi Vincent and Mark: On Sep 13, 2013, at 1:06 AM, Salisbury, Mark mark.salisb...@hp.com wrote: Vincent, Maybe some tips I’ve learned could be of help to you or others: ·Calling DestroyWindow will cause WebView::close() to be called (when WM_DESTROY is received), but it does not

Re: [webkit-dev] TimerWindowWndProc and dangling page instances

2013-09-13 Thread Brent Fulgham
Hi Vincent, On Sep 13, 2013, at 1:34 AM, Van Den Berghe, Vincent vincent.vandenber...@bvdinfo.com wrote: I’m embedding the Wincairo build of WebKit to generate PDF files from web pages in an ASP.NET application. Yay! Webkit isn’t really designed for such a scenario but with some careful

Re: [webkit-dev] Changes in QtWebKit development

2013-09-13 Thread Brent Fulgham
On Sep 13, 2013, at 10:22 AM, Benjamin Poulain benja...@webkit.org wrote: On 9/13/13, 4:50 AM, Albisser Zeno wrote: As many of you have probably noticed already, we have recently been focusing on a project called Qt WebEngine. Our WebKit efforts have therefore been reduced significantly

Re: [webkit-dev] Announcing new port: Nix

2013-09-12 Thread Brent Fulgham
Hi, On 09/12/13, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Improving cURL network backend (which used by Apple's WinCairo port too) The WinCairo port is not an Apple project, though it is tied very closely to the existing Apple Windows port. However, I am quite happy that people have

Re: [webkit-dev] Announcing new port: Nix

2013-09-12 Thread Brent Fulgham
However, you've already clarified that you're going to improve WebRTC and are, in fact, in the process of doing so. Furthermore, you've clarified that there is a demand for your port and human resources to maintain it. I'm actually curious if anyone's opposed to supporting Nix port and

Re: [webkit-dev] Changes to main Frame creation in WebCore

2013-08-18 Thread Brent Fulgham
I can take care of this for the Windows ports. Can you cc me on the bug, please? Thanks, -Brent Sent from my iPhone On Aug 18, 2013, at 4:33 PM, Andreas Kling akl...@apple.com wrote: Hello everyone! Just a friendly heads-up that I’m planning to land some changes to the way main Frames

Re: [webkit-dev] Windows Build Broken?

2013-08-02 Thread Brent Fulgham
Hi Rakesh, On Aug 2, 2013, at 1:29 AM, Rakesh Sadhu rakeshsa...@hotmail.com wrote: But I am facing one more problem , my release winlauncher launches properly whereas debug winlauncher fails with the message Failed to determine path to AAS Directory”. WebKit requires certain support

Re: [webkit-dev] WebGL on Windows

2013-08-02 Thread Brent Fulgham
Let’s do it! -Brent On Aug 2, 2013, at 1:57 PM, Benjamin Poulain benja...@webkit.org wrote: On Fri, Aug 2, 2013 at 1:09 PM, Alex Christensen achristen...@apple.com wrote: In the near future I plan to enable WebGL on the AppleWin and WinCairo ports. This change will require the addition

Re: [webkit-dev] Windows Build Broken?

2013-08-01 Thread Brent Fulgham
Please review your build log. The problem is the following: fatal error C1083: Cannot open include file: 'd3dx9.h': No such file or directory” You do not have the DirectX SDK installed, as documented in Step 4 of http://www.webkit.org/building/tools.html. -Brent On Aug 1, 2013, at 1:46 AM,

Re: [webkit-dev] Ports not building as C++11?

2013-07-30 Thread Brent Fulgham
Hi Patrick, On Jul 29, 2013, at 10:42 AM, Patrick East patri...@bsquare.com wrote: There is support for C++11 on Windows Embedded Compact 2013 using the newer VC11 compiler, but for CE 5, 6, or WEC 7 they will not be able to support it since they are limited to the VC9 compiler. Afaik there

Re: [webkit-dev] Ports not building as C++11?

2013-07-28 Thread Brent Fulgham
We can support auto and move semantics. We cannot support ranged iterators until VS2012. But at least it's a step in the right direction... Sent from my iPad On Jul 28, 2013, at 2:36 PM, Oliver Hunt oli...@apple.com wrote: So wait, is everyone using C++11 now? I dream of using auto…

Re: [webkit-dev] Ports not building as C++11?

2013-07-27 Thread Brent Fulgham
The only platform I know cannot support C++11 is WinCE, and that port is in favor of making the move to C++11 in anticipation of updated build tools from Microsoft. What other platform are we talking about here? The GNU compilers have supported C++11 for a long time. -Brent Sent from my

Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard

2013-07-02 Thread Brent Fulgham
wrote: Fwiw, the original author is no longer working on Blink, and the code has been removed from there. mike On Jun 5, 2013 1:24 AM, Brent Fulgham bfulg...@apple.com wrote: We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit

Re: [webkit-dev] There is a linking error when build webkit on windows 7

2013-06-18 Thread Brent Fulgham
Hi SiqinBilige: On Jun 18, 2013, at 8:03 PM, siqinbilige siqinbil...@gmail.com wrote: I wan to build webkit on Windows. My environment is : Windows 7 Ultimate (Service Pack1) 64bit (japanese) Intel(R) Core(TM) i7 CPU / 12.0GB Memory VC++ 2010 Express Microsoft Windows SDK for windows

Re: [webkit-dev] There is a linking error when build webkit on windows 7

2013-06-18 Thread Brent Fulgham
Hi Siqinbilige: On Jun 18, 2013, at 8:31 PM, ビリゴ スチン siqinbil...@gmail.com wrote: Yes, There is a WebKitLibraries/win/lib32 folder and also have WebKitLibraries/win/lib folder. first, there is one file WebKitSystemInterface.lib. I copied the all of the files which including libicuuc.lib

Re: [webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard

2013-06-05 Thread Brent Fulgham
Hi Gyuyoung, On Jun 4, 2013, at 10:15 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: I'm interested in this feature. So, I took Bug 92330 over. Though I rebased the feature according to review comments, this feature doesn't work yet. So, I have investigated why it doesn't work. However,

[webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard

2013-06-04 Thread Brent Fulgham
We have code in WebKit that is protected by the ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to enable this feature. Is anyone currently working on (or planning to work on) this feature? Since this CSS feature is currently in an early draft form, and is likely to

[webkit-dev] Mismatched Allocators in Windows

2013-05-01 Thread Brent Fulgham
While investigating a crash in the 'create-lots-of-workers' test (see https://bugs.webkit.org/show_bug.cgi?id=115130), I found that there were a number of cases where objects were created using the system allocator, but later freed using the 'fastFree' overload provided by fastMalloc.h. I

Re: [webkit-dev] Compiling WebKit up to 25% faster in Windows?

2013-04-16 Thread Brent Fulgham
Hi Daniel, I'm afraid I don't quite understand the nature of the change you are proposing: 1. Is it sufficient to supply the full path to the include files (e.g., change Foo.h to WebCore/html/Foo.h) to achieve these gains? 2. ... or ... is it sufficient to copy all header files to a common

Re: [webkit-dev] Buildsystem cleanup

2013-04-10 Thread Brent Fulgham
Hi everyone: Sent from my iPhone On Apr 10, 2013, at 3:30 PM, Roger Fong roger_f...@apple.com wrote: 2. If you're working on Windows, open up the solution with Visual Studio and do work as usual, unless you want to add files in which case you go through the CMake scripts again before

  1   2   3   >