Re: [webkit-dev] Modern image formats for WebKit
I am discussing the code in 1). It seems to me that an image decoder itself should come from an external library, rather than be compiled directly from WebKit sources. Exactly. Assuming that we are linking with external decoding libraries, I do not have any strong opinion as to which image decoding libraries that we build scaffolding in order to link with. O.K Thanks for making clear. =) ChangSeok On Mar 22, 2015, at 12:46 AM, Myles C. Maxfield mmaxfi...@apple.com wrote: Sorry, I think we are misunderstanding each other. Let me try to be more explicit: There are two conceptual pieces that are required to support image formats: 1) the image decoder itself 2) scaffolding around the API of a decoder to correctly hook it up to the rest of WebKit. First of all, the code in 2) is required no matter what. I am discussing the code in 1). It seems to me that an image decoder itself should come from an external library, rather than be compiled directly from WebKit sources. Assuming that we are linking with external decoding libraries, I do not have any strong opinion as to which image decoding libraries that we build scaffolding in order to link with. -Myles On Mar 20, 2015, at 6:16 PM, ChangSeok Oh changseok...@collabora.com mailto:changseok...@collabora.com wrote: So this is a really a question for people working on other active ports like the EFL and GTK ones. Are there other libraries that you could use for image decoding, or do you still want to keep and maintain a WebKit copy of these image decoders? Maybe the latter one. I’m not sure what you meant other libraries here if they are not libwebp nor libjxr. I found webp has been supported by gtk elf ports already. At least WebPImageDecoder.cpp is a build target for those ports. JXR support would be a same shape with webp support, i. e adding a glue layer JPEGXRImageDecoder.cpp/h and linking libjxr.so. ChangSeok On Mar 21, 2015, at 6:39 AM, Darin Adler da...@apple.com mailto:da...@apple.com wrote: We should consider whether to keep the image format decoders in the WebKit tree or not. Dave Hyatt originally created this when we first were planning the Apple Windows port of WebKit, but in the end we chose to not use them for the Windows port. They aren’t used in the Windows port nor in the Mac or iOS ports; for all of those we use a separate image decoding library. So this is a really a question for people working on other active ports like the EFL and GTK ones. Are there other libraries that you could use for image decoding, or do you still want to keep and maintain a WebKit copy of these image decoders? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Modern image formats for WebKit
Are there no existing libraries that can be conditionally linked with for supporting these formats? In the long term, it seems like bad design to have WebKit have its own custom decoders. Yes. there are of course. libwebp, libjxr are available on linux based systems and also seem available on mac and Windows. [1] Both are BSD license so that there is no license issue to port them for any platforms if necessary. I’m not telling about inventing new wheels for them, but adding a kind of a glue layer in webkit as png, gif and png supports do. ;) (e.g PNGImageDecoder.* JPEGImageDecoder.*) [1] https://developers.google.com/speed/webp/download https://developers.google.com/speed/webp/download https://jxrlib.codeplex.com/releases/view/107208 https://jxrlib.codeplex.com/releases/view/107208 https://packages.debian.org/wheezy/webp https://packages.debian.org/wheezy/webp https://packages.debian.org/sid/utils/libjxr-tools https://packages.debian.org/sid/utils/libjxr-tools ChangSeok On Mar 20, 2015, at 2:21 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: Are there no existing libraries that can be conditionally linked with for supporting these formats? In the long term, it seems like bad design to have WebKit have its own custom decoders. If that isn't an option, it seems fine to me provided that the decoders' sources are all close together (for some definition of close) and not peppered throughout WebKit. On Mar 19, 2015, at 9:38 PM, ChangSeok Oh changseok...@collabora.com wrote: Hi WebKittens. I just saw apng support landed on webkit main stream. [1] (even it works for gtk port only now) So I suddenly wonder if webkit community is getting interested in bringing other modern image formats like webp or jpeg-xr into webkit. If so, I can lend my hands for it. For webp support, as you know, we can reuse blink's codebase. [2] For jpeg-xr supprot, I have a rough sketch for it [3] (it might be outdated or not fit tot of webkit though, bringing it to webkit is just a piece of cake. ;)) My intention is not to argue which format is better, just to ask community's thoughts, preferences or like that. [1] https://bugs.webkit.org/show_bug.cgi?id=17022 [2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cppq=webpimasq=package:chromiuml=1 [3] http://cgit.collabora.com/git/user/kevino/Blink.git/commit/?h=jxr-supportid=2ac58312a5aae502aacc1c55c0bfdff767ab82a2 BR. -- ChangSeok ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WebCore/platform standalone library
Low-level Object Library. This sounds good to me. Something prefixed “NEW” could not be new forever. ;) If I suggest one.. how about WAFL? WebKit(or WebCore) Abstraction Framework Library(or Layer) It should sound sweet like waffle =) ChangSeok On Mar 21, 2015, at 3:26 AM, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at 11:03 AM, Edward O'Connor eocon...@apple.com mailto:eocon...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object Library. Algorithm Reuse Framework. New Framework for WebCore, New System Framework for WebCore. Platform Obfuscation Source. Platform Interface and Testing Abstraction. General Independent Framework (pronounced jiff, of course). Low-Level Abstract Platform would also be a logical choice. Low-level Object Library. Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Modern image formats for WebKit
So this is a really a question for people working on other active ports like the EFL and GTK ones. Are there other libraries that you could use for image decoding, or do you still want to keep and maintain a WebKit copy of these image decoders? Maybe the latter one. I’m not sure what you meant other libraries here if they are not libwebp nor libjxr. I found webp has been supported by gtk elf ports already. At least WebPImageDecoder.cpp is a build target for those ports. JXR support would be a same shape with webp support, i. e adding a glue layer JPEGXRImageDecoder.cpp/h and linking libjxr.so. ChangSeok On Mar 21, 2015, at 6:39 AM, Darin Adler da...@apple.com wrote: We should consider whether to keep the image format decoders in the WebKit tree or not. Dave Hyatt originally created this when we first were planning the Apple Windows port of WebKit, but in the end we chose to not use them for the Windows port. They aren’t used in the Windows port nor in the Mac or iOS ports; for all of those we use a separate image decoding library. So this is a really a question for people working on other active ports like the EFL and GTK ones. Are there other libraries that you could use for image decoding, or do you still want to keep and maintain a WebKit copy of these image decoders? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Modern image formats for WebKit
Hi WebKittens. I just saw apng support landed on webkit main stream. [1] (even it works for gtk port only now) So I suddenly wonder if webkit community is getting interested in bringing other modern image formats like webp or jpeg-xr into webkit. If so, I can lend my hands for it. For webp support, as you know, we can reuse blink's codebase. [2] For jpeg-xr supprot, I have a rough sketch for it [3] (it might be outdated or not fit tot of webkit though, bringing it to webkit is just a piece of cake. ;)) My intention is not to argue which format is better, just to ask community's thoughts, preferences or like that. [1] https://bugs.webkit.org/show_bug.cgi?id=17022 [2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cppq=webpimasq=package:chromiuml=1 [3] http://cgit.collabora.com/git/user/kevino/Blink.git/commit/?h=jxr-supportid=2ac58312a5aae502aacc1c55c0bfdff767ab82a2 BR. -- ChangSeok ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Žan Doberšek is now WebKit reviewer
Congrats Žan! ChangSeok On 01/07/2015 09:06 PM, Carlos Garcia Campos wrote: I'm happy to announce that Žan Doberšek is now a WebKit reviewer. Žan has contributed to WebKit for more than 6 years working on almost all areas of WebKit. Mainly focused on the GTk+ port he has also helped a lot improving the whole codebase, fixing bugs, cleaning up code, modernizing code using new C++ 11 features, etc. He is currently leading the new WebKit for Wayland port. Thank you Žan for all the work you have done so far for WebKit. Congratulations! ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Proposal: Datalist support for text input field.
Hi Webkitten. I'd like to bring datalist support to text field. To do that, I spent some time and made an initial patch. You can check it out here https://bugs.webkit.org/show_bug.cgi?id=98934 I haven't received any feedback from any reviewer unfortunately even though several weeks are passed away. Would anyone review it if interested? Any feedback is welcome. B.R -- ChangSeok ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] webkit-dev Digest, Vol 105, Issue 10
Congrats! Sergio ChangSeok On Fri, Feb 14, 2014 at 5:00 AM, webkit-dev-requ...@lists.webkit.orgwrote: Send webkit-dev mailing list submissions to webkit-dev@lists.webkit.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.webkit.org/mailman/listinfo/webkit-dev or, via email, send a message with subject or body 'help' to webkit-dev-requ...@lists.webkit.org You can reach the person managing the list at webkit-dev-ow...@lists.webkit.org When replying, please edit your Subject line so it is more specific than Re: Contents of webkit-dev digest... Today's Topics: 1. Sergio Villar Senin is now a WebKit reviewer! (Philippe Normand) -- Message: 1 Date: Thu, 13 Feb 2014 00:19:44 +0100 From: Philippe Normand ph...@igalia.com To: WebKit Development webkit-dev@lists.webkit.org Subject: [webkit-dev] Sergio Villar Senin is now a WebKit reviewer! Message-ID: 1392247184.30212.7.camel@debian.localdomain Content-Type: text/plain; charset=UTF-8 Hi, I'm happy to announce that Sergio (svillar) is now a WebKit reviewer! Sergio's areas of expertize span from WebCore (CSS Grid Layout, Parser, editing) to WebKit2 with a special dedication to the GTK port. Sergio also spends a lot of efforts on the libsoup networking backend. Thanks Sergio for all the work you have done so far and congratulations! Philippe -- ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev End of webkit-dev Digest, Vol 105, Issue 10 *** ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
