Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Chris Dumez
> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa wrote: > >  > >> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto wrote: >> >>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa wrote: On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro wrote: >>> On Fri, Nov 1, 2019 at 11:19 am,

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Chris Dumez
I mildly prefer without the space :) --  Chris Dumez > On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote: > > Hi all, > > There seems to be inconsistency in our coding style with regards to spacing > in lambdas. > > Namely, some people wri

Re: [webkit-dev] 2019 WebKit Contributors Meeting - Registration is Open

2019-09-18 Thread Chris Dumez
Did not work for me either, got a page with text “None” shortly after logging in. --  Chris Dumez > On Sep 18, 2019, at 2:12 PM, > wrote: > > Seems like the login form isn't working—I see: > > MultipleObjectsReturned at /auth/wlogin/ > get() returned

Re: [webkit-dev] IPC implementation help in haiku's webkit port

2019-05-28 Thread Chris Dumez
Alex is likely right that you are ending up with some kind of IPC deadlock since the IPC is synchronous. But also, > On May 27, 2019, at 11:49 PM, Rajagopalan Gangadharan > wrote: > > > Please check the source references for more info: > NetworkProcessProxy: [ >

Re: [webkit-dev] Crash When Running run-safari

2019-04-10 Thread Chris Dumez
Bug 196777 <https://bugs.webkit.org/show_bug.cgi?id=196777> will fix this. --  Chris Dumez > On Apr 10, 2019, at 10:54 AM, Chris Dumez wrote: > > Yes, this commit broke it: http://trac.webkit.org/r243320 > <http://trac.webkit.org/r243320> > > -- >  Chr

Re: [webkit-dev] Crash When Running run-safari

2019-04-10 Thread Chris Dumez
Yes, this commit broke it: http://trac.webkit.org/r243320 <http://trac.webkit.org/r243320> --  Chris Dumez > On Apr 10, 2019, at 10:47 AM, Assaf Inbal wrote: > > Thanks for the update! > Since I don’t really need the bleeding-edge, can you tell me which tag/commit >

Re: [webkit-dev] Crash When Running run-safari

2019-04-10 Thread Chris Dumez
Oh, I am responsible for this. This is due to an incompatibility between the very recent WebKit you built and the older system’s Safari. I will look into fixing this shortly, thanks for letting me know. --  Chris Dumez > On Apr 10, 2019, at 4:44 AM, Assaf Inbal wrote: > > Hey,

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Chris Dumez
0, 2019, at 7:48 AM, Daniel Bates >> <mailto:dba...@webkit.org>> wrote: >>> >>> Thanks for the opinion! >>> >>> Dan >>> >>> On Feb 20, 2019, at 7:26 AM, Saam Barati >> <mailto:sbar...@apple.com>> wrote: >>> &g

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Chris Dumez
that we should not allow this pattern. Therefore, I was also surprised by your email saying that we’d reached a consensus. > > Dan > > On Feb 20, 2019, at 6:58 AM, Chris Dumez <mailto:cdu...@apple.com>> wrote: > >> I also prefer allowed returning void. >&g

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Chris Dumez
I also prefer allowed returning void. Chris Dumez > On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: > > > >> On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: >> >>> On Tue, Feb 19, 2019 at 8:59 PM Daniel Bates wrote: >> >>> &g

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-07 Thread Chris Dumez
Same here, I used it in PSON code with completion handlers. I liked the more concise code but I also do not feel strongly about it. The extra return line often would have meant adding curly brackets for if statements leading to early returns. Chris Dumez > On Feb 7, 2019, at 8:23 PM, Za

Re: [webkit-dev] Rename AtomicString to AtomString

2019-01-30 Thread Chris Dumez
Fine by me. --  Chris Dumez > On Jan 30, 2019, at 9:35 AM, Antti Koivisto wrote: > > Sounds good to me. > > > antti > > On Wed, Jan 30, 2019 at 6:33 PM Darin Adler <mailto:da...@apple.com>> wrote: > So, did we reach consensus that we shou

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Chris Dumez
> On Dec 19, 2018, at 9:41 PM, Chris Dumez wrote: > >> >> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak > <mailto:m...@apple.com>> wrote: >> >> >> >>> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa >> <mailto:rn...@webkit.

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Chris Dumez
> On Dec 19, 2018, at 9:17 PM, Maciej Stachowiak wrote: > > > >> On Dec 19, 2018, at 8:06 PM, Ryosuke Niwa > > wrote: >> >> On Wed, Dec 19, 2018 at 1:13 PM Simon Fraser > > wrote: >> > On Dec 19, 2018, at 12:33 PM, Michael Catanzaro > >

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Chris Dumez
;> On Dec 17, 2018, at 12:50 PM, Alex Christensen >> <mailto:achristen...@apple.com>> wrote: >>> >>> This one and the many others like it are fragile, relying on undefined >>> behavior, and should be replaced by std::exchange. Such a change was made

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Chris Dumez
> On Dec 17, 2018, at 11:10 AM, Chris Dumez wrote: > > > >> On Dec 17, 2018, at 10:27 AM, Alex Christensen > <mailto:achristen...@apple.com>> wrote: >> >>>>>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >>>>> <mail

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Chris Dumez
> On Dec 17, 2018, at 10:27 AM, Alex Christensen wrote: > >>>>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >>>> <mailto:cdu...@apple.com>> wrote: >>>> >>>>> >>>>> As far as I know, our convention in WebKit s

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-16 Thread Chris Dumez
> On Dec 16, 2018, at 7:43 PM, Fujii Hironori wrote: > > I don't like the proposal because it encourages misuse of move. > We can use move only for values about to be destroyed. Just for reference, there are close to 400 matches for "WTFMove(m_” in our code base. People do seem to rely on the

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Chris Dumez
So to be clear, it is often not truly about using the value after it is moved. It is about expecting that the variable / member has been nulled out after moving it. If I WTFMove() out a data member m_dataMember, I expect later on `if (m_dataMember)` to be false. --  Chris Dumez > On

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Chris Dumez
> On Dec 14, 2018, at 3:39 PM, Fujii Hironori wrote: > > > On Sat, Dec 15, 2018 at 6:38 AM Chris Dumez <mailto:cdu...@apple.com>> wrote: > > I have now been caught twice by std::optional’s move constructor. > > I don't understand how this could be use

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Chris Dumez
> On Dec 14, 2018, at 1:56 PM, Saam Barati wrote: > > > >> On Dec 14, 2018, at 1:54 PM, Saam Barati > <mailto:sbar...@apple.com>> wrote: >> >> >> >>> On Dec 14, 2018, at 1:37 PM, Chris Dumez >> <mailto:cdu...@apple.com&

[webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Chris Dumez
“empty” state. As such, I find that std::optional’s move constructor behavior is error-prone. I’d like to know how do other feel about this behavior? If enough people agree this is error-prone, would we consider having our own optional type in WTF which resets the engaged flag (and ne

Re: [webkit-dev] PSA: String shouldn't be a member of a ThreadSafeRefCounted class

2018-02-24 Thread Chris Dumez
m_impl ? m_impl->isolatedCopy() : String { }; } The isolatedCopy() optimization (i.e. isSafeToSendToAnotherThread) can only be used if the String is a temporary. If you example, m_name is not a temporary and will be deep copied. --  Chris Dumez > On Feb 23, 2018, at 11:45 PM, Ryosuke Niwa <

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Chris Dumez
> On Nov 17, 2017, at 9:18 AM, youenn fablet wrote: > > Chris recently noticed that some heavily used files (testharness*) were > cacheable through Apache but not WPT. Wasn’t me. Alexey reported this via Description

Re: [webkit-dev] buildbot / ios-sim failing on serviceworket tests?

2017-11-06 Thread Chris Dumez
These are likely flaky tests, unrelated to your change. --  Chris Dumez > On Nov 6, 2017, at 5:38 AM, Colin Bendell | +1.613.914.3387 > <co...@bendell.ca> wrote: > > Can someone provide guidance on how I should interpret serviceworker > failures on the ios-sim que

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Chris Dumez
ould be a nice way to do so. Finally, the storage space argument from Maciej is a good one. --  Chris Dumez > On Sep 1, 2017, at 9:46 AM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Sep 1, 2017, at 9:30 AM, Brady Eidson <beid...@apple.com> wrote: >

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Chris Dumez
ifferent behavior because we end up calling a different overload. This would seem very risky for a big project such as WebKit. --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Chris Dumez
-resolving dependencies so much. --  Chris Dumez > On Aug 29, 2017, at 9:05 AM, Darin Adler <da...@apple.com> wrote: > >> On Aug 28, 2017, at 8:34 PM, Ryosuke Niwa <rn...@webkit.org >> <mailto:rn...@webkit.org>> wrote: >> >>> Wherever po

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Chris Dumez
I indeed think this will require “using” statements or explicit namespace at call sites. I don’t think anonymous namespaces are suitable for resolving naming conflicts due to unity builds since the functions and up in the same compilation unit. --  Chris Dumez > On Aug 29, 2017, at 9

Re: [webkit-dev] How we enable template functions

2017-08-22 Thread Chris Dumez
I personally prefer std::enable_if<>. For e.g. template::value> Class Foo { } I don’t like that something inside the body of a class / function would cause a template to be enabled or not. --  Chris Dumez > On Aug 22, 2017, at 8:34 PM, Keith Miller <keith_mil...@a

Re: [webkit-dev] Does someone know how to fix WTF::Function on Windows

2017-07-15 Thread Chris Dumez
I seem to remember I fixed it last time by calling the WTF::Function constructor explicitly. Chris Dumez > On Jul 15, 2017, at 9:14 AM, Yusuke SUZUKI <utatane@gmail.com> wrote: > > I'm not 100% confident, but can you try it `` instead? > > Regards, > Yusuke Suz

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Chris Dumez
subclass that just asserts that it has been called >> once. That would’ve prevented some bugs, too, but not every use of >> WTF::Function has such a requirement. >> >>> On Jun 13, 2017, at 12:31 PM, Chris Dumez <cdu...@apple.com >>> <mailto:cdu

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Chris Dumez
We already have BlockPtr for passing a Function as a lambda block. Chris Dumez > On Jun 13, 2017, at 12:29 PM, Alex Christensen <achristen...@apple.com> wrote: > > std::function, c++ lambda, and objc blocks are all interchangeable. > WTF::Functions cannot be used as o

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Chris Dumez
in WebCore since we actually very rarely need copying (either it just builds or the code can be refactored very slightly to avoid the copying). --  Chris Dumez > On Jun 13, 2017, at 9:34 AM, Filip Pizlo <fpi...@apple.com> wrote: > > We should have a better story here. Right now t

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Chris Dumez
base but there are still a lot of uses of std::function. --  Chris Dumez > On Jun 13, 2017, at 9:24 AM, Darin Adler <da...@apple.com> wrote: > > I’ve noticed many patches switching us from std::function to WTF::Function > recently, to fix problems with copying and thread saf

Re: [webkit-dev] "ReflectOnly" IDL equivalent

2017-06-09 Thread Chris Dumez
> On Jun 9, 2017, at 11:47 AM, Sam Weinig <wei...@apple.com> wrote: > > > >> On Jun 2, 2017, at 11:32 AM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >> On Fri, Jun 2, 2017 at 9:18 AM, Chris Dumez <cdu...@apple.com> wrote: >>> Hi,

Re: [webkit-dev] "ReflectOnly" IDL equivalent

2017-06-02 Thread Chris Dumez
could also consider adding support for something like ReflectOnly in our bindings generator considering that this seems to be used quite a bit in the HTML specification and it would decrease code complexity a little. I’d actually be in favor of that. --  Chris Dumez > On Jun 1, 2017, at

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Chris Dumez
ones) and it is not necessarily obvious just by looking at the test. --  Chris Dumez > On May 12, 2017, at 2:10 PM, Simon Fraser <simon.fra...@apple.com> wrote: > >> >> On May 12, 2017, at 12:04 PM, Alexey Proskuryakov <a...@webkit.org >> <mailto:a...@we

Re: [webkit-dev] Another WPT bite

2017-05-08 Thread Chris Dumez
> On May 8, 2017, at 9:44 PM, Geoffrey Garen wrote: > >> Is it time to make testharness.js the recommended way of writing LayoutTests? > > What are the costs and benefits of testharness.js? Benefit: - Tests would be more easily upstreamable to web-platform-tests, which are

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Chris Dumez
sEmpty()) looks even better :) --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] !!Tests for equality comparison

2017-04-27 Thread Chris Dumez
I also do not like this rule when it comes to integers. I personally think JF’s proposal to allow == 0 sounds nice. I don’t think JF was suggesting rewriting existing code (which would indeed cause a lot of churn). --  Chris Dumez > On Apr 27, 2017, at 4:30 PM, Geoffrey Garen &

Re: [webkit-dev] bugs.webkit.org - Maintenance: 10.00 - 11.00am

2017-03-30 Thread Chris Dumez
Any update? It’s been a few minutes :) --  Chris Dumez > On Mar 30, 2017, at 9:55 AM, Ling Ho <lin...@apple.com> wrote: > > Hello WebKit developers, > > We are flipping a switch to restart bugs.webkit.org on a new server between > 10-11am this morning. There shou

[webkit-dev] Bugzilla down?

2017-03-10 Thread Chris Dumez
Bugzilla seems down for me. I am getting certificate errors: --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SVN trouble

2017-02-26 Thread Chris Dumez
It also seems bugzilla mail notifications may be down. Chris Dumez > On Feb 25, 2017, at 8:40 AM, Simon Fraser <simon.fra...@apple.com> wrote: > > EWS is still down. Do we have an ETA? > > Simon > >>> On Feb 24, 2017, at 10:25 PM, Alexey Proskuryakov <a...

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Chris Dumez
like EWS is still down. Did it break again or is it just not fixed yet? --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] SVN trouble

2017-02-24 Thread Chris Dumez
ow is that > someone committed to trunk, and thus invoked post-commit hooks. Yes, I confirm manual commits work now :) --  Chris Dumez ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-05 Thread Chris Dumez
not advocating we use testharness.js for everything (although I would be OK with this). I propose we make it opt-in. We have a lot of tests that are not necessarily interesting to upstream. However, the ones that are, using testharness.js makes a lot of sense. Chris Dumez > On Feb 5, 2017, at 5

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Chris Dumez
in the case where maximum() returns an integer but checks if the value is set in the case the function returns an std::optional. Chris Dumez On Jan 10, 2017, at 9:51 PM, Darin Adler <da...@apple.com> wrote: >> On Jan 10, 2017, at 9:49 PM, Darin Adler <da...@apple.com> wrote: >&

[webkit-dev] Can no longer commit manually or via CQ?

2016-06-20 Thread Chris Dumez
e --skip" instead. To check out the original branch and stop rebasing, run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2661. Kr, --  Chris Dumez _

Re: [webkit-dev] Removing ENABLE(DATA_TRANSFER_ITEMS)

2016-01-29 Thread Chris Dumez
work on enabling this feature rather than removing it? Kr, --  Chris Dumez > On Dec 21, 2015, at 10:02 PM, Gyuyoung Kim <gyuyoung@webkit.org> wrote: > > Hello, > > It looks like no ports have used a data transfer items feature. Even the > feature hasn't been updat

[webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

2015-04-21 Thread Chris Dumez
://src.chromium.org/viewvc/blink?view=revisionrevision=152363 Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Safari browser on Mac OSX complains AudioContext.createMediaStreamSource is undefined !

2015-03-19 Thread Chris Dumez
Jer or Eric would know more about this but AudioContext.createMediaStreamSource() is behind a MEDIA_STREAM compile-time flag. It appears the mac port does not turn this flag on so Safari does not currently support the Media Stream API. Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA

[webkit-dev] run-webkit-tests and run-perf-tests scripts now use WebKitTestRunner by default

2015-03-05 Thread Chris Dumez
to these scripts. Kr, --  Chris Dumez - Apple Inc. - Cupertino, CA [1] https://trac.webkit.org/r181093 https://trac.webkit.org/r181093___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-30 Thread Chris Dumez
Hi, I made the changes in: http://trac.webkit.org/changeset/179401 http://trac.webkit.org/changeset/179409 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 29, 2015, at 10:23 AM, Chris Dumez cdu...@apple.com wrote: Hi all, Thanks for the feedback. I submitted a coding style

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-29 Thread Chris Dumez
code unless there is any objection. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 9:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jan 28, 2015 at 9:19 PM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com wrote: This may be a question of what jargon we’ve

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Chris Dumez
Yes, instance() is what I’ve seen mostly outside WebKit as well. This would be my preference. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 8:44 PM, Michael Catanzaro mcatanz...@igalia.com wrote: On Wed, Jan 28, 2015 at 8:11 PM, Maciej Stachowiak m...@apple.com wrote

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Chris Dumez
Fair enough, singleton() is very explicit indeed. I would be happy with this naming too. -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 28, 2015, at 9:19 PM, Maciej Stachowiak m...@apple.com wrote: This may be a question of what jargon we’ve encountered, but to me, “singleton clearly

[webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Chris Dumez
thought I would email webkit-dev to make sure this is actually the case and make sure we agree on a given pattern (one way or another) for current and future code. We could then maybe document this as part of our coding style. Any feedback on this matter? Kr, -- Chris Dumez - Apple Inc. Cupertino

Re: [webkit-dev] EFL EWS bot failures

2015-01-13 Thread Chris Dumez
FYI, this still seems to be happening: https://webkit-queues.appspot.com/results/6182699735711744 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Jan 9, 2015, at 6:55 AM, Gyuyoung Kim gyuyoung@webkit.org wrote: Hello Ossy, Now I'm running two machines for EFL EWS and buildbot

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-20 Thread Chris Dumez
The corresponding Blink bug did contain some performance data: CrBug#229226 https://code.google.com/p/chromium/issues/detail?id=229226 Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Nov 20, 2014, at 11:32 AM, Geoffrey Garen gga...@apple.com wrote: I wonder what the downsides

[webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Chris Dumez
that this change was controversial, but now that it seems it is, I thought I would raise the question on webkit-dev to see what people think about this. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA [1] http://trac.webkit.org/changeset/176275 http://trac.webkit.org/changeset/176275 [2] http

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Chris Dumez
Hi, I believe the Vector class is already checking for overflows. I looked quickly and it seems that when trying to allocate / reallocate the Vector buffer, we will call CRASH() if: (newCapacity std::numeric_limitsunsigned::max() / sizeof(T)) Kr, -- Chris Dumez - Apple Inc. Cupertino, CA

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

2014-11-19 Thread Chris Dumez
If we don’t want to crash on overflow, the callers can use the try*() API I believe (e.g. tryAppend()). This returns false (and does not resize the vector) instead of crashing, when we reach the size limit. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA On Nov 19, 2014, at 2:58 PM, Alexey

[webkit-dev] Transition to is() / downcast() is complete

2014-10-20 Thread Chris Dumez
be nice IMHO. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Behavior change: is(T*) is now doing a null check on the pointer argument

2014-10-02 Thread Chris Dumez
build error (instead of the obscure linking error we would get previously). Kr, -- Chris Dumez - Apple Inc. Cupertino, CA [1] http://trac.webkit.org/changeset/174225 http://trac.webkit.org/changeset/174225___ webkit-dev mailing list webkit-dev

[webkit-dev] Type checking / casting helpers

2014-09-25 Thread Chris Dumez
type check” / “Unnecessary type cast” static assertion. Also note that the plan is to get rid of TYPE_CAST_BASE() macro entirely and extend is() / downcast() to all types, not just Nodes. Kr, -- Chris Dumez - Apple Inc. Cupertino, CA ___ webkit-dev