Re: [webkit-dev] Timing attacks on CSS Shaders (was Re:Security problems with CSS shaders)

2011-12-08 Thread Chris Marrin
On Dec 7, 2011, at 7:23 PM, Vincent Hardy wrote: Hello, @chris So I take back my statement that CSS Shaders are less dangerous than WebGL. They are more!!! It seems to me that the differences are: a. It is easier to do the timing portion of a timing attack in WebGL because it

Re: [webkit-dev] Timing attacks on CSS Shaders (was Re: Security problems with CSS shaders)

2011-12-05 Thread Chris Marrin
On Dec 3, 2011, at 11:57 PM, Adam Barth wrote: On Sat, Dec 3, 2011 at 11:37 PM, Dean Jackson d...@apple.com wrote: On 04/12/2011, at 6:06 PM, Adam Barth wrote: On Mon, Oct 24, 2011 at 9:51 PM, Adam Barth aba...@webkit.org wrote: Personally, I don't believe it's possible to implement this

Re: [webkit-dev] Timing attacks on CSS Shaders (was Re: Security problems with CSS shaders)

2011-12-05 Thread Chris Marrin
On Dec 5, 2011, at 11:32 AM, Adam Barth wrote: On Mon, Dec 5, 2011 at 10:53 AM, Chris Marrin cmar...@apple.com wrote: To be clear, it's not the difference between white and black pixels, it's the difference between pixels with transparency and those without. Can you explain why the attack

Re: [webkit-dev] Starting implementation on W3C Filter Effects

2011-11-04 Thread Chris Marrin
On Nov 3, 2011, at 7:00 PM, Charles Pritchard wrote: In my experience, implementing filters leads to writing them multiple times for various targets. I suggest starting with the lowest common denominator before targeting platforms like webgl. I understand that Google is working on an

Re: [webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

2011-09-28 Thread Chris Marrin
On Sep 27, 2011, at 8:57 PM, James Robinson wrote: ...With that said, I agree with you that there will still be a visual glitch in the current implementation. But what's actually happening is that the timestamp we're sending to rAF is wrong. We're sending current time. Depending on

Re: [webkit-dev] Enable REQUEST_ANIMATION_FRAME on all ports? (was Re: ENABLE flag cleanup strawman proposal)

2011-09-27 Thread Chris Marrin
On Sep 26, 2011, at 9:48 PM, James Robinson wrote: On Sun, Sep 25, 2011 at 6:52 PM, Darin Adler da...@apple.com wrote: On Sep 25, 2011, at 12:20 AM, James Robinson wrote: The TIMER based support for RAF is very new (only a few weeks old) and still has several major bugs. I'd suggest

Re: [webkit-dev] Enable ArrayBuffer by default?

2011-02-11 Thread Chris Marrin
On Feb 11, 2011, at 9:09 AM, Alex Milowski wrote: On Fri, Feb 11, 2011 at 1:41 AM, Adam Barth aba...@webkit.org wrote: How would folks feel about enabling ArrayBuffer by default? It seems to be a basic data type that's used by a bunch of stuff today and likely to be used by more stuff in

[webkit-dev] The future of TransformationMatrix

2011-01-14 Thread Chris Marrin
The current reworking of the TransformationMatrix class and friends (https://bugs.webkit.org/show_bug.cgi?id=48031) got me thinking about the future of this class. I've chit chatted about this with various people, but nothing serious has been done yet. As WebKit and HTML5 get more 3D

Re: [webkit-dev] The future of TransformationMatrix

2011-01-14 Thread Chris Marrin
On Jan 14, 2011, at 4:12 PM, Dirk Schulze wrote: At first SVGMatrix and the complete SVG code itself is not using TransformationMatrix. We had bigger performance problems and the memory amount raised up by 6-10%. Thats why we decided to turn back to AffineTransform. Because of the

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 22, 2010, at 5:34 PM, Jian Li wrote: Hi, TypedArray has been used in some non-WebGL areas, like File API and XHR. It would be nice if we move it out of WebGL feature guard. Any objection? It would probably be best if it had its own guard. Then its various users could turn it on in

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 11:01 AM, Darin Adler wrote: Yes, we want correct conditionals, and TypedArray should not be in the WebGL feature guard if it’s used in other features. Adding a feature new guard would not be good if it has to be set explicitly. It would be much better if the build

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 11:23 AM, Darin Adler wrote: On Dec 23, 2010, at 11:21 AM, Jian Li wrote: We do not add an additional check expression when TypedArray is added to XHR. Is the TypedArray support in XHR a feature in its own right? Should it be off by default or is it ready to be on

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Chris Marrin
On Dec 23, 2010, at 1:47 PM, Charles Pritchard wrote: You need to have Blobs for ArrayBuffer to be of much use for XHR, because you need to be able to set the Content-Type, and browsers may/will fiddle with the content-type header you set, if you have not passed a Blob. Blobs are defined

Re: [webkit-dev] Bools are strictly worse than enums

2010-12-06 Thread Chris Marrin
On Dec 6, 2010, at 10:15 AM, Darin Adler wrote: On Dec 4, 2010, at 3:01 PM, Maciej Stachowiak wrote: Passing a true or false literal (at least in cases where it's not the sole argument) is a likely indicator of unclear style, as opposed to taking a boolean argument. Agreed. In

Re: [webkit-dev] XHR responseArrayBuffer attribute: possible implementation

2010-10-25 Thread Chris Marrin
On Oct 25, 2010, at 12:22 PM, Darin Fisher wrote: The solution for .responseBlob was to add an .asBlob attribute that would need to be set to true before calling .send(). We could do the same for .responseArrayBuffer. -Darin On Mon, Oct 25, 2010 at 12:17 PM, Geoffrey Garen

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-12 Thread Chris Marrin
On Oct 11, 2010, at 5:15 PM, Maciej Stachowiak wrote: On Oct 11, 2010, at 4:03 PM, Chris Marrin wrote: On Oct 11, 2010, at 3:35 PM, James Robinson wrote: On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar...@apple.com wrote: For accelerated 2D rendering we created a class called

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-12 Thread Chris Marrin
On Oct 12, 2010, at 10:44 AM, Darin Adler wrote: On Oct 12, 2010, at 9:47 AM, Chris Marrin wrote: But refcounting is simpler and my current patch has a clear() method on DrawingBuffer which gets rid of all the resources. I could leave that method and change to a refcounted model, so

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-12 Thread Chris Marrin
On Oct 12, 2010, at 2:37 PM, Darin Fisher wrote: ...So it seems like we have two choices: 1) my current patch, which uses backpointers to manage the lifetime of the weak pointers, or 2) refcounting. My current approach has the advantage that the resources are cleared as soon as the

[webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-11 Thread Chris Marrin
For accelerated 2D rendering we created a class called DrawingBuffer. This encapsulates the accelerated drawing surface (usually in the GPU) and the compositing layer used to display that surface on the page. The drawing surface (which is called a Framebuffer Object or FBO) is allocated by

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-11 Thread Chris Marrin
On Oct 11, 2010, at 3:35 PM, James Robinson wrote: On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar...@apple.com wrote: For accelerated 2D rendering we created a class called DrawingBuffer. This encapsulates the accelerated drawing surface (usually in the GPU) and the compositing layer

Re: [webkit-dev] Protecting against stale pointers in DrawingBuffer and GraphicsContext3D

2010-10-11 Thread Chris Marrin
On Oct 11, 2010, at 4:34 PM, James Robinson wrote: On Mon, Oct 11, 2010 at 4:03 PM, Chris Marrin cmar...@apple.com wrote: On Oct 11, 2010, at 3:35 PM, James Robinson wrote: On Mon, Oct 11, 2010 at 3:15 PM, Chris Marrin cmar...@apple.com wrote: ... So is this something I should

Re: [webkit-dev] ArrayBuffer supprot

2010-10-09 Thread Chris Marrin
On Oct 8, 2010, at 3:51 PM, Jian Li wrote: On Fri, Oct 8, 2010 at 3:29 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 8, 2010, at 3:05 PM, Jian Li wrote: Sounds good. I will add the File API feature guard to it and still keep those files under html/canvas. Another possibility

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-10-06 Thread Chris Marrin
+1 +1 +1 ! On Oct 6, 2010, at 5:00 PM, Darin Adler wrote: Hi folks. For those working on Mac OS X: Any objection to upgrading to Xcode 3.2.4? It’s now showing up in Apple’s Software Update for all Xcode users, I believe. I ask because this adds a developmentRegion = English string to

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-30 Thread Chris Marrin
On Sep 29, 2010, at 6:34 PM, Maciej Stachowiak wrote: ...The idea is that when an ArrayBuffer is sent via postMessage, it is atomically closed on this side; its publicly visible length goes to 0, as do the lengths of any views referring to it. On the other side, a new ArrayBuffer wrapper

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-30 Thread Chris Marrin
On Sep 30, 2010, at 10:46 AM, Kenneth Russell wrote: ... Sure, transfer semantics avoid shared mutable state, though it would be inconsistent with most other pure data types. But what if you have some data that doesn't need mutating but you'd like to share with multiple other Workers? Now

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can see. I think we should avoid that. We could keep the raw data around, which hopefully is directly usable as

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 27, 2010, at 6:40 PM, James Robinson wrote: On Mon, Sep 27, 2010 at 6:37 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can see. I think we should avoid that. We

Re: [webkit-dev] XHR responseArrayBuffer attribute

2010-09-28 Thread Chris Marrin
On Sep 28, 2010, at 9:45 AM, Maciej Stachowiak wrote: On Sep 28, 2010, at 7:15 AM, Chris Marrin wrote: On Sep 27, 2010, at 6:37 PM, Maciej Stachowiak wrote: On Sep 27, 2010, at 3:19 PM, Michael Nordman wrote: Webkit's XHR currently does not keep two copies of the data that I can

Re: [webkit-dev] Review tool changes

2010-09-20 Thread Chris Marrin
On Sep 20, 2010, at 11:36 AM, Adam Roben wrote: On Sep 20, 2010, at 2:34 PM, Oliver Hunt wrote: I really would like to be able to select some text and add a comment that uses the selection as context, a single line of context is frequently insufficient, this is about the only thing that

Re: [webkit-dev] Arena is crufty?

2010-09-02 Thread Chris Marrin
On Sep 2, 2010, at 9:41 AM, Kenneth Russell wrote: On Thu, Sep 2, 2010 at 8:51 AM, Chris Marrin cmar...@apple.com wrote: On Sep 1, 2010, at 7:20 PM, Kenneth Russell wrote: I would be happy to not add another Arena client, but the primary reason I need an arena is not just for performance

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Chris Marrin
On Aug 31, 2010, at 6:59 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 6:42 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 31, 2010, at 5:29 PM, Chris Marrin wrote: On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-09-01 Thread Chris Marrin
On Sep 1, 2010, at 1:48 PM, Simon Fraser wrote: On Sep 1, 2010, at 1:04 PM, Chris Marrin wrote: On Sep 1, 2010, at 12:29 PM, Maciej Stachowiak wrote: On Sep 1, 2010, at 11:43 AM, Chris Marrin wrote: But I agree with Maciej that all of the public API is transformation oriented. Even

[webkit-dev] Arena is crufty?

2010-09-01 Thread Chris Marrin
Ken's PODRedBlackTree patch has made me go back and take a closer look at WebKit's Arena class. Turns out it's not a class at all, just some structs and macros. That seems very un-WebKit-like to me. Ken's patch also has a PODArena class, which uses Arena in its implementation. Sam suggests

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Chris Marrin
On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote: On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote: Ken's PODRedBlackTree patch has made me go back and take a closer look at WebKit's Arena class. Turns out it's not a class at all, just some structs and macros. That seems very un

Re: [webkit-dev] Arena is crufty?

2010-09-01 Thread Chris Marrin
On Sep 1, 2010, at 5:12 PM, Kenneth Russell wrote: On Wed, Sep 1, 2010 at 5:08 PM, Chris Marrin cmar...@apple.com wrote: On Sep 1, 2010, at 4:39 PM, Maciej Stachowiak wrote: On Sep 1, 2010, at 4:20 PM, Chris Marrin wrote: Ken's PODRedBlackTree patch has made me go back and take

[webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
I just noticed these classes, added 7 months ago as part of Chris Rogers' audio work. I think it's a mistake to have these in WTF for a few reasons: 1) Complex is just std::complex with a single added function, complexFromMagnitudePhase(), which seems pretty audio specific, so it should go

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 11:05 AM, David Hyatt hy...@apple.com wrote: On Aug 31, 2010, at 10:36 AM, Chris Marrin wrote

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 3:43 PM, Kenneth Russell wrote: On Tue, Aug 31, 2010 at 3:39 PM, Chris Marrin cmar...@apple.com wrote: On Aug 31, 2010, at 3:25 PM, Maciej Stachowiak wrote: On Aug 31, 2010, at 2:06 PM, Chris Marrin wrote: On Aug 31, 2010, at 11:48 AM, Kenneth Russell wrote

Re: [webkit-dev] Complex and Vector3 classes in WTF?

2010-08-31 Thread Chris Marrin
On Aug 31, 2010, at 5:25 PM, Kenneth Russell wrote: ...Yes, I did the Google search and you're right that the term is not in common usage (although I still maintain it's a completely reasonable term). The reason I think it's meaningful is because it really is a matrix of sorts, but a

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-30 Thread Chris Marrin
On Aug 30, 2010, at 11:56 AM, Kenneth Russell wrote: On Sat, Aug 28, 2010 at 12:36 PM, Darin Fisher da...@chromium.org wrote: On Sat, Aug 28, 2010 at 11:32 AM, Adam Barth aba...@webkit.org wrote: On Sat, Aug 28, 2010 at 7:44 AM, Chris Marrin cmar...@apple.com wrote: That's why I still

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-28 Thread Chris Marrin
On Aug 27, 2010, at 4:32 PM, Kenneth Russell wrote: ... Since I decided not to attach these files, here are the non-quantized versions: http://www.rawbw.com/~kbrussel/tmp/butterfly.png http://www.rawbw.com/~kbrussel/tmp/butterfly-o3d.png Another thing we need to discuss are the

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-28 Thread Chris Marrin
On Aug 27, 2010, at 5:32 PM, Kenneth Russell wrote: ... So here's my concern. If you have to multisample for anti-aliasing anyway, why not just tesselate the shape at an appropriate sampling resolution and multisample the resulting triangle rendering. That would have the disadvantage of

[webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Chris Marrin
Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly your tessellation logic works and what it is intended to do. For instance, is the algorithm you're using based on Loop-Blinn? I'm a bit familiar with that algorithm and some of the problems it has

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Chris Marrin
On Aug 27, 2010, at 10:59 AM, Nico Weber wrote: On Fri, Aug 27, 2010 at 10:51 AM, Chris Marrin cmar...@apple.com wrote: On Aug 27, 2010, at 10:32 AM, Nico Weber wrote: On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Chris Marrin
On Aug 27, 2010, at 4:21 PM, Kenneth Russell wrote: On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly your tessellation logic works and what it is intended to do

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Marrin
the following enable: #if ENABLE(AUDIOCONTEXT) After discussing the directory layout in some detail with Eric Carlson, Chris Marrin, Simon Fraser, and Jer Noble, we've decided that the files will primarily live in two places: WebCore/audio WebCore/platform/audio I know that some

Re: [webkit-dev] Web Audio API

2010-08-24 Thread Chris Marrin
On Aug 24, 2010, at 3:53 PM, Chris Rogers wrote: Hi Chris, That also sounds like a reasonable naming scheme. The only counter-argument I would have is that we have several directories in WebCore which don't have the 'web' prefix such as: WebCore/notifications WebCore/storage

Re: [webkit-dev] ANGLE compile failure?

2010-08-17 Thread Chris Marrin
On Aug 17, 2010, at 1:42 PM, Eric Uhrhane wrote: I'm getting the same failure in two clients, and the second has nothing checked out. This is on OSX 10.5.8, using the standard webkit build scripts and code synced yesterday [several times, same error]. Given that I don't hear anyone else

Re: [webkit-dev] ANGLE compile failure?

2010-08-17 Thread Chris Marrin
On Aug 17, 2010, at 3:24 PM, Eric Uhrhane wrote: On Tue, Aug 17, 2010 at 2:00 PM, Chris Marrin cmar...@apple.com wrote: On Aug 17, 2010, at 1:42 PM, Eric Uhrhane wrote: I'm getting the same failure in two clients, and the second has nothing checked out. This is on OSX 10.5.8, using

Re: [webkit-dev] ANGLE

2010-08-13 Thread Chris Marrin
On Aug 13, 2010, at 4:25 AM, Zoltan Herczeg wrote: Hi, ANGLE looks like a graphics helper library. Why it is placed in the root WebKit directory? Perhaps WebCore/platform/graphics or some kind of /3rparty directory would be better, wouldn't it? ANGLE is a library from Google

Re: [webkit-dev] WebKit Icon license?

2010-03-24 Thread Chris Marrin
On Mar 23, 2010, at 9:05 PM, Maciej Stachowiak wrote: On Mar 23, 2010, at 9:00 PM, Shinichiro Hamaji wrote: A related P1 issue :) http://webkit.org/b/19371 Want. Where can I obtain that shirt? Print out the image and send it to http://cafepress.com. I have gotten some custom

Re: [webkit-dev] Video feature request

2010-01-14 Thread Chris Marrin
On Jan 14, 2010, at 9:23 AM, Oliver Hunt wrote: On Jan 14, 2010, at 9:00 AM, Zack S wrote: Hi all, There's a feature that I would find useful that's not as far as I know a part of HTML5/Javascript in Webkit based browsers. Namely, I'd like to be able to open a video from within

[webkit-dev] DOMAttrModified events in WebKit

2010-01-05 Thread Chris Marrin
There is a bug posted (https://bugs.webkit.org/show_bug.cgi?id=8191) about the implementation of DOMAttrModified events. The implementation is quite far along and there are many posts begging for it, but it is stalled because of one comment (https://bugs.webkit.org/show_bug.cgi?id=8191#c17)

[webkit-dev] Resolution on switch statement indentation

2009-12-09 Thread Chris Marrin
I saw another patch get rejected today because of switch statement indentation. We discussed this last week, and I saw a lot of support for my proposal of indenting case labels from their switch. But the discussion did not end in resolution. To summarize, here are the options mentioned:

Re: [webkit-dev] Resolution on switch statement indentation

2009-12-09 Thread Chris Marrin
On Dec 9, 2009, at 8:13 AM, Adam Treat wrote: On Wednesday 09 December 2009 10:26:24 am Chris Marrin wrote: I saw another patch get rejected today because of switch statement indentation. We discussed this last week, and I saw a lot of support for my proposal of indenting case labels from

Re: [webkit-dev] Resolution on switch statement indentation

2009-12-09 Thread Chris Marrin
On Dec 9, 2009, at 9:41 AM, Maciej Stachowiak wrote: On Dec 9, 2009, at 7:26 AM, Chris Marrin wrote: I saw another patch get rejected today because of switch statement indentation. We discussed this last week, and I saw a lot of support for my proposal of indenting case labels from

[webkit-dev] Switch statement indentation

2009-12-02 Thread Chris Marrin
The style script flagged an issue in my code yesterday for an issue I didn't even know existed. How do you indent case clauses for a switch statement? The WebKit style states that case clauses have the same indentation as their switch. I HATE that style. And I had no idea that was the

Re: [webkit-dev] Switch statement indentation

2009-12-02 Thread Chris Marrin
On Dec 2, 2009, at 4:47 PM, Alexey Proskuryakov wrote: On 02.12.2009, at 15:25, Chris Marrin wrote: Maybe we could change the style rule in the interest of changing fewer files (and because I think it generally reads better)? I support changing or dropping this rule. Because

Re: [webkit-dev] New requirement for building on Windows coming

2009-11-24 Thread Chris Marrin
On Nov 24, 2009, at 11:12 AM, Alexey Proskuryakov wrote: On 24.11.2009, at 9:46, Adam Roben wrote: On second thought, even if we soft-link, we'll still have dependencies on the D3D headers... Can we make a local copy of those? I've used the DXSDK_DIR env var to handle both the

Re: [webkit-dev] Running WebGL layout tests

2009-11-11 Thread Chris Marrin
On Nov 3, 2009, at 12:35 PM, Kenneth Russell wrote: Hi, Trying to run the WebGL layout tests in LayoutTests/fast/canvas/webgl. Here's the command line I'm using: run-webkit-tests --debug LayoutTests/fast/canvas/webgl/[test name.html] (I built WebKit --debug.) All of the tests fail while

Re: [webkit-dev] Style guide for indenting nested #if #define in headers

2009-10-15 Thread Chris Marrin
On Oct 15, 2009, at 8:54 AM, Timothy Hatcher wrote: This is rather ugly and does not match the majority of the code we have in WebCore already. I agree. I don't find any issues with the current, unindented style. I just think that ifdefs that span more than 10 lines or so should always put

Re: [webkit-dev] WebKit and Khronos Group

2009-08-10 Thread Chris Marrin
On Aug 8, 2009, at 7:02 PM, Jeremy Orlow wrote: On Sat, Aug 8, 2009 at 2:02 PM, Maciej Stachowiak m...@apple.com wrote: On Aug 8, 2009, at 11:39 AM, Harry Underwood wrote: Thanks for the link. Didn't even know that WebGL is being considered by WebKit. What Oliver showed you is patches

Re: [webkit-dev] Patch process - let's make it better

2009-07-10 Thread Chris Marrin
On Jul 10, 2009, at 3:55 PM, Maciej Stachowiak wrote: Hi everyone, One common topic for discussion has been how to make our process around patch submission better. As the project grows, it's becoming more important for this process to work really smoothly, and we are seeing some

Re: [webkit-dev] Proposed Timer API

2008-10-03 Thread Chris Marrin
On Oct 2, 2008, at 6:13 PM, Maciej Stachowiak wrote: On Oct 2, 2008, at 6:01 PM, Cameron McCormack wrote: Hi Maciej. Cameron McCormack: If possible, it would be nice if there could be some degree of compatibility between this proposed API and the one in SVG Tiny 1.2:

Re: [webkit-dev] Proposed Timer API

2008-10-03 Thread Chris Marrin
On Oct 3, 2008, at 1:48 PM, Maciej Stachowiak wrote: On Oct 3, 2008, at 11:01 AM, Chris Marrin wrote: On Oct 2, 2008, at 6:13 PM, Maciej Stachowiak wrote: On Oct 2, 2008, at 6:01 PM, Cameron McCormack wrote: Hi Maciej. Cameron McCormack: If possible, it would be nice if there could