Re: [webkit-dev] Cannot load pages with run-safari --ios-simulator (public SDK)

2019-06-06 Thread Dan Bernstein
> On Jun 6, 2019, at 9:19 AM, Frédéric Wang wrote: > > WebContent and Networking seems to abort but the backtraces are not > really helpful: > > * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT > * frame #0: 0x00011421338e dyld`__abort_with_payload + 10 >

Re: [webkit-dev] Freenode spam counter-measure

2018-08-05 Thread Dan Bernstein
> On Aug 5, 2018, at 3:20 PM, Darin Adler wrote: > >> On Aug 5, 2018, at 2:38 AM, Philippe Normand wrote: >> >> Can one of the #webkit admin please set the +r mode on? This would help >> reducing spam. Only messages from registered nicks would come through. > > I tried this by typing

Re: [webkit-dev] How can I reset the $DYLD_FRAMEWORK_PATH to the default value?

2018-06-08 Thread Dan Bernstein
s/Scripts leave the variable set outside the scope of the script execution. So unless you set it yourself in some context (such as your current shell), you don’t need to worry about it. If you do set it, then simply un-setting it should suffice. > > At 2018-06-08 23:12:51, "Dan Bernstein&

Re: [webkit-dev] How can I reset the $DYLD_FRAMEWORK_PATH to the default value?

2018-06-08 Thread Dan Bernstein
> On Jun 8, 2018, at 6:19 AM, Jingbin Yu wrote: > > Hi, everybody: > As what's said on webkit.org, running the WebKit I built involves changing > the value of $DYLD_FRAMEWORK_PATH environment variable to point to my build > products, making Safari load my WebKit build instead of using the

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Dan Bernstein
> On Jun 6, 2018, at 9:28 AM, Darin Adler wrote: > > Hi folks. > > As some of you have probably noticed, I’ve begun making changes with the goal > of preparing us to move most Objective-C code in WebKit to ARC. In doing so, > I have been exploring the existing code in the tree and the

Re: [webkit-dev] Tips to build faster on Mac?

2018-03-27 Thread Dan Bernstein
> On Mar 27, 2018, at 9:07 AM, Frédéric Wang wrote: > > I see that the make command allows to make incremental builds for macOS. Does > anyone know how to specify that we want to build for the iOS Simulator? Add SDKROOT=iphonesimulator to the make

Re: [webkit-dev] [webkit-changes] [224805] trunk/Source/WebKit

2017-11-13 Thread Dan Bernstein
> On Nov 13, 2017, at 11:26 PM, rn...@webkit.org wrote: > > -#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101200 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101200 A right-closed interval for __MAC_OS_X_VERSION_MIN_REQUIRED is usually incorrect. Did you mean to write < 101300 ?

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Dan Bernstein
> On Aug 30, 2017, at 7:33 PM, Dean Jackson wrote: > > Dan, how did you gather the data below (i.e. how did you count the number of > files compiled)? Number of Compile* instances in the build log. ___ webkit-dev mailing list

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
uch a benchmark would be a good approximation, so that’s a bad alternative to gathering more evidence. > > Geoff > >> On Aug 29, 2017, at 2:21 PM, Dan Bernstein <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Aug 2

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 1:39 PM, Geoffrey Garen wrote: > >> I see. The right question to ask would have been how much change occurs in >> their working copy between consecutive incremental builds. > > If you want to help make our benchmark righter, please do share any data

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 12:48 PM, Geoffrey Garen wrote: > >>> We have some preliminary data that says incremental builds will be OK, but >>> not a full benchmark. >>> >>> Here’s a full benchmark I propose to test incremental builds: >>> >>> Start 7 days ago in SVN

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 11:03 AM, Geoffrey Garen wrote: > >> I worry about adopting unity build because while it makes clean builds >> faster, it also slows down incremental builds. As a developer, I rarely do >> clean builds, I mostly do incremental builds so this would

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-19 Thread Dan Bernstein
On Jun 19, 2017, at 10:20 AM, Geoffrey Garen wrote: >>> Another minor comment: it seems like this new API returns raw data. It >>> seems like the native way to use this would result in running untrusted >>> data from the network through image decoders outside the Web

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-16 Thread Dan Bernstein
> On Jun 16, 2017, at 11:25 AM, Brady Eidson wrote: > > >> On Jun 16, 2017, at 11:11 AM, Maciej Stachowiak > > wrote: This is slightly tangential, but a comment on the model: it doesn't seem like there's a way for clients

Re: [webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Dan Bernstein
I suggest that when this takes place, the Xcode projects within these directories get renamed as well, to maintain the invariant that the .xcodeproj is named after the enclosing directory. > On May 10, 2017, at 11:18 AM, Maciej Stachowiak wrote: > > > I'd like to propose the

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Dan Bernstein
> On May 9, 2017, at 10:23 PM, Maciej Stachowiak wrote: > >> JSTests, and > > Could go under JavaScriptCore, since these by design don't test anything > outside of JavaScriptCore. There is an advantage to Apple’s internal production build system in keeping large amounts of

Re: [webkit-dev] !!Tests for equality comparison

2017-04-27 Thread Dan Bernstein
> On Apr 27, 2017, at 4:36 PM, Geoffrey Garen wrote: > >>> On Apr 27, 2017, at 16:30, Geoffrey Garen >> > wrote: >>> >>> I’ve never really liked this style rule, and I’ve always felt like it snuck >>> into the style document

[webkit-dev] Unable to log in to bugs.webkit.org

2017-04-01 Thread Dan Bernstein
Can someone help me log in to by bugs.webkit.org account? I logged out of bugs.webkit.org and now when I try to log in with my email m...@webkit.org, an error message appears saying that I must request a new password. When I click the

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Dan Bernstein
> On Jan 11, 2017, at 5:43 PM, Maciej Stachowiak wrote: > > > To be clear, I think PAL is a great move. Details like the namespace, > placement of the code, and how includes look are all things that can be > changed after the fact. > > That said, I think we need to

Re: [webkit-dev] Problems running WebKit/Safari in Sierra

2016-11-15 Thread Dan Bernstein
> On Nov 15, 2016, at 7:23 AM, Joanmarie Diggs wrote: > > Hey all. > > WebKit/Safari builds just like it always does, but running it now fails > for me in Safari (10.12.1): > > $ ./Tools/Scripts/run-safari > Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Dan Bernstein
> On Sep 5, 2016, at 10:13 AM, Darin Adler wrote: > > Hi folks. > > WebKit has some critical functions that involve asking an object to give up > ownership of something so the caller can take ownership. > > In the C++ standard library itself, this is called move, as in

Re: [webkit-dev] Request for editbugs bit on Bugzilla

2016-02-18 Thread Dan Bernstein
I’ve added canconfirm and editbugs to web...@chrisrebert.com. > On Feb 18, 2016, at 10:59 PM, Chris Rebert wrote: > > Hello, > > I'd like to request the editbugs bit on Bugzilla, so as to be able to > correct the Component field or (after testing) update the >

[webkit-dev] A recent change to how WebKit XPC services work for development

2016-01-28 Thread Dan Bernstein
The recent r195795 changed how WebKit XPC services work for development. I expect this change to not have any impact on most of your workflows, but read on for the details, and be on the lookout for any things that might have broken

Re: [webkit-dev] OSX: Linking to custom build resorts to system version...

2015-11-28 Thread Dan Bernstein
> On Nov 11, 2015, at 2:06 AM, Nikolay Tsenkov wrote: > > Hello, > > First of all, thanks for the awesome OSS software that WebKit is! > > I need some help with linking to a fresh build of WebKit.framework on OS X: > - I am building a modified version of WebKit.framework

Re: [webkit-dev] Request for editbugs privilege on bugzilla

2015-08-20 Thread Dan Bernstein
On Aug 20, 2015, at 11:39 AM, Andrunko andru...@gmail.com wrote: Hi all, I would like to request editbugs privilege on bugzilla (I went to close #124167 in favor of #148028 but dont have permission) - I am a committer. Please let me know if I should ask someplace else instead. BR,

Re: [webkit-dev] Port-specific OpenType support

2014-09-11 Thread Dan Bernstein
On Sep 11, 2014, at 11:44 AM, Myles C. Maxfield mmaxfi...@apple.com wrote: Hello, Webkittens! I have started work on an SVG font - OpenType converter [1] with the intent of eventually getting rid of our code path which lays out and draws text using SVG fonts. The motivation is

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Dan Bernstein
On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa rn...@webkit.org wrote: When the bug for a rollout is created, the original bug is automatically reopened. This is a long-standing bug in the bot. The original bug should not be reopened until the change that fixed it is reverted.

Re: [webkit-dev] EFL and GTK on Darwin

2014-02-11 Thread Dan Bernstein
On Feb 11, 2014, at 12:29 AM, Žan Doberšek zandober...@gmail.com wrote: Hi. On Mon, Feb 10, 2014 at 6:30 PM, Dan Bernstein m...@apple.com wrote: Hi everyone, and especially EFL and GTK contributors! In preparation for changing PLATFORM(MAC) to be false when building for iOS, I have

[webkit-dev] EFL and GTK on Darwin

2014-02-10 Thread Dan Bernstein
Hi everyone, and especially EFL and GTK contributors! In preparation for changing PLATFORM(MAC) to be false when building for iOS, I have been reviewing usage of PLATFORM(MAC) throughout our codebase. Some of these uses are really about targeting the Darwin OS. However, I could not simply

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Dan Bernstein
On Jan 11, 2014, at 2:47 PM, Darin Adler da...@apple.com wrote: Hi folks. There is a lot of WebKit code that needs to be on for “the Mac and iOS ports”. Some of it is guarded be conditionals with a higher level concept. But most of it, now this is guarded by PLATFORM(MAC). I think that’s

Re: [webkit-dev] Rename PLATFORM(MAC) to PLATFORM(COCOA)?

2014-01-11 Thread Dan Bernstein
On Jan 11, 2014, at 3:19 PM, Darin Adler da...@apple.com wrote: On Jan 11, 2014, at 3:12 PM, Anders Carlsson ander...@apple.com wrote: One downside is that we won’t be able to make PLATFORM(MAC) mean “the Mac port” before all the uses have been audited and converted to

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Dan Bernstein
Sent from my iPad On Jan 6, 2014, at 11:55 AM, Darin Adler da...@apple.com wrote: I suggest we use nullptr, rather than of 0 or NULL, for all pointer nulls in WebKit C++ sources. I don’t see any advantage to using 0 or NULL over nullptr, and nullptr has multiple advantages. Three

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-02 Thread Dan Bernstein
On Jan 2, 2014, at 1:12 PM, Geoffrey Garen gga...@apple.com wrote: Hi folks. Recently, I’ve seen patches go by using the C++11 “auto” keyword. For example, let me pick on Andreas: http://trac.webkit.org/changeset/161143 +auto newRenderer = textNode.createTextRenderer(style); +

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-07-01 Thread Dan Bernstein
On Jul 1, 2013, at 7:31 PM, Brady Eidson beid...@apple.com wrote: On Jul 1, 2013, at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sun, Jun 30, 2013 at 9:39 PM, Filip Pizlo fpi...@apple.com wrote: On Jun 19, 2013, at 9:41 AM, Dan Bernstein m...@apple.com wrote: On Jun 19, 2013

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-06-30 Thread Dan Bernstein
On Jun 19, 2013, at 7:37 PM, Timothy Hatcher timo...@apple.com wrote: What about? StyleResolver* existingStyleResolver() StyleResolver styleResolver() I like it. — Timothy Hatcher On Jun 19, 2013, at 11:49 AM, Balazs Kelemen kbal...@webkit.org wrote: For me optional seems very

Re: [webkit-dev] Safari support for Web Speech API

2013-05-15 Thread Dan Bernstein
On May 15, 2013, at 4:46 PM, Randy Brown rbr...@madmobile.com wrote: I'm trying to ascertain if, and when, Apple is planning on supporting the Web Speech API. This email from Chris that was attached to this post earlier in the year, is the ONLY thing I can find on the web regarding Apple's

Re: [webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?

2013-03-10 Thread Dan Bernstein
On Mar 10, 2013, at 6:15 PM, Darin Adler da...@apple.com wrote: On Mac, SVGStopElement.idl keeps getting recompiled every time I build WebCore, and then in turn everything that uses the headers generated. Anyone know why this happens? Is this specific to Mac, or happening with other build

[webkit-dev] New web-exposed feature: ruby-position: {before, after}

2012-11-29 Thread Dan Bernstein
As specified in http://www.w3.org/TR/2011/WD-css3-ruby-20110630/#rubypos, the ruby-position property takes four values: before, after, inter-character, and inline. In http://trac.webkit.org/r136142 I added a -webkit-ruby-position property and support for the before and after values (the former,

Re: [webkit-dev] WKCreateCTLineWithUniCharProvider

2012-09-27 Thread Dan Bernstein
On Sep 26, 2012, at 2:34 AM, Glenn Adams gl...@skynav.com wrote: Where can I find the source for WKCreateCTLineWithUniCharProvider? I'm working on a bug [1] in which I will need to at least understand and perhaps modify its behavior. Basically, to fix this bug, I need to pass character

Re: [webkit-dev] unsigned vs unsigned int

2012-09-13 Thread Dan Bernstein
On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi there, I was telling people to use unsigned instead of unsigned int, as I have been told that was the preferred style before, but apparently that is not in the style guide. The question

Re: [webkit-dev] testing strategy? - CJK line breaking tests

2012-09-04 Thread Dan Bernstein
On Sep 4, 2012, at 5:50 AM, Glenn Adams gl...@skynav.com wrote: Alternatively, you can compute the with of each character with script (without adding any new feature to WebKit). Unfortunately, that won't work since I can't access the width of individual lines produced by formatting a

[webkit-dev] Please include function-level comments in change log entries

2012-07-06 Thread Dan Bernstein
It appears that lately most WebCore change log entires don’t include any comments on individual functions. An overall description of the change at the top of the change log entry is valuable, but it is no substitute for describing the changes to each function. Good function-level comments are

Re: [webkit-dev] Compiling WebKit in 32 bit for Mac

2012-06-17 Thread Dan Bernstein
On Jun 17, 2012, at 11:12 AM, Mark Gilbert wrote: Hi There, Could anyone enlighten me on how to create a 'build-webkit' tool which compiles the frameworks with 32-bit (and 64-bit perhaps). I need a 32-bit compatible set of frameworks to allow the WebKit app to support 32-bit plug ins

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Dan Bernstein
On Jun 12, 2012, at 5:17 PM, Ojan Vafai o...@chromium.org wrote: See https://bugs.webkit.org/show_bug.cgi?id=87772. It's great to use a fuzzer in order to find cases where we're broken and then make reduced layout tests from those. The viewspec-parser tests are themselves just a fuzzer

Re: [webkit-dev] editbugs permission

2012-06-13 Thread Dan Bernstein
On Jun 13, 2012, at 9:25 PM, Mike Lawther wrote: Hi there, I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has already landed a couple of patches and is helping us triage bugs. Done ___ webkit-dev mailing list

Re: [webkit-dev] We should rename layoutTestController to testController

2012-05-31 Thread Dan Bernstein
On May 31, 2012, at 12:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, May 31, 2012 at 11:56 AM, Darin Adler da...@apple.com wrote: I am thinking we should rename layoutTestController to testController. Or if you don’t like that name, maybe testHarness or some even better name.

Re: [webkit-dev] [webkit-changes] [119113] trunk/Source/WebKit/gtk

2012-05-31 Thread Dan Bernstein
On May 31, 2012, at 9:36 AM, commit-qu...@webkit.org wrote: Revision 119113 Author commit-qu...@webkit.org Date 2012-05-31 09:36:29 -0700 (Thu, 31 May 2012) Modified: trunk/Source/WebKit/gtk/ChangeLog (119112 = 119113) --- trunk/Source/WebKit/gtk/ChangeLog 2012-05-31 16:32:33 UTC

Re: [webkit-dev] Debugging With Xcode

2012-05-06 Thread Dan Bernstein
On Apr 24, 2012, at 12:18 AM, Eric Seidel wrote: I have updated to the latest Xcode. My current hack for being able to build from the command line as well as within Xcode is that I've manually added symlinks from Source/WebCore/build - ../../WebKitBuild (since it no longer seems possible

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Dan Bernstein
this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you

[webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Dan Bernstein
Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient. Thanks. ___ webkit-dev

[webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Dan Bernstein
Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient. Thanks. ___ webkit-dev

Re: [webkit-dev] Load event for cached resources in DRT

2012-01-06 Thread Dan Bernstein
On Jan 6, 2012, at 8:18 AM, Alexandru Chiculita ach...@adobe.com wrote: I need to add more tests for CSS Shaders, but I couldn't find a nice way to know that a cached resource is loaded. So the result is that in DRT the screenshot is taken too early. Other tests use the onload event of the

Re: [webkit-dev] For debugging in xcode - Breakpoint does not work.

2011-12-07 Thread Dan Bernstein
On Dec 6, 2011, at 11:01 PM, Kihong Kwon vim...@gmail.com wrote: Hello. I am a new to mac. Can anyone help me for debugging WebCore? I have a problem about breakpoint with xcode. What I want to say, I can't use a breakpoint with WebCore in the xcode. After finish to build webkit, I

Re: [webkit-dev] Forcing relayout on style change

2011-11-17 Thread Dan Bernstein
On Nov 17, 2011, at 7:55 AM, Fady Samuel fsam...@chromium.org wrote: Hi all, I've been in the process of implementing the aspect-ratio CSS property. I have a patch that plumbs the property to RenderStyle. I'd like to include code that force relayout upon a change to aspect ratio on the

[webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/ScriptElement.h (96818 = 96819) --- trunk/Source/WebCore/dom/ScriptElement.h 2011-10-06 16:37:35 UTC (rev 96818) +++ trunk/Source/WebCore/dom/ScriptElement.h 2011-10-06 16:40:47 UTC (rev 96819)

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
, 2011 at 10:07 AM, Dan Bernstein m...@apple.com wrote: On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/ScriptElement.h (96818 = 96819) --- trunk/Source/WebCore/dom/ScriptElement.h 2011-10-06 16:37:35 UTC (rev 96818) +++ trunk/Source/WebCore/dom

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
On Oct 6, 2011, at 10:11 AM, Gavin Peters (蓋文彼德斯) wrote: Dan, You're right. I'm adding #if PLATFORM(CHROMIUM) to this change shortly. Thank you. - Gavin On 6 October 2011 13:07, Dan Bernstein m...@apple.com wrote: On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: Modified

Re: [webkit-dev] Chromium PLT regression

2011-10-04 Thread Dan Bernstein
On Oct 4, 2011, at 10:37 PM, Adam Barth wrote: About a week ago, the Chromium project measured a PLT regression on Windows, Mac, and Linux: https://bugs.webkit.org/show_bug.cgi?id=69238 I don't know whether the regression affects any other ports, but according to the Chromium

Re: [webkit-dev] Hyphenation in webkit

2011-09-07 Thread Dan Bernstein
On Sep 7, 2011, at 2:28 AM, Sireesha Janakiraman wrote: Hello, I tried hyphenation test files in webkit. a)'http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphens.html' b) http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphenate-character.html via GtkLauncher

Re: [webkit-dev] Using inline-block divs for line breaking tests

2011-08-24 Thread Dan Bernstein
On Aug 24, 2011, at 1:08 PM, Alan Stearns wrote: I have an idea for writing LayoutTests where what's being tested are line breaks. Take the case of this recent bug fix: https://bugs.webkit.org/show_bug.cgi?id=2 The problem here was that if you had a left float and text-indent

Re: [webkit-dev] Switching away from integers for layout

2011-06-23 Thread Dan Bernstein
On Jun 23, 2011, at 11:46 AM, Levi Weintraub wrote: We’ve been getting an increasing number of complaints lately about the zooming support in webkit and how hard it is to correctly support zooming in complex web applications. To address this we plan to convert the rendering tree to float

[webkit-dev] Why is gtest in the Source directory?

2011-05-12 Thread Dan Bernstein
Is gtest required to build any of the WebKit ports? If not, can it be moved out of Source and into Tools? Thanks, —Dan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)

2011-04-06 Thread Dan Bernstein
On Apr 6, 2011, at 3:11 PM, Pere Martir wrote: On Wed, Apr 6, 2011 at 11:50 PM, Adam Roben aro...@apple.com wrote: It's possible that you need the fonts from a specific version of Mac OS X. I don't know what version that would be, though. What if I want to submit a patch and I am working

Re: [webkit-dev] Use of -webkit- prefix on CSS Values and Properties

2011-03-27 Thread Dan Bernstein
On Mar 27, 2011, at 9:27 AM, Simon Fraser wrote: On Mar 27, 2011, at 9:07 AM, Eric Seidel wrote: Do we have any guidelines as to when we use -webkit- for new properties vs not? For example, when implementing CSS3 properties (like we are this week for the BiDi sprint):

Re: [webkit-dev] process for unreviewed commits

2011-03-04 Thread Dan Bernstein
On Mar 3, 2011, at 11:58 PM, Ojan Vafai wrote: This isn't a big deal either way, but I noticed that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit lists the following as the process for unreviewed commits: Unreviewed commits should include a line saying

[webkit-dev] Why does Ahem have different vertical metrics in Qt?

2011-02-08 Thread Dan Bernstein
In an attempt to give layout tests consistent results across platforms, I ofter use the Ahem font. However, I’ve noticed that Qt still requires platform-specific results when I do that. One recent example is fast/dynamic/unicode-bidi.html $ diff -u

[webkit-dev] Please set the svn:mime-type property on binary files before committing

2011-01-14 Thread Dan Bernstein
Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient. Thanks.___ webkit-dev

[webkit-dev] WebKitTools has changed to Tools

2010-12-17 Thread Dan Bernstein
Done in r74301. On Nov 20, 2010, at 11:29 PM, Dan Bernstein wrote: WebKit developers, I am going to commit the patch from https://bugs.webkit.org/show_bug.cgi?id=49861, renaming the WebKitTools directory to Tools and updating all internal references. If you update your tree after

Re: [webkit-dev] WebKitTools is changing to Tools

2010-12-10 Thread Dan Bernstein
date. -eric On Fri, Dec 10, 2010 at 2:10 PM, Dan Bernstein m...@apple.com wrote: On Dec 10, 2010, at 1:58 PM, Adam Barth aba...@webkit.org wrote: Is it time to throw the switch now? How about next week, Dec 17 at around 4PM PST? Adam On Sun, Nov 21, 2010 at 9:55 AM, Dan

Re: [webkit-dev] Pixel tests and displaying text

2010-12-08 Thread Dan Bernstein
On Dec 8, 2010, at 12:13 PM, Peter Kasting wrote: If you never write layout tests, you can stop reading. Right now few ports run pixel tests (a shame). One reason is because we frequently need different reference images for each port, and creating hundreds or thousands of these is a

Re: [webkit-dev] Rebaselining render tree dumps

2010-12-06 Thread Dan Bernstein
On Dec 6, 2010, at 12:30 PM, David Hyatt wrote: RenderTreeAsTetxt has a large number of hacks in it that have been put in over time to keep the dumps from changing too dramatically. Some of these include: (1) Table cells dump incorrect dimensions and positions. (2) Text nodes dump an

Re: [webkit-dev] Build Errors on Mac OS

2010-11-29 Thread Dan Bernstein
On Nov 29, 2010, at 1:18 PM, Eric Mader wrote: Hi, I'm trying to build TOT (as of an hour or so ago) on Mac OS. I'm getting a bunch of compile errors in WebKit2Shared/mac/SandboxExtensionMac.mm. The compiler can't find any of the WKSandBoxExtensionXXX symbols (e.g.

Re: [webkit-dev] WebKitTools is changing to Tools

2010-11-21 Thread Dan Bernstein
On Nov 21, 2010, at 5:41 AM, Eric Seidel wrote: That's likely to break all the ews and commit bots. Since I'm on vacation at least the ones I run will remain broken until I return on 29th. Thanks for letting me know. I will make this change some other time. On Nov 21, 2010 2:31 AM, Dan

[webkit-dev] WebKitTools is changing to Tools

2010-11-20 Thread Dan Bernstein
WebKit developers, I am going to commit the patch from https://bugs.webkit.org/show_bug.cgi?id=49861, renaming the WebKitTools directory to Tools and updating all internal references. If you update your tree after that, you might need to adjust any personal scripts or tools that refer to the

[webkit-dev] Can the build bot trigger be limited to trunk?

2010-11-04 Thread Dan Bernstein
As far as I can tell, all of the builders and testers use trunk, so changes to branches and tags should not trigger a build. Can the build bot be configured accordingly? ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] disable selection of text and images

2010-10-19 Thread Dan Bernstein
On Oct 19, 2010, at 10:07 AM, Efan... wrote: Hi All unfortunately I can not use JAVA script or any thing like that cause my application is totally c++ , QT based. I need to make the change in webkit src code I guess. Note that this is already supported (with no source changes) on Mac OS X

Re: [webkit-dev] X-Purpose, again!

2010-10-11 Thread Dan Bernstein
On Oct 9, 2010, at 7:11 AM, Gavin Peters (蓋文彼德斯) wrote: On 8 October 2010 12:02, Dan Bernstein m...@apple.com wrote: On Oct 8, 2010, at 6:26 AM, Gavin Peters (蓋文彼德斯) wrote: In particular, Safari sends X-Purpose: preview headers on requests for resources and subresources motivated

Re: [webkit-dev] X-Purpose, again!

2010-10-08 Thread Dan Bernstein
On Oct 8, 2010, at 6:26 AM, Gavin Peters (蓋文彼德斯) wrote: In particular, Safari sends X-Purpose: preview headers on requests for resources and subresources motivated by the previw feature of Safari. That’s incorrect. The header is only present in the request for the main

Re: [webkit-dev] RenderStyle inheritance

2010-09-18 Thread Dan Bernstein
On Sep 18, 2010, at 12:39 PM, François Sausset wrote: If, in a RenderObject method (let's say addChild() or layout()), I change a style property that should be inherited (for instance style()-setColor()), the corresponding style property of the children is not updated. As a rule, you

Re: [webkit-dev] What is XBL?

2010-08-25 Thread Dan Bernstein
On Aug 25, 2010, at 9:11 AM, Julien Chaffraix wrote: http://en.wikipedia.org/wiki/XBL , I guess? FYI XBL has been superseded by XBL 2.0 that is not backward compatible with the first version [1]. Thus our code is just obsolete. All XBL-related code in WebKit is for XBL2. It seems as if

Re: [webkit-dev] Name nitpick: layout tests

2010-08-02 Thread Dan Bernstein
On Aug 2, 2010, at 4:28 AM, Alexey Proskuryakov wrote: 29.07.2010, в 10:59, Darin Adler написал(а): The directory should be eventually be named Tests or WebKitTests or RegressionTests. Ideally, the directory will have a unique first letter for better tab completion - so

Re: [webkit-dev] Crash in RenderLayer related to setStyle() - Questions

2010-07-24 Thread Dan Bernstein
On Jul 23, 2010, at 3:48 PM, Alex Milowski wrote: I've identified a crash with the MathML implementation related to use of CSS style rules that cause a RenderLayer instance to be created. In the MathML code's various createRenderer() methods, they always call RenderObject::setStyle() on the

Re: [webkit-dev] STIX Fonts and MathML Tests

2010-07-07 Thread Dan Bernstein
On Jul 7, 2010, at 3:48 AM, Alex Milowski wrote: Is there any precedence for this or default policy for tests requiring fonts? Yes. Some tests require the Ahem font, so the font is checked into the repository and—at least on Mac OS X and Windows—DumpRenderTree activates the font while

Re: [webkit-dev] STIX Fonts and MathML Tests

2010-07-07 Thread Dan Bernstein
On Jul 7, 2010, at 9:57 AM, Alex Milowski wrote: The STIX fonts are relatively small (2.6MB for the full download) and we probably don't need all of them. Would it be acceptable to check these in like the Ahem font? Subject to WebKit’s licensing requirements, yes.

Re: [webkit-dev] STIX Fonts and MathML Tests

2010-07-07 Thread Dan Bernstein
On Jul 7, 2010, at 11:17 AM, Sausset François wrote: If every is OK with licenses, how DumpRenderTree needs to be modified to use custom fonts? This is where the Mac version activates test fonts: http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L218 and

Re: [webkit-dev] How to convert character offset into VisiblePosition?

2010-06-02 Thread Dan Bernstein
On Jun 1, 2010, at 10:48 PM, Xiaomei Ji wrote: Given a DOM Node and an InlineBox, is there a way to convert the character offset within this InlineBox to a VisiblePosition? considering bidi/RTL. Not sure how being given a DOM node helps here… Using span node in the following example as

Re: [webkit-dev] About fixing old layout bugs

2010-06-01 Thread Dan Bernstein
Hi Xianzhu, On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote: Hi, I'm new to webkit development, and I'd like to hear opinions about the problems I met. Now I'm trying to fix some old layout bugs, for example: * white space preceding br (https://bugs.webkit.org/show_bug.cgi?id=37261)

Re: [webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Dan Bernstein
On Mar 28, 2010, at 7:08 PM, Sam Weinig wrote: I am not sure which tests you are referring to that use the user-agent to change behavior, but that is not the way it is supposed to be done. Instead, tests that test a platform specific behavior should go in the LayoutTest/YOURPLATFORM

Re: [webkit-dev] Antialiasing GraphicsContext::drawLine

2010-03-13 Thread Dan Bernstein
On Mar 13, 2010, at 9:06 AM, Sausset François wrote: I recently began to work on the square root implementation in MatML and I'm near to submit a patch. But as I'm new to WebKit development, I have a beginner question: To draw the square root, the GraphicsContext::drawLine method is

Re: [webkit-dev] Commit queue blocked because of failing tests

2010-02-24 Thread Dan Bernstein
On Feb 24, 2010, at 3:50 PM, Eric Seidel wrote: I find http://build.webkit.org/console more useful. In this case, looks like mitz's patch changed the test: http://trac.webkit.org/changeset/55203 Sorry about the inconvenience. I will try to fix this shortly. I'm glad to see more folks

Re: [webkit-dev] [webkit-changes] [52439] trunk/WebCore

2009-12-21 Thread Dan Bernstein
On Dec 21, 2009, at 3:00 AM, pfeld...@chromium.org wrote: Revision 52439 Author pfeld...@chromium.org Date 2009-12-21 03:00:06 -0800 (Mon, 21 Dec 2009) Log Message 2009-12-20 Pavel Feldman pfeld...@chromium.org Reviewed by Eric Seidel. Web Inspector: extract

Re: [webkit-dev] Platform API for Uniscribe/ComplexTextController?

2009-12-03 Thread Dan Bernstein
On Dec 2, 2009, at 10:52 AM, Kevin Ollivier wrote: Hi Dan, On Dec 1, 2009, at 8:29 AM, Dan Bernstein wrote: On Nov 29, 2009, at 10:27 AM, Kevin Ollivier wrote: Hi all, The wx port is starting to look at getting proper support for complex text, and one of the first places I

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-02 Thread Dan Bernstein
On Dec 2, 2009, at 9:46 PM, Peter Kasting wrote: On Wed, Dec 2, 2009 at 9:19 PM, Mark Rowe mr...@apple.com wrote: On 2009-12-02, at 21:00, Peter Kasting wrote: I find this tricky to read and error-prone. I propose that the rule be modified to be: * When all arms of a conditional or

Re: [webkit-dev] Platform API for Uniscribe/ComplexTextController?

2009-12-01 Thread Dan Bernstein
On Nov 29, 2009, at 10:27 AM, Kevin Ollivier wrote: Hi all, The wx port is starting to look at getting proper support for complex text, and one of the first places I started looking at was the Win and Mac port implementations. I noticed that the complex text code in FontWin.cpp and

Re: [webkit-dev] Why are some layout tests renamed with a suffix of -disabled?

2009-11-25 Thread Dan Bernstein
On Nov 25, 2009, at 9:55 AM, Darin Fisher wrote: Why are some layout tests renamed with a suffix of -disabled? Why aren't such tests simply added to the skipped list? Is -disabled simply the old way? Usually a test is disabled, with a bug filed to re-enable it, when a WebKit bug makes it

Re: [webkit-dev] adding script type to webcore

2009-10-17 Thread Dan Bernstein
On Oct 17, 2009, at 1:47 PM, Alexander Cohen wrote: Hello, Forgive me if this is a very vague question, but where should i start in webkit to view how it implements the script tag and how it starts evaluating JS. I'm looking into adding a new script type and having it evaluated and run.

Re: [webkit-dev] How does Zooming Work?

2009-10-06 Thread Dan Bernstein
On Oct 6, 2009, at 8:49 PM, Alex Milowski wrote: What exactly happens during a zoom (command +/-) ? Depends on the flavor of zoom (“full-page” zoom vs. text-only zoom), but in both cases, a full style recalculation for the document is forced. I have code that works well but layout

Re: [webkit-dev] Purging as much memory as possible

2009-10-01 Thread Dan Bernstein
On Oct 1, 2009, at 6:24 PM, Peter Kasting wrote: * Does anyone already know the likely footprint of the Glyph cache, or how to clear it? FontCache::purgeInactiveFontData(). If you’re using Safari then you can see Font and Glyph Caches statistics in its Caches window, which also includes

Re: [webkit-dev] map tag and zoom donot work ..?

2009-09-18 Thread Dan Bernstein
On Sep 18, 2009, at 8:09 AM, Simon Fraser wrote: On Sep 17, 2009, at 11:08 PM, Purushottam Sholapur wrote: Hi All, Web pages with map tag do not behave as expected when page is zoomed. Typically, map tag with coords property do not scale properly when page is zoomed. E.g:

Re: [webkit-dev] Whitespace changes

2009-08-26 Thread Dan Bernstein
On Aug 26, 2009, at 10:35 PM, Oliver Hunt wrote: Adam just landed a fairly substantial patch that did nothing but remove whitespace from the ends of lines. While we had a thread about style changes earlier, it was in the context of changes that actually bring code into line with style

  1   2   >