[webkit-dev] Peng Liu is now a WebKit reviewer!

I am delighted to announce that Peng Liu is now a WebKit reviewer. Peng has done a lot of work in WebKit media. Most recently he has helped enable media features in the GPU process. Please join me in congratulating Peng on his reviewer status! ___

[webkit-dev] Code Style: Opinion on returning void

I just had to change a void function to a non-void function in < https://bugs.webkit.org/show_bug.cgi?id=195281>. I was very happy that all of the existing code was written by people that did not return void because I didn't have to change any call sites returning void into two lines. This saved

[webkit-dev] Code Style: Opinion on returning void

Thanks for the opinion! Dan On Feb 20, 2019, at 7:26 AM, Saam Barati wrote: I prefer it as well. - Saam On Feb 20, 2019, at 6:58 AM, Chris Dumez wrote: I also prefer allowed returning void. Chris Dumez On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: On Feb 19, 2019, at 9:42 PM

[webkit-dev] Code Style: Opinion on returning void

:35 PM, Daniel Bates wrote: On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: On Tue, Feb 19, 2019 at 8:59 PM Daniel Bates wrote: > > On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: > > > > Hi all, > > > > Something bothers me about code like

Re: [webkit-dev] Code Style: Opinion on returning void

On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: On Tue, Feb 19, 2019 at 8:59 PM Daniel Bates wrote: > > On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: > > > > Hi all, > > > > Something bothers me about code like: > > > > void f(); > > void

Re: [webkit-dev] Code Style: Opinion on returning void

> On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: > > Hi all, > > Something bothers me about code like: > > void f(); > void g() > { > if (...) > return f(); > return f(); > } > > I prefer: > > void g() > { > i

[webkit-dev] Code Style: Opinion on returning void

Hi all, Something bothers me about code like: void f(); void g() { if (...) return f(); return f(); } I prefer: void g() { if (...) { f(); return } f(); } Does it bother you? For the former? For the latter? Update our style guide? Opinions, please.

Re: [webkit-dev] Watch out for std::optional's move constructor

> On Dec 14, 2018, at 3:52 PM, Chris Dumez > wrote: > > So to be clear, it is often not truly about using the value after it is > moved. It is about expecting that the variable / member has been nulled out > after moving it. > If I WTFMove() out a data member

Re: [webkit-dev] EWS for security bugs

> > *From:* webkit-dev *On Behalf Of *Daniel > Bates > *Sent:* Thursday, June 28, 2018 1:53 PM > *To:* WebKit Development Mailing List > *Subject:* [webkit-dev] EWS for security bugs > > > > Hi all, > > > > All Mac and iOS EWS bots now process security b

[webkit-dev] EWS for security bugs

Hi all, All Mac and iOS EWS bots now process security bug patches. We are working to configure the Apple Windows EWS bots and the WinCairo EWS bots should follow shortly. I do not know who maintains the GTK and WPE EWS bots. If you maintain one of these bots then please email me directly so that

[webkit-dev] Design for review: EWS for security bugs

Hi all, I am working to support EWS processing of patches on security bugs (see < https://bugs.webkit.org/show_bug.cgi?id=186291>) and I am writing to this list to solicit feedback on any show-stopper bugs in the proposed design. Historically we have not supported this functionality because the

Re: [webkit-dev] Running Safari on the simulator

Please file a bug. Dan > On Sep 27, 2017, at 2:21 PM, Frédéric WANG wrote: > > On 27/09/2017 19:24, Alex Christensen wrote: >> When I want to use the public iOS SDK for WebKit on iOS, I refer to >> Dan’s blog post >> at

Re: [webkit-dev] Code style: Propose using C++11 uniform initializer syntax in member initializer lists

Posted patch to update Code Style Guidelines at < https://bugs.webkit.org/show_bug.cgi?id=176058>. Dan On Mon, Aug 28, 2017 at 9:24 PM, Daniel Bates <dba...@webkit.org> wrote: > Hi all, > > I am writing to propose using C++11 uniform initializer syntax in membe

[webkit-dev] Code style: Propose using C++11 uniform initializer syntax in member initializer lists

Hi all, I am writing to propose using C++11 uniform initializer syntax in member initializer lists. The following: class A { public: A(B&& b, float i, int j) : m_b(WTFMove(b)) , m_i(i) , m_j(j) { } ... }; Would become: class A { public: A(B&& b, float i, int j)

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

Thank you for looking into speeding up the build. How does the speed gain with your proposed "unified source" approach compare to using CMake + Ninja to build currently (I think builder Apple El Capitan CMake Debug does this)? Do we know what is the cause(es) for the slow clean builds? I am

Re: [webkit-dev] New tool for Xcode (Emacs?) users: Copy WebKit Permalink

Hi Charlie, Thanks for the script! File a bugs.webkit.org bug, CC'ing me, and upload a patch. We still need Vim and Textmate plugins :D Dan On Mon, Aug 14, 2017 at 4:52 PM, Daniel Bates <dba...@intudata.com> wrote: > Hi Charlie, > > Thanks for the script! File a bugs.webkit.org

[webkit-dev] New tool for Xcode users: Copy WebKit Permalink

Hi again, If you use Xcode then I just landed an Automator service in < https://trac.webkit.org/changeset/220705/> that you can install to copy a Trac permalink to your clipboard to the source view or blame view of the focused file at the currently selected line. To install, just double click

[webkit-dev] Implement Credential Management Level 1

Hi all, I wanted to let you know that I plan to implement the Credential Management Level 1 spec., . This work will be done behind a runtime flag. You can follow along by tracking the master bug at .

[webkit-dev] Replaced CSSPropertyNames.in with CSSProperties.json

Hi all, Following r209001 the file Source/WebCore/css/CSSPropertyNames.in has been replaced with a JSON file in the same directory called CSSProperties.json. See the top of this file for editing instructions,

Re: [webkit-dev] Windows EWS not working?

tting to this one. >> >> Does this mean the Windows EWS is stuck? Who can get it unstuck? > > Yes, Windows EWS bots fail to start with the below error. I think that this > is a regression from <http://trac.webkit.org/changeset/192087>, so Daniel > Bates has volunte

[webkit-dev] Use WTF::move() instead of std::move()

Hi all, Following http://trac.webkit.org/changeset/170774, please use WTF::move() instead of std::move(). I substituted WTF::move() for std::move() in all code to date. WTF::move() is a replacement for std::move() that is less error prone to use. Depending on std::move() to lead to a move

Re: [webkit-dev] Error while applying on EWS bots.

Hi Pravin, svn-apply currently doesn't support SVN 1.7 property diffs. See https://bugs.webkit.org/show_bug.cgi?id=80762 for more details. I hope to take a look at implementing support for these diffs this weekend unless someone beats me to it. Dan On May 10, 2012, at 10:56 PM, Pravin D

Re: [webkit-dev] WebKit QNX Port

On Oct 15, 2011, at 4:57 PM, Adam Barth wrote: Great! Does the QNX port require a new build system, or does it integrate with one of the existing build systems (e.g., cmake or Visual Studio)? No, it doesn't require a new build system. It integrates with the existing CMake build system.

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

Please commit the updated Xcode project files. Dan On Oct 6, 2010, at 5:00 PM, Darin Adler da...@apple.com wrote: Hi folks. For those working on Mac OS X: Any objection to upgrading to Xcode 3.2.4? It’s now showing up in Apple’s Software Update for all Xcode users, I believe. I ask