Re: [webkit-dev] Moving from WTF::Optional to std::optional

2021-06-02 Thread Darin Adler via webkit-dev
instead of WTFMove() > if you want to leave to std::optional in a clean state for reuse later. > > Chris Dumez > >>> On Jun 1, 2021, at 8:54 PM, Darin Adler via webkit-dev >>> wrote: >>> >> Hi folks. >> >> We’re getting rid of the W

[webkit-dev] Moving from WTF::Optional to std::optional

2021-06-01 Thread Darin Adler via webkit-dev
Hi folks. We’re getting rid of the WTF::Optional class template, because, hooray, std::optional is supported quite well by all the C++17 compilers we use, and we don’t have to keep using our own special version. Generally we don’t want to reimplement the C++ standard library when there is not

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Darin Adler via webkit-dev
Sorry, I should clarify. Apple’s ports of WebKit already use -Werror and always have, everywhere, not just on EWS. Since day one. I do not know why we do not already use -Werror on GTK and WPE and I support using it there after fixing all the warnings. — Darin

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Darin Adler via webkit-dev
I’m a big fan of -Werror. Back when WebKit started, it was controversial to use it at Apple. But we can’t just turn on -Werror until after we fix all the warnings! Who will do that project. — Darin ___ webkit-dev mailing list

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-30 Thread Darin Adler via webkit-dev
OK. I acknowledge my view on this is different from the others commenting here, perhaps because of different ideas about what is hard and requires expertise. I won’t stand in the way of changes you want to make. You know my view now. — Darin ___

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Darin Adler via webkit-dev
> On Apr 29, 2021, at 9:06 PM, Tim Horton via webkit-dev > wrote: > > it is definitely highly annoying It’s possible that where my thinking differs from others on this is that I don’t think shifting annoying work from one set of commits (the ones adding a new file) to a different set (the

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Darin Adler via webkit-dev
> On Apr 29, 2021, at 9:01 PM, Tim Horton wrote: > > This is a huge problem for people on the Apple platforms using the Xcode > projects. Nearly every time someone adds a file they have to add random > headers to unrelated code. OK, sorry, I must be out of touch with the rest of you about how

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Darin Adler via webkit-dev
> On Apr 29, 2021, at 12:04 PM, Ross Kirsling via webkit-dev > wrote: > > Yeah, I think it's important to clarify that nobody is "using > non-Unified-Source building for their development", at least to my knowledge. > Being broken by the shifting sands of unified sources is an everybody

Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Darin Adler via webkit-dev
Given the issue is that there are people that are using non-Unified-Source building for their development, the best fix is to add post-commit and EWS builders for one of those platforms. I do not support the idea of adding an additional builder just to “keep non-Unified-Source building” if no

Re: [webkit-dev] Mailman web interface missing

2021-04-26 Thread Darin Adler via webkit-dev
> On Apr 26, 2021, at 1:03 PM, Adrian Perez de Castro via webkit-dev > wrote: > > - https://lists.webkit.org/listinfo/webkit-wpe/ results in “Not Found” > - https://lists.webkit.org/admindb/webkit-wpe/ results in “403 Forbidden” I took a look and it seems that the URLs have simply changed,

Re: [webkit-dev] GitHub Account and Commit Attribution

2020-12-17 Thread Darin Adler via webkit-dev
> On Dec 17, 2020, at 8:47 AM, Jonathan Bedard via webkit-dev > wrote: > > Something we’ve just learned about commit attribution and GitHub is that > adding an email to your GitHub account may not attribute commits that were > pushed to a repository before you added the email. There were a

Re: [webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-09 Thread Darin Adler via webkit-dev
> On Dec 9, 2020, at 1:02 PM, Geoff Garen via webkit-dev > wrote: > >> - Make FontCache thread-safe, but do it via introducing a completely >> separate thread-safe AtomString type and leave the current one as it is >> (I don't have a good grasp of how difficult this would actually be) > > I

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 4:08 PM, Sam Weinig wrote: > > For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs > should just have the appropriate Conditional=* extended attribute added, then > they can be included unconditionally in the makefile. > > For the ones

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 3:09 PM, Sam Weinig wrote: > > For the Platform.h issue, I think we could probably engineer things in the > short term to have a script phase that produces a Defines.txt that the other > script phases and build rules depend on. We definitely can, and it’s simpler than

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
It would be wonderful to drastically cut down the repeated mentions of the same filenames. People not on Xcode platforms probably focus primarily on Xcode projects for this frustration. But I find it ridiculous how many places I have to add things. For example, to add AbstractRange I had to add

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
Oops, I was in the middle of writing this and hit send by mistake ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
Please note that this is a Cocoa-only, Xcode-only conversation. As Sam pointed out, there’s a whole different “will you please switch to CMake” conversation. That’s not an easy switch to make for programmers working on the Apple platforms, but we might do it at some point if we can work out the

Re: [webkit-dev] Trailing space changes in "expected.txt" files

2020-09-26 Thread Darin Adler
> On Sep 26, 2020, at 8:13 PM, Darin Adler wrote: > > by rebasing and either regenerating the expected.txt files hand editing. … resolve the conflicts by rebasing and either regenerating the expected.txt files with run-webkit-tests or by hand editing the expected.txt files.

[webkit-dev] Trailing space changes in "expected.txt" files

2020-09-26 Thread Darin Adler
Hi folks. This afternoon, I changed dumpAsText so it strips trailing spaces. https://trac.webkit.org/changeset/267640 As part of that change, run-webkit-tests temporarily will ignore trailing spaces in expected.txt files, so they can be checked in with, or without, the spaces. Over the

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Darin Adler
> On Sep 23, 2020, at 12:18 PM, Ryosuke Niwa wrote: > > There are quite a few cases where data members are references but then those > can also be replaced by a simple member function which retrieves the value of > the smart pointer member variable and returns a reference. I think this should

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Darin Adler
> On Sep 23, 2020, at 10:32 AM, Darin Adler wrote: > >> On Sep 16, 2020, at 11:32 PM, Ryosuke Niwa > <mailto:rn...@webkit.org>> wrote: >> Every data member to a ref counted object must use either Ref, RefPtr, or >> WeakPtr. webkit.NoUncountedMemberCheck

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Darin Adler
> On Sep 16, 2020, at 11:32 PM, Ryosuke Niwa wrote: > Every data member to a ref counted object must use either Ref, RefPtr, or > WeakPtr. webkit.NoUncountedMemberChecker > My > only worry here is

[webkit-dev] Could use some help from people who care about the WinCairo port

2020-09-12 Thread Darin Adler
The patch for this bug https://bugs.webkit.org/show_bug.cgi?id=216428 is failing to build on WinCairo because of some kind of precompiled header problem. I could use some help figuring out what I did wrong. —

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-04 Thread Darin Adler
> On Sep 3, 2020, at 11:14 PM, Fujii Hironori wrote: > > BTW, I don't like to idea adding a new rule, but keeping old style code. It > introduces divergence between the guideline and actual code. Do we really > need a new rule that one doesn’t necessary have to follow? I understand that you

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-08-31 Thread Darin Adler
> On Aug 31, 2020, at 9:33 AM, David Bokan wrote: > > We've made lots of improvements to the spec, notably around issues raised in > Mozilla's standards-position > . Do you think those improvements address Maciej’s concerns from last

Re: [webkit-dev] Plugin process

2020-07-20 Thread Darin Adler
> On Jul 20, 2020, at 7:35 AM, Michael Catanzaro wrote: > > Then we can make the plugin process specific to PLATFORM(COCOA) Side note: It will be specific to PLATFORM(MAC). — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Darin Adler
> On Jul 16, 2020, at 3:33 PM, Adrian Perez de Castro wrote: > > enabling/disabling features changes the set of source files to > build, which results in different source files being #included from each > unifier source compilation unit. Let’s stop doing it that way. Just compile the files and

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Darin Adler
> On Jul 16, 2020, at 2:28 PM, Adrian Perez de Castro wrote: > > It is not feasible to test unified builds for all the possible combinations of > target architectures and set of features enabled at build time (there is a > combinatorial explosion of configurations). Keeping non-unified builds in

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Darin Adler
> On Jul 16, 2020, at 12:54 PM, Kirsling, Ross wrote: > > Non-unified build fixes are done to support *all* platforms, because sudden > unification shifts can happen anywhere. I’m not sure that benefit is worth the additional code churn. I understand that it’s frustrating to run into a

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Darin Adler
> On Jul 14, 2020, at 2:38 PM, Simon Fraser wrote: > > Could someone educate me about ? When should I use this > instead of individual wtf headers? Forward.h is analogous to forward-declaring a class ('class IntPoint;' instead of ‘#include “IntPoint.h”'), but it works for many often-used

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Darin Adler
We need to be cautious about adding header includes to other headers. Adding includes to .cpp files is likely fine and not a deeply consequential decision, but adding to headers is something that can have a massive effect on build times over time. > On Jul 13, 2020, at 10:44 PM,

Re: [webkit-dev] Platform.h vs. makefiles

2020-05-11 Thread Darin Adler
> On May 10, 2020, at 10:07 PM, Maciej Stachowiak wrote: > > I think the best way to configure WebKit is to use a separate data file, > neither a header nor a makefile or similar, that defines the options in a > single place with clear syntax. Then everything else is generated from that. >

[webkit-dev] Platform.h vs. makefiles

2020-05-10 Thread Darin Adler
Hi folks. The Platform.h configuration file family has been useful for WebKit for a long time. We created it to try to organize configuration options in WebKit so the would not be spread out through the whole project. One way to look at these, particularly the ENABLE options, is as a set of

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Darin Adler
Here’s my take: The source code we check into the WebKit repository is there for the convenience of the people *contributing* to WebKit, and is need not be the sole input when building and packaging WebKit for distribution. Including ICU sources in a GTK WebKit tarball would not necessarily

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Darin Adler
> On Jan 13, 2020, at 5:52 PM, Yusuke Suzuki wrote: > > We can purge type-encoding-string if we use Objective-C NS_DIRECT feature > (which makes Objective-C function as C function calling convention, removing > metadata). > However, this does not work universally: with NS_DIRECT, Objective-C

Re: [webkit-dev] Introducing WTF::makeUnique and WTF::makeUniqueWithoutFastMallocCheck

2019-08-23 Thread Darin Adler
> On Aug 23, 2019, at 7:26 AM, Antti Koivisto wrote: > > Could WTF::makeUnique simply use FastMalloc by default? We could then remove > most of these messy annotations. > > This would require replacing std::unique_ptr with a type that knows how to > free the objects correctly (bring back

Re: [webkit-dev] Moving to Python 3

2019-07-16 Thread Darin Adler
> On Jul 16, 2019, at 12:46 PM, Alexey Proskuryakov wrote: > > - They shouldn't make it excessively difficult to do WebKit engineering on > older versions of macOS. > > "Excessively" is not clearly defined, but it seems obvious that there is a > tradeoff between tools work difficulty, and

Re: [webkit-dev] Incremental unified builds on macOS

2019-06-25 Thread Darin Adler
It’s unlikely the problem is due to unified builds, since those are just source files with includes in them. But I have encountered problems like this before; sometimes they are things affecting lots of people and I’ve been able to fix them. When trying to understand causes of this kind of

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-16 Thread Darin Adler
> On Jun 15, 2019, at 9:13 PM, Aakash Jain wrote: > > 1) Do not upload archive (for layout-test-results) on bugzilla, instead > upload it to another server, unzip it and post a link to the results.html. > Pros: > a) Engineers won't have to download the attachment, unzip it, look for >

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Darin Adler
> On May 10, 2019, at 1:13 PM, Keith Miller wrote: > > I’m not sure I know what you mean by allow a whole-directory exception. Do > you mean a top level directory? Or some kind of parameter we pass to the hook > to ignore some directory for that run? I meant that we could add something the

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Darin Adler
> On May 10, 2019, at 1:00 PM, Keith Miller wrote: > > I don’t know if this is possible but it would be great if some > sub-directories could be excluded from the no-tabs pre-commit hook. Maybe we can rewrite the pre-commit hook to allow a whole-directory exception. Ideally I’d prefer not to

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Darin Adler
Should we post instructions somewhere for people dealing with spam? I believe the instructions are: 1) Look up the email address of the account that posted the spam and disable it first, so spammers don’t get email about other steps. Do this by clicking on Administration, Users, finding the

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-21 Thread Darin Adler
I tried not to weigh in on this, but my view on the materials we should use to build the bike shed must be shared! Generally it seems neat to be able to make the code slightly more tight and terse by merging the function call and the return into a single statement. Other than not being

[webkit-dev] Rename AtomicString to AtomString

2019-01-30 Thread Darin Adler
So, did we reach consensus that we should rename AtomicString to AtomString? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Darin Adler
Vector’s inline capacity feature was originally created as an alternative to variable length arrays for most of the purposes people would want to put them. Imagine, for example, that you need a variable length buffer of characters that is almost always going to be less then 32 bytes. You write

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Darin Adler
Seems to me we could fix the current problem by renaming from AtomicString to AtomString without causing any new problem. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

2018-12-19 Thread Darin Adler
Let’s be clear about what we are discussing. The choice is not be between “final” and “override”. The choice is between “final override”, “override final”, and “final” for functions which are both overrides and final. — Darin Sent from my iPhone > On Dec 19, 2018, at 12:27 PM, Michael

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

2018-12-19 Thread Darin Adler
> On Dec 19, 2018, at 1:52 AM, Fujii Hironori wrote: > > I'd like to change this because 'final' doesn't necessarily imply > 'override'. See the following stackoverflow: > https://stackoverflow.com/questions/29412412/does-final-imply-override I’d be happy to require both final and override if

Re: [webkit-dev] the name "AtomicString"

2018-12-18 Thread Darin Adler
The name “AtomicString” was inspired by the term of art, “atom”, traditionally used in at least some programming language implementations for what I see now is often called interned strings. You’ll see a mention of that term in the article https://en.wikipedia.org/wiki/String_interning in the

Re: [webkit-dev] WebCorePrefix.h vs. config.h

2018-12-11 Thread Darin Adler
> On Dec 9, 2018, at 10:34 PM, Fujii Hironori wrote: > > MSVC has /FI option. > > /FI (Name Forced Include File) | Microsoft Docs > > https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017 > > Unfortunately, it seems that MSVC's precompiled header

Re: [webkit-dev] WebCorePrefix.h vs. config.h

2018-12-08 Thread Darin Adler
OK, here’s my answer after thinking on it a bit: Best would be to eliminate “config.h”: Change “config.h” into an empty file first, then remove all “config.h” includes, and then remove the file. But to do that, we need to make sure every build system for WebKit supports prefix headers. I don’t

Re: [webkit-dev] WebCorePrefix.h vs. config.h

2018-12-08 Thread Darin Adler
> On Dec 8, 2018, at 2:56 PM, Darin Adler wrote: > >> On Dec 7, 2018, at 2:44 PM, Alexey Proskuryakov wrote: >> >> only keep config.h just to include WebCorePrefix for the lone build scenario >> where that's needed, and to undef new/delete? > > I thi

Re: [webkit-dev] WebCorePrefix.h vs. config.h

2018-12-08 Thread Darin Adler
Useful background exists in Wikipedia: https://en.wikipedia.org/wiki/Prefix_header and https://en.wikipedia.org/wiki/Precompiled_header are relevant. Alexey, perhaps you know all of this already,

Re: [webkit-dev] WebCorePrefix.h vs. config.h

2018-12-08 Thread Darin Adler
> On Dec 7, 2018, at 2:44 PM, Alexey Proskuryakov wrote: > > only keep config.h just to include WebCorePrefix for the lone build scenario > where that's needed, and to undef new/delete? I think the answer likely lies here: What is this lone build scenario where config.h is needed? — Darin

Re: [webkit-dev] Clarifying feature flags

2018-11-07 Thread Darin Adler
A while ago Kentaro Hara did some IDL keyword cleanup. One of the best things he did was to make a single file with a list of all the keywords. In that case he was able to set things up so that if the file was inaccurate the build would fail; not sure if that’s practical for the various

Re: [webkit-dev] Rename wtf/unicode/UTF8.h

2018-10-31 Thread Darin Adler
> On Oct 31, 2018, at 7:52 AM, Konstantin Tokarev wrote: > > 31.10.2018, 05:18, "Fujii Hironori" >: >> wtf/unicode/UTF8.h is conflicting with ICU header in MSVC builds. I'd like >> to rename wtf/unicode/UTF8.h to wtf/unicode/WTFUTF8.h. >> Any suggestion? > >

Re: [webkit-dev] node-jsc: A node.js port to the JavaScriptCore engine and iOS

2018-09-23 Thread Darin Adler
> On Sep 23, 2018, at 1:34 PM, Koby Boyango wrote: > > I will merge your changes to my fork Would you be willing to focus on upstreaming first, instead? That would also get you the latest improvements, but in a more sustainable way. — Darin ___

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

2018-09-17 Thread Darin Adler
I don’t know. Sent from my iPhone > On Sep 17, 2018, at 7:49 AM, Filip Pizlo wrote: > > > >> On Sep 16, 2018, at 8:48 PM, Darin Adler wrote: >> >>> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: >>> >>> Which offline assemb

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

2018-09-16 Thread Darin Adler
> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: > > Which offline assembler build step are you referring to? The one that is the “Offline Assembler” target in Xcode, which runs this command: ruby JavaScriptCore/offlineasm/asm.rb JavaScriptCore/llint/LowLevelInterpreter.asm

[webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

2018-09-16 Thread Darin Adler
I noticed that the “Offline Assembler” build step was taking between 5 and 30 seconds every time I build. Really stands out in incremental builds. I realized that this step does not do any dependency analysis. Every time, it builds a hash of the input to see if it needs to recompute the

Re: [webkit-dev] Unified sources have broken our #include hygiene

2018-09-01 Thread Darin Adler
> On Sep 1, 2018, at 5:14 PM, Simon Fraser wrote: > > Unified sources allow you to get away without #including all the files you > need in a .cpp file, because some earlier file in the group has probably > already included them for you. > > This means that when you add a new file to the

Re: [webkit-dev] Freenode spam counter-measure

2018-08-06 Thread Darin Adler
> On Aug 6, 2018, at 5:22 AM, Konstantin Tokarev wrote: > >>> On Aug 5, 2018, at 2:38 AM, Philippe Normand wrote: >>> >>> Can one of the #webkit admin please set the +r mode on? This would help >>> reducing spam. Only messages from registered nicks would come through. >> >> I tried this by

Re: [webkit-dev] Freenode spam counter-measure

2018-08-05 Thread Darin Adler
> On Aug 5, 2018, at 2:38 AM, Philippe Normand wrote: > > Can one of the #webkit admin please set the +r mode on? This would help > reducing spam. Only messages from registered nicks would come through. I tried this by typing this: /msg ChanServ set #webkit restricted on But ChanServ

Re: [webkit-dev] Proposal: Not supporting x86 w/o SSE2

2018-07-29 Thread Darin Adler
Sounds good. There are clients of WebKit outside web browsing. A significant client like that on Windows at Apple is iTunes. I checked and Windows versions of iTunes require a processor with support for SSE2, so clarifying WebKit’s lack of support won’t

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
> On Jun 6, 2018, at 9:39 AM, Dan Bernstein wrote: > > libwebrtc.xcconfig sets CLANG_ENABLE_OBJC_ARC to YES for the libwebrtc > target. Since RTCVideoCodecH264.mm is part of that target the file is > compiled with ARC. OK, great. That’s what I missed. I’ll get rid of the stray -fobjc-arc in

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
> On Jun 6, 2018, at 9:28 AM, Darin Adler wrote: > > best keep working with manual retain and release best kept working > a non-tribal amount of code that already seems to assume ARC a non-trivial amount — Darin ___ webkit-dev mailing

[webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
Hi folks. As some of you have probably noticed, I’ve begun making changes with the goal of preparing us to move most Objective-C code in WebKit to ARC. In doing so, I have been exploring the existing code in the tree and the various projects in our source tree. The nine projects with

Re: [webkit-dev] Build issues due to anonymous namespace

2017-12-03 Thread Darin Adler
> On Dec 3, 2017, at 12:16 PM, Filip Pizlo wrote: > > That also means not using static, for the same reason. FWIW, I think it’s a > good idea. Maybe. There is definitely no benefit in wrapping a class, structure, or type definition in an anonymous namespace. My comment was

Re: [webkit-dev] Build issues due to anonymous namespace

2017-12-03 Thread Darin Adler
I think it’s also worthwhile to remove the anonymous namespace wrapping each of these DestroyFunc structures when renaming them. Generally speaking, anonymous namespace doesn’t work when compilation units are arbitrary, since they say “limit this to one compilation unit”. So I’m not sure we

Re: [webkit-dev] Unified sources build errors when adding new source files

2017-11-21 Thread Darin Adler
Oh, I see. Errors in EWS in that bug. Looking. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Unified sources build errors when adding new source files

2017-11-21 Thread Darin Adler
> On Nov 21, 2017, at 6:54 AM, Javier Fernandez wrote: > > It builds perfectly with the no-unify tag, but I produces totally > unrelated errors when using the unified building. I wonder whether my > patch could make those errors arise because of altering the building >

[webkit-dev] EWS queues seem stuck

2017-10-08 Thread Darin Adler
A couple of my patches have been sitting around all day and some of the EWS servers still say they are 15 patches behind. Are they stuck? Can someone bring them back to life? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Tests failing because WPT images not served at correct URL?

2017-10-07 Thread Darin Adler
Youenn is helping me figure this out. My original guess about why it’s failing was probably wrong. You can follow along here >. — Darin___ webkit-dev

[webkit-dev] Tests failing because WPT images not served at correct URL?

2017-10-07 Thread Darin Adler
Look at the expected results here . The results show “expected" failures like this one: "FAIL Image with usemap of #åωk should not

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
Sent from my iPhone > On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: > > I doubt anyone is going to run such a script before they go to upload a > patch to bugzilla. EWS was what I was hoping for; likely to be sufficient. But it could also be integrated into the

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
If we decide that we can’t support file scope identifiers then we should figure out the most practical way to do it. Of course this affects constants and variables, too, not just functions. I think this special FILENAME namespace isn’t all that helpful or needed. If a file contains a class

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
How does this work? Without a “using” how does it know to search this namespace? Is this superior to using anonymous namespaces instead of “static”? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-08-01 Thread Darin Adler
> On Jul 31, 2017, at 2:04 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler <da...@apple.com> wrote: >> I don’t think we should add lots of includes of “config.h”, though. I think >> we can come up with some

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Darin Adler
We originally adopted this “config.h” style to make WebKit buildable with autotools. Since that has not been a consideration for years I would be willing to abandon this and change how we do things. I don’t think we should add lots of includes of “config.h”, though. I think we can come up with

Re: [webkit-dev] Does someone know how to fix WTF::Function on Windows

2017-07-15 Thread Darin Adler
;> On Jul 15, 2017, at 9:14 AM, Yusuke SUZUKI <utatane@gmail.com> wrote: >> >> I'm not 100% confident, but can you try it `` instead? >> >> Regards, >> Yusuke Suzuki >> >>> On Sun, Jul 16, 2017 at 1:13 AM, Darin Adler <da...@apple.com&

[webkit-dev] Does someone know how to fix WTF::Function on Windows

2017-07-15 Thread Darin Adler
Hi folks. On Windows, WTF::Function doesn’t quite work right. Code that is something like this: void addCallback(WTF::Function&&); void testFunction() { // ... } void addTestFunction() { addCallback(testFunction); } Leads to errors like

[webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Darin Adler
I noticed we don’t have has_value() in our version of std::optional. Does anyone know why? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Darin Adler
I’ve noticed many patches switching us from std::function to WTF::Function recently, to fix problems with copying and thread safety. Does std::function have any advantages over WTF::Function? Should we ever prefer std::function, or should we use WTF::Function everywhere in WebKit where we

Re: [webkit-dev] WebCore/platform standalone library

2017-01-14 Thread Darin Adler
> On Jan 14, 2017, at 12:39 PM, Myles C. Maxfield wrote: > > However, a shared library would enforce layering naturally, whereas a static > library would need either an application to link to it and not to WebCore, > such as a unit test suite, or some out-of-band layering

Re: [webkit-dev] usage of auto

2017-01-12 Thread Darin Adler
We probably need to step away from mandating style for a while until we have more consensus. I’m sad that we are so far away from that right now. I’ve found greatly increased use of auto during coding and refactoring that I am doing feels like it’s improving clarity quite at bit. From the

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Darin Adler
> On Jan 11, 2017, at 9:41 AM, Alexey Proskuryakov wrote: > > In a way, these are read-time assertions. Exactly. A type name is a read-time assertion of the specific type that a variable has and “auto” is a read-time assertion that the type of the variable is the same as the

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Darin Adler
OK, you didn’t convince me but I can see that your opinions here are strongly held! — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 10:17 PM, Filip Pizlo wrote: > > while (Arg src = worklist.pop()) { > HashMap::iterator iter = > mapping.find(src); > if (iter == mapping.end()) { > // With a shift it's possible

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:49 PM, Darin Adler <da...@apple.com> wrote: > >> On Jan 10, 2017, at 9:46 PM, Simon Fraser <simon.fra...@apple.com> wrote: >> >> auto countOfThing = getNumberOfThings(); >> ASSERT(countOfThing >= 0); // Can’t tell by reading

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:46 PM, Simon Fraser wrote: > > auto countOfThing = getNumberOfThings(); > ASSERT(countOfThing >= 0); // Can’t tell by reading whether the ASSERT is > assured at compile time if countOfThing is unsigned I understand wanting to know, but I am not

Re: [webkit-dev] WebCore/platform standalone library

2017-01-10 Thread Darin Adler
> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: > > We opted for WebCore to include files using “#include ” instead of > just including Foo.h. Will this work without ForwardingHeaders on macOS and iOS? Given that WTF chose , what is the reasoning for PAL choosing

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Darin Adler
I understand the appeal of “org.webkit” and structured names but personally I would prefer to read names that look like titles and are made up of words with spaces, like these: “WebKit: Image Decoder”, rather than “org.webkit.ImageDecoder”. “WebKit: JavaScript DFG Compiler” rather than

Re: [webkit-dev] Reducing the use of EncodedJSValue and use JSValue directly instead.

2017-01-03 Thread Darin Adler
> On Jan 3, 2017, at 2:33 PM, Mark Lam wrote: > > I propose that we switch to using JSValue directly where we can. Sounds like a great idea to me. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Status of GTK EWS bot?

2016-10-25 Thread Darin Adler
> On Oct 25, 2016, at 1:18 AM, Philippe Normand wrote: > > The GTK EWS is back online. Thanks! I was able to use the EWS results this morning to improve my patch. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Status of GTK EWS bot?

2016-10-24 Thread Darin Adler
Hi folks. As I am uploading patches to for EWS processing I noticed that all the other platforms said “#1”, but gtk-wk2 said #85. Is this just the bot falling a bit behind because of load, or is there a more serious problem? This is important

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-07 Thread Darin Adler
> On Sep 7, 2016, at 1:57 AM, Maciej Stachowiak wrote: > > perhaps a syntax like Ref x = notNull(move(refPtr)) could be made to work It definitely can. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Darin Adler
> On Sep 6, 2016, at 6:43 PM, Maciej Stachowiak wrote: > > RefPtr does also have regular release() though. I'm not sure if this is for a > practical reason or just no one has fixed it yet. It’s still around until we finish getting rid of PassRefPtr, that’s all. > A wacky

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Darin Adler
> On Sep 6, 2016, at 4:48 PM, Maciej Stachowiak wrote: > > STL smart pointers have a 0-argument reset for non-returning remove instead, > and convention seems to be to use swap() or move() for the returning remove > on a smart pointer. So an alternate possibility would be to

[webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Darin Adler
Hi folks. WebKit has some critical functions that involve asking an object to give up ownership of something so the caller can take ownership. In the C++ standard library itself, this is called move, as in std::move. In WebKit smart pointers, we call this operation release, as in

Re: [webkit-dev] WebKit GObject bindings: Who is guiding their future?

2016-08-30 Thread Darin Adler
Thanks for the frank discussion, guys. I do think we may be able to make the GObject bindings better and better over time even if they are hand written rather than generated. I understand that you want to keep them vital and up to date in a way that the Apple folks are not planning to do for

  1   2   3   4   5   6   7   8   9   10   >