Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-21 Thread Kangil Han
+1

-Original Message-
From: webkit-dev-boun...@lists.webkit.org 
[mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Carlos Garcia Campos
Sent: Wednesday, August 21, 2013 3:08 PM
To: Martin Robinson
Cc: WebKit Development
Subject: Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in 
shouldShowPlaceholderWhenFocused?

El mar, 20-08-2013 a las 10:41 -0700, Martin Robinson escribió:
 On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote:
  Are Qt and GTK+ (and other) ports intentionally returning false in 
  shouldShowPlaceholderWhenFocused?  Or is this just an oversight due 
  to the fact the default implementation returned false?
 
 I just confirmed that the native GTK+ behavior is for placeholder text 
 to disappear when a text entry is focused. I believe for GTK+ this 
 method should return false.

I think that removing the placeholder text when starting typing instead of when 
the entry is focused is indeed a good idea. I implemented the placeholder text 
in GTK+ following the WebKit approach, so maybe we can change it in both places.

 --Martin
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 

--
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Adding document.currentScript to WebCore

2013-06-17 Thread Kangil Han
Hi webkit-dev!
I wanted to let you know that I plan to add document.currentScript attribute
support to WebKit.
 
At this moment, it's been supported in chrome and firefox.
You can find this attribute details in [1][2][3].
 
You can also find related bug in
https://bugs.webkit.org/show_bug.cgi?id=104221
I am looking forward to your comments.
 
Thanks!
Kangil Han
 
[1]
http://www.w3.org/html/wg/drafts/html/master/dom.html#dom-document-currentsc
ript
[2]
http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#dom-doc
ument-currentscript
[3] https://developer.mozilla.org/en-US/docs/Web/API/document.currentScript
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Any port still using a compiler that doesn't support move semantics?

2013-06-12 Thread Kangil Han
Hi Ryosuke!
 
EFL port has no problem to support move semantics.
 
Thanks for asking!
Kangil Han
 
From: webkit-dev-boun...@lists.webkit.org
[mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Ryosuke Niwa
Sent: Thursday, June 13, 2013 7:39 AM
To: WebKit Development
Subject: [webkit-dev] Any port still using a compiler that doesn't support
move semantics?
 
Hi,
 
Now that we've moved onto use VS.net 2010 on Windows port, it appears that
we can finally start using move semantics everywhere!
 
Am I correct in assuming that there is no port that still relies on a
compiler that doesn't support move semantics?


- R. Niwa
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Enable encoding detector on layout(regression) test

2012-09-18 Thread Kangil Han
Hi,
 
I am working on a bad case that encoding detector doesn't recognize it.
So I created a bug, https://bugs.webkit.org/show_bug.cgi?id=97054, then try
to make a layout(regression) test case.
However, enabling encoding detector by javaScript manipulation seems not
feasible since encoding detector works on reading input stream level.
 
Therefore, I am asking here if any of WebKittens would give some
advices/opinions including good precedent to resolve this case.
 
- Kangil Han
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] [WK2] WebContext destructor is never triggered on normal exit

2012-08-27 Thread Kangil Han
I hope below bug url would help your understanding.
https://bugs.webkit.org/show_bug.cgi?id=94783
 
My query was from finding 'LEAK' on WebContext that is supposed being
triggered from 'WTF::RefCountedLeakCounter' automatically when exit
minibrowser.
I have investigated little bit further and found WebContext would be freed
by WebProcessProxy which depends on WebProcess.
 
As Alexey described in that bug, we would gain little compared to efforts.
However, I think ignoring destructor call and see the 'LEAK' print out
message at every time I exit program on debug build would not be so nice.
That's why I've asked here for hearing opinions. :)
 
- kangil
 
From: Sam Weinig [mailto:wei...@apple.com] 
Sent: Sunday, August 26, 2012 8:36 AM
To: kangil@samsung.com
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] [WK2] WebContext destructor is never triggered on
normal exit
 
I'm not clear on what you mean.  A client of WebKit2 release their
WKContextRef pointer from atexit() if they wanted to (or in whatever other
termination routines they already have), but its not clear to me why the
framework should do it for them.  We don't do this for any other objects.
 
-Sam
 
On Aug 24, 2012, at 7:15 PM, Kangil Han kangil@samsung.com wrote:



Hi,
 
I've found WebContext destructor is never triggered on normal exit in WK2.
 
This happens because only IPC message from WebProcess could terminate it but
won't do that in this case.
One possibility for doing this is to create a flow of termination from
UIProcess on exit.
 
But, before starting investigation, I would like to ask your opinion.
 
kangil
 
___
webkit-dev mailing list
 mailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev
http://lists.webkit.org/mailman/listinfo/webkit-dev
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] [WK2] WebContext destructor is never triggered on normal exit

2012-08-27 Thread Kangil Han
I hope so, but it seems not to be easy one because WebProcessProxy has a
reference to WebContext and it would only be released by IPC message from
WebProcess.
 
- kangil
 
From: Sam Weinig [mailto:wei...@apple.com] 
Sent: Tuesday, August 28, 2012 12:03 PM
To: kangil@samsung.com
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] [WK2] WebContext destructor is never triggered on
normal exit
 
I see.  Then what I said was right, you just need to release your
WKContextRef when exiting your minibrowser.  This should not be changed in
WebKit.
 
-Sam
 
On Aug 27, 2012, at 8:02 PM, Kangil Han kangil@samsung.com wrote:



I hope below bug url would help your understanding.
 https://bugs.webkit.org/show_bug.cgi?id=94783
https://bugs.webkit.org/show_bug.cgi?id=94783
 
My query was from finding 'LEAK' on WebContext that is supposed being
triggered from 'WTF::RefCountedLeakCounter' automatically when exit
minibrowser.
I have investigated little bit further and found WebContext would be freed
by WebProcessProxy which depends on WebProcess.
 
As Alexey described in that bug, we would gain little compared to efforts.
However, I think ignoring destructor call and see the 'LEAK' print out
message at every time I exit program on debug build would not be so nice.
That's why I've asked here for hearing opinions. :)
 
- kangil
 
From: Sam Weinig [mailto:wei...@apple.com] 
Sent: Sunday, August 26, 2012 8:36 AM
To: kangil@samsung.com
Cc: webkit-dev@lists.webkit.org
Subject: Re: [webkit-dev] [WK2] WebContext destructor is never triggered on
normal exit
 
I'm not clear on what you mean.  A client of WebKit2 release their
WKContextRef pointer from atexit() if they wanted to (or in whatever other
termination routines they already have), but its not clear to me why the
framework should do it for them.  We don't do this for any other objects.
 
-Sam
 
On Aug 24, 2012, at 7:15 PM, Kangil Han  mailto:kangil@samsung.com
kangil@samsung.com wrote:




Hi,
 
I've found WebContext destructor is never triggered on normal exit in WK2.
 
This happens because only IPC message from WebProcess could terminate it but
won't do that in this case.
One possibility for doing this is to create a flow of termination from
UIProcess on exit.
 
But, before starting investigation, I would like to ask your opinion.
 
kangil
 
___
webkit-dev mailing list
 mailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev
http://lists.webkit.org/mailman/listinfo/webkit-dev
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] [WK2] WebContext destructor is never triggered on normal exit

2012-08-24 Thread Kangil Han
Hi,
 
I've found WebContext destructor is never triggered on normal exit in WK2.
 
This happens because only IPC message from WebProcess could terminate it but
won't do that in this case.
One possibility for doing this is to create a flow of termination from
UIProcess on exit.
 
But, before starting investigation, I would like to ask your opinion.
 
kangil
 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev