Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-16 Thread Keith Miller
2020 at 9:15 PM Keith Miller <mailto:keith_mil...@apple.com>> wrote: > If you tell me how to enable paint timing by default, I can start an A/B task > for you. I’m probably not qualified to review it for code maturity though. > Awesome, thanks! > It's an experimental runtime fl

Re: [webkit-dev] Suggesting to enable paint timing by default

2020-07-13 Thread Keith Miller
If you tell me how to enable paint timing by default, I can start an A/B task for you. I’m probably not qualified to review it for code maturity though. Cheers, Keith > On Jul 13, 2020, at 3:02 AM, Noam Rosenthal wrote: > > > > On Wed, May 27, 2020 at 12:04 PM Yoav Weiss

Re: [webkit-dev] New EWS queues for tvOS and watchOS

2020-07-12 Thread Keith Miller
It looks like just arm64_32. Cheers, Keith > On Jul 11, 2020, at 8:41 PM, Yusuke Suzuki wrote: > > Nice, > > Is watchOS build ARMv7k? Or is it ARM64_32? > > -Yusuke > >> On Jul 11, 2020, at 8:09 AM, Aakash Jain wrote: >> >> Hi Everyone, >> >> I am happy to announce that we have added new

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2020-04-03 Thread Keith Miller
Resurrecting this from the dead because it came up in: https://bugs.webkit.org/show_bug.cgi?id=209979 > On May 10, 2019, at 5:34 PM, Alexey Proskuryakov wrote: > > >> 10 мая 2019 г., в 13:50, Darin Adler > <mailto:da...@apple.com>> написал(а): >> >>>

Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Keith Miller
> On May 10, 2019, at 1:07 PM, Darin Adler wrote: > >> On May 10, 2019, at 1:00 PM, Keith Miller wrote: >> >> I don’t know if this is possible but it would be great if some >> sub-directories could be excluded from the no-tabs pre-commit hook. > > Mayb

[webkit-dev] Changing the svn commit hook to allow tabs for tests.

2019-05-10 Thread Keith Miller
. Alternatively, we could remove the pre-commit hook as tabs should be caught by the style-checker anyway. This is a more contentious choice so I’m not proposing it as the first option unless someone else wants to push for it. Cheers, Keith Miller ___ webkit

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-13 Thread Keith Miller
I’ve definitely done this in JSC before. As with everyone else, I don’t feel particularly strongly about it. > On Feb 7, 2019, at 8:45 PM, Chris Dumez wrote: > > Same here, I used it in PSON code with completion handlers. I liked the more > concise code but I also do not feel strongly about

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

2018-09-17 Thread Keith Miller
IIRC, it spends a bunch of time in the offline assembler ruby scripts. AFAIK, those scripts only depend on the LowLevelInterpreter*.asm files. So we should only need to run it if those files have changed. Or, for the assembly generation half, if there is also a new object offsets binary (from

[webkit-dev] Disabling the 32-bit JITs by default.

2018-02-16 Thread Keith Miller
I recently created a patch to disable the 32-bit JITs by default. https://bugs.webkit.org/show_bug.cgi?id=182886. The last time this was discussed was before the discovery of Spectre. In the interim, there have been a number of changes made to JavaScriptCore in an attempt to mitigate Spectre.

[webkit-dev] Moving WebCore to unified source builds and style changes.

2017-10-12 Thread Keith Miller
Hello WebKittens, As discussed previously, I’m preparing to start migrating WebCore to unified-source builds. I was originally going to move over in one step but I have since realized that is going to be super hard to rebase fast enough. Instead I’ll move WebCore over incrementally. I have a

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Keith Miller
This seems like a good progress change we could make. I’m on board! Cheers, Keith > On Sep 21, 2017, at 11:54 AM, Tim Horton wrote: > > Hi, all! > > Would anybody mind if build-webkit stopped being a source of default values > of feature flags? > > We have defaults

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Keith Miller
> On Aug 30, 2017, at 7:25 PM, Dean Jackson <d...@apple.com> wrote: > > >> On 29 Aug 2017, at 10:37 am, Keith Miller <keith_mil...@apple.com >> <mailto:keith_mil...@apple.com>> wrote: >> >> Are you growing tired of long cat naps whil

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Keith Miller
> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: > > > >> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen > > wrote: >> >>> This isn’t the scenario I find myself in most often. A much more common >>> scenario is working on a

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Keith Miller
> On Aug 30, 2017, at 1:01 PM, Alexey Proskuryakov wrote: > > > >> 30 авг. 2017 г., в 11:55, Andy Estes > > написал(а): >> > In a completely other direction, what does this mean for use of Xcode? > Can we still build

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
In addition to what Darin said, I think using a consistent name makes the most sense. If “Internal” is what we would use for some of the places we should use it everywhere. Cheers, Keith > On Aug 29, 2017, at 5:29 PM, Darin Adler wrote: > >> On Aug 29, 2017, at 4:32 PM,

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 4:20 PM, Alicia Boya García <ab...@igalia.com> wrote: > > On 08/30/2017 12:00 AM, Keith Miller wrote: > >> The automated system should handle your concern about bundling similar .cpp >> files together. The proposed system bundles by director

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
As far as the static renaming problem, Darin convinced me in the other thread that we probably don’t need such a heavy handed approach. At least in JSC, there are a number of variables that have generic names that should be put into a namespace but the majority probably don’t need to be

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 11:37 AM, Maciej Stachowiak <m...@apple.com> wrote: > > > >> On Aug 29, 2017, at 11:31 AM, Darin Adler <da...@apple.com> wrote: >> >> Sent from my iPhone >> >>> On Aug 29, 2017, at 11:22 AM, Keith Miller <kei

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 11:03 AM, Geoffrey Garen wrote: > >> I worry about adopting unity build because while it makes clean builds >> faster, it also slows down incremental builds. As a developer, I rarely do >> clean builds, I mostly do incremental builds so this would

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 10:15 AM, Darin Adler wrote: > > If we decide that we can’t support file scope identifiers then we should > figure out the most practical way to do it. Of course this affects constants > and variables, too, not just functions. > > I think this special

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: > > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 28, 2017, at 8:10 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, Aug 28, 2017 at 7:37 PM, Keith Miller <keith_mil...@apple.com> wrote: >> Given that most of the build time in incremental builds is scanning >> dependencies, th

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 9:04 AM, Chris Dumez wrote: > > I indeed think this will require “using” statements or explicit namespace at > call sites. Yeah, this is basically what’s required. Unfortunately, if you ‘using namespace’ in a namespace all subsequent copies of that

[webkit-dev] Unified source builds: A new rule for static variables

2017-08-28 Thread Keith Miller
Hello WebKittens, As many of you already know build times in WebKit have a major impact on the productivity of developers. My hope is to change that for clean builds without significantly impacting incremental builds. We’re expecting to see a 3-4x build time speedup on clean builds of WebKit!

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Keith Miller
> On Aug 23, 2017, at 12:21 PM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 23.08.2017, 21:15, "Keith Miller" <keith_mil...@apple.com > <mailto:keith_mil...@apple.com>>: >> You can totally have the enable_if in the templa

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Keith Miller
t --no-ews flag is good enough. > > -Aakash > >> On Aug 23, 2017, at 11:56 AM, Ryosuke Niwa <rn...@webkit.org> wrote: >> >> On Wed, Aug 23, 2017 at 9:11 AM, Andy Estes <aes...@apple.com> wrote: >>> >>> >>> On Aug 22, 2017

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Keith Miller
look like: >> >> template::value)> >> class Foo {...}; >> >> template::value)> >> class Foo {...}; >> >> template::value)> >> class Foo {...}; >> >> So when I know I want to use a Foo but I forgot the signature I now need to >

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Keith Miller
h a more standard approach. Cheers, Keith > > -- >  Chris Dumez > > > > >> On Aug 22, 2017, at 8:34 PM, Keith Miller <keith_mil...@apple.com >> <mailto:keith_mil...@apple.com>> wrote: >> >> Hello fellow WebKittens, >> >

[webkit-dev] How we enable template functions

2017-08-22 Thread Keith Miller
Hello fellow WebKittens, I’ve noticed over time that we don’t have standard way that we enable versions of template functions/classes (flasses?). For the most part it seems that people use std::enable_if, although, it seems like it is attached to every possible place in the function/class. I

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-22 Thread Keith Miller
Does it make sense to have a --wip option that’s basically --no-review / don’t run EWS? There are times I upload clearly broken patches for early analysis that don’t need to be run on EWS. Cheers, Keith > On Aug 14, 2017, at 2:16 PM, Daniel Bates wrote: > > Hi all, > >

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-08-07 Thread Keith Miller
> On Aug 5, 2017, at 1:48 PM, Konstantin Tokarev wrote: > 04.08.2017, 21:20, "Carlos Alberto Lopez Perez" : >> On 02/08/17 12:14, Konstantin Tokarev wrote: >>> FWIW, I use ENABLE_ALLINONE_BUILD=ON as a default build option in Qt >>> port and don't have

Re: [webkit-dev] Python

2017-08-07 Thread Keith Miller
Out of curiosity, is this just about building or is part of the concern with development scripts? AFAICT, we invoke all our python scripts by invoking $(PYTHON), which can be whatever path you need. I didn’t look too closely though... Cheers, Keith > On Aug 7, 2017, at 6:47 AM, Michael

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-08-01 Thread Keith Miller
as possible, I’m less concerned with production build times. Although, I would like to improve production build times also. Cheers, Keith > On Aug 1, 2017, at 3:48 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Tue, Aug 1, 2017 at 11:33 PM, Keith Miller <keith_mil..

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-08-01 Thread Keith Miller
That’s right if we end up going with C++ modules. We will either need to produce a replacement for config.h or have all root headers (i.e. headers that don’t include any other WebKit headers) include config.h. This is because with C++ modules the rule is that you have to include what you use.

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Keith Miller
Is there any opposition to relaxing this rule? Speak now or forever hold your piece! (not really but I would be curious to hear opposition). Cheers, Keith > On Apr 27, 2017, at 10:32 PM, Carlos Garcia Campos > wrote: > > El jue, 27-04-2017 a las 16:06 -0700, JF Bastien

Re: [webkit-dev] !!Tests for equality comparison

2017-04-27 Thread Keith Miller
I agree that using ! does not make the code more readable. I almost always find ! subtly harder to read. Keith > On Apr 27, 2017, at 4:36 PM, Caio Lima wrote: > > O also think it's a good notation. It helps a lot the code reading IMO. > > Caio. > Em qui, 27 de abr de

Re: [webkit-dev] Importing Test262 into WebKit

2016-05-17 Thread Keith Miller
ormance, we currently fail 2610 tests in the suite. > I willingly help testing patches on X86_64/ARM Linux environments, > reviewing run-jsc-stress-tests improvements, please cc me to the > related bug reports and feel free to ping me on IRC. > > br, > Ossy > > On 2016-

Re: [webkit-dev] Importing Test262 into WebKit

2016-05-12 Thread Keith Miller
a better coverage but perhaps we need to increase > the number of bots if we're adding 20min to our cycle time. > - R. Niwa > > > On Thu, May 12, 2016 at 4:02 PM, Keith Miller <keith_mil...@apple.com> wrote: >> Hi everyone, >> >> For those of you that have not

[webkit-dev] Importing Test262 into WebKit

2016-05-12 Thread Keith Miller
Hi everyone, For those of you that have not already heard of Test262, it is a continually updated conformance test suite for upcoming ECMAScript standards (https://github.com/tc39/test262). I think it’s in our best interest to include the test suite in our normal testing infrastructure for