Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Keith Rollin
> On Oct 20, 2020, at 10:51, Andy Estes wrote: > >> On Oct 18, 2020, at 11:01, Sam Weinig wrote: >> >> One direct benefit of moving away from DerivedSources.make would likely be >> (I say likely, as the details of how it works out are far from certain in my >> mind) removing at least one

Re: [webkit-dev] Switching to XCBuild for Apple builds

2020-04-01 Thread Keith Rollin
> On Apr 1, 2020, at 06:21, Frédéric Wang wrote: > > On 31/03/2020 08:42, Keith Rollin wrote: > >> For several years now, Xcode has included two build systems: the “legacy” >> build system and the newer “XCBuild” system (see, for example, >> <https://develop

[webkit-dev] Switching to XCBuild for Apple builds

2020-03-31 Thread Keith Rollin
the build requirements are stricter. I’ve made the changes to switch over to XCBuild but I haven’t yet posted them. I want to first find out if this move will cause any issues for developers who — for whatever reason — need to stay on old versions of Xcode. If so, please let

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-17 Thread Keith Rollin
> On Jun 16, 2019, at 11:14, Darin Adler wrote: > > If we want to augment it, we should think of what we are aiming at. I do find > it useful to see which tests are failing, and when I click on the red bubble > I don’t see that information. I have to click once to see the “log of >

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Keith Rollin
> On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro > wrote: > Hi, > > For the past several years, I've been regularly fixing -Wformat > warnings that look like this: > > ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning: > format ‘%llu’ expects argument of type ‘long long

Re: [webkit-dev] Unified sources have broken our #include hygiene

2018-09-04 Thread Keith Rollin
> On Sep 1, 2018, at 19:25, Darin Adler wrote: > > I’ve long been interested in and wondered > whether we could use it, but it sort of does the opposite, and the “multiple > platforms” problem could well make even that tool impractical for us. I’ve spent a

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Keith Rollin
> On Apr 24, 2017, at 11:15, JF Bastien wrote: > > 1) Reduce #includes by doing more forward declaring and less inlining. We > would probably need link time optimization to not lose performance benefits > of inlining functions in headers. > >