I just want to say that I absolutely love the new review tool and the
ability to select multiply lines of contents!
Kenneth
On Fri, Sep 17, 2010 at 4:11 AM, Darin Fisher wrote:
> On Fri, Sep 17, 2010 at 12:05 AM, Alexey Proskuryakov wrote:
>>
>> 16.09.2010, в 23:39, Adam Barth написал(а):
>>
>>
I'm fine with it as well; the name confuses a lot of new contributors.
Kenneth
On Thu, Jul 29, 2010 at 3:15 PM, Dirk Pranke wrote:
> On Thu, Jul 29, 2010 at 10:59 AM, Darin Adler wrote:
>> Hi folks.
>>
>> WebKit regression tests are in a directory named LayoutTests. The object the
>> tests use
Currently it seems that at least icecc does not. Also, qmake which is
the build system for the Qt port does not support prefix headers
directly and we thus have to emulate it using the precompiled header
support.
Kenneth
On Wed, Jul 7, 2010 at 2:27 PM, Sam Weinig wrote:
> It should not be neces
> 6) Add validator rules that make invocation of the "new" operator legal
> only inside adoptRef and adoptPtr function calls.
That is probably going to be a problem for Qt code on the WebKit API
side. If we disable this rule for WebKitTools and WebKit I think we
should be OK
Kenneth
Isn't the idea here that Mechanisms are for global clients, where as
the current clients are not?
Kenneth
On Wed, Jun 16, 2010 at 9:55 PM, Darin Adler wrote:
> Sounds reasonable to me. We already follow pointers and use virtual functions
> for all these things, so I don’t see them adding a lot
Hi there Anders,
I think this sounds pretty fine at least from a Qt perspective; and it
will also easily enable us to let some of our platforms override the
implementation using a plugin system. We already have such a system in
place (PlatformPlugin) so that platforms can re-implement the handling
t; On May 31, 2010, at 11:09 AM, Kenneth Christiansen wrote:
>
>> Hi Kevin,
>>
>> They export privately using some files listing the symbols to be
>> exported (mac supports that as so does visual studio, I believe). We
>> cannot do this for Qt, so if you search bugzi
Hi Kevin,
They export privately using some files listing the symbols to be
exported (mac supports that as so does visual studio, I believe). We
cannot do this for Qt, so if you search bugzilla you will find that we
have some old patches adding export declarations to the classes being
exported (or
Nice work Ojan,
Will you make webkit-patch apply-attachment understand patches doing
renames/mv created with git format-patch? That would be really useful.
Cheers,
Kenneth
On Mon, Apr 26, 2010 at 2:55 PM, Ojan Vafai wrote:
> The behavior of git and webkit-patch changed with
> http://trac.webkit
That said, the Tiger bot is often lacking behind as well, which I'm
not sure should be acceptable for core builders.
Kenneth
On Wed, Apr 21, 2010 at 7:27 PM, Gavin Barraclough
wrote:
> Hi Eric,
>
> Many apologies for the redness. These changes are pretty much complete now,
> so hopefully there
Last I looked there are still patches up for review for Haiku. It
would be nice to know why it is not being maintained. Is that due to
having no interest from their community or due to the fact that noone
are reviewing the patches?
Kenneth
On Fri, Apr 9, 2010 at 6:26 PM, Adam Barth wrote:
> Is t
Which ports are considered unmaintained?
Kenneth
On Fri, Apr 9, 2010 at 6:03 PM, Adam Barth wrote:
> On Fri, Apr 9, 2010 at 1:53 PM, Cameron Zwarich wrote:
>> We seem to welcome pretty much any port that has an active maintainer.
>
> IMHO, that's a good thing. I wonder if we should "archive" p
2, 2010 at 12:55 PM, Dimitri Glazkov wrote:
> I just reached out to the Russian icon powerhouse, Turbomilk
> (turbomilk.com), and they're interested in pitching in as well. Maybe
> we should have a contest?
>
> :DG<
>
> On Mon, Mar 22, 2010 at 5:43 AM, Kenneth Chr
I have asked our designers to look into it :-)
Kenneth
On Mon, Mar 22, 2010 at 8:42 AM, Jeremy Orlow wrote:
> On Fri, Mar 19, 2010 at 4:00 PM, Darin Adler wrote:
>>
>> On Mar 19, 2010, at 8:40 AM, Dimitri Glazkov wrote:
>>
>> > Would you happen to know how WebKit icon is licensed?
>>
>> The ico
If you cannot get it working, please add it to Skipped and I will look
into it on monday when I'm back at work.
I was actually talking to a co-worker about our long list of new
results while on the plane yesterday and I will see if my team can
dedicate a day per week to look into these.
Kenneth
That is really good news! Congratulation!
Kenneth
On Fri, Mar 19, 2010 at 2:13 PM, Dimitri Glazkov wrote:
> WebKit folks,
>
> We're finally ready to land our port's expected results in the WebKit
> tree. It's been a long journey, but we are now to the point where it
> no longer makes sense to ke
That is some of the best 9 cents spend ever!
Kenneth
On Fri, Feb 26, 2010 at 1:58 PM, Adam Barth wrote:
> On Fri, Feb 26, 2010 at 8:55 AM, Adam Barth wrote:
>> Amazon tells me that our current bots use about 4 GB/month of download
>> bandwidth and 600 MB/month of upload bandwidth. I presume al
> 1) Contributor uploads patch and nominates it for review.
> 2) Patch vetted by the EWS on numerous platforms.
When a non-committer uploads a patch, it is not being vet by EWS. I
know that is due to security issues. It would be really nice with an
option for a reviewer to accept it to run on the
Sounds like a good idea, I'm all for it.
Kenneth
On Wed, Jan 20, 2010 at 1:18 PM, Darin Adler wrote:
> Hi folks.
>
> We’ve never formalized this, but I believe that patches tagged with a
> particular platform name such as
>
> [Qt] Add new API for fluffy bunnies
>
> should be limited to one
In Qt we only allow underscored in methods that start with qt_ and they are
used for private API, such as for the DRT and for API that we havent had the
time to API review, but are still needed by some other software products.
Kenneth
On Wed, Jan 13, 2010 at 9:32 PM, Darin Fisher wrote:
> On We
romium.cpp.
>
> -Darin
>
>
>
> On Thu, Jan 7, 2010 at 2:44 PM, Kenneth Christiansen <
> kenneth.christian...@openbossa.org> wrote:
>
>> Hi there,
>>
>> A co-worker of mine is implementing the ability to reimplement how popup
>> menus (comboboxes)
>
> Maybe add a virtual like:
>
>virtual PlatformPopupMenu platformPopupMenu() const = 0;
>
> to HostWindow.h ?
>
That is an option but I do not know if that is the purpose of HostWindow.
> Much like Qt already returns QWebPageClient for 'platformPageClient()' ?
> Maybe you can even re-u
Hi there,
A co-worker of mine is implementing the ability to reimplement how popup
menus (comboboxes) etc will appear from our Qt WebKit API.
As these UI delegates are per page, we thought about adding a method to our
ChromeClientQt like AbstractPopupMenu* createPopupMenu(PopupMenuClient*
client)
This should go to the webkit...@lists.webkit.org list instead. Please repost
there.
Creating a bug report on bugs.webkit.org for tracking your issues is another
welcome option.
Kenneth
On Tue, Dec 15, 2009 at 5:24 PM, Andrew Webster wrote:
> For all the Qt people out there, here is my problem:
I'm OK with both. Peter's is my preferred solution, though.
Kenneth
On Thu, Dec 3, 2009 at 11:39 PM, Dirk Pranke wrote:
> +1. Peter's is better than Maciej's is better than status quo.
>
> -- Dirk
>
> On Thu, Dec 3, 2009 at 6:24 PM, Jeremy Orlow wrote:
> > On Thu, Dec 3, 2009 at 6:15 PM, Macie
Nice, that change would make it compatible with the Qt style guide! I:-) I
say go for it!
Kenneth
On Thu, Dec 3, 2009 at 2:00 AM, Peter Kasting wrote:
> This is a followup to my thread yesterday regarding consistent enforcement
> of the style guide. Like Yong Li, I find the current rule about
Maybe in the case of failure, provide a link to further information?
Kenneth
On Sun, Nov 29, 2009 at 3:44 AM, Maciej Stachowiak wrote:
>
> On Nov 28, 2009, at 10:53 AM, Adam Barth wrote:
>
> On Sat, Nov 28, 2009 at 10:21 AM, Maciej Stachowiak
>> wrote:
>>
>>> On Nov 28, 2009, at 2:21 AM, Adam
FYI this in not just related to Qt, as at least both win and mac have
similar code.
Kenneth
On Fri, Nov 13, 2009 at 5:34 PM, Alexey Proskuryakov wrote:
>
> I'm not sure if this is a great approach. Previously, people with other
> default locales exercised code paths that aren't normally taken o
I think that sounds like a really good idea, and I can see my self
using that when touching cross platform code.
Kenneth
On Thu, Nov 12, 2009 at 4:37 PM, Adam Barth wrote:
> As the project grows, we need to scale our processes to match. In
> large part, that means automating as much work as pos
Nice stuff Jonni,
Kai showed me the examples at the Qt Dev Days and I got quite
impressed; it runs very smoothly.
Good work guys!
Kenneth
On Thu, Oct 15, 2009 at 5:56 AM, wrote:
>
> FYI, we have just released experimental branch of multitouch support of
> QtWebKit for Windows7 on gitorious.
>
I cannot say that I will be using it soon, but I really like the
project and think that it can become very important for MathML and the
web in general.
As a Qt developer, it would also open the door for our users to
integrate math into their applications.
Cheers,
Kenneth
On Mon, Oct 5, 2009 at 5
Hi there,
I'm unfortunately not a QMake expert or I would have looked into it.
Simon, do you know who is the right person for looking into this? You,
perhaps? :-) or can you recommend someone from Qt?
Cheers,
Kenneth
On Fri, Aug 14, 2009 at 5:05 PM, Mark Rowe wrote:
>
> On 2009-08-12, at 18:37,
Hi there,
In bug 27499 (https://bugs.webkit.org/show_bug.cgi?id=27499) it was
pointed out that the coding style guide doesn't clarify whether it is
allowed to place a space before a comma or semicolon in a control
condition or in functions.
Thus asking the question whether the three following cod
When then I guess that you can only expect to get help after you have
contributed the code back to the community. ;-)
Good luck with your port anyway.
Kenneth
On Wed, Jun 17, 2009 at 6:29 PM, Toshiyasu Morita wrote:
> wrote:
>
>> That doesn't mean that you cannot develop it in the open. We can
That doesn't mean that you cannot develop it in the open. We can
integrate the code once you are ready to do so.
Kenneth
> I've talked to my client, and he's told me it's their intent to contribute
> the port back to the community once the port is finished.
>
> IMHO main problem with trying to co
Hi there,
I would also say that is it pretty understanding that Apple does not
share information about working on a ARM JIT targeting thumb2,
especially as this can be used to foresee the hardware of future
iPhone models. Something they are probably not interesting in
revealing.
I agree whole-hea
lease file a bug on bugs.webkit.org and attach a patch. The webkit.org web
> site is in the svn repository, so you may create patches against the HTML.
> Thanks!
> Dave
>
> ________
> From: Kenneth Christiansen
> To: webkit-dev
> Sent: Thursday, June 4
Hi there,
I'm having a question regarding the coding style.
According to 2. An else statement should go on the same line as a
preceding close brace.
I would always need a brace when using if-else, in order to but the
else statement on the same line as the preceding close brace, is this
right?
or
I believe Qt uses instance() in this situation.
> Sadly we have not yet found a good verb for the common "get or create"
> idiom.
Cheers.
Kenneth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit
Great! I notices that RegExp.h still includes WREC, will that be changed?
If it requires the JIT why are there both a ENABLE_YARR and an ENABLE_YARR_JIT ?
Cheers,
Kenneth
On Tue, May 19, 2009 at 9:52 PM, Geoffrey Garen wrote:
>>> If so, does it work on the same platforms at the JSCore JIT?
>>
Hi there,
I made a patch that replaces WREC usage in the Qt port by YARR, but
I'm having a few questions.
1) Does it make sense to enable ENABLE_YARR by default and use it even
when we have no JIT support.
2) Does the YARR JIT depend on the JSCore JIT, or is it a separate
JIT. If so, does it work
I would definately be interested in this work for my EFL port of WebKit.
Currently we use cURL and do not support cookies. Libsoup is apparently a
no-go as I was told that it requires a running glib mainloop.
Cheers,
Kenneth
On Tue, Feb 10, 2009 at 12:08 PM, Julien Chaffraix <
julien.chaffr...@g
There is also the FontCache growing, I do not know if there is a
setting for that as well, but on shutdown I empty ours in order to be
able to finalize FontConfig.
-Kenneth
On Thu, Jan 8, 2009 at 7:03 AM, Ariya Hidayat
wrote:
>
>> Why did it happen?
>> Is there a way to deallocate memory from a
Hi there,
I had a crash the other day and found some code that looks wrong to me.
The affected method is FrameView::endDeferredRepaints() found in
WebCore/page/FrameView.cpp
unsigned size = d->m_repaintRects.size();
for (unsigned i = 0; i < size; i++)
repaintContentRectangle(d->m_repaintRe
44 matches
Mail list logo
