Re: [webkit-dev] Re: Qt's default webkit user agent

2008-02-12 Thread Lars Knoll
On Tuesday 12 February 2008, Alp Toker wrote: (It's disappointing to see the growing number of WebCore changes in Qt's git tree that could benefit the whole project. Are you planning to submit these changes for review?) All of our changes are supposed to go into trunk. This is not always

Re: [webkit-dev] I hope I'm posting this in the right place - QtWebkit from git (Qt)

2008-01-10 Thread Lars Knoll
On Thursday 10 January 2008, Mark Rowe wrote: On 10/01/2008, at 16:58, Chris Fuenty wrote: Using Qt's Git repo, Is this able to be successfully compiled on Win32? I'm running into a few issues, but I can post them after I get conformation that this can be compiled on win32, or if it's

Re: [webkit-dev] Re: ProjectVision

2007-11-25 Thread Lars Knoll
On Friday 23 November 2007 23:59:25 Maciej Stachowiak wrote: On Nov 23, 2007, at 9:31 AM, Alp Toker wrote: http://trac.webkit.org/projects/webkit/wiki/ProjectVision?action=diffver sion=1 Please revert this change until the topic has been discussed on the mailing list or bug tracker. You

Re: [webkit-dev] Just a few ?'s about the Qt WebKit port...

2007-10-19 Thread Lars Knoll
On Friday 19 October 2007, Fuenty, Chris wrote: .As I'm reading on http://trac.webkit.org/projects/webkit/wiki/QtWebKitTodo I notice a few things that spark interest... #1: New HTTP Stack, Does this currently use any Stacks provided by the Qt Toolkit? From some usage with QtWebKit, I see no

Re: [webkit-dev] Is WebKit really working with QT4 ?

2007-10-17 Thread Lars Knoll
Lionel, don't use that ubuntu package for Qt4. It's based on qt 4.3.0 beta1, and there have been some API changes between beta1 and 4.3.0 final. Get yourself Qt 4.3.1 or 4.3.2 from www.trolltech.com, and use that. QtWebKit is still work in progress, but most things do actually work (even

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Lars Knoll
On Tuesday 09 October 2007, Timothy Hatcher wrote: I think Git is rather slow on Windows I hear. Yes, it's quite a bit slower than on Unix systems. But there has been quite a bit of work happening lately on the windows port speeding it up substantially. It's now pretty usable for us (Qt

Re: [webkit-dev] Should we consider switching to git over svn?

2007-10-09 Thread Lars Knoll
I'll just add my 2 cents here. I'm very much in favor of switching over to git at some point. There are many reasons for that, but I'll try to highlight the main ones that come to my mind (in addition to the ones Oliver mentioned already): * local repository and working offline: I often have

Re: [webkit-dev] Netscape API plugins for WebKit on Linux

2007-10-08 Thread Lars Knoll
On Monday 08 October 2007, Song Yuan wrote: Hi, I successfully built WebKit based on Qt port on Ubuntu. The browser in Qt window works really fine. But when I tried the test cases in /LayoutTests/plugins that uses Netscape API, none of them works as expected. I'm wondering how the progress

Re: [webkit-dev] Qt/Win32 build environment

2007-08-17 Thread Lars Knoll
). QtWebKit itself has no external dependency (apart from Qt). I'm not sure if things would build in cygwin. It's something we haven't tested. Cheers, Lars Thanks, Artem Lars Knoll wrote: Hi Artem, there are some instructions on howto build QtWebKit on Windows on the WebKit wiki: http

Re: [webkit-dev] Qt/Win32 build environment

2007-08-16 Thread Lars Knoll
Hi Artem, there are some instructions on howto build QtWebKit on Windows on the WebKit wiki: http://trac.webkit.org/projects/webkit/wiki/BuildingQtOnWindows Hope this helps, Lars On Wednesday 15 August 2007, Artem Ananiev wrote: Hi, all, looking at the recent WebKit changes, I noticed

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-29 Thread Lars Knoll
On Sunday 29 July 2007 08:47:50 Maciej Stachowiak wrote: On Jul 28, 2007, at 3:52 AM, Lars Knoll wrote: On Saturday 28 July 2007 00:26:19 Maciej Stachowiak wrote: On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: Other organizations have requested the ability to use other XML parsers

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 18:56:40 Darin Adler wrote: On Jul 27, 2007, at 7:45 AM, Darin Adler wrote: On Jul 27, 2007, at 4:03 AM, Alexey Proskuryakov wrote: On 7/27/07 1:51 PM, Simon Hausmann [EMAIL PROTECTED] wrote: Does anybody know/remember why JSChar is defined to wchar_t on Windows and

Re: [webkit-dev] type of JSChar

2007-07-27 Thread Lars Knoll
I do understand this for your Windows port. In Qt we try to have the same types across all platforms. This is also true for our QChar abstraction that is built on top of an unsigned short. So for us typedef'ing this to wchar_t is as wrong as unsigned short would be for your windows port.

[webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 16:50:01 Darin Adler wrote: I'm not happy with the code organization here. XMLTokenizer now has tons of ifdefs and two separate implementations. It's fine to have a QXmlStream implementation, but the two implementations should be in separate files, side by side, as we do

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 20:50:53 Darin Adler wrote: On Jul 27, 2007, at 11:36 AM, Lars Knoll wrote: 2. add a qt/XMLTokenizerQt.cpp and a libxml/XMLTokenizerLibXml.cpp and keep a common XMLTokenizer.cpp for code that is used in both. I like that option best. It's the pattern used in platform

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 21:05:00 Darin Adler wrote: On Jul 27, 2007, at 11:53 AM, Lars Knoll wrote: I'm fine with moving to this approach (even though it'll still lead to some code duplication if we do it the easy way without refactoring). I don't think we should insist on doing it without

Re: [webkit-dev] Re: [webkit-changes] [24723] trunk/WebCore

2007-07-27 Thread Lars Knoll
On Friday 27 July 2007 21:15:27 Lars Knoll wrote: On Friday 27 July 2007 21:05:00 Darin Adler wrote: On Jul 27, 2007, at 11:53 AM, Lars Knoll wrote: I'm fine with moving to this approach (even though it'll still lead to some code duplication if we do it the easy way without refactoring

Re: [webkit-dev] WebKit licensing and LGPLv3

2007-07-25 Thread Lars Knoll
On Wednesday 25 July 2007, Allan Sandfeld Jensen wrote: On Wednesday 25 July 2007 01:51, Maciej Stachowiak wrote: 1) We will continue to accept only code that's licensed under a BSD- style (no advertising clause) license, or LGPL 2.1, or other compatible license. We don't want to accept

Re: [webkit-dev] WebKit Project Goals

2007-07-25 Thread Lars Knoll
On Wednesday 25 July 2007, Maciej Stachowiak wrote: I sent this a while ago with not much comment. Any thoughts? Should I post this on webkit.org somewhere? I like both the goals and non-goals. Please put it onto webkit.org. Cheers, Lars - Maciej On May 10, 2007, at 3:34 PM, Maciej

Re: [webkit-dev] layout tests

2007-01-19 Thread Lars Knoll
On Friday 19 January 2007 14:31, David D. Kilzer wrote: On Jan 19, 2007, at 4:23 AM, Lars Knoll wrote: * run-webkit-tests generated results for new tests on the fly [...] I've fixed this issue with r18976. run-webkit-tests does now not generate new results by default anymore. You'll