[webkit-dev] Removing the ENABLE(CSS_SCROLL_SNAP) flag

2021-06-15 Thread Martin Robinson via webkit-dev
Recently, css-scroll-snap was enabled on all ports. The implementation has also been extended to be mostly platform-independent. Since all ports are compiling this code and it's a fairly basic CSS feature should we go ahead and remove the ENABLE(CSS_SCROLL_SNAP) build flag? I think this would

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2015-11-16 Thread Martin Robinson
On Fri, Nov 13, 2015 at 10:15 AM, Osztrogonác Csaba wrote: > I like the idea to have a platform free, standalone JSC. > It would make easier to maintain various ARM backends. > > We don't need update-webkit*-libs at all for the > standalone JSC, it really depends only on ICU

Re: [webkit-dev] forwarding headers and CMake

2015-07-28 Thread Martin Robinson
I think this might cause issues, because it requires the forwarding headers be regenerated when any of the target headers change. Why does Windows need this change? Are the headers being copied for some packaging purpose? If so, perhaps that can be a separate step specific to Windows. --Martin

Re: [webkit-dev] CMake on Windows

2015-07-21 Thread Martin Robinson
This is great news! Do you plan to remove the WinCairo portion of the Visual Studio build? --Martin On Tue, Jul 21, 2015 at 4:29 PM, Alex Christensen achristen...@apple.com wrote: I plan to switch build-webkit --wincairo to use CMake in the near future. We are not ready to remove the Visual

[webkit-dev] WTF USE(...) macro

2015-04-29 Thread Martin Robinson
Hi, please forgive my continuing quest into the realm of small build cleanups. We have some handy WTF macros to deal with build variables. For example #if ENABLE(WHATEVER) will be true if ENABLE_WHATEVER is defined and not 0. There are a few others such as PLATFORM(...) and USE(...). One

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-24 Thread Martin Robinson
On Thu, Apr 23, 2015 at 4:48 PM, Simon Fraser simon.fra...@apple.com wrote: USE(3D_GRAPHICS) appears to surround WebGL code in general. I don’t see any non-WebGL bits in a quick search. It seems that USE(3D_GRAPHICS) simply enables GraphicsContext3D and its helper classes, so I propose that we

Re: [webkit-dev] Proposal: Remove TextureMapperImageBuffer

2015-04-24 Thread Martin Robinson
On Fri, Apr 24, 2015 at 8:48 AM, Ilyes GOUTA ilyes.go...@st.com wrote: At STMicroelectronics, we do have an accelerated WebGL and Video compositing path that's based on TextureMapperImageBuffer (so native platform's pixmaps). We use that with the Qt port. Compositing happens accelerated

[webkit-dev] Proposal: Remove TextureMapperImageBuffer

2015-04-23 Thread Martin Robinson
Background: There currently exists a fallback TextureMapper implementation that does not use OpenGL to composite and project layers, but instead relies on 2D rasterization. This does not work correctly for Cairo, since Cairo only supports affine transformations. I believe this path is only used by

Re: [webkit-dev] Proposal: Remove TextureMapperImageBuffer

2015-04-23 Thread Martin Robinson
accelerated compositing completely for WebKitEFL (if possible) and skip those tests. Once the bots have the ability to run tests that use OpenGL, we can re-enable that code path for WebKitEFL. --Martin On Thu, Apr 23, 2015 at 11:12 AM, Martin Robinson mrobin...@webkit.org wrote: Background

[webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Martin Robinson
In the process of cleaning up and dusting off the GTK+ cmake build system, we have rediscovered the pair of somewhat confusing feature defines WTF_USE_3D_GRAPHICS and ENABLE_3D_RENDERING. From a brief audit, it appears that WTF_USE_3D_GRAPHICS is a generic flag for any kind of 3D rendering at all

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Martin Robinson
, Apr 23, 2015 at 4:48 PM, Simon Fraser simon.fra...@apple.com wrote: On Apr 23, 2015, at 4:39 PM, Martin Robinson mrobin...@webkit.org wrote: In the process of cleaning up and dusting off the GTK+ cmake build system, we have rediscovered the pair of somewhat confusing feature defines

Re: [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

2014-10-14 Thread Martin Robinson
On Tue, Oct 14, 2014 at 9:29 AM, Darin Adler da...@apple.com wrote: What file turns this on for GTK builds? I see it set in cmake/OptionsEfl.cmake for the EFL port, and in WebKit2/WebKit2Prefix.h for the Mac and iOS ports. Like the Mac and iOS ports, this is enabled via

Re: [webkit-dev] Port-specific OpenType support

2014-09-15 Thread Martin Robinson
On Sun, Sep 14, 2014 at 11:22 AM, Tim Horton thor...@apple.com wrote: On 2014.09.14, at 01:11, Dirk Schulze k...@webkit.org wrote: On Sep 11, 2014, at 11:03 PM, Martin Robinson mrobin...@webkit.org wrote: WebKitGTK+ supports OpenType natively and I as far as I know we have no problems dropping

Re: [webkit-dev] Port-specific OpenType support

2014-09-15 Thread Martin Robinson
On Mon, Sep 15, 2014 at 12:54 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: With this in mind, my original question should make more sense - are there any ports who want support for SVG fonts but whose platforms don’t support OpenType? It sounds like the GTK platform supports OTF, which

Re: [webkit-dev] Port-specific OpenType support

2014-09-11 Thread Martin Robinson
On Thu, Sep 11, 2014 at 11:44 AM, Myles C. Maxfield mmaxfi...@apple.com wrote: My question to WebKit-Dev is: Are there any ports who: 1) Want continued support for SVG fonts, and 2) Whose platforms do not support OpenType fonts natively? WebKitGTK+ supports OpenType natively and I as far as I

Re: [webkit-dev] Planning on Requiring Python 2.7 Soon

2014-09-11 Thread Martin Robinson
On Thu, Sep 11, 2014 at 11:36 AM, Brian Burg b...@cs.washington.edu wrote: IIRC, some GTK bots still run Python 2.6. (But not all of them?) Here’s a relevant workaround I landed a while ago: http://trac.webkit.org/changeset/172686 I think (someone can correct me, if I'm wrong) that we can

Re: [webkit-dev] accelerated 2d canvas removal

2014-06-24 Thread Martin Robinson
On Tue, Jun 24, 2014 at 12:13 PM, Alex Christensen achristen...@apple.com wrote: ACCELERATED_2D_CANVAS seems to be dead code. Is anyone using it, or does anyone have any reason to keep it in WebKit? For GTK+, it was possible to turn it on when compiling with a version of Cairo that supported

[webkit-dev] DynamicAnnotations

2014-04-17 Thread Martin Robinson
Is anyone using the DynamicAnnotations.h support for Valgrind and similar tools [1]? If they are unused, perhaps we should simply remove them [2], since DyanamicAnnotations.h is included in many files. 1. http://code.google.com/p/data-race-test/wiki/DynamicAnnotations 2.

Re: [webkit-dev] DynamicAnnotations

2014-04-17 Thread Martin Robinson
On Thu, Apr 17, 2014 at 9:05 AM, Martin Robinson mrobin...@webkit.org wrote: Is anyone using the DynamicAnnotations.h support for Valgrind and similar tools [1]? If they are unused, perhaps we should simply remove them [2], since DyanamicAnnotations.h is included in many files. It seems I

[webkit-dev] Moving the WebKit1 port of GTK+ to maintenance mode

2014-03-28 Thread Martin Robinson
After discussions on the WebKitGTK+ mailing list, the WebKitGTK+ community has decided to move the WebKit1 port of WebKitGTK+ to maintenance mode. Until the release of WebKit3, we plan to focus our efforts on the WebKit2 port of WebKitGTK+. In the upcoming weeks we will be turning off the buildbot

Re: [webkit-dev] CMake for WebKitGTK+

2014-03-25 Thread Martin Robinson
On Wed, Mar 5, 2014 at 7:30 PM, Martin Robinson mrobin...@webkit.org wrote: For a time, I kindly request that authors writing GTK+-specific patches consider both the autotools and CMake GTK+ builds in their patches. Hopefully within the next couple months, we can announce the complete removal

Re: [webkit-dev] CMake for WebKitGTK+

2014-03-25 Thread Martin Robinson
On Tue, Mar 25, 2014 at 10:57 AM, Filip Pizlo fpi...@apple.com wrote: Wow, that's awesome! Do you guys have any write-ups on what it took to do the transition? It might help us understand CMake better when/if we ever want to transition anything else to CMake. I plan to write a blog post in

Re: [webkit-dev] DerivedSources.make: Another try?

2014-03-16 Thread Martin Robinson
On Sat, Mar 15, 2014 at 11:46 PM, Darin Adler da...@apple.com wrote: Side question: With the recent GTK port developments, is it time to remove our automake files entirely? The agreement I have with Carlos Garcia Campos (our current release manager), is that I can remove the automake build

[webkit-dev] CMake for WebKitGTK+

2014-03-05 Thread Martin Robinson
Over the past year or so the WebKitGTK+ port has gradually grown a CMake build, in parallel to the existing autotools build. Our motivation for this work is to reduce the number of build systems in WebKit, escape some long-standing bugs in the autotools build, and to speed up build times. With

Re: [webkit-dev] WebGL backends

2014-02-10 Thread Martin Robinson
On Mon, Feb 10, 2014 at 9:16 AM, Brent Fulgham bfulg...@apple.com wrote: I’m pretty sure the GTK+ port uses OpenGL directly, but Martin Robinson can probably confirm that. The GTK+ port uses the OpenGL or OpenGLES GraphicsContext3D depending on the system it is compiled on and configuration

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Martin Robinson
On Tue, Jan 28, 2014 at 2:05 AM, Andrei Bucur abu...@adobe.com wrote: Do you happen to know if we still have ports that build WebKit without accelerated compositing? If not, I'd like to write a patch that removes the flag and makes AC mandatory. From IRC, I've heard that the Haiku port (not

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Martin Robinson
On Tue, Jan 28, 2014 at 10:00 AM, Anders Carlsson ander...@apple.com wrote: This begs the question: How widely used is the GTK+ port of WebKit on Windows? Do enough people use it that it's worth the maintenance burden for the other ports that use accelerated compositing? An example of a

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Martin Robinson
On Tue, Jan 28, 2014 at 10:58 AM, Anders Carlsson ander...@apple.com wrote: Since we don’t have any WebKitGTK+/Windows buildbots or EWS bots, I think Andrei should go ahead and remove the flag and then the GTK+ maintainers can fix WebKitGTK+ for Windows. Does that sound like a reasonable

Re: [webkit-dev] GTK+ EWS bot lagging behind

2014-01-27 Thread Martin Robinson
On Mon, Jan 27, 2014 at 5:55 PM, Anders Carlsson ander...@apple.com wrote: Hello, there are currently 93 patches in the GTK+ EWS patch queue, is it stuck? If it’s not, I think it’s completely unreasable to expect committers to wait for 93 patches to be processed before landing. (This lead

Re: [webkit-dev] Should we explicitly disallow indentation to align lines or add an example?

2014-01-21 Thread Martin Robinson
On Tue, Jan 21, 2014 at 5:13 PM, Ryosuke Niwa rn...@webkit.org wrote: I realize our style guideline DOES state the indentation must be done by 4 spaces but should we also explicitly prohibit using indentations for alignment? Correct: someFunction(someLongArgument,

Re: [webkit-dev] Guideline for nullptr

2014-01-06 Thread Martin Robinson
On Mon, Jan 6, 2014 at 1:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Sounds like a great idea to me. Seconding this. nullptr also has much better compatibility with varargs than 0. --Martin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Range based loops

2013-11-08 Thread Martin Robinson
On Fri, Nov 8, 2013 at 11:01 AM, Jon Lee jon...@apple.com wrote: Moving to MSVC 2013 is definitely the goal. My hope is we’ll be able to upgrade within the coming months. This is great news. I'm pretty excited about trying to move our spinlocks to std::atomic. --Martin

Re: [webkit-dev] You can force a clean build on build.webkit.org now

2013-11-01 Thread Martin Robinson
On Fri, Nov 1, 2013 at 2:57 PM, Ryosuke Niwa rn...@webkit.org wrote: I've added a Force clean build check box to the forced build field if you're logged in on build.webkit.org. It deletes the WebKitBuild directory by running Tools/BuildSlaveSupport/clean-build. Superfluous Platform.h and

Re: [webkit-dev] WTF::fastMalloc

2013-10-01 Thread Martin Robinson
On Mon, Sep 30, 2013 at 7:41 PM, Zoltan Horvath zol...@webkit.org wrote: Based on a 2.5-year-old measurement (http://webkit.sed.hu/blog/20100302/war-allocators-qtlaunchers-coast) on the Qt-port, the page loading on the Methanol test suite was 5% faster (avg) with TCmalloc than the default

Re: [webkit-dev] WTF::fastMalloc

2013-10-01 Thread Martin Robinson
On Tue, Oct 1, 2013 at 11:34 AM, Geoffrey Garen gga...@apple.com wrote: (4) Find a fast API for aligned virtual memory allocation. (5) Find a fast API for committing / decommitting physical memory without releasing virtual memory pages. Hrm. Isn't this already available via OSAllocator or

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-20 Thread Martin Robinson
On Mon, Aug 19, 2013 at 10:16 PM, Ryosuke Niwa rn...@webkit.org wrote: Are Qt and GTK+ (and other) ports intentionally returning false in shouldShowPlaceholderWhenFocused? Or is this just an oversight due to the fact the default implementation returned false? I just confirmed that the native

Re: [webkit-dev] Upcoming changes to WebKit's logging functionality

2013-08-03 Thread Martin Robinson
On Sat, Aug 3, 2013 at 1:39 AM, Mark Rowe mr...@apple.com wrote: For developers of other ports, the syntax used to enable logging channels may change for you. Some ports had been using a space-separated list of channel names rather than a comma-separated list. Please let me know if you feel

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Martin Robinson
On Thu, Jul 25, 2013 at 7:01 AM, Antonio Gomes toniki...@webkit.org wrote: Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there

Re: [webkit-dev] compact ICU unicode

2013-06-14 Thread Martin Robinson
On Fri, Jun 14, 2013 at 4:34 PM, Laszlo Gombos laszlo.gom...@gmail.com wrote: Qt port of WebKit trunk can only be built with Qt v5, which has a hard dependency on ICU. Older version of Qt and WebKit (v4.8) had an option to build with or without ICU. See [1] an [2] for more background

Re: [webkit-dev] OpenVG backend

2013-04-19 Thread Martin Robinson
On Tue, Apr 9, 2013 at 6:55 PM, Jeff Rogers jeffcrog...@gmail.com wrote: BlackBerry/RIM is no longer using the OpenVG backend and we are ok with removing it (we were the original contributors). Thanks for the reply. Patch posted here:https://bugs.webkit.org/show_bug.cgi?id=114881 --Martin

Re: [webkit-dev] Current status of threaded compositor for WebKit Gtk

2013-04-14 Thread Martin Robinson
On Sun, Apr 14, 2013 at 12:52 AM, Gwang-Yoon Hwang ryum...@company100.net wrote: Nice work! 1. There are 3 accelerated compositing methods in WebKit1 Gtk. Cairo, Clutter, and GL. These patches will adds 1 more options, threaded compositing. I think we need to simplify/unite rendering paths to

Re: [webkit-dev] Buildsystem cleanup

2013-04-10 Thread Martin Robinson
On Wed, Apr 10, 2013 at 3:30 PM, Roger Fong roger_f...@apple.com wrote: If my above concerns can be resolved and the example you posted works fine for us (I'll try to take a look at it soon), it's probably okay to start checking in stuff to get ready for the move to CMake. I don't think we

[webkit-dev] OpenVG backend

2013-04-09 Thread Martin Robinson
Is any upstream port maintaining and using the OpenVG backend? I don't see references to it in any build files. If we are going to remove the Skia backend, we should probably consider removing all unused graphics backends. --Martin ___ webkit-dev

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Martin Robinson
On Thu, Apr 4, 2013 at 10:34 AM, Geoffrey Garen gga...@apple.com wrote: What would it take for WebKitGTK+ to adopt the JSC bindings? Just for clarity's sake. WebKitGTK+ only supports JSC, but it seems there are some external branches/forks using V8. In the past, we've rejected proposals to add

Re: [webkit-dev] Compiling WebKit up to 25% faster in Windows?

2013-03-26 Thread Martin Robinson
On Tue, Mar 26, 2013 at 1:31 PM, Ryosuke Niwa rn...@webkit.org wrote: Another idea. What you copied all headers into one directory (in a pre compilation step) and used that as the single include directory? I don't dare chime in about full paths versus short paths, but I'd like to point out

Re: [webkit-dev] big .asc file for 1.10.2

2013-02-26 Thread Martin Robinson
On Tue, Feb 26, 2013 at 8:43 AM, jepusgf...@snkmail.com wrote: Why is the .asc file for webkit.org/releases/webkitgtk-1.10.2.tar.xz so big? ... webkitgtk-1.10.2.tar.xz 12-Dec-2012 18:01 8.2M webkitgtk-1.10.2.tar.xz.asc 12-Dec-2012 18:01 8.2M Thanks for reporting this. It

Re: [webkit-dev] Access WebKit Rendering pixel data

2013-02-18 Thread Martin Robinson
On Mon, Feb 18, 2013 at 9:57 AM, Arunprasad Rajkumar ararunpra...@gmail.com wrote: yes :). WebKit is not a library, so it don't have defined form of API exposed. The one who _uses_ WebCore(WebCore+WTF+JSC/V8) called as Embedders have some form of API, but again it is up-to them to expose the

Re: [webkit-dev] NetworkProcess / NetworkThread in the UIProcess

2013-02-12 Thread Martin Robinson
On Tue, Feb 12, 2013 at 12:09 PM, Brady Eidson beid...@apple.com wrote: We already support custom schemes on Mac by proxying the loading from the networking process to the UI process. I believe we do something like this for the libsoup port as well, though network process support is still

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Martin Robinson
On Mon, Feb 11, 2013 at 11:27 AM, Kevin Ollivier kev...@theolliviers.com wrote: The project is not dead per-se, but it's true that it's not very active these days. Recently, I haven't had a lot of time to devote to the port. The other big factor has been that I've been the only active

Re: [webkit-dev] Is the wxWidgets port maintained?

2013-02-11 Thread Martin Robinson
On Mon, Feb 11, 2013 at 1:41 PM, Kevin Ollivier kev...@theolliviers.com wrote: Actually, it will, if anything, increase the workload. Because I use waf, I am able to use Python to auto-generate the list of sources to build. In other words, I tell it to build all sources in a defined list of

Re: [webkit-dev] Gated trunk, experiences from OpenStack

2013-02-05 Thread Martin Robinson
On Tue, Feb 5, 2013 at 9:28 AM, Adam Barth aba...@webkit.org wrote: Do you know how they got rid of flakiness in their tests? We've spent a bunch of effort fixing flaky tests (and in marking the remaining flaky tests as flaky), but there's still a long tail of flakiness. I wonder if that

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Martin Robinson
On Tue, Feb 5, 2013 at 12:20 PM, Nico Weber tha...@chromium.org wrote: http://www.haskell.org/haskellwiki/Wadlers_Law I've started working on an experimental gyp build for GTK+, so I have first-hand experience as a gyp newbie editing .gyp and .gypi files. While the aesthetics of the files

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

2013-01-31 Thread Martin Robinson
On Thu, Jan 31, 2013 at 5:39 PM, Ryosuke Niwa rn...@webkit.org wrote: Doesn't GTK+ port also require symbol exports for WebKit2? In particular, I thought all symbols used in Internals need to be exported there. WebKitGTK+ does not need to export symbols from WebCore for WebKit2, because WebCore

Re: [webkit-dev] Chromium for Android upstreaming has been completed!

2012-11-06 Thread Martin Robinson
On Tue, Nov 6, 2012 at 9:56 AM, Peter Beverloo pe...@chromium.org wrote: Following Adam’s progress update on the Chromium-Android port in July[1], we’re happy to tell you that our upstreaming has been completed and that the Chromium-Android port is now fully supported. We’ve closed the master

Re: [webkit-dev] HbbTV support within Webkit

2012-10-08 Thread Martin Robinson
On Mon, Oct 8, 2012 at 7:11 AM, Mark Toller mark.tol...@samsung.com wrote: I know that support requests for CE-HTML have been briefly touched upon in the past. As I understand it, the main objection to providing support within WebKit is that the CE-HTML specification is not freely available,

[webkit-dev] Procedure for adding new blogs to the WebKit Planet

2012-08-02 Thread Martin Robinson
Hi all, What's the procedure for adding a blog to the WebKit Planet? I often post material interesting to some of the WebKit community, but not suitable for Surfin' Safari since it is often specific to WebKitGTK+ or to just a subset of ports. --Martin

Re: [webkit-dev] [webkit-changes] [119113] trunk/Source/WebKit/gtk

2012-05-31 Thread Martin Robinson
On Thu, May 31, 2012 at 1:46 PM, Adam Barth aba...@webkit.org wrote: +mrobinson Looks like the odd ChangeLog was in a patch uploaded by mrobinson: https://bugs.webkit.org/attachment.cgi?id=143171action=review Apologies. I'm unsure how this patch became corrupted. I've fixed the ChangeLog.

Re: [webkit-dev] Default viewport value on WAP DTDs

2012-05-05 Thread Martin Robinson
On Fri, May 4, 2012 at 2:32 PM, Ojan Vafai o...@chromium.org wrote: That said, we did all this testing in 2008. The web may have changed considerably since then. In either case, if your UA string diverges too much, I expect this problem will just be the tip of the iceberg of compatibility

[webkit-dev] Hosting the webkitgtk.org site on svn.webkit.org

2012-03-27 Thread Martin Robinson
Until this point, the webkitgtk.org page has maintained by an elite cadre of volunteers working outside the realm of svn.webkit.org. I feel that it could be quite valuable to host the page on svn.webkit.org, so that others can file bugs against the page and submit patches. This isn't an entirely

[webkit-dev] Ambiguity in the style guide

2012-03-19 Thread Martin Robinson
Hello WebKittens, While I am loathe to take up list space with another style guide threads, Eric Seidel recently pointed out to me some ambiguities in the style guide at https://bugs.webkit.org/show_bug.cgi?id=81602. Namely sections three and four of the #include Statements section. The relevant

Re: [webkit-dev] exporting symbols for building .so/.dll's

2012-03-10 Thread Martin Robinson
On Sat, Mar 10, 2012 at 4:34 PM, Alp Toker a...@nuanti.com wrote: If we follow this to the logical conclusion, no unification of granular export lists is realistic with the current WebKit porting layer. If the strategy were adapted to define exported functionality at class granularity, it

Re: [webkit-dev] WebKit modularization

2012-02-23 Thread Martin Robinson
On Thu, Feb 23, 2012 at 10:24 AM, Adam Barth aba...@webkit.org wrote: Currently, the plan is that there won't be any direct dependencies from WebCore into code in Modules, but code in Modules will be able to depend on anything in WebCore it likes.  We've added a couple abstract Observer

[webkit-dev] WebKitGTK+ 1.6.3 released

2012-02-01 Thread Martin Robinson
We are happy to announce the release of WebKitGTK+ 1.6.3. http://webkitgtk.org/webkit-1.6.3.tar.xz sha256sum: 12d0dbce6a895c7a8491a028e34a1dc55ae13ab76ac6202b2e489da9468077c3 md5sum: c476d9335419df061510d31e21175df1 You may also access the stable branch directly from the SVN repository:

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-17 Thread Martin Robinson
On Mon, Jan 16, 2012 at 5:00 PM, Gyuyoung Kim gyuyoung@samsung.com wrote: Hello Antonio, Ok, I'm going to update the test results for EFL port as GTK port's way. As far as I know, you shouldn't need to rebaseline anything unless you take a similar approach to what we did in r99147. This

Re: [webkit-dev] [gtk] OpenGL headers are not listed as a dependency

2011-12-02 Thread Martin Robinson
On Fri, Dec 2, 2011 at 12:45 AM, John Yani van...@gmail.com wrote: Got it working by installing these packages: libgl1-mesa-glx libgl1-mesa-dev Probably, It should've been written in the instruction. Thanks for bringing this to my attention. This is a fairly recent requirement. I have

Re: [webkit-dev] new-run-webkit-tests --gtk fails with AttributeError: GtkDriver instance has no attribute '_server_process'

2011-11-07 Thread Martin Robinson
On Mon, Nov 7, 2011 at 3:54 PM, Vanya Yani van...@gmail.com wrote: I'm trying to run NRWT for gtk build revision 99472. But script fails with exceptions: AttributeError: GtkDriver instance has no attribute '_server_process' worker/0 raised OSError('[Errno 2] No such file or directory'):

Re: [webkit-dev] use binary webkit

2011-10-24 Thread Martin Robinson
On Sun, Oct 23, 2011 at 8:58 AM, Eric Seidel e...@webkit.org wrote: I'm told there is a Win-Cairo port of WebKit: http://trac.webkit.org/wiki/BuildingCairoOnWindows but I don't know how well it works. The WinCairo port is always improving. It has a buildbot which even runs tests now. In my

Re: [webkit-dev] Regarding OPENVG for GTK Build....

2011-10-18 Thread Martin Robinson
On Tue, Oct 18, 2011 at 2:11 PM, Julien Chaffraix julien.chaffr...@gmail.com wrote: I am trying to build OPENVG for GTK port. You should know that the OpenVG back-end is not fully upstreamed in WebKit and has lacked some maintenance lately so don't expect an easy build. More here [1] (which

Re: [webkit-dev] Pixel testing and WebKit2

2011-10-11 Thread Martin Robinson
On Tue, Oct 11, 2011 at 3:24 PM, Simon Fraser simon.fra...@apple.com wrote: After various fixes, pixel tests now work reasonably well in WebKitTestRunning (i.e. when running with WebKit2). Do any of these fixes apply to other platforms as well? I'd like to have GTK+ pixel tests matching

Re: [webkit-dev] Please use platform prefixes in bug titles

2011-10-05 Thread Martin Robinson
On Wed, Oct 5, 2011 at 6:09 PM, David Levin le...@chromium.org wrote: btw, I'm not planning to work on this for now but would be happy to give advice if someone took it up. A queryable mapping of which source directories and files apply to which ports could be quite useful indeed. --Martin

Re: [webkit-dev] cookie implementation

2011-08-15 Thread Martin Robinson
On Mon, Aug 15, 2011 at 12:43 PM, Moumita Banerjee mouban1...@gmail.com wrote: I want to implement cookie in cairo port webkit. But I am unbale to do this. Please help me. I don’t understant which class is responceble to get and set the cookie. Please help me. You didn't mention, exactly what

[webkit-dev] Committer Nomations: Amruth Raj and Ravi Phaneendra Kasibhatla

2011-08-02 Thread Martin Robinson
I'd like to nominate both Amruth Raj and Ravi Phaneendra Kasibhatla as WebKit committers. Amruth and Ravi worked together to create the foundation of the GTK+ WebKit 2 port. Ravi Phaneendra Kasibhatla has 13 commits (of which 11 are shared commits between himself and Amruth), while Amruth has 15

Re: [webkit-dev] Committer Nomations: Amruth Raj and Ravi Phaneendra Kasibhatla

2011-08-02 Thread Martin Robinson
On Wed, Aug 3, 2011 at 12:22 AM, Martin Robinson mrobin...@webkit.org wrote: I'd like to nominate both Amruth Raj and Ravi Phaneendra Kasibhatla as WebKit committers. Amruth and Ravi worked together to create the foundation of the GTK+ WebKit 2 port. Ravi Phaneendra Kasibhatla has 13 commits

Re: [webkit-dev] LayoutTests results fallback graph

2011-07-11 Thread Martin Robinson
On Mon, Jul 11, 2011 at 1:34 PM, Leandro Pereira lean...@profusion.mobi wrote: I like this idea, in general. However, since some ports (GTK+ and EFL, for instance) shares the same backends (Cairo, FontConfig, Pango, etc.), pixel tests are often the same. It's been my experience that pixel

Re: [webkit-dev] [Webkit GTK][Windows] Plug-ins fails to load

2011-06-28 Thread Martin Robinson
On Mon, Jun 27, 2011 at 9:42 PM, dipak kumar mail.di...@gmail.com wrote: I have configured Webkit GTK port on Win32. Apart from that I have created some NPAPI architecture based plug-in to implement my own functionality. I have created DLL's and keeping them on the standard MOZ_PLUGIN_PATH

Re: [webkit-dev] Compiling SVG lighting filters for ARM NEON

2011-06-17 Thread Martin Robinson
On Fri, Jun 17, 2011 at 5:04 AM, itisravi cybera...@gmail.com wrote: Hello, 1.Could someone give inputs on what specific project files are to be modified in a webkit-gtk build if I add new sources to the tree? 2.I was trying to build the FELighting Filters for NEON; the build fails with the

Re: [webkit-dev] Rounding issues on different platforms

2011-06-07 Thread Martin Robinson
On Tue, Jun 7, 2011 at 9:33 AM, Evan Martin e...@chromium.org wrote: On Tue, Jun 7, 2011 at 5:34 AM, Zoltan Herczeg zherc...@inf.u-szeged.hu wrote: If you maintain some bots, and you saw rounding issues which makes 1px difference on let's say 32 and 64 bit environments for several layout

[webkit-dev] WebKitGTK+ Lucid PPA now available

2011-05-31 Thread Martin Robinson
Hello fellow WebKittens, Recently many non-WebKitGTK+ developers have been kind enough to debug failures that only show up on WebKitGTK+. Since WebKitGTK+ typically tracks bleeding-edge GNOME, compiling can be a daunting task for those not up on the latest GNOME releases. In particular, some of

Re: [webkit-dev] Unifying the build systems

2011-05-12 Thread Martin Robinson
On Wed, May 11, 2011 at 9:31 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: This implementation still lacks some parts (these are the biggest ones I remember from top of my head, there might be others): - There's no option to enable WebKit2, webgl and webaudio; - It always uses GTK2

Re: [webkit-dev] Windowless X based plugin and its support in WebKit and WebKit2 (GTK+ port)

2011-05-06 Thread Martin Robinson
On Fri, May 6, 2011 at 4:43 AM, Aneesh Bhasin contact.ane...@gmail.com wrote: Could someone please have a look and let me know if there is something in the plugin that is wrong, or is there an issue in WebKit/GTK+ port with respect to window-less plugins ? I tried looking at bugzilla but could

Re: [webkit-dev] Plugin layout tests in WebKit2-Gtk port

2011-05-03 Thread Martin Robinson
On Mon, May 2, 2011 at 9:39 PM, naren.me...@gmail.com wrote: So, I am facing a roadblock now. Is there any other way to run those layout tests on wekbkit2-gtk ?? Can I use the available patch in the above listed bug report ?? While waiting for my patch to finish the review process, feel free

Re: [webkit-dev] Is there any introduction to the blur algorithm used in ContextShadow::blurLayerImage

2011-05-02 Thread Martin Robinson
On Mon, May 2, 2011 at 6:54 PM, Chengwei Wu meegodeve...@gmail.com wrote:     As the title says. Anyone can help me? Ariya Hidayat originally wrote this code. He wrote a blog post about it here: http://ariya.blogspot.com/2010/09/art-of-blurring-shadow.html It does three successive box blurs to

Re: [webkit-dev] Text display procedure in Webkit GtK

2011-04-11 Thread Martin Robinson
On Mon, Apr 11, 2011 at 10:13 AM, Soheil Servati Beiragh sserv...@yahoo.com wrote: I'm working on the WebKit and Text placement. I did lots of back trace on webkit in Gtk to find out where actually does the webkit gives the string of text to the text handler like cairo to show it. Can you

Re: [webkit-dev] Progress

2011-04-01 Thread Martin Robinson
on the bots. Igalia has a rotation of people keeping the tree green as well. Here's the current list if you're curious who you should poke about GTK+ redness: Monday: Alejandro Garcia Castro (alexg) Tuesday: Mario Sanchez Prada (msanchez) Wednesday: Martin Robinson (mrobinson) Thursday: Philippe

Re: [webkit-dev] XHTMLMP support

2011-03-07 Thread Martin Robinson
On Mon, Mar 7, 2011 at 12:46 PM, Alexey Proskuryakov a...@webkit.org wrote: Given that a build fix for XHTMLMP has been landed four days ago http://trac.webkit.org/changeset/80246, it seems clear that it's used and supported. Just for some context, I landed the fix because someone reported

Re: [webkit-dev] process for unreviewed commits

2011-03-04 Thread Martin Robinson
On Thu, Mar 3, 2011 at 11:58 PM, Ojan Vafai o...@chromium.org wrote: This isn't a big deal either way, but I noticed that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit lists the following as the process for unreviewed commits: Unreviewed commits should include a

Re: [webkit-dev] [webkit-help] Need help in running build webkit with GTK in ubuntu

2011-02-17 Thread Martin Robinson
2011/2/17 Osztrogonac Csaba o...@inf.u-szeged.hu: Ubuntu 10.10 has libglib2.0-dev version 2.26.0, but you need version = 2.27.90 for building WebKitGTK+ . Ubuntu 11.04 has 2.28 libglib2.0. Or you have to build a newer version from source. Probably you have to install newer libsoup too.

[webkit-dev] GTK+ release bots are missing results

2010-12-01 Thread Martin Robinson
For some weeks now the GTK+ release bots have been missing results. When you try to click on any result in results.html, there's an error page. I'm not sure what the issue is, but the results upload output looks quite sane: http://build.webkit.org/builders/GTK Linux 32-bit

Re: [webkit-dev] GTK+ release bots are missing results

2010-12-01 Thread Martin Robinson
On Wed, Dec 1, 2010 at 7:19 PM, William Siegrist wsiegr...@apple.com wrote: On Dec 1, 2010, at 10:04 AM, Gustavo Noronha Silva wrote: Damn, yeah, I made the change but I was not aware the configuration files were actually handled by a centralized configuration system that later restored the

Re: [webkit-dev] Gtk EWS

2010-11-17 Thread Martin Robinson
On Wed, Nov 17, 2010 at 10:14 PM, Eric Seidel e...@webkit.org wrote: Seems very broken: http://queues.webkit.org/results/6184043 Could someone fix build-webkit or whatever piece is looking for the missing Makefile? I believe that my patch at https://bugs.webkit.org/show_bug.cgi?id=49400 may

[webkit-dev] Tests that fail across different architectures

2010-10-08 Thread Martin Robinson
The GTK+ port runs layout tests on both a x86_64 and i386 operating system installations. We have a growing list of tests that generate different expected results between achitectures. These are almost all SVG tests. Last night tests were added that even have different results between our debug

Re: [webkit-dev] Tests that fail across different architectures

2010-10-08 Thread Martin Robinson
On Fri, Oct 8, 2010 at 9:21 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: we just switched over to a platform independant way to dump circles, rect, ellipses etc. Paths are prepared, but the switch is not fully done yet. I'm working on a patch, that rounds the results for each

Re: [webkit-dev] Rationale for PlatformRefPtr?

2010-09-30 Thread Martin Robinson
On Thu, Sep 30, 2010 at 4:53 PM, Martin Robinson martin.james.robin...@gmail.com wrote: On Thu, Sep 30, 2010 at 3:20 PM, Darin Adler da...@apple.com wrote: For example, for Core Foundation and Cocoa we made RetainPtr. For JavaScript we made JSRetainPtr. For GTK I think we should have GTKRefPtr

Re: [webkit-dev] Rationale for PlatformRefPtr?

2010-09-30 Thread Martin Robinson
On Thu, Sep 30, 2010 at 5:02 PM, Darin Adler da...@apple.com wrote: But couldn’t someone get into a situation where they want to use GObject and Cairo reference counted types in the same port? This is the situation with the GTK+ port now. The GTK+ port simply adds template specializations for

Re: [webkit-dev] Rationale for PlatformRefPtr?

2010-09-30 Thread Martin Robinson
On Thu, Sep 30, 2010 at 5:46 PM, Darin Adler da...@apple.com wrote: If we can collapse multiple smart pointer types based on overloading, I think that’s great. In those cases, I think it’s OK to have a single RefPtr class that can handle multiple types as long as we can come up with a good

Re: [webkit-dev] Request to add Build Bot

2010-09-24 Thread Martin Robinson
On Fri, Sep 24, 2010 at 8:50 AM, Brent Fulgham bfulg...@gmail.com wrote: I've finally gotten a system setup and configured to run as a build bot for the WinCairo port.  Per the instructions in the wiki, I've filed a bug (https://bugs.webkit.org/show_bug.cgi?id=46360) to add the configuration

Re: [webkit-dev] Making GRefPtr more general

2010-08-25 Thread Martin Robinson
On Tue, Aug 24, 2010 at 5:31 PM, Darin Adler da...@apple.com wrote: If overloading can be used to determine how to do the take a ref and release a ref functions, then many different subsystems can share a single PassRefPtr/RefPtr class. One complication in the GObject case, is that the

[webkit-dev] Making GRefPtr more general

2010-08-23 Thread Martin Robinson
Recently there was a need to make the smart pointer wrapping GLib reference-counted types more general. In this case it was to extend it to Cairo. Here is the bug for that: https://bugs.webkit.org/show_bug.cgi?id=44354 It struck me that the name GRefPtr wasn't very applicable to this type any

Re: [webkit-dev] Canvas performance and memory usage

2010-08-10 Thread Martin Robinson
Anyway I'm open to suggestions here. :) I came to very similar conclusions that you did and posted a WIP patch here: https://bugs.webkit.org/show_bug.cgi?id=43507 . I'm not sure if it is ready or good, but in particular removing the caching behavior for ::image() led to a lot of unexpected

Re: [webkit-dev] Canvas performance and memory usage

2010-08-04 Thread Martin Robinson
On Wed, Aug 4, 2010 at 3:23 PM, Christophe Public christophe.pub...@gmail.com wrote: Thanks for the clarification. If this is the main reason, then it seems a valuable optimization to do. Here's the bug for this issue: https://bugs.webkit.org/show_bug.cgi?id=43507

  1   2   >