[webkit-dev] Table layout does not clear setNeedsLayout flag for rows?

2014-03-13 Thread Mayur K
Hi,

I am checking the layout and rendering of the table element in webkit.
In the process I figured out that the link of renderers is as follows:
RenderTable has RenderTableSection has RenderTableRow has
RenderTableCell
The layout of the table rows is done in RenderTableSection::layoutRows.
I did not see any code to specifically set
RenderTableRow::setNeedsLayout(false) at the end of the function.
While there is a call to RenderTableCell::layout , which will then clear
the layout flag for RenderTableCell.
So is a RenderTableRow::setNeedsLayout(false) needed at the end of the
layout of each row in RenderTableSection::layoutRows?
If not then where is the RenderTableRow layout flag cleared?

Regards,
Mayur Kankanwadi.

-- 
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Getting compilation errors even after INSPECTOR has been disabled!!

2012-09-27 Thread Mayur K
Hi,
I am getting the following compilation errors while building WebCore

c1xx : fatal error C1083: Cannot open source file:
'..\..\..\..\output\Debug\obj\WebCore\DerivedSources\InspectorFrontend.cpp':
No such file or directory

I have disabled INSPECTOR flag in wtf/platform.h , but am still
getting these errors.
It's the windows port of Apple webkit and being built in VS2008
express edition on VISTA x64.
Any hints to get rid of them?

--
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JSGlobalData GC collection thread lifetime if webview is recreated without application exit.

2012-05-25 Thread Mayur K
Hi All,
Thanks for the reply Geoff.
I am currently facing an issue where in after deleting the webview, but not
exiting the application, after some time the javascript gc thread is seg
faulting. The breakpoints that I have added are also not hitting. So I
think that gc thread is still active even though webview has been deleted.
Are my assumptions correct regarding the js gc thread?
One more query is that JSDOMWindowBase::commonJSGlobalData is a static
object. Again I do not see any one clearing it on webview deletion. Is this
correct behavior?
Thanks.
--Mayur.

On Wed, May 23, 2012 at 12:23 PM, Geoffrey Garen gga...@apple.com wrote:

 So now to my question : Is it required to delete JSGlobalData and kill the
 GC thread if we keep on re-creating the webview again and again without
 exiting the process?


 No.

 Geoff




-- 
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] JSGlobalData GC collection thread lifetime if webview is recreated without application exit.

2012-05-23 Thread Mayur K
Hi All,
I have been studying the JS execution and noticed that the JSGlobalData is
stored in a static variable and never deleted.
I traced even the windows port and noticed one more thing, that the
JSGlobalData and the Heap class destructor are never called. As it is
static I assume that the JSGlobalData is cleaned up automatically on
process exit.
I realised that this would in turn have an effect if we delete the webview
and recreate it again. The JSGlobalData will still point to the old static
var.

So now to my question : Is it required to delete JSGlobalData and kill the
GC thread if we keep on re-creating the webview again and again without
exiting the process?

Thanks.
--Mayur.

-- 
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] How to specify the window size in DumpRenderTree?

2012-02-24 Thread Mayur K
Hi,
I want to specify the window size/view size in DumpRenderTree, so that
rendertree, can reflect the structure according to the new window size.
Is there an existing option/method to do so?
Thanks in advance.
--Mayur Kankanwadi.

-- 
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to specify the window size in DumpRenderTree?

2012-02-24 Thread Mayur K
Well, that would be too limiting.Passing the window size as a command line
option would be better, to get know the content behavior and would avoid
adding the resizeTo to every content. Also adding resizeTo would not be an
option to live content.
I tried playing around with the windows port of DumpRenderTree. But could
not figure out the way to provide the window size to affect the rendertree,
it was taking the default values of 800 X 600 always.
--Mayur.

On Sat, Feb 25, 2012 at 12:06 AM, Tony Chang t...@chromium.org wrote:

 In your test case, you should be able to use window.resizeTo to change the
 size of the window.

 On Fri, Feb 24, 2012 at 5:01 AM, Mayur K emineme...@gmail.com wrote:

 Hi,
 I want to specify the window size/view size in DumpRenderTree, so that
 rendertree, can reflect the structure according to the new window size.
 Is there an existing option/method to do so?
 Thanks in advance.
 --Mayur Kankanwadi.

 --
 Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev





-- 
Symbiangeek,Codekata  Webkitwiki all in one - http://flaminghorns.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev