Re: [webkit-dev] WebKit Documentation

2022-09-21 Thread Michael Catanzaro via webkit-dev
On Tue, Sep 20 2022 at 08:03:12 PM -0700, Ryosuke Niwa via webkit-dev wrote: (2) is particularly important because many people who are new to WebKit often don’t know what they don’t know. This is why, for example, memory management section appears towards the beginning of the document and the

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Michael Catanzaro via webkit-dev
On Tue, Sep 20 2022 at 01:16:53 AM -0700, Ryosuke Niwa via webkit-dev wrote: I’ve been working on https://github.com/WebKit/WebKit/blob/main/Introduction.md for the past couple of years, and I’d would have preferred to have a collaboration rather than a competition here. This

Re: [webkit-dev] WebKit Documentation

2022-09-19 Thread Michael Catanzaro via webkit-dev
Why not double-down on the GitHub wiki? It's very easy to learn to use, and there are edit buttons everywhere so there is no "distance" between the docs and the ability to edit them. The easier it is to edit docs, the better we'll do at keeping them up to date. I like Markdown, and am OK

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-08 Thread Michael Catanzaro via webkit-dev
On Thu, Sep 8 2022 at 03:00:00 PM +0300, Adrian Perez de Castro wrote: My laptop has 20 GiB of memory and a debug build in non-unified mode links just fine with either LLD or Mold (I haven't used the GNU linker for months). Something smells fishy with your setup. I haven't changed the

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-07 Thread Michael Catanzaro via webkit-dev
At this point I would just go ahead and create the EWS bot. Even if it's not going to be a default build configuration, we're still wasting a bunch of time and effort to keep it working, and the EWS would help fix that. ___ webkit-dev mailing

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-07 Thread Michael Catanzaro via webkit-dev
On Sat, May 21 2022 at 09:43:06 AM -0500, Michael Catanzaro wrote: I would go even further and consider enabling unified builds only in DEVELOPER_MODE (for CMake ports). For non-developer builds, compilation time is much less important than limiting RAM usage to reasonable levels. Using

Re: [webkit-dev] InjectedBundle deprecation

2022-08-12 Thread Michael Catanzaro via webkit-dev
That sounds like the ideal way to handle this. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] InjectedBundle deprecation

2022-08-12 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 12 2022 at 01:40:02 PM -0700, Alex Christensen via webkit-dev wrote: Would the maintainers of the GTK and WPE APIs be willing to assist in migrating from those APIs and designing replacements in the UI process? Sigh... we'll need to discuss what to do. Unfortunately, these are

[webkit-dev] Move CODEOWNERS file?

2022-07-07 Thread Michael Catanzaro via webkit-dev
Hi devs, any opinions on moving CODEOWNERS from its current location, .github/CODEOWNERS, up one level to the root directory? This will make it easier to see and hopefully encourage more use and updates. The more accurate and comprehensive this file, the easier it will be to get our pull

Re: [webkit-dev] WebKit is now on GitHub

2022-06-23 Thread Michael Catanzaro via webkit-dev
On Thu, Jun 23 2022 at 03:21:59 PM -0700, Jonathan Bedard wrote: I’m aware of the WebKitGTK branches, please reach out about the WPE ones, I’m not sure which ones those are. The WPE releases actually use the WebKitGTK branches! They are shared branches. I suppose that is pretty confusing,

Re: [webkit-dev] WebKit is now on GitHub

2022-06-23 Thread Michael Catanzaro via webkit-dev
On Thu, Jun 23 2022 at 10:29:55 AM -0700, Jonathan Bedard via webkit-dev wrote: Let me know if there is any fallout, As far as I know, WebKitGTK and WPE WebKit stable branches have not yet been migrated and are now read-only? Let's make sure not to delete SVN until we're certain they have

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Michael Catanzaro via webkit-dev
On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev wrote: I am concerned by this proposal given how slow EWS and the merge queue are these days. Hopefully Jonathan's three proposed blockers will address this: - run-webkit-tests consulting results.webkit.org to avoid

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-01 Thread Michael Catanzaro via webkit-dev
On Sat, May 21 2022 at 09:43:06 AM -0500, Michael Catanzaro wrote: I would go even further and consider enabling unified builds only in DEVELOPER_MODE (for CMake ports). For non-developer builds, compilation time is much less important than limiting RAM usage to reasonable levels. Using

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-05-21 Thread Michael Catanzaro via webkit-dev
On Sat, May 21 2022 at 07:10:30 AM +, "Kirsling, Ross via webkit-dev" wrote: This is wonderful news—thanks Diego! Agreed. I would go even further and consider enabling unified builds only in DEVELOPER_MODE (for CMake ports). For non-developer builds, compilation time is much less

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Michael Catanzaro via webkit-dev
On Wed, May 11 2022 at 12:16:46 AM -0700, Ryosuke Niwa via webkit-dev wrote: No, I'm using Github clones to write patches then using Subversion checkout to commit those patches. If you use the old git repo via git-svn, not the GitHub repo, then you can use 'git svn dcommit'.

Re: [webkit-dev] accounts.google.com is blocking WebKitGTK

2022-05-04 Thread Michael Catanzaro via webkit-dev
Thanks very much Ken! ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] accounts.google.com is blocking WebKitGTK

2022-05-03 Thread Michael Catanzaro via webkit-dev
Hi, see: https://bugs.webkit.org/show_bug.cgi?id=240041 It is a little finicky, in that it *sometimes* works, and I don't know why. But usually Google blocks us. See screenshot: https://bugs.webkit.org/attachment.cgi?id=458768 I was hoping that it could be avoided by a user agent quirk, but

Re: [webkit-dev] JSC broken on s390x

2022-04-19 Thread Michael Catanzaro via webkit-dev
On Tue, Apr 19 2022 at 11:42:31 AM -0700, Yusuke Suzuki wrote: Do you have a s390x machine which can be accessible to JSC developers? Nope. :( I think, probably, only someone having this machine access can fix the problem. I agree. I've raised this as an issue. Anyway, we did manage to

[webkit-dev] JSC broken on s390x

2022-04-19 Thread Michael Catanzaro via webkit-dev
Hi, I want to call attention to: https://bugs.webkit.org/show_bug.cgi?id=238956 It breaks JSC on s390x. If anybody is interested in this architecture, or cares about WebKitGTK updates in Fedora (this issue will be a blocker), any help would be much appreciated. :) I've also informed Red

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-18 Thread Michael Catanzaro via webkit-dev
On Mon, Apr 18 2022 at 02:55:08 PM -0700, Yusuke Suzuki wrote: I think this is important. We are using commit message / ChangeLog as a document tied to the change, and we are writing very detailed description to make the intention / design of the change clear and making it as a good

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-18 Thread Michael Catanzaro via webkit-dev
On Mon, Apr 18 2022 at 08:30:04 AM -0700, Jonathan Bedard via webkit-dev wrote: 2) We need a way to comment on commit messages in review Current tooling sets the pull request description as the commit message, “Quote Reply” kind of provides a way to inline comment, although it’s not the

Re: [webkit-dev] WebKit and GitHub Update

2022-04-12 Thread Michael Catanzaro via webkit-dev
I guess I should create a feedback issue: https://bugs.webkit.org/show_bug.cgi?id=239124 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebKit and GitHub Update

2022-04-12 Thread Michael Catanzaro via webkit-dev
On Mon, Apr 11 2022 at 03:55:36 PM -0700, Jonathan Bedard via webkit-dev wrote: start creating some pull requests! Hi, For pull requests to find interested reviewers, we need a way to subscribe to labels. E.g. I want to receive notifications for pull requests with a WebKitGTK or WPE label.

Re: [webkit-dev] Proposal to update WebKitGTK dependency policy

2022-03-08 Thread Michael Catanzaro via webkit-dev
On Tue, Mar 8 2022 at 03:01:04 PM +0100, Carlos Alberto Lopez Perez wrote: It turns out this above opinion of mine doesn't reflect a consensus opinion inside Igalia. After sending the above e-mail, I talked with my colleagues at Igalia (my failure for not doing that before) and it seems that

Re: [webkit-dev] Proposal to update WebKitGTK dependency policy

2022-02-28 Thread Michael Catanzaro via webkit-dev
On Thu, Feb 17 2022 at 01:20:50 PM -0600, Michael Catanzaro via webkit-dev wrote: That seems like a reasonable request. I'll delay modifying the policy until I'm able to provide an answer regarding the requested bots. This could take a while, so the proposed policy change is dead for now

Re: [webkit-dev] Proposal to update WebKitGTK dependency policy

2022-02-17 Thread Michael Catanzaro via webkit-dev
On Thu, Feb 17 2022 at 05:41:34 PM +, Carlos Alberto Lopez Perez via webkit-dev wrote: If I understand this correctly, that would mean that we would have to support the libraries that we rely on, up to a version that may be quite old. Right now we are supporting a cycle of 2+1=3

Re: [webkit-dev] Proposal to update WebKitGTK dependency policy

2022-02-17 Thread Michael Catanzaro via webkit-dev
Hi, Since nobody objected to this proposal, I will update our policy soon. Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] How to make changes to website?

2022-02-16 Thread Michael Catanzaro via webkit-dev
On Wed, Feb 16 2022 at 02:05:40 PM -0800, Chris Dumez wrote: Jon Davis is probably the right contact for Webkit.org. Um... yeah, of course he is. I knew this. Brain fart, sorry. My suggested change is to add a warning sentence to the

[webkit-dev] How to make changes to website?

2022-02-16 Thread Michael Catanzaro via webkit-dev
Hi, I want to make a modification to: https://webkit.org/contributing-code/ Suggested here: https://bugs.webkit.org/show_bug.cgi?id=232935#c6 It looks like this page is not part of WebKit/Websites/webkit.org. Anyone know who can edit it? Michael

Re: [webkit-dev] Proposed changes to Bugzilla 'Resolution' categories

2022-02-10 Thread Michael Catanzaro via webkit-dev
On Thu, Feb 10 2022 at 11:55:56 AM -0800, Brent Fulgham via webkit-dev wrote: (1) Add a new “Behaves As Designed” option: This will represent bugs that were filed when the reporter misunderstands a feature, or wants behavior that we have considered, but chosen not to allow. This would be

[webkit-dev] Proposal to update WebKitGTK dependency policy

2022-02-08 Thread Michael Catanzaro via webkit-dev
Hi, I'd like to selfishly propose updating our dependencies policy https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy in order to accommodate RHEL in addition to Debian and Ubuntu. My goal is to provide WebKitGTK updates for the first five years (the "full support" period) of a RHEL

Re: [webkit-dev] Request for position: Cookie Expires/Max-Age attribute upper limit

2022-01-19 Thread Michael Catanzaro via webkit-dev
On Wed, Jan 19 2022 at 08:12:07 AM -0800, Ari Chivukula via webkit-dev wrote: The limit MUST NOT be greater than 400 days (3456 seconds) in duration. I don't see any super great reason to prevent browsers from choosing a larger max age if desired. That said, 400 days sounds like a good

Re: [webkit-dev] [PSA] WebKitGTK layout testers available on the Bugzilla EWS bubbles

2021-12-24 Thread Michael Catanzaro via webkit-dev
On Fri, Dec 24 2021 at 12:44:49 AM +, Carlos Alberto Lopez Perez via webkit-dev wrote: So we ended deploying a different version of the EWS that has a much higher tolerance to pre-existent failures (up to 500 before exiting early) and also that tries hard to discard pre-existent failures

Re: [webkit-dev] WebKit Objective-C++ style, pointer and reference placement

2021-12-21 Thread Michael Catanzaro via webkit-dev
On Tue, Dec 21 2021 at 02:08:42 PM +0200, Kimmo Kinnunen via webkit-dev wrote: * All C and Objective-C code should be formatted with rules consistent to the C++ rules Unfortunately all of the WPE/GTK C code intentionally uses a space between the type and the asterisk * (for example,

Re: [webkit-dev] Review request time limit

2021-11-01 Thread Michael Catanzaro via webkit-dev
On Mon, Nov 1 2021 at 01:30:28 PM -0700, Alex Christensen via webkit-dev wrote: I just removed r? on all the bugs in http://webkit.org/pending-review that had requested review in 2018 or before and had been untouched since then. I imagine that did not interrupt anyone’s work. I was thinking

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-29 Thread Michael Catanzaro via webkit-dev
On Fri, Oct 29 2021 at 03:06:17 PM -0700, Myles Maxfield wrote: Will GTK/WPE EWS catch these errors? Currently no, but they will once we solve https://bugs.webkit.org/show_bug.cgi?id=155047. ___ webkit-dev mailing list

Re: [webkit-dev] Proposal to enable logging under non-systemd linux distros

2021-10-19 Thread Michael Catanzaro via webkit-dev
On Wed, Oct 20 2021 at 02:07:56 AM +0200, Pablo Correa Gomez via webkit-dev wrote: - Rename USE_SYSTEMD to USE_JOURNALD and have a conditional check which looks for elogind if libsystemd is not found, similar to the hack I used for proof-testing. This one! Do this one! We don't need two

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-19 Thread Michael Catanzaro via webkit-dev
On Tue, Oct 19 2021 at 01:43:19 PM -0700, Ryosuke Niwa wrote: Can we add a style checker rule to detect at least simple cases? I think detecting this pattern without false positives would be pretty tough. Requires too much knowledge of the semantics of the code. Michael

[webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-19 Thread Michael Catanzaro via webkit-dev
Hi devs, A reminder about this common idiom: switch (...) { case Foo: return ...; case Bar: return ...; } RELEASE_ASSERT_NOT_REACHED(); When it's intended that the code always returns inside the switch statement, the RELEASE_ASSERT_NOT_REACHED() is required to avoid tripping GCC's

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Michael Catanzaro via webkit-dev
OK, so you are using the existing OS-level network interface settings. At least on Linux, that is a heuristic-based per-interface setting with a manual override. None of this happens without the user voluntarily revealing the information. How would that possibly work? A new type of

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Michael Catanzaro via webkit-dev
On Mon, Aug 30 2021 at 10:16:54 AM +0200, Thomas Steiner via webkit-dev wrote: Thanks for the reply, Ryosuke! Just to clarify, the `metered` attribute would be a manual user setting, not a browser heuristic. This means you could easily mark your all-data included WiFi at home as metered if

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-20 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 20 2021 at 06:30:16 PM -0600, Alemar wrote: Okay that makes sense. How do I install debuginfo for webkit though? Looking into apt, all I can find is this: Hi, there are distro-specific instructions here:

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-20 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 20 2021 at 11:27:17 AM -0600, Alemar wrote: #2 0x7fcfd172ff2b in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37 #3 0x7fcfd37e0622 in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37 #4 0x7fcfd37efef6 in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-14 Thread Michael Catanzaro via webkit-dev
Hi, you need to get a backtrace with gdb. There are some instructions here: https://wiki.gnome.org/GettingInTouch/Bugzilla/GettingTraces Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Position on font-family: emoji (and -webkit-pictograph)

2021-08-13 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 13 2021 at 01:54:39 PM +0200, Frédéric Wang via webkit-dev wrote: I understand there is backward compat concerns about removing features but do we agree to add "emoji" as an alias for "-webkit-pictograph", similar to what we did in [3] for "system-ui"? This sounds pretty

Re: [webkit-dev] Removing the ENABLE(CSS_SCROLL_SNAP) flag

2021-06-15 Thread Michael Catanzaro via webkit-dev
Hi Martin! My $0.02: when all ports have the feature enabled and the code is cross-platform, it's usually best to remove the build flag unless there's a particular strong reason to keep it around. We have more than enough build flags, and if you get to delete old code that just makes it

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Tue, May 25 2021 at 06:22:41 AM -0500, Michael Catanzaro via webkit-dev wrote: I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will probably be a few, though, which could be caused by (a) EWS using non-default build options

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 07:36:03 PM -0700, Darin Adler via webkit-dev wrote: I do not know why we do not already use -Werror on GTK and WPE and I support using it there after fixing all the warnings. I'd be willing to enable it at the CMake level if it was conditional on

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 06:32:03 PM -0700, Darin Adler via webkit-dev wrote: But we can’t just turn on -Werror until after we fix all the warnings! Who will do that project. I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 05:42:37 PM -0500, Michael Catanzaro wrote: But really, rather than cherry-picking particular warning flags, using -Werror seems simplest to me. Problematic warnings should be disabled or suppressed. We might want to globally suppress -Warray-bounds and -Wnonnull when

[webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
Hi, I'd like to suggest turning on -Werror on at least the GTK and WPE EWS, to reduce the amount of time I spend cleaning up newly-introduced build warnings. ;) If we're worried about too many spurious build failures, let's at least build with a few flags to prevent the most common GCC

Re: [webkit-dev] JPEG XL support?

2021-05-05 Thread Michael Catanzaro via webkit-dev
Hi Sami, I don't have any strong opinion on JPEG XL, asides from the general observation that adding more image decoders written in memory-unsafe languages is a generally sad thing to do. (I'm still not happy about how we were forced to support JPEG 2000 a couple years back due to websites

Re: [webkit-dev] New EWS Non-Unified builder

2021-05-04 Thread Michael Catanzaro via webkit-dev
On Mon, May 3 2021 at 12:21:57 PM -0700, Sam Weinig via webkit-dev wrote: So, does anyone have any recent measurements of clean build times with and without unified sources enabled? If so, what is the current delta? That would be painful to check, because you would first have to fix all the

Re: [webkit-dev] Detecting and handling unresponsive web processes

2021-04-28 Thread Michael Catanzaro via webkit-dev
On Wed, Apr 28 2021 at 04:14:16 PM +0200, Miguel Gomez via webkit-dev wrote: But if we give the option to disable this behavior, then we need to provide a way for the apps to handle the situation, don't you think? And this means adding new API (being it the one to retrieve the process ID or

Re: [webkit-dev] Request for position: Removing 3DES from TLS

2021-04-28 Thread Michael Catanzaro via webkit-dev
Looks like this change is clearly safe. I doubt Safari controls its own TLS ciphersuite settings. In WebKitGTK, they're controlled by the operating system's TLS backend and crypto policy. 3DES has been disabled for a while now on modern systems, and users have not reported any compat

Re: [webkit-dev] Detecting and handling unresponsive web processes

2021-04-28 Thread Michael Catanzaro via webkit-dev
On Tue, Apr 27 2021 at 10:18:04 AM +0200, Miguel Gomez via webkit-dev wrote: * Have some API method that allows to kill the problematic web process, and let the browser call it when needed. The next load will create a new web process. We only need this API if we are unable to fix the

Re: [webkit-dev] Any way to get a debugging symbols build without compiling?

2021-04-08 Thread Michael Catanzaro via webkit-dev
On Thu, Apr 8 2021 at 08:38:55 AM -0600, Alemar via webkit-dev wrote: Oh also, sorry for the extra email, but I just noticed that my webkit2gtk build is like 3 GB of size (!) no wonder why it doesn't crash, with that size that's the least thing I'd expect haha. But I can't definitely distribute

Re: [webkit-dev] Fwd: Any way to get a debugging symbols build without compiling?

2021-04-08 Thread Michael Catanzaro via webkit-dev
On Thu, Apr 8 2021 at 08:21:43 AM -0600, Alemar via webkit-dev wrote: So, my question is: What CLI arguments are used for building the release version posted on the website? I'm assuming it's not just: cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_GAMEPAD=NO

Re: [webkit-dev] Request for position on Schemeful Same-Site

2020-11-30 Thread Michael Catanzaro via webkit-dev
On Mon, Nov 30, 2020 at 11:18 am, Steven Bingler via webkit-dev wrote: Pinging this thread again. Schemeful Same-Site is moving into the Intent to Ship phase in Blink. Hi Ryosuke, any update? Schemeful Sames-Site looks like a clear improvement to me. Michael

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
On Tue, Nov 17, 2020 at 3:22 pm, Maciej Stachowiak wrote: This sounds obnoxious and potentially anti-competitive. But I think it’s restricted to OAuth flows, which would indeed only affect other sites that allow the user to sign in with their Google account. So that would be the thing to

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
On Tue, Nov 17, 2020 at 12:50 pm, Michael Catanzaro wrote: Oh, I missed a very important point. There is a header we can use to test: Google-Accounts-Check-OAuth-Login:true. I will try to figure out how to hack up the libsoup backend to send that header with all requests and see what happens

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
Oh, I missed a very important point. There is a header we can use to test: Google-Accounts-Check-OAuth-Login:true. I will try to figure out how to hack up the libsoup backend to send that header with all requests and see what happens ___

[webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
Hi, Today I received a Google Developers email with subject "[Action Required] Starting January 4, 2021, we will block all sign-ins to Google accounts from embedded browser frameworks." It linked to this Google blog post:

Re: [webkit-dev] Embedding Identifiers in Commit Messages

2020-11-11 Thread Michael Catanzaro
On Wed, Nov 4, 2020 at 11:51 am, Jonathan Bedard wrote: We don’t have post commit hooks in SVN to do this sort of thing, and I don’t intend to add them now. We are going to have a system on GitHub to do this (not post commit hooks, but I won’t dive into the details here). There really

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Michael Catanzaro
I suppose what I'm describing is Konstantin's Workflow 2, which is overwhelmingly popular. On Tue, Oct 13, 2020 at 2:19 pm, Ryosuke Niwa wrote: Not squashing only helps if each commit can stand on its own. At that point, I'd suggest such a sequence of commits be made into multiple PRs

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Michael Catanzaro
On Tue, Oct 13, 2020 at 12:32 pm, Maciej Stachowiak wrote: I’m assuming your objection is to regular merges, but how do you feel about squash merges? Or do you think all PRs should be landed by rebasing? If we want a linear history (we do), all PRs ultimately have to land as fast-forward

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Michael Catanzaro
On Wed, Oct 7, 2020 at 4:17 am, Konstantin Tokarev wrote: BTW, could you estimate how many of users which have provided meaningful bug reports were directed to bugs.webkit.org but never made it? A lot. I'd say maybe about half make it upstream. That's OK. We don't have time to fix

Re: [webkit-dev] WebKit Transition to Git

2020-10-06 Thread Michael Catanzaro
On Wed, Oct 7, 2020 at 2:22 am, Tetsuharu OHZEKI wrote: If we move to GitHub Issue, compared to bugzilla, that does not have "component watching". (I don't know the case of GitLab's Issue) We only can watch all issues or not for the repository. Oh dear. I had assumed that you could easily

Re: [webkit-dev] WebKit Transition to Git

2020-10-06 Thread Michael Catanzaro
On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev wrote: 1. Sub-par support for linking issues to each other Traditional bug tracking systems (like Bugzilla or JIRA) have support of "related" or "linked" issues. Most important

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Michael Catanzaro
On Mon, Oct 5, 2020 at 8:40 am, Jonathan Bedard wrote: That's one solution, but even that is somewhat insufficient because we don’t want to give someone access to every security issue just to give access to a single one. One of the solutions we’ve discussed is to migrate bugs component by

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Michael Catanzaro
On Sat, Oct 3, 2020 at 9:52 pm, Konstantin Tokarev wrote: If I understand correctly, there is no way in GitHub UI to see a difference between patches submitted at step 1 and step 3. It's still possible to see old version of patches if you navigate to old commit hash, but that's not for long as

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Michael Catanzaro
On Sat, Oct 3, 2020 at 3:16 am, Ryosuke Niwa wrote: I've gotta say I'm very much concerned about getting rid of change logs when we move to Git. We put a lot of useful information about what was causing the bug, how we fixed it, and why we fixed the way we did in a change log. I've seen a few

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: The biggest blocker we are aware of is managing security bugs, since the security advisory system used by GitHub is essentially the opposite of how WebKit security bugs work. Moving to GitHub Issues, if it happens, will be the last part of

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: Github's code review UI has a couple of feature gaps in my opinion. It's difficult to look at earlier versions of the pull request, in particular to verify that issues found during code review have been fixed. I remember it also being difficult

[webkit-dev] Issue reports, merge requests, etc. (was: WebKit Transition to Git)

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 11:51 am, Ryosuke Niwa wrote: Since Igalia has a lot more experience working with other open source projects, do you have some suggestions in how to approach that? Sorry for a long-ish mail. I didn't mean for this to turn into an essay. Too late. :P I actually moved

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: Would you also consider preventing merge commits in order to keep a clean mainline branch? Big +1 to blocking merge commits. Merge commits in a huge project like WebKit would make commit archaeology very frustrating. (I assume this is

Re: [webkit-dev] Question: referrerpolicy in Safari

2020-09-23 Thread Michael Catanzaro
On Wed, Sep 23, 2020 at 1:50 pm, Dominic Farolino wrote: I haven't dug too deep here, but just going to post this in case it answers your question and saves you some time. As documented here, it appears that Safari is starting to not honor the `referrerpolicy` attribute on HTML elements

Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-22 Thread Michael Catanzaro
On Wed, Jul 22, 2020 at 11:15 am, shriva...@firemail.cc wrote: DerivedSources/ForwardingHeaders/JavaScriptCore/JSContext.h:40:1: error: duplicate interface definition for class 'JSContext' @interface JSContext : NSObject ^ ../../Source/JavaScriptCore/API/JSContext.h:40:12: note: previous

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 9:35 am, Michael Catanzaro wrote: For now, I'll submit a patch to deprecate these settings without changing behavior yet. Meh, I did this, but realized that it's easier to write deprecation messages when we remove support for the feature at the same time that it's

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 11:47 am, Adrian Perez de Castro wrote: Our tentative plan for sunsetting the NPAPI support is to keep supporting the GTK3 plugin process in the next stable release series. This means that we could remove the support from trunk after creating the stable branch for the

[webkit-dev] Plugin process

2020-07-19 Thread Michael Catanzaro
Hi, Is anybody still using the plugin process? I understand that Safari does not allow plugins anymore. Epiphany doesn't either, nor does anything packaged in Linux distros (afaik). If nothing is using it, maybe we can delete a lot of code? Is it exposed in Apple system APIs? WebKitGTK

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Michael Catanzaro
On Thu, Jul 16, 2020 at 4:14 pm, Darin Adler wrote: Let’s stop doing it that way. Just compile the files and have #if inside the file. I removed all conditional source files from the Xcode build system. Let's do the same for the CMake build system. — Darin I agree we should do this.

Re: [webkit-dev] Position on User-Agent Client Hints

2020-05-07 Thread Michael Catanzaro
My personal $0.02: I'm mildly supportive of this spec. It's certainly an improvement on existing HTTP user agent headers. I appreciate that you worked to incorporate feedback into the spec and considered the concerns of small browsers. Is it going to solve all the problems caused by user

Re: [webkit-dev] webkitgtk and bubblewrap help needed

2020-04-28 Thread Michael Catanzaro
On Mon, Apr 27, 2020 at 11:22 pm, Jack Hill wrote: Can this problem be worked-around in WebKitGTK? Looks like WebKit should call realpath() for each path it passes to bwrap. Annoying, but certainly doable. Want to report a bug for it on WebKit Bugzilla?

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 2:48 pm, Michael Catanzaro wrote: Sometimes distros make exceptions (e.g. for WebKitGTK, which is special due to very high number of CVEs), but ICU does not warrant an exception. There are probably hundreds of applications using ICU in distros, if not more. Who knows

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 7:08 pm, "Olmstead, Don" wrote: Hi Michael, There are a couple problems with checking in a version of ICU. * Other libraries used by WebKit have dependencies on ICU. For our ports harfbuzz, libxml2, libxslt, libpsl and CFlite all require ICU. You're right, it's a

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 11:49 am, Alexey Proskuryakov wrote: The license is not BSD or LGPL, so that's one aspect to consider. Why exactly are distros unwilling to update ICU? - Alexey Distros would upgrade to newer minor releases of the library, but updating system packages to new

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
Any objections to uploading a bundled ICU 60 under Source/ThirdParty? Seems easier than forcing downstreams to work out bundling themselves. Most major distros will just stop providing WebKit security updates if we don't bundle it for them. E.g. this is sure to kill Ubuntu's current long

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Michael Catanzaro
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: Namely, some people write a lambda as: auto x = [] () { } with a space between [] and () while others would write it as: auto x = []() { } : I omit the () when there are no parameters, as in these examples. No preference on spacing.

Re: [webkit-dev] Issues running remote debug inspector for WPE instance with Epiphany dev preview

2019-10-11 Thread Michael Catanzaro
Hi Ryan, This is https://bugs.webkit.org/show_bug.cgi?id=202321 Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Moving to Python 3

2019-07-14 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 9:26 PM, Maciej Stachowiak wrote: Can you clarify why this is needed? Well it just wouldn't seem very kosher to use a virtualenv for the serious work of performing real distro builds, right? In contrast to developer scripts for developer convenience, where I'd say

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: This is exactly what virtualenvs can do. And this is how we should do it IMO, even for systems that natively have some version of Python 3. I guess that's fine for everything not required by the CMake build, e.g. build-webkit and

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: I frequently do WebKit development in older versions of macOS to diagnose old OS specific regressions, and having to install Python 3 each time I install an old OS is too much of a trouble. I understand it would be a hassle. :/ But please

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: The trouble I foresee us encountering with any scheme which attempts a conversion which retains both Python 2.7 and Python 3 compatibility is code like this: Is python2 support required for a well-motivated transitional purpose? I had

Re: [webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
I received a good answer and will upgrade our versions accordingly. Thanks. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
Hi, Relevant to [1], could someone please check what Safari's current UA string is, please? This is important to help me make sure WebKitGTK fakes the Safari user agent as well as possible. In particular, I'd like to know the version numbers used in the UA. I had thought we were frozen on:

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Michael Catanzaro
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham wrote: Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 10:42 AM, Michael Catanzaro wrote: You say the cloop seems unstable for you, which is option (3). So perhaps you should try option (2) if you haven't already. I'm not actually sure if that works, because I'm not an expert, which is why I added

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
It's great that you find our stable branches helpful, but keep in mind those branches do not include Windows-specific fixes. On Tue, Jun 25, 2019 at 9:53 AM, Arunprasad Rajkumar wrote: Right. Actually the problem is in 32-bit Windows platform. I see that the JIT support has been dropped some

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 8:31 AM, Arunprasad Rajkumar wrote: So my question is, do WebKit/JavaScriptCore still supports 32-bit Windows? Hi Arunprasad, The last version of WebKitGTK to support Windows was 2.4, from 2014. If you had 2.22 working, that's news to us. To my knowledge, nobody has

  1   2   3   4   >