Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Michael Catanzaro via webkit-dev
OK, so you are using the existing OS-level network interface settings. At least on Linux, that is a heuristic-based per-interface setting with a manual override. None of this happens without the user voluntarily revealing the information. How would that possibly work? A new type of

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Michael Catanzaro via webkit-dev
On Mon, Aug 30 2021 at 10:16:54 AM +0200, Thomas Steiner via webkit-dev wrote: Thanks for the reply, Ryosuke! Just to clarify, the `metered` attribute would be a manual user setting, not a browser heuristic. This means you could easily mark your all-data included WiFi at home as metered if

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-20 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 20 2021 at 06:30:16 PM -0600, Alemar wrote: Okay that makes sense. How do I install debuginfo for webkit though? Looking into apt, all I can find is this: Hi, there are distro-specific instructions here:

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-20 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 20 2021 at 11:27:17 AM -0600, Alemar wrote: #2 0x7fcfd172ff2b in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37 #3 0x7fcfd37e0622 in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37 #4 0x7fcfd37efef6 in () at /lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37

Re: [webkit-dev] [Help] WebProcess CRASHED

2021-08-14 Thread Michael Catanzaro via webkit-dev
Hi, you need to get a backtrace with gdb. There are some instructions here: https://wiki.gnome.org/GettingInTouch/Bugzilla/GettingTraces Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Position on font-family: emoji (and -webkit-pictograph)

2021-08-13 Thread Michael Catanzaro via webkit-dev
On Fri, Aug 13 2021 at 01:54:39 PM +0200, Frédéric Wang via webkit-dev wrote: I understand there is backward compat concerns about removing features but do we agree to add "emoji" as an alias for "-webkit-pictograph", similar to what we did in [3] for "system-ui"? This sounds pretty

Re: [webkit-dev] Removing the ENABLE(CSS_SCROLL_SNAP) flag

2021-06-15 Thread Michael Catanzaro via webkit-dev
Hi Martin! My $0.02: when all ports have the feature enabled and the code is cross-platform, it's usually best to remove the build flag unless there's a particular strong reason to keep it around. We have more than enough build flags, and if you get to delete old code that just makes it

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Tue, May 25 2021 at 06:22:41 AM -0500, Michael Catanzaro via webkit-dev wrote: I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will probably be a few, though, which could be caused by (a) EWS using non-default build options

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 07:36:03 PM -0700, Darin Adler via webkit-dev wrote: I do not know why we do not already use -Werror on GTK and WPE and I support using it there after fixing all the warnings. I'd be willing to enable it at the CMake level if it was conditional on

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 06:32:03 PM -0700, Darin Adler via webkit-dev wrote: But we can’t just turn on -Werror until after we fix all the warnings! Who will do that project. I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 05:42:37 PM -0500, Michael Catanzaro wrote: But really, rather than cherry-picking particular warning flags, using -Werror seems simplest to me. Problematic warnings should be disabled or suppressed. We might want to globally suppress -Warray-bounds and -Wnonnull when

[webkit-dev] Let's use -Werror on EWS?

2021-05-24 Thread Michael Catanzaro via webkit-dev
Hi, I'd like to suggest turning on -Werror on at least the GTK and WPE EWS, to reduce the amount of time I spend cleaning up newly-introduced build warnings. ;) If we're worried about too many spurious build failures, let's at least build with a few flags to prevent the most common GCC

Re: [webkit-dev] JPEG XL support?

2021-05-05 Thread Michael Catanzaro via webkit-dev
Hi Sami, I don't have any strong opinion on JPEG XL, asides from the general observation that adding more image decoders written in memory-unsafe languages is a generally sad thing to do. (I'm still not happy about how we were forced to support JPEG 2000 a couple years back due to websites

Re: [webkit-dev] New EWS Non-Unified builder

2021-05-04 Thread Michael Catanzaro via webkit-dev
On Mon, May 3 2021 at 12:21:57 PM -0700, Sam Weinig via webkit-dev wrote: So, does anyone have any recent measurements of clean build times with and without unified sources enabled? If so, what is the current delta? That would be painful to check, because you would first have to fix all the

Re: [webkit-dev] Detecting and handling unresponsive web processes

2021-04-28 Thread Michael Catanzaro via webkit-dev
On Wed, Apr 28 2021 at 04:14:16 PM +0200, Miguel Gomez via webkit-dev wrote: But if we give the option to disable this behavior, then we need to provide a way for the apps to handle the situation, don't you think? And this means adding new API (being it the one to retrieve the process ID or

Re: [webkit-dev] Request for position: Removing 3DES from TLS

2021-04-28 Thread Michael Catanzaro via webkit-dev
Looks like this change is clearly safe. I doubt Safari controls its own TLS ciphersuite settings. In WebKitGTK, they're controlled by the operating system's TLS backend and crypto policy. 3DES has been disabled for a while now on modern systems, and users have not reported any compat

Re: [webkit-dev] Detecting and handling unresponsive web processes

2021-04-28 Thread Michael Catanzaro via webkit-dev
On Tue, Apr 27 2021 at 10:18:04 AM +0200, Miguel Gomez via webkit-dev wrote: * Have some API method that allows to kill the problematic web process, and let the browser call it when needed. The next load will create a new web process. We only need this API if we are unable to fix the

Re: [webkit-dev] Any way to get a debugging symbols build without compiling?

2021-04-08 Thread Michael Catanzaro via webkit-dev
On Thu, Apr 8 2021 at 08:38:55 AM -0600, Alemar via webkit-dev wrote: Oh also, sorry for the extra email, but I just noticed that my webkit2gtk build is like 3 GB of size (!) no wonder why it doesn't crash, with that size that's the least thing I'd expect haha. But I can't definitely distribute

Re: [webkit-dev] Fwd: Any way to get a debugging symbols build without compiling?

2021-04-08 Thread Michael Catanzaro via webkit-dev
On Thu, Apr 8 2021 at 08:21:43 AM -0600, Alemar via webkit-dev wrote: So, my question is: What CLI arguments are used for building the release version posted on the website? I'm assuming it's not just: cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_GAMEPAD=NO

Re: [webkit-dev] Request for position on Schemeful Same-Site

2020-11-30 Thread Michael Catanzaro via webkit-dev
On Mon, Nov 30, 2020 at 11:18 am, Steven Bingler via webkit-dev wrote: Pinging this thread again. Schemeful Same-Site is moving into the Intent to Ship phase in Blink. Hi Ryosuke, any update? Schemeful Sames-Site looks like a clear improvement to me. Michael

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
On Tue, Nov 17, 2020 at 3:22 pm, Maciej Stachowiak wrote: This sounds obnoxious and potentially anti-competitive. But I think it’s restricted to OAuth flows, which would indeed only affect other sites that allow the user to sign in with their Google account. So that would be the thing to

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
On Tue, Nov 17, 2020 at 12:50 pm, Michael Catanzaro wrote: Oh, I missed a very important point. There is a header we can use to test: Google-Accounts-Check-OAuth-Login:true. I will try to figure out how to hack up the libsoup backend to send that header with all requests and see what happens

Re: [webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
Oh, I missed a very important point. There is a header we can use to test: Google-Accounts-Check-OAuth-Login:true. I will try to figure out how to hack up the libsoup backend to send that header with all requests and see what happens ___

[webkit-dev] Starting January 4, 2021, Google will block all sign-ins to Google accounts from embedded browser frameworks

2020-11-17 Thread Michael Catanzaro via webkit-dev
Hi, Today I received a Google Developers email with subject "[Action Required] Starting January 4, 2021, we will block all sign-ins to Google accounts from embedded browser frameworks." It linked to this Google blog post:

Re: [webkit-dev] Embedding Identifiers in Commit Messages

2020-11-11 Thread Michael Catanzaro
On Wed, Nov 4, 2020 at 11:51 am, Jonathan Bedard wrote: We don’t have post commit hooks in SVN to do this sort of thing, and I don’t intend to add them now. We are going to have a system on GitHub to do this (not post commit hooks, but I won’t dive into the details here). There really

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Michael Catanzaro
I suppose what I'm describing is Konstantin's Workflow 2, which is overwhelmingly popular. On Tue, Oct 13, 2020 at 2:19 pm, Ryosuke Niwa wrote: Not squashing only helps if each commit can stand on its own. At that point, I'd suggest such a sequence of commits be made into multiple PRs

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Michael Catanzaro
On Tue, Oct 13, 2020 at 12:32 pm, Maciej Stachowiak wrote: I’m assuming your objection is to regular merges, but how do you feel about squash merges? Or do you think all PRs should be landed by rebasing? If we want a linear history (we do), all PRs ultimately have to land as fast-forward

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Michael Catanzaro
On Wed, Oct 7, 2020 at 4:17 am, Konstantin Tokarev wrote: BTW, could you estimate how many of users which have provided meaningful bug reports were directed to bugs.webkit.org but never made it? A lot. I'd say maybe about half make it upstream. That's OK. We don't have time to fix

Re: [webkit-dev] WebKit Transition to Git

2020-10-06 Thread Michael Catanzaro
On Wed, Oct 7, 2020 at 2:22 am, Tetsuharu OHZEKI wrote: If we move to GitHub Issue, compared to bugzilla, that does not have "component watching". (I don't know the case of GitLab's Issue) We only can watch all issues or not for the repository. Oh dear. I had assumed that you could easily

Re: [webkit-dev] WebKit Transition to Git

2020-10-06 Thread Michael Catanzaro
On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev wrote: 1. Sub-par support for linking issues to each other Traditional bug tracking systems (like Bugzilla or JIRA) have support of "related" or "linked" issues. Most important

Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Michael Catanzaro
On Mon, Oct 5, 2020 at 8:40 am, Jonathan Bedard wrote: That's one solution, but even that is somewhat insufficient because we don’t want to give someone access to every security issue just to give access to a single one. One of the solutions we’ve discussed is to migrate bugs component by

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Michael Catanzaro
On Sat, Oct 3, 2020 at 9:52 pm, Konstantin Tokarev wrote: If I understand correctly, there is no way in GitHub UI to see a difference between patches submitted at step 1 and step 3. It's still possible to see old version of patches if you navigate to old commit hash, but that's not for long as

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Michael Catanzaro
On Sat, Oct 3, 2020 at 3:16 am, Ryosuke Niwa wrote: I've gotta say I'm very much concerned about getting rid of change logs when we move to Git. We put a lot of useful information about what was causing the bug, how we fixed it, and why we fixed the way we did in a change log. I've seen a few

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 09:43, Jonathan Bedard wrote: The biggest blocker we are aware of is managing security bugs, since the security advisory system used by GitHub is essentially the opposite of how WebKit security bugs work. Moving to GitHub Issues, if it happens, will be the last part of

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: Github's code review UI has a couple of feature gaps in my opinion. It's difficult to look at earlier versions of the pull request, in particular to verify that issues found during code review have been fixed. I remember it also being difficult

[webkit-dev] Issue reports, merge requests, etc. (was: WebKit Transition to Git)

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 11:51 am, Ryosuke Niwa wrote: Since Igalia has a lot more experience working with other open source projects, do you have some suggestions in how to approach that? Sorry for a long-ish mail. I didn't mean for this to turn into an essay. Too late. :P I actually moved

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Michael Catanzaro
On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: Would you also consider preventing merge commits in order to keep a clean mainline branch? Big +1 to blocking merge commits. Merge commits in a huge project like WebKit would make commit archaeology very frustrating. (I assume this is

Re: [webkit-dev] Question: referrerpolicy in Safari

2020-09-23 Thread Michael Catanzaro
On Wed, Sep 23, 2020 at 1:50 pm, Dominic Farolino wrote: I haven't dug too deep here, but just going to post this in case it answers your question and saves you some time. As documented here, it appears that Safari is starting to not honor the `referrerpolicy` attribute on HTML elements

Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-22 Thread Michael Catanzaro
On Wed, Jul 22, 2020 at 11:15 am, shriva...@firemail.cc wrote: DerivedSources/ForwardingHeaders/JavaScriptCore/JSContext.h:40:1: error: duplicate interface definition for class 'JSContext' @interface JSContext : NSObject ^ ../../Source/JavaScriptCore/API/JSContext.h:40:12: note: previous

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 9:35 am, Michael Catanzaro wrote: For now, I'll submit a patch to deprecate these settings without changing behavior yet. Meh, I did this, but realized that it's easier to write deprecation messages when we remove support for the feature at the same time that it's

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 11:47 am, Adrian Perez de Castro wrote: Our tentative plan for sunsetting the NPAPI support is to keep supporting the GTK3 plugin process in the next stable release series. This means that we could remove the support from trunk after creating the stable branch for the

[webkit-dev] Plugin process

2020-07-19 Thread Michael Catanzaro
Hi, Is anybody still using the plugin process? I understand that Safari does not allow plugins anymore. Epiphany doesn't either, nor does anything packaged in Linux distros (afaik). If nothing is using it, maybe we can delete a lot of code? Is it exposed in Apple system APIs? WebKitGTK

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Michael Catanzaro
On Thu, Jul 16, 2020 at 4:14 pm, Darin Adler wrote: Let’s stop doing it that way. Just compile the files and have #if inside the file. I removed all conditional source files from the Xcode build system. Let's do the same for the CMake build system. — Darin I agree we should do this.

Re: [webkit-dev] Position on User-Agent Client Hints

2020-05-07 Thread Michael Catanzaro
My personal $0.02: I'm mildly supportive of this spec. It's certainly an improvement on existing HTTP user agent headers. I appreciate that you worked to incorporate feedback into the spec and considered the concerns of small browsers. Is it going to solve all the problems caused by user

Re: [webkit-dev] webkitgtk and bubblewrap help needed

2020-04-28 Thread Michael Catanzaro
On Mon, Apr 27, 2020 at 11:22 pm, Jack Hill wrote: Can this problem be worked-around in WebKitGTK? Looks like WebKit should call realpath() for each path it passes to bwrap. Annoying, but certainly doable. Want to report a bug for it on WebKit Bugzilla?

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 2:48 pm, Michael Catanzaro wrote: Sometimes distros make exceptions (e.g. for WebKitGTK, which is special due to very high number of CVEs), but ICU does not warrant an exception. There are probably hundreds of applications using ICU in distros, if not more. Who knows

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 7:08 pm, "Olmstead, Don" wrote: Hi Michael, There are a couple problems with checking in a version of ICU. * Other libraries used by WebKit have dependencies on ICU. For our ports harfbuzz, libxml2, libxslt, libpsl and CFlite all require ICU. You're right, it's a

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 11:49 am, Alexey Proskuryakov wrote: The license is not BSD or LGPL, so that's one aspect to consider. Why exactly are distros unwilling to update ICU? - Alexey Distros would upgrade to newer minor releases of the library, but updating system packages to new

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
Any objections to uploading a bundled ICU 60 under Source/ThirdParty? Seems easier than forcing downstreams to work out bundling themselves. Most major distros will just stop providing WebKit security updates if we don't bundle it for them. E.g. this is sure to kill Ubuntu's current long

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Michael Catanzaro
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: Namely, some people write a lambda as: auto x = [] () { } with a space between [] and () while others would write it as: auto x = []() { } : I omit the () when there are no parameters, as in these examples. No preference on spacing.

Re: [webkit-dev] Issues running remote debug inspector for WPE instance with Epiphany dev preview

2019-10-11 Thread Michael Catanzaro
Hi Ryan, This is https://bugs.webkit.org/show_bug.cgi?id=202321 Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Moving to Python 3

2019-07-14 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 9:26 PM, Maciej Stachowiak wrote: Can you clarify why this is needed? Well it just wouldn't seem very kosher to use a virtualenv for the serious work of performing real distro builds, right? In contrast to developer scripts for developer convenience, where I'd say

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: This is exactly what virtualenvs can do. And this is how we should do it IMO, even for systems that natively have some version of Python 3. I guess that's fine for everything not required by the CMake build, e.g. build-webkit and

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: I frequently do WebKit development in older versions of macOS to diagnose old OS specific regressions, and having to install Python 3 each time I install an old OS is too much of a trouble. I understand it would be a hassle. :/ But please

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: The trouble I foresee us encountering with any scheme which attempts a conversion which retains both Python 2.7 and Python 3 compatibility is code like this: Is python2 support required for a well-motivated transitional purpose? I had

Re: [webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
I received a good answer and will upgrade our versions accordingly. Thanks. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
Hi, Relevant to [1], could someone please check what Safari's current UA string is, please? This is important to help me make sure WebKitGTK fakes the Safari user agent as well as possible. In particular, I'd like to know the version numbers used in the UA. I had thought we were frozen on:

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Michael Catanzaro
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham wrote: Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 10:42 AM, Michael Catanzaro wrote: You say the cloop seems unstable for you, which is option (3). So perhaps you should try option (2) if you haven't already. I'm not actually sure if that works, because I'm not an expert, which is why I added

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
It's great that you find our stable branches helpful, but keep in mind those branches do not include Windows-specific fixes. On Tue, Jun 25, 2019 at 9:53 AM, Arunprasad Rajkumar wrote: Right. Actually the problem is in 32-bit Windows platform. I see that the JIT support has been dropped some

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 8:31 AM, Arunprasad Rajkumar wrote: So my question is, do WebKit/JavaScriptCore still supports 32-bit Windows? Hi Arunprasad, The last version of WebKitGTK to support Windows was 2.4, from 2014. If you had 2.22 working, that's news to us. To my knowledge, nobody has

Re: [webkit-dev] C++17 is here. Should we use it?

2019-06-17 Thread Michael Catanzaro
Alex already switched all WebKit ports to building with C++17 enabled in https://bugs.webkit.org/show_bug.cgi?id=197131. On Sun, Jun 16, 2019 at 8:25 PM, Sam Weinig wrote: If the issue is getting these bots updated, can we do that? Are there any other bots that might need updating as well?

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-16 Thread Michael Catanzaro
1-4 all seem uncontroversial, especially with Tim's suggested improvement to immediately leave a "some queues failed" comment. On Sat, Jun 15, 2019 at 11:13 PM, Aakash Jain wrote: 5) Do not comment on bugzilla bug at all, instead send email to the author of the patch. Pros: less noisy, also

Re: [webkit-dev] CI builds failing for ppc64, ppc64le and s390x

2019-06-04 Thread Michael Catanzaro
https://bugs.webkit.org/show_bug.cgi?id=198518 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CI builds failing for ppc64, ppc64le and s390x

2019-06-03 Thread Michael Catanzaro
Did your builds for ARM succeed? We're having a similar (though completely different) packing problem there: https://bugs.webkit.org/show_bug.cgi?id=198274 ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-11 Thread Michael Catanzaro
On Fri, May 10, 2019 at 6:47 PM, Yusuke Suzuki wrote: 1. We can use GCC 7 2. We can use libstdc++7 Is my understanding correct? Basically, this means that we can use cool C++17 features super aggressively :) I would say you can use cool C++ 17 features cautiously, enjoying those features

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
On Tue, May 7, 2019 at 1:46 PM, Konstantin Tokarev wrote: Note that since we have to support libstdc++ 6.x, most of C++17 standard library features () should be disallowed. Those include std::filesystem, std::string_view, etc. Core language features should be fine. With my suggested

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
On Tue, May 7, 2019 at 1:53 PM, Alex Christensen wrote: If you have a minimum-requirements system that you want to keep building, put build infrastructure on build.webkit.org so we can see when things break. We already have stable release bots to test the lowest-supported configurations,

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
Since there were no objections, I've updated the policy on the wiki: https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-04 Thread Michael Catanzaro
On Tue, Apr 23, 2019 at 10:50 AM, Konstantin Tokarev wrote: [1] says: "we support each major Debian version until one year after the release of the next major version" Given that Buster is not released yet, bumping GCC requirement to 7 seems to be premature. The dependencies policy states

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Michael Catanzaro
On Thu, May 2, 2019 at 4:32 PM, Darin Adler wrote: For example, can someone without administration privileges do the right thing? Nope. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Spam and indexing

2019-04-22 Thread Michael Catanzaro
On Mon, Apr 22, 2019 at 11:06 AM, Konstantin Tokarev wrote: Another possible way is to disable self-registration for new users, similarly to what LLVM project did [1]. GCC Bugzilla did this a long time ago. It will make it really hard to convince users to report bugs. I would try

Re: [webkit-dev] Spam and indexing

2019-04-22 Thread Michael Catanzaro
Not indexing bugs.webkit.org will be sad for people who won't be able to find bugs they may be interested in via search engines... but those people are probably not WebKit developers working with WebKit on a daily basis. For us, it's just annoying to deal with the spam. I would turn off the

Re: [webkit-dev] Spam and indexing

2019-03-29 Thread Michael Catanzaro
On Thu, Mar 28, 2019 at 3:57 PM, Alexey Proskuryakov wrote: 2. Block indexing completely. Seems like no one was bothered by lack of indexing on new bugs so far. Spam problem seems worse than not being indexed. If you want to search for WebKit bugs, you can do that on WebKit Bugzilla,

Re: [webkit-dev] webkitgtk 2.22.6 tarball inaccessible

2019-03-22 Thread Michael Catanzaro
Looks like a permissions mistake. We'll investigate. Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-19 Thread Michael Catanzaro
Several more return WTFMove() cases were committed just between yesterday and today. Please be careful. :) On Tue, Mar 19, 2019 at 8:01 AM, Emilio Cobos =?iso-8859-1?q?=C1lvarez?= wrote: In Gecko, when I switched from mozilla::Move to std::move [1], I had to disable the warning and fix all

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-19 Thread Michael Catanzaro
On Tue, Mar 19, 2019 at 12:57 AM, Tomas Popela wrote: If a note from https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66 applies, then you can't fix it until we support Ubuntu 14.04 (due to its old gcc version): Turns out the std::move can only

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-18 Thread Michael Catanzaro
On Mon, Mar 18, 2019 at 4:43 PM, Andy Estes wrote: FWIW, Apple’s ports use the equivalent clang warning for pessimizing and redundant moves, and we cleaned up a bunch of these mistakes in our ports a few years ago. Hopefully you aren’t finding any of these mistakes in shared code. There are

[webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-18 Thread Michael Catanzaro
Hi, GCC 9 has new -Wpessimizing-move ("warning: moving a local object in a return statement prevents copy elision") and -Wredundant-move ("warning: redundant move in return statement") warnings. These are enabled by -Wextra (which we use) and will be triggered by code like: return

Re: [webkit-dev] Queries regarding few Components in webkit

2019-03-17 Thread Michael Catanzaro
Hi, It might be more realistic to try making an existing WebKit port work on Haiku (either WebKitGTK or WPE WebKit) rather than try to create an entirely new port. Previously you indicated that you were planning to create a new network backend for Haiku; that alone would be enough to occupy

Re: [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not

2019-03-12 Thread Michael Catanzaro
On Tue, Mar 12, 2019 at 9:42 PM, Ryosuke Niwa wrote: On that note, I'd appreciate if someone who maintains PlayStation / Windows ports could cleanup standardsUserAgentForURL to use WebsitePolicies in WebKit layer instead of having the logic in WebCore. Looks like standardUserAgentForURL is

Re: [webkit-dev] Rename AtomicString to AtomString

2019-03-04 Thread Michael Catanzaro
On Wed, Jan 30, 2019 at 1:38 PM, Adrian Perez de Castro wrote: Hi, On Wed, 30 Jan 2019 08:31:49 -0800, Darin Adler wrote: So, did we reach consensus that we should rename AtomicString to AtomString? Let's go with it  https://bugs.webkit.org/show_bug.cgi?id=195276

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Michael Catanzaro
On Wed, Feb 27, 2019 at 6:05 PM, Keith Rollin wrote: The underlying Cocoa os_log facility Yeah this is really interesting too. RELEASE_LOG is Cocoa-specific, because it's only backed by os_log. So when you change debug LOGs to RELEASE_LOG, you're removing the logging for other platforms. I

[webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Michael Catanzaro
Hi, For the past several years, I've been regularly fixing -Wformat warnings that look like this: ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 6 has type ‘uint64_t’ {aka ‘long unsigned

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Michael Catanzaro
On Wed, Feb 20, 2019 at 12:33 PM, Simon Fraser wrote: I find it mind bending. It makes me wonder if the author made a coding error. Yeah me too. It does seem to work nicely in Alex's CompletionHandler example, but still, I'd just add braces and return on an extra line if I was writing it.

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Michael Catanzaro
FWIW, it's not hard to enforce fast-forward merges with a git hook; that way, we can guarantee that the history has no merge commits and is fully linear. GitLab has built-in support to enforce this for merge requests (though not for direct commits). I agree that linear history is a must for a

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
No strong opinion from me here. I'm not familiar with how Safari's UI exposes some features but not others. In the GTK/WPE API, the features are not enumerable and only a few selected features are exposed at all, so that's not an issue for us. I do think we have a semantic issue, though,

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
On Wed, Feb 13, 2019 at 9:16 PM, Simon Fraser wrote: For these two, we now have them on by default because we think they are ready to ship. They still exist as experimental features so that people can turn them off for regression testing, but is the policy now to move them back to Debug

[webkit-dev] Experimental features review

2019-02-13 Thread Michael Catanzaro
Hi, Last year, we cleaned up experimental features in WebPreferences.yaml to ensure no experimental features were enabled by default. Since then we have regressed a bit when enabling cool new web features. :) Currently we have 12 offenders, listed below. Most likely, the category:

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Michael Catanzaro
On Tue, Feb 5, 2019 at 4:01 PM, ross.kirsl...@sony.com wrote: That said, I would expect specifically the Tools/TestWebKitAPI/Tests subdirectory to be the thing moved to APITests/, since the code that actually runs the tests is as much a “tool” as DRT, WKTR, or various other test-running

[webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Michael Catanzaro
Hi, I started writing this mail to propose creating a separate ChangeLog for Tools/TestWebKitAPI, to make the Tools/ ChangeLog more focused on, you know, actual tools. So many of my changes under Tools/ are to the API tests. But this reminded me that TestWebKitAPI is the only testsuite we

Re: [webkit-dev] WebKit2 owners help for GTK and WPE

2019-02-04 Thread Michael Catanzaro
Also: [GTK] Implement back/forward touchpad gesture https://bugs.webkit.org/show_bug.cgi?id=193919 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] More suggested Bugzilla component renames

2019-02-01 Thread Michael Catanzaro
WebKit Gtk -> WebKitGTK+ (or just WebKitGTK if the + is not allowed) WebKit WPE -> WPE WebKit ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reducing globals

2019-01-30 Thread Michael Catanzaro
Sorry again for the delay. I've started here: https://bugs.webkit.org/show_bug.cgi?id=194075 That covers the first two out of six parameters. I'll do CookieAcceptPolicy next, separately, since it requires modifying cross-platform stuff to do properly. And then the second half. Michael

Re: [webkit-dev] Rename AtomicString to AtomString

2019-01-30 Thread Michael Catanzaro
On Wed, Jan 30, 2019 at 10:31 AM, Darin Adler wrote: So, did we reach consensus that we should rename AtomicString to AtomString? +1 from me, it seems like a much less confusing name. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] libsoup and libcurl networking implementations

2019-01-19 Thread Michael Catanzaro
I just started on reducing use of NetworkProcessCreationParameters, which is a little trickier than I was expecting. (WebCore::SoupNetworkSession vs. WebKit::NetworkSessionSoup: confusing much?) I'll look into this too, since it's related. Michael

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 1:13 PM, Maciej Stachowiak wrote: std::array is fixed size. Er, yeah, oops. Size must be known at compile time, so it can't be used to replace a VLA. Vector it is ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 11:12 AM, Darin Adler wrote: Vector’s inline capacity feature was originally created as an alternative to variable length arrays for most of the purposes people would want to put them. Any advantages of this over std::array (which is widely-used in WebKit)?

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 2:27 AM, Salisbury, Mark wrote: Thanks Tim! I didn’t know about C++ variable length arrays. That makes perfect sense now. Looks like people have been requesting Visual Studio add support for VLAs; there are no indications they will be supported. We shouldn't

Re: [webkit-dev] Lots of spam on Bugzilla

2019-01-15 Thread Michael Catanzaro
On Wed, Dec 5, 2018 at 11:30 AM, Michael Catanzaro wrote: Wow, I never noticed this. I thought Apple folks were using superpowers to obsolete comments! Hi, Recently a spammer added me to his Bugzilla user watchlist (Preferences -> Email Preferences -> User Watching on the botto

  1   2   3   4   >