Re: [webkit-dev] Question: referrerpolicy in Safari

2020-09-23 Thread Michael Catanzaro
On Wed, Sep 23, 2020 at 1:50 pm, Dominic Farolino wrote: I haven't dug too deep here, but just going to post this in case it answers your question and saves you some time. As documented here, it appears that Safari is starting to not honor the `referrerpolicy` attribute on HTML elements

Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-22 Thread Michael Catanzaro
On Wed, Jul 22, 2020 at 11:15 am, shriva...@firemail.cc wrote: DerivedSources/ForwardingHeaders/JavaScriptCore/JSContext.h:40:1: error: duplicate interface definition for class 'JSContext' @interface JSContext : NSObject ^ ../../Source/JavaScriptCore/API/JSContext.h:40:12: note: previous

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 9:35 am, Michael Catanzaro wrote: For now, I'll submit a patch to deprecate these settings without changing behavior yet. Meh, I did this, but realized that it's easier to write deprecation messages when we remove support for the feature at the same time that it's

Re: [webkit-dev] Plugin process

2020-07-20 Thread Michael Catanzaro
On Mon, Jul 20, 2020 at 11:47 am, Adrian Perez de Castro wrote: Our tentative plan for sunsetting the NPAPI support is to keep supporting the GTK3 plugin process in the next stable release series. This means that we could remove the support from trunk after creating the stable branch for the

[webkit-dev] Plugin process

2020-07-19 Thread Michael Catanzaro
Hi, Is anybody still using the plugin process? I understand that Safari does not allow plugins anymore. Epiphany doesn't either, nor does anything packaged in Linux distros (afaik). If nothing is using it, maybe we can delete a lot of code? Is it exposed in Apple system APIs? WebKitGTK

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Michael Catanzaro
On Thu, Jul 16, 2020 at 4:14 pm, Darin Adler wrote: Let’s stop doing it that way. Just compile the files and have #if inside the file. I removed all conditional source files from the Xcode build system. Let's do the same for the CMake build system. — Darin I agree we should do this.

Re: [webkit-dev] Position on User-Agent Client Hints

2020-05-07 Thread Michael Catanzaro
My personal $0.02: I'm mildly supportive of this spec. It's certainly an improvement on existing HTTP user agent headers. I appreciate that you worked to incorporate feedback into the spec and considered the concerns of small browsers. Is it going to solve all the problems caused by user

Re: [webkit-dev] webkitgtk and bubblewrap help needed

2020-04-28 Thread Michael Catanzaro
On Mon, Apr 27, 2020 at 11:22 pm, Jack Hill wrote: Can this problem be worked-around in WebKitGTK? Looks like WebKit should call realpath() for each path it passes to bwrap. Annoying, but certainly doable. Want to report a bug for it on WebKit Bugzilla?

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 2:48 pm, Michael Catanzaro wrote: Sometimes distros make exceptions (e.g. for WebKitGTK, which is special due to very high number of CVEs), but ICU does not warrant an exception. There are probably hundreds of applications using ICU in distros, if not more. Who knows

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 7:08 pm, "Olmstead, Don" wrote: Hi Michael, There are a couple problems with checking in a version of ICU. * Other libraries used by WebKit have dependencies on ICU. For our ports harfbuzz, libxml2, libxslt, libpsl and CFlite all require ICU. You're right, it's a

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
On Thu, Apr 9, 2020 at 11:49 am, Alexey Proskuryakov wrote: The license is not BSD or LGPL, so that's one aspect to consider. Why exactly are distros unwilling to update ICU? - Alexey Distros would upgrade to newer minor releases of the library, but updating system packages to new

Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-09 Thread Michael Catanzaro
Any objections to uploading a bundled ICU 60 under Source/ThirdParty? Seems easier than forcing downstreams to work out bundling themselves. Most major distros will just stop providing WebKit security updates if we don't bundle it for them. E.g. this is sure to kill Ubuntu's current long

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Michael Catanzaro
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: Namely, some people write a lambda as: auto x = [] () { } with a space between [] and () while others would write it as: auto x = []() { } : I omit the () when there are no parameters, as in these examples. No preference on spacing.

Re: [webkit-dev] Issues running remote debug inspector for WPE instance with Epiphany dev preview

2019-10-11 Thread Michael Catanzaro
Hi Ryan, This is https://bugs.webkit.org/show_bug.cgi?id=202321 Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Moving to Python 3

2019-07-14 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 9:26 PM, Maciej Stachowiak wrote: Can you clarify why this is needed? Well it just wouldn't seem very kosher to use a virtualenv for the serious work of performing real distro builds, right? In contrast to developer scripts for developer convenience, where I'd say

Re: [webkit-dev] Moving to Python 3

2019-07-13 Thread Michael Catanzaro
On Sat, Jul 13, 2019 at 6:02 PM, Maciej Stachowiak wrote: This is exactly what virtualenvs can do. And this is how we should do it IMO, even for systems that natively have some version of Python 3. I guess that's fine for everything not required by the CMake build, e.g. build-webkit and

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 5:22 PM, Ryosuke Niwa wrote: I frequently do WebKit development in older versions of macOS to diagnose old OS specific regressions, and having to install Python 3 each time I install an old OS is too much of a trouble. I understand it would be a hassle. :/ But please

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Michael Catanzaro
On Fri, Jul 12, 2019 at 2:18 PM, Jonathan Bedard wrote: The trouble I foresee us encountering with any scheme which attempts a conversion which retains both Python 2.7 and Python 3 compatibility is code like this: Is python2 support required for a well-motivated transitional purpose? I had

Re: [webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
I received a good answer and will upgrade our versions accordingly. Thanks. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] What's the current Safari UA?

2019-07-12 Thread Michael Catanzaro
Hi, Relevant to [1], could someone please check what Safari's current UA string is, please? This is important to help me make sure WebKitGTK fakes the Safari user agent as well as possible. In particular, I'd like to know the version numbers used in the UA. I had thought we were frozen on:

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Michael Catanzaro
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham wrote: Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 10:42 AM, Michael Catanzaro wrote: You say the cloop seems unstable for you, which is option (3). So perhaps you should try option (2) if you haven't already. I'm not actually sure if that works, because I'm not an expert, which is why I added

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
It's great that you find our stable branches helpful, but keep in mind those branches do not include Windows-specific fixes. On Tue, Jun 25, 2019 at 9:53 AM, Arunprasad Rajkumar wrote: Right. Actually the problem is in 32-bit Windows platform. I see that the JIT support has been dropped some

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Michael Catanzaro
On Tue, Jun 25, 2019 at 8:31 AM, Arunprasad Rajkumar wrote: So my question is, do WebKit/JavaScriptCore still supports 32-bit Windows? Hi Arunprasad, The last version of WebKitGTK to support Windows was 2.4, from 2014. If you had 2.22 working, that's news to us. To my knowledge, nobody has

Re: [webkit-dev] C++17 is here. Should we use it?

2019-06-17 Thread Michael Catanzaro
Alex already switched all WebKit ports to building with C++17 enabled in https://bugs.webkit.org/show_bug.cgi?id=197131. On Sun, Jun 16, 2019 at 8:25 PM, Sam Weinig wrote: If the issue is getting these bots updated, can we do that? Are there any other bots that might need updating as well?

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

2019-06-16 Thread Michael Catanzaro
1-4 all seem uncontroversial, especially with Tim's suggested improvement to immediately leave a "some queues failed" comment. On Sat, Jun 15, 2019 at 11:13 PM, Aakash Jain wrote: 5) Do not comment on bugzilla bug at all, instead send email to the author of the patch. Pros: less noisy, also

Re: [webkit-dev] CI builds failing for ppc64, ppc64le and s390x

2019-06-04 Thread Michael Catanzaro
https://bugs.webkit.org/show_bug.cgi?id=198518 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CI builds failing for ppc64, ppc64le and s390x

2019-06-03 Thread Michael Catanzaro
Did your builds for ARM succeed? We're having a similar (though completely different) packing problem there: https://bugs.webkit.org/show_bug.cgi?id=198274 ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-11 Thread Michael Catanzaro
On Fri, May 10, 2019 at 6:47 PM, Yusuke Suzuki wrote: 1. We can use GCC 7 2. We can use libstdc++7 Is my understanding correct? Basically, this means that we can use cool C++17 features super aggressively :) I would say you can use cool C++ 17 features cautiously, enjoying those features

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
On Tue, May 7, 2019 at 1:46 PM, Konstantin Tokarev wrote: Note that since we have to support libstdc++ 6.x, most of C++17 standard library features () should be disallowed. Those include std::filesystem, std::string_view, etc. Core language features should be fine. With my suggested

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
On Tue, May 7, 2019 at 1:53 PM, Alex Christensen wrote: If you have a minimum-requirements system that you want to keep building, put build infrastructure on build.webkit.org so we can see when things break. We already have stable release bots to test the lowest-supported configurations,

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-07 Thread Michael Catanzaro
Since there were no objections, I've updated the policy on the wiki: https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] C++17 is here. Should we use it?

2019-05-04 Thread Michael Catanzaro
On Tue, Apr 23, 2019 at 10:50 AM, Konstantin Tokarev wrote: [1] says: "we support each major Debian version until one year after the release of the next major version" Given that Buster is not released yet, bumping GCC requirement to 7 seems to be premature. The dependencies policy states

Re: [webkit-dev] Spam and indexing

2019-05-02 Thread Michael Catanzaro
On Thu, May 2, 2019 at 4:32 PM, Darin Adler wrote: For example, can someone without administration privileges do the right thing? Nope. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Spam and indexing

2019-04-22 Thread Michael Catanzaro
On Mon, Apr 22, 2019 at 11:06 AM, Konstantin Tokarev wrote: Another possible way is to disable self-registration for new users, similarly to what LLVM project did [1]. GCC Bugzilla did this a long time ago. It will make it really hard to convince users to report bugs. I would try

Re: [webkit-dev] Spam and indexing

2019-04-22 Thread Michael Catanzaro
Not indexing bugs.webkit.org will be sad for people who won't be able to find bugs they may be interested in via search engines... but those people are probably not WebKit developers working with WebKit on a daily basis. For us, it's just annoying to deal with the spam. I would turn off the

Re: [webkit-dev] Spam and indexing

2019-03-29 Thread Michael Catanzaro
On Thu, Mar 28, 2019 at 3:57 PM, Alexey Proskuryakov wrote: 2. Block indexing completely. Seems like no one was bothered by lack of indexing on new bugs so far. Spam problem seems worse than not being indexed. If you want to search for WebKit bugs, you can do that on WebKit Bugzilla,

Re: [webkit-dev] webkitgtk 2.22.6 tarball inaccessible

2019-03-22 Thread Michael Catanzaro
Looks like a permissions mistake. We'll investigate. Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-19 Thread Michael Catanzaro
Several more return WTFMove() cases were committed just between yesterday and today. Please be careful. :) On Tue, Mar 19, 2019 at 8:01 AM, Emilio Cobos =?iso-8859-1?q?=C1lvarez?= wrote: In Gecko, when I switched from mozilla::Move to std::move [1], I had to disable the warning and fix all

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-19 Thread Michael Catanzaro
On Tue, Mar 19, 2019 at 12:57 AM, Tomas Popela wrote: If a note from https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66 applies, then you can't fix it until we support Ubuntu 14.04 (due to its old gcc version): Turns out the std::move can only

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-18 Thread Michael Catanzaro
On Mon, Mar 18, 2019 at 4:43 PM, Andy Estes wrote: FWIW, Apple’s ports use the equivalent clang warning for pessimizing and redundant moves, and we cleaned up a bunch of these mistakes in our ports a few years ago. Hopefully you aren’t finding any of these mistakes in shared code. There are

[webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-18 Thread Michael Catanzaro
Hi, GCC 9 has new -Wpessimizing-move ("warning: moving a local object in a return statement prevents copy elision") and -Wredundant-move ("warning: redundant move in return statement") warnings. These are enabled by -Wextra (which we use) and will be triggered by code like: return

Re: [webkit-dev] Queries regarding few Components in webkit

2019-03-17 Thread Michael Catanzaro
Hi, It might be more realistic to try making an existing WebKit port work on Haiku (either WebKitGTK or WPE WebKit) rather than try to create an entirely new port. Previously you indicated that you were planning to create a new network backend for Haiku; that alone would be enough to occupy

Re: [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not

2019-03-12 Thread Michael Catanzaro
On Tue, Mar 12, 2019 at 9:42 PM, Ryosuke Niwa wrote: On that note, I'd appreciate if someone who maintains PlayStation / Windows ports could cleanup standardsUserAgentForURL to use WebsitePolicies in WebKit layer instead of having the logic in WebCore. Looks like standardUserAgentForURL is

Re: [webkit-dev] Rename AtomicString to AtomString

2019-03-04 Thread Michael Catanzaro
On Wed, Jan 30, 2019 at 1:38 PM, Adrian Perez de Castro wrote: Hi, On Wed, 30 Jan 2019 08:31:49 -0800, Darin Adler wrote: So, did we reach consensus that we should rename AtomicString to AtomString? Let's go with it  https://bugs.webkit.org/show_bug.cgi?id=195276

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Michael Catanzaro
On Wed, Feb 27, 2019 at 6:05 PM, Keith Rollin wrote: The underlying Cocoa os_log facility Yeah this is really interesting too. RELEASE_LOG is Cocoa-specific, because it's only backed by os_log. So when you change debug LOGs to RELEASE_LOG, you're removing the logging for other platforms. I

[webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Michael Catanzaro
Hi, For the past several years, I've been regularly fixing -Wformat warnings that look like this: ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 6 has type ‘uint64_t’ {aka ‘long unsigned

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Michael Catanzaro
On Wed, Feb 20, 2019 at 12:33 PM, Simon Fraser wrote: I find it mind bending. It makes me wonder if the author made a coding error. Yeah me too. It does seem to work nicely in Alex's CompletionHandler example, but still, I'd just add braces and return on an extra line if I was writing it.

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Michael Catanzaro
FWIW, it's not hard to enforce fast-forward merges with a git hook; that way, we can guarantee that the history has no merge commits and is fully linear. GitLab has built-in support to enforce this for merge requests (though not for direct commits). I agree that linear history is a must for a

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
No strong opinion from me here. I'm not familiar with how Safari's UI exposes some features but not others. In the GTK/WPE API, the features are not enumerable and only a few selected features are exposed at all, so that's not an issue for us. I do think we have a semantic issue, though,

Re: [webkit-dev] Experimental features review

2019-02-14 Thread Michael Catanzaro
On Wed, Feb 13, 2019 at 9:16 PM, Simon Fraser wrote: For these two, we now have them on by default because we think they are ready to ship. They still exist as experimental features so that people can turn them off for regression testing, but is the policy now to move them back to Debug

[webkit-dev] Experimental features review

2019-02-13 Thread Michael Catanzaro
Hi, Last year, we cleaned up experimental features in WebPreferences.yaml to ensure no experimental features were enabled by default. Since then we have regressed a bit when enabling cool new web features. :) Currently we have 12 offenders, listed below. Most likely, the category:

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Michael Catanzaro
On Tue, Feb 5, 2019 at 4:01 PM, ross.kirsl...@sony.com wrote: That said, I would expect specifically the Tools/TestWebKitAPI/Tests subdirectory to be the thing moved to APITests/, since the code that actually runs the tests is as much a “tool” as DRT, WKTR, or various other test-running

[webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Michael Catanzaro
Hi, I started writing this mail to propose creating a separate ChangeLog for Tools/TestWebKitAPI, to make the Tools/ ChangeLog more focused on, you know, actual tools. So many of my changes under Tools/ are to the API tests. But this reminded me that TestWebKitAPI is the only testsuite we

Re: [webkit-dev] WebKit2 owners help for GTK and WPE

2019-02-04 Thread Michael Catanzaro
Also: [GTK] Implement back/forward touchpad gesture https://bugs.webkit.org/show_bug.cgi?id=193919 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] More suggested Bugzilla component renames

2019-02-01 Thread Michael Catanzaro
WebKit Gtk -> WebKitGTK+ (or just WebKitGTK if the + is not allowed) WebKit WPE -> WPE WebKit ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reducing globals

2019-01-30 Thread Michael Catanzaro
Sorry again for the delay. I've started here: https://bugs.webkit.org/show_bug.cgi?id=194075 That covers the first two out of six parameters. I'll do CookieAcceptPolicy next, separately, since it requires modifying cross-platform stuff to do properly. And then the second half. Michael

Re: [webkit-dev] Rename AtomicString to AtomString

2019-01-30 Thread Michael Catanzaro
On Wed, Jan 30, 2019 at 10:31 AM, Darin Adler wrote: So, did we reach consensus that we should rename AtomicString to AtomString? +1 from me, it seems like a much less confusing name. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] libsoup and libcurl networking implementations

2019-01-19 Thread Michael Catanzaro
I just started on reducing use of NetworkProcessCreationParameters, which is a little trickier than I was expecting. (WebCore::SoupNetworkSession vs. WebKit::NetworkSessionSoup: confusing much?) I'll look into this too, since it's related. Michael

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 1:13 PM, Maciej Stachowiak wrote: std::array is fixed size. Er, yeah, oops. Size must be known at compile time, so it can't be used to replace a VLA. Vector it is ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 11:12 AM, Darin Adler wrote: Vector’s inline capacity feature was originally created as an alternative to variable length arrays for most of the purposes people would want to put them. Any advantages of this over std::array (which is widely-used in WebKit)?

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 2:27 AM, Salisbury, Mark wrote: Thanks Tim! I didn’t know about C++ variable length arrays. That makes perfect sense now. Looks like people have been requesting Visual Studio add support for VLAs; there are no indications they will be supported. We shouldn't

Re: [webkit-dev] Lots of spam on Bugzilla

2019-01-15 Thread Michael Catanzaro
On Wed, Dec 5, 2018 at 11:30 AM, Michael Catanzaro wrote: Wow, I never noticed this. I thought Apple folks were using superpowers to obsolete comments! Hi, Recently a spammer added me to his Bugzilla user watchlist (Preferences -> Email Preferences -> User Watching on the botto

Re: [webkit-dev] Reducing globals

2019-01-15 Thread Michael Catanzaro
This: On Thu, Nov 29, 2018 at 8:15 PM, Alex Christensen wrote: Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and

Re: [webkit-dev] JSCOnly bots on dashboard

2019-01-03 Thread Michael Catanzaro
On Wed, Jan 2, 2019 at 1:54 PM, Yusuke Suzuki wrote: This is because of old ICU. In old ICU, Intl.NumberFormats does not work. Intl feature usually requires very new ICU. IIRC, the similar issue happened in test262, and Ross skipped them. I think we should put the condition in the tests that

[webkit-dev] JSCOnly bots on dashboard

2019-01-02 Thread Michael Catanzaro
Hi, I've updated https://build.webkit.org/dashboard/ to show our JSCOnly bots in addition to WPE and GTK, so we can monitor the health of these bots. Tip: disable all but the Linux ports in the upper-left to make the page load faster. Current status is: * 90 failures on aarch64 * ARMv7

[webkit-dev] Hash table empty value

2018-12-19 Thread Michael Catanzaro
On Tue, Dec 18, 2018 at 2:31 PM, Ryosuke Niwa wrote: I tend to agree but then we'd come up with other numbers for the empty & deleted values. I've been thinking that we could use -1 and -2 but that's also somewhat arbitrary restriction. Using min/max values seems much safer. E.g. we already

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Michael Catanzaro
On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: I’ve gotten used to the name AtomicString over the years, but I wouldn’t strongly object to changing it if other programmers are often confused by it’s similarity to the term “atomic operations”. Well there were two other developers in the

Re: [webkit-dev] 'final' class specifier and 'final' method specifier

2018-12-19 Thread Michael Catanzaro
On Wed, Dec 19, 2018 at 1:58 PM, Konstantin Tokarev wrote: Adding override to method which already has final specifier doesn't affect anything, because both final and override may ony be used on virtual methods FWIW I prefer override because it's much more clear what that keyword is used

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-18 Thread Michael Catanzaro
I know I'm getting a bit far afield here, but: On Mon, Dec 17, 2018 at 9:26 PM, Ryosuke Niwa wrote: But then our behavior of HashMap which doesn't accept the POD integral value of 0 as a key This behavior is really unexpected and dangerous [1], and we should seriously consider changing it.

Re: [webkit-dev] What goes in FeatureDefines.xcconfig

2018-12-12 Thread Michael Catanzaro
On Mon, Dec 10, 2018 at 5:49 PM, don.olmst...@sony.com wrote: Recently I did some work around syncing the contents of FeatureDefines.xcconfig and WebKitFeatures.cmake, https://bugs.webkit.org/show_bug.cgi?id=191167 . Michael mentioned someone noticing that ENABLE(RESOURCE_LOAD_STATISTICS)

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-05 Thread Michael Catanzaro
On Wed, Dec 5, 2018 at 10:44 AM, ross.kirsl...@sony.com wrote: You can click Tag and enter "spam". (There's also the "obsolete" tag for hiding, say, outdated feedback from the EWS bots. Unfortunately tagging is purely by manual entry right now, but it works.) Wow, I never noticed this. I

Re: [webkit-dev] Lots of spam on Bugzilla

2018-12-05 Thread Michael Catanzaro
On Tue, Dec 4, 2018 at 7:47 PM, Alexey Proskuryakov wrote: Anyone can tag comments to make them invisible How? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Remove HAVE_ACCESSIBILITY

2018-11-14 Thread Michael Catanzaro
On Wed, Nov 14, 2018 at 7:49 PM, Fujii Hironori wrote: No, it isn't high. It is no problem to keep the code. CMake defines the similar name macro ENABLE_ACCESSIBILITY=0 in generated cmakeconfig.h. https://trac.webkit.org/browser/webkit/trunk/Source/cmake/WebKitFeatures.cmake#L88 This

Re: [webkit-dev] Is gperf really needed when building the JSCOnly with CMake?

2018-10-01 Thread Michael Catanzaro
On Sun, Sep 30, 2018 at 7:29 PM, Konstantin Tokarev wrote: Or, better, if (ENABLE_WEBCORE) Yeah, that's better ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Is gperf really needed when building the JSCOnly with CMake?

2018-09-30 Thread Michael Catanzaro
Yeah, I'd just put it in an if (NOT ${PORT} STREQUAL "JSCOnly") (writing that off the top of my head, probably somehow wrong) ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [jsc-dev] Proposal: Using LLInt Asm in major architectures even if JIT is disabled

2018-09-20 Thread Michael Catanzaro
On Thu, Sep 20, 2018 at 12:02 PM, Filip Pizlo wrote: - Enable cloop/JSVALUE64 to work on 32-bit. I don’t think it does right now, but that’s probably trivial to fix. - Switch Darwin ports to that configuration for 32-bit. - When changes land to support new features, make it mandatory to

Re: [webkit-dev] [jsc-dev] Proposal: Using LLInt Asm in major architectures even if JIT is disabled

2018-09-20 Thread Michael Catanzaro
I believe Guillaume has previously established that results in a substantial performance regression for WPE. It is currently running in production on tens of millions of consumer set top boxes. I think that's substantial testing. :) Michael ___

Re: [webkit-dev] Proposal: macros to explicitly ignore warnings

2018-08-28 Thread Michael Catanzaro
On Tue, Aug 28, 2018 at 11:47 AM, Guillaume Emont wrote: PRAGMA_IGNORE_WARNING_CLANG("-Wfoo-bar") // Code that triggers the warning. PRAGMA_IGNORE_WARNING_CLANG_END("-Wfoo-bar") Maybe: PRAGMA_IGNORE_CLANG_WARNING("-Wfoo-bar") ? That reads slightly better to me. FWIW I think this is

Re: [webkit-dev] Bugzilla component for CMake

2018-08-24 Thread Michael Catanzaro
On Fri, Aug 24, 2018 at 12:23 PM, Lucas Forschler wrote: Done! Lucas I'm afraid you'll likely be hearing from me a lot less now! ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Bugzilla component for CMake

2018-08-24 Thread Michael Catanzaro
Hi, I think it would be useful to have a Bugzilla component for CMake build system changes. We have a lot of such bugs, and normally use the Tools/Tests component for them currently, which is not a great fit (and causes Lucas to be CCed unnecessarily on a bunch of bugs ;) Michael

Re: [webkit-dev] Proposal: Not supporting x86 w/o SSE2

2018-08-04 Thread Michael Catanzaro
Technically, many of WebKitGTK+'s distributors require that it not use SSE2 instructions in 32-bit builds. I am no longer sure which ones. (It used to be the case for Fedora, for example, but that changed recently.) In practice, so few people care about these old machines anymore that such

[webkit-dev] Fujii Hironori is now a WebKit reviewer

2018-07-14 Thread Michael Catanzaro
Hi, Fujii Hironori is now a WebKit reviewer. He has expertise in Windows support, WebKitGTK+, and WebCore bugs. Please congratulate him and send him patches to review! Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-27 Thread Michael Catanzaro
On Tue, Jun 26, 2018 at 6:49 PM, Yusuke SUZUKI wrote: My suggestion is introducing Fushcia port, adding both PLATFORM(FUSHCIA) and OS(FUSHCIA) ifdefs. Use OS(FUSHCIA) when the change is b/c of Fushcia's APIs. And use PLATFORM(FUSHCIA) to change the policy of the released build (e.g. enabling /

Re: [webkit-dev] Experimental features enabled by default

2018-06-27 Thread Michael Catanzaro
On Wed, Jun 27, 2018 at 1:00 PM, Tim Horton wrote: Alright, how’s it looking now? :) Good, thanks for taking care of this, Tim! Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Experimental features enabled by default

2018-06-26 Thread Michael Catanzaro
Hi, We're a lot closer after r233227! There is still IsSecureContextAttributeEnabled. Shall we switch the default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of true? We should also move CSSAnimationTriggersEnabled to the experimental features section of the

Re: [webkit-dev] Experimental features enabled by default

2018-06-20 Thread Michael Catanzaro
On Wed, Jun 20, 2018 at 6:05 PM, Tim Horton wrote: It’s definitely not OK, no. Well, we should make sure the right choice is made for each individual feature, but I don't know what those right choices are... hence the motivation for my mail. I think we have some sorting out of this to do,

[webkit-dev] Experimental features enabled by default

2018-06-20 Thread Michael Catanzaro
Hi, I noticed in glancing over WebPreferences.yaml that we have a large number of experimental features enabled by default. There is a comment header indicating that the only allowed values are false or DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, so true is disallowed, but that's being ignored in

Re: [webkit-dev] Switch to std::variant?

2018-05-23 Thread Michael Catanzaro
On Wed, May 23, 2018 at 10:52 AM, Konstantin Tokarev wrote: What do you mean under "std::optional fiasco"? Well we had a bunch of difficult build failures: https://bugs.webkit.org/show_bug.cgi?id=185159 https://bugs.webkit.org/show_bug.cgi?id=185194

Re: [webkit-dev] Switch to std::variant?

2018-05-23 Thread Michael Catanzaro
On Wed, May 23, 2018 at 6:14 AM, z...@falconsigh.net wrote: Some GCC-and-libstdc++ configurations would still require a fallback implementation After the std::optional fiasco, I'm pretty nervous about the state of using new C++ 17 features. We've wound up in a situation where we're OK with

Re: [webkit-dev] [jsc-dev] Proposal: Removing ENABLE(INTL)

2018-05-21 Thread Michael Catanzaro
On Mon, May 21, 2018 at 9:45 AM, Michael Catanzaro <mcatanz...@igalia.com> wrote: But I'm curious if anyone knows what the ICU requirement is for ENABLE(INTL)? Also, Ms2ger reported https://bugs.webkit.org/show_bug.cgi?id=185714 recently. It seems there are new o

Re: [webkit-dev] [jsc-dev] Proposal: Removing ENABLE(INTL)

2018-05-21 Thread Michael Catanzaro
On Mon, May 21, 2018 at 8:55 AM, Konstantin Tokarev wrote: For the record, having !ENABLE(INTL) option allowed to build WebKit against old ICU versions, e.g. version that is shipped with RHEL 7. For WebKitGTK+, we do not support building without ENABLE(INTL), and we don't

Re: [webkit-dev] New iOS versions sending bogus User-Agent build data

2018-04-26 Thread Michael Catanzaro
On Thu, Apr 26, 2018 at 12:48 PM, Colin Bendell | +1.613.914.3387 wrote: Can you give me an example where UA parsing is punishing users of alternative user agents? Is this a theoretical problem, or a widespread problem? I'm not asking to be divisive, but because I know for a

Re: [webkit-dev] New iOS versions sending bogus User-Agent build data

2018-04-26 Thread Michael Catanzaro
On Thu, Apr 26, 2018 at 11:13 AM, Michael Catanzaro <mcatanz...@igalia.com> wrote: By fixing the WebKit bug, of course. And in the meantime you can work around it on the server side by not using img src=mp4, right? Consider the other perspective on this problem. If other server

Re: [webkit-dev] New iOS versions sending bogus User-Agent build data

2018-04-26 Thread Michael Catanzaro
On Thu, Apr 26, 2018 at 10:57 AM, Colin Bendell | +1.613.914.3387 wrote: How do we navigate this? By fixing the WebKit bug, of course. And in the meantime you can work around it on the server side by not using , right? Michael

Re: [webkit-dev] Compiling Webkit --wincairo

2018-04-19 Thread Michael Catanzaro
On Thu, Apr 19, 2018 at 9:24 AM, Barone Ashura wrote: Can someone give me some hints on how to better control the output of the build process? I would just use CMake directly, so you won't need to deal with build-webkit getting in the way. That script is not really

Re: [webkit-dev] python2

2018-04-11 Thread Michael Catanzaro
OK then... this won't be fun, but we'll just have to make the scripts support both major versions of python. At least the scripts we use during the build, and use ourselves... and the ones that are tested by test-webkitpy... oh boy. Michael ___

[webkit-dev] python2

2018-04-10 Thread Michael Catanzaro
Hi, python2 end of life is January 1, 2020. But even before then, we'll need to make WebKit work in environments without python2 available, because it's not going to be present in the next Red Hat Enterprise Linux or SUSE Linux Enterprise, and its fate in community distros like Fedora (where

Re: [webkit-dev] C++17 is here. Should we use it?

2018-03-26 Thread Michael Catanzaro
On Fri, Mar 23, 2018 at 4:32 PM, JF Bastien wrote: Hello again WebKitten! April 2018 is fast approaching, which means that we might be able to require GCC 6 and all the great C++17 features that’ll come with it. So what say you? From C++17 it looks like we wouldn’t get

Re: [webkit-dev] Using compile_command.json in sources that go into Unified Sources

2018-03-26 Thread Michael Catanzaro
On Sat, Mar 24, 2018 at 6:03 PM, Cadu Bentzen wrote: I included calling this script at the end of the build-webkit (under a command line option) script. So far it has work for me, but I wonder if this is the right approach or if you already solved that in another way.

  1   2   3   >