Re: [webkit-dev] Code Style: Opinion on returning void

2019-03-20 Thread Nico Weber
On Thu, Feb 21, 2019 at 12:31 PM Darin Adler wrote: > I tried not to weigh in on this, but my view on the materials we should > use to build the bike shed must be shared! > > Generally it seems neat to be able to make the code slightly more tight > and terse by merging the function call and the

Re: [webkit-dev] WebCore/platform standalone library

2015-03-20 Thread Nico Weber
On Fri, Mar 20, 2015 at 9:56 AM, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the

Re: [webkit-dev] Ports not building as C++11?

2013-07-29 Thread Nico Weber
FYI: In gcc 4.7, things like foo%PRIuS are hard errors due to user-defined literals (it's a disablable warning in clang and gcc4.8, and gcc4.6 is fine since it doesn't implement user-defined literals yet), and some system headers (dbus1.0, dbus1.2, probably others) contain code like that. I'd

Re: [webkit-dev] Compiling WebKit up to 25% faster in Windows?

2013-03-27 Thread Nico Weber
On Wed, Mar 27, 2013 at 12:05 PM, Brent Fulgham bfulg...@gmail.com wrote: Hi Daniel, On Tue, Mar 26, 2013 at 11:21 AM, Daniel Bratell brat...@opera.comwrote: As an experiment we took the (chromium) project webcore_dom, that normally compiles in 56 seconds in Windows on a generic computer

Re: [webkit-dev] Compiling WebKit up to 25% faster in Windows?

2013-03-26 Thread Nico Weber
On Tue, Mar 26, 2013 at 4:51 PM, Daniel Bratell brat...@opera.com wrote: Den 2013-03-26 21:20:10 skrev Dirk Pranke dpra...@chromium.org: If we have consensus that we should just switch to paths relative to Source (or maybe a couple different options), that would be (IMO) a big win. It

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2013-02-26 Thread Nico Weber
On Tue, Jan 22, 2013 at 2:22 AM, Nico Weber tha...@chromium.org wrote: On Sat, Jan 12, 2013 at 9:49 PM, Nico Weber tha...@chromium.org wrote: On Tue, Dec 11, 2012 at 3:43 PM, Eric Seidel e...@webkit.org wrote: Nevermind. After further discussion with Nico, this can't work yet. Ninja

Re: [webkit-dev] Removing ENABLE(WEB_INTENTS) code

2013-02-11 Thread Nico Weber
Going once, going twice… https://bugs.webkit.org/show_bug.cgi?id=109501 On Sat, Feb 2, 2013 at 3:09 PM, Sam Weinig wei...@apple.com wrote: Sounds good to me as well. -Sam On Jan 30, 2013, at 3:54 PM, Nico Weber tha...@chromium.org wrote: Hi, I'd like to delete all the ENABLE(WEB_INTENTS

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-05 Thread Nico Weber
http://www.haskell.org/haskellwiki/Wadlers_Law On Tue, Feb 5, 2013 at 12:16 PM, Eric Seidel e...@webkit.org wrote: I'm curious if YAML was ever considered? I have very limited experience with YAML, except for Google App Engine config files. It's very python parse-able? :) On Tue, Feb 5,

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-02-02 Thread Nico Weber
On Sat, Feb 2, 2013 at 4:58 PM, Adam Barth aba...@webkit.org wrote: Ninja has extremely fast incremental builds and can be generated by GYP. Here are some stats from a year ago: https://plus.google.com/101038813433650812235/posts/irc26fhRtPC Ninja has gotten even faster since then. If

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

2013-01-31 Thread Nico Weber
This is a lovely discussion to have every now and then :-) Maybe the file add/move/delete tool that someone wrote could land without xcode support for now? Then the pain of moving files is reduced to two systems (xcode and everyone else), and that's something that's at least tractable. Nico On

[webkit-dev] Removing ENABLE(WEB_INTENTS) code

2013-01-30 Thread Nico Weber
Hi, I'd like to delete all the ENABLE(WEB_INTENTS) code. As far as I know, nobody ever shipped this and nobody intents to. Please speak up if you'd like that code to stick around. Nico ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2013-01-21 Thread Nico Weber
On Sat, Jan 12, 2013 at 9:49 PM, Nico Weber tha...@chromium.org wrote: On Tue, Dec 11, 2012 at 3:43 PM, Eric Seidel e...@webkit.org wrote: Nevermind. After further discussion with Nico, this can't work yet. Ninja is currently configured to use a non-webkitty out build directory, which

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2013-01-12 Thread Nico Weber
On Tue, Dec 11, 2012 at 3:43 PM, Eric Seidel e...@webkit.org wrote: Nevermind. After further discussion with Nico, this can't work yet. Ninja is currently configured to use a non-webkitty out build directory, which is undoubtably going to confus some scripts/bots. We'll try this again at a

Re: [webkit-dev] Proposal: Make Ninja the default build-system for build-webkit --chromium

2012-12-10 Thread Nico Weber
On Mon, Dec 10, 2012 at 1:30 AM, Jochen Eisinger joc...@chromium.org wrote: Will the buildbots use ninja or the native build tools? My only concern is that we're catching problems with e.g. MSVS only after we roll the WebKit deps in chromium and one of the MSVS bots starts failing. The idea

Re: [webkit-dev] About text decoration wavy style implementation on Skia platform

2012-11-05 Thread Nico Weber
On Mon, Nov 5, 2012 at 5:18 AM, Bruno Abinader brunoabina...@gmail.com wrote: Hi all, I am implementing the CSS3 text decoration style wavy for Skia platform [3], and I would like to know a few things (please let me know if this is not the right mailing list to ask this): - There is already

Re: [webkit-dev] Pre-proposal: Adding a Coverity instance for WebKIt

2012-09-17 Thread Nico Weber
On Tue, Sep 18, 2012 at 8:11 AM, James Hawkins jhawk...@chromium.org wrote: Hey folks, TL;DR - If you have opinions one way or another about having a Coverity instance available for WebKit developers, please respond to this message. I don't have an opinion, but: Coverity is a static

[webkit-dev] ninja build available for chromium/mac, empty builds up to 20x as fast

2012-02-07 Thread Nico Weber
Hi, we recently made the webkit/chromium/mac port buildable with ninja, a new build system focused on build speed (http://martine.github.com/ninja/). I don't have any numbers for webkit standalone builds, but in a chromium checkout ninja is 20x as fast as make on empty builds (1s instead of 20s),

Re: [webkit-dev] chromium-cg-mac results

2012-01-03 Thread Nico Weber
Hi Adam, On Tue, Jan 3, 2012 at 3:00 PM, Adam Barth aba...@webkit.org wrote: Hi Elliot, It looks like Chromium Mac has successfully moved to Skia. I'd wait with this assessment until a version of Chrome with Skia has shipped to stable. Things are looking really good so that should be smooth

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-04 Thread Nico Weber
The chromium port still has a bot that runs tests (but doesn't build) on 10.5. Nico On Fri, Nov 4, 2011 at 3:20 PM, Eric Seidel e...@webkit.org wrote: Now that Apple has removed the Leopard build bot (and presumably stopped supporting WebKit on Leopard), all webkit platforms I know of have

Re: [webkit-dev] [chromium] make build for chromium/mac (build twice as fast!) clang for chromium/linux

2011-10-24 Thread Nico Weber
the make build, ld is now serialized by default, so you can just mv /usr/bin/real-ld back to /usr/bin/ld.) Nico On Fri, Oct 21, 2011 at 1:37 PM, Nico Weber tha...@chromium.org wrote: Hi, if you don't work on the chromium webkit port for mac or linux, you can stop reading now. Three

[webkit-dev] [chromium] make build for chromium/mac (build twice as fast!) clang for chromium/linux

2011-10-21 Thread Nico Weber
Hi, if you don't work on the chromium webkit port for mac or linux, you can stop reading now. Three announcements about stand-alone webkit/chromium checkouts: 1.) Chromium/mac is now compiled with clang instead of gcc by default. This happens automatically, you don't need to do anything (on

Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?

2011-09-09 Thread Nico Weber
Hi Eric, chromium's mac tryservers (which are similar to webkit's EWS) all build with svg disabled. Nico On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel e...@webkit.org wrote: I am interested in removing the ENABLE_SVG define, and all associated sub-defines ENABLE_SVG_ANIMATION

[webkit-dev] Git mirror out of sync?

2011-08-17 Thread Nico Weber
Hi, git fetch origin git log origin/master suggests that the git mirror stopped syncing at r93166. Can someone kick it? Thanks, Nico ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git mirror out of sync?

2011-08-17 Thread Nico Weber
just hangs, hard to tell why its broken dave On Wed, Aug 17, 2011 at 7:56 AM, Nico Weber tha...@chromium.org wrote: Hi,  git fetch origin git log origin/master suggests that the git mirror stopped syncing at r93166. Can someone kick it? Thanks, Nico

Re: [webkit-dev] commit-queue platform musical chairs

2011-06-08 Thread Nico Weber
I noticed that the commit-queue is a lot zippier now. Thanks! Nico On Wed, Jun 8, 2011 at 1:57 PM, Adam Barth aba...@webkit.org wrote: Update: The new commit-queue nodes run about 6x faster than the old nodes (wow).  We're now fully switched over and have re-allocated the Mac Minis to the

Re: [webkit-dev] Build system update

2011-04-25 Thread Nico Weber
On Fri, Mar 25, 2011 at 10:59 AM, Maciej Stachowiak m...@apple.com wrote: In addition to your comments, I also find the gyp syntax somewhat unpleasant. In particular, in .gypi lists of files to compile, ever entry is double-quoted, comma-separated, line-separated, and then grouped in

Re: [webkit-dev] Bools are strictly worse than enums

2010-12-03 Thread Nico Weber
On Fri, Dec 3, 2010 at 1:45 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Dec 3, 2010 at 1:37 PM, David Hyatt hy...@apple.com wrote: The only exception I would make to this rule is if all the call sites use variables and never pass in raw true or false.  In that case there's no loss of

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Nico Weber
On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly your tessellation logic works and what it is intended to do. For instance, is the algorithm you're using based on Loop-Blinn?

Re: [webkit-dev] Accelerated 2D Tesselation Implementation

2010-08-27 Thread Nico Weber
On Fri, Aug 27, 2010 at 10:51 AM, Chris Marrin cmar...@apple.com wrote: On Aug 27, 2010, at 10:32 AM, Nico Weber wrote: On Fri, Aug 27, 2010 at 10:18 AM, Chris Marrin cmar...@apple.com wrote: Hi Ken, It would help me, and I think many others, if we could have a discussion of how exactly

Re: [webkit-dev] style question for empty for loops

2010-08-26 Thread Nico Weber
On Thu, Aug 26, 2010 at 11:49 AM, Darin Adler da...@apple.com wrote: On Aug 26, 2010, at 11:35 AM, Chris Fleizach wrote:     for (...; ...; ...) { } This seems OK.     for (...; ...; ...)     { } The above is definitely not allowed, because braces go on the line with the for. The

Re: [webkit-dev] Not enough space message when linking webkit (lots of free disk space)

2010-08-22 Thread Nico Weber
Are you using a 32 bit linker? Maybe it's running out of address space. Nico On Sun, Aug 22, 2010 at 12:32 PM, Chris Hatko cha...@gmail.com wrote: I'm running revision 65648  and building cairo-win32 release I'm getting Not enough space when linking WebKit project. I have 40Gig free space on

Re: [webkit-dev] CMake as a build system?

2010-04-16 Thread Nico Weber
This is from an earlier thread on this issue on webkit-dev: We also considered CMake, and had it demonstrably working for some of our smaller projects as well. Unfortunately, transitioning to CMake would have required moving everything over at once, without allowing for some existing projects