Re: [webkit-dev] When should I use AtomicString vs String?

2013-05-31 Thread Rafael Brandao
This thread contains really useful information, so I've created a new topic
on https://trac.webkit.org/wiki/EfficientStrings and pointed to here.

Best regards,
Rafael


On Fri, May 31, 2013 at 8:32 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We shouldn't use AtomicString if the string we're about to create doesn't
 get shared across multiple AtomicStrings.

 For example, if we had used AtomicString for the strings inside Text
 nodes, then we may end up filling up the atomic string table with all these
 really long strings that don't typically appear more than once.  It also
 slows down the hash map look up for all other atomic strings.

 On Fri, May 31, 2013 at 3:00 PM, Brendan Long s...@brendanlong.comwrote:

  So should I just never use String and always use AtomicString?


 On 05/31/2013 03:14 PM, Daker Pinheiro wrote:

 It is faster to compare and hash AtomicString than regular Strings.


 On Fri, May 31, 2013 at 5:57 PM, Brendan Long s...@brendanlong.comwrote:

 I hope this isn't a stupid question, but I can't find any references to
 what the difference between AtomicString and String is. It looks like
 AtomicString is generally preferred, but I don't know why. Can someone
 fill me in on this? Is there any refences for the classes in WTF?


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




  --
 Daker Fernandes Pinheiro
 http://codecereal.blogspot.com



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Getting started with making Qt WebKit patches

2013-03-25 Thread Rafael Brandao
You're probably missing subversion package. If you're on ubuntu, sudo
apt-get install subversion should do the trick.

On Mon, Mar 25, 2013 at 12:00 PM, Sze Howe Koh szehowe@gmail.comwrote:

 Hello,

 I'm trying to submit a patch for Qt WebKit. I've applied the patch to
 my local copy of qtwebkit.git, but am having trouble using
 webkit-patch. What am I missing?

 I'm running Windows 8 x64, Git version 1.8.0.msysgit.0, and
 ActivePython 2.7.2 x64. From Git Bash, I called
 `Tools/Scripts/webkit-patch prepare --cc=hausm...@webkit.org'

 I got the error message below, but am not told what file the script is
 unable to find. I tried it with my changes uncommitted and committed,
 but got the same result.

 ==
 Traceback (most recent call last):
   File Tools/Scripts/webkit-patch, line 84, in module
 main()
   File Tools/Scripts/webkit-patch, line 79, in main
 WebKitPatch(os.path.abspath(__file__)).main()
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\multicommandtool.py,
 line 304, in main
 self.handle_global_options(options)
   File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\tool\main.py,
 line 94, in handle_global_options
 self.initialize_scm(options.patch_directories)
   File c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\host.py,
 line 132, in initialize_scm
 self._scm = detector.default_scm(patch_directories)
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py,
 line 55, in default_scm
 scm_system = self.detect_scm_system(cwd, patch_directories)
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\detection.py,
 line 71, in detect_scm_system
 if SVN.in_working_directory(absolute_path, executive=self._executive):
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\checkout\scm\svn.py,
 line 93, in in_working_directory
 exit_code = executive.run_command(svn_info_args, cwd=path,
 return_exit_code=True)
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py,
 line 405, in run_command
 close_fds=self._should_close_fds())
   File
 c:\Qt\git\5.x.y\qtwebkit\Tools\Scripts\webkitpy\common\system\executive.py,
 line 461, in popen
 return subprocess.Popen(*args, **kwargs)
   File c:\Python27\lib\subprocess.py, line 679, in __init__
 errread, errwrite)
   File c:\Python27\lib\subprocess.py, line 893, in _execute_child
 startupinfo)
 WindowsError: [Error 2] The system cannot find the file specified

 ==

 Running Tools/Scripts/prepare-ChangeLog worked ok, but I was under the
 impression that webkit-patch is preferred as it automates a lot more
 aspects of the workflow (is that correct?)

 Thanks in advance for your guidance.


 Regards,
 Sze-Howe
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Rafael Brandao
This also happened to me, quite annoying. :-(
I've followed the thread
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/YpKL4xiJHPQ
and
did the following:
editing .gitattributes to disable the eol=crlf flag for .sln files, then
doing a reset/checkout, then un-editing .gitattributes.


On Thu, Feb 14, 2013 at 6:45 AM, John Yani van...@gmail.com wrote:

 Checkout this link:
 https://help.github.com/articles/dealing-with-line-endings

 I don't know what the webkit convention is when dealing with line-endings,
 but you may want to make sln files to always have crlf line-ending.

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Allan Sandfeld Jensen is now a WebKit reviewer!

2012-12-21 Thread Rafael Brandao
Congrats Allan! :-)

On Fri, Dec 21, 2012 at 1:09 PM, Turcotte Jocelyn 
jocelyn.turco...@digia.com wrote:

   Before joining WebKit a year ago, Allan was spending some of his free
 time hacking on KHTML. Since then he has been contributing in various areas
 of the Qt port, WebKit2 and WebCore, including touch adjustment and hit
 testing.

 Please join me in congratulating Allan on his new role as a
 WebKit reviewer!
 - Jocelyn

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-11-09 Thread Rafael Brandao
I've just submitted a patch for this issue (bug
90823https://bugs.webkit.org/show_bug.cgi?id=90823).
I'm also a shameless printfer and I believe the project could benefit with
such debugging helpers.
I've decided to isolate the debug definitions in a single place, so instead
of adding alien code on IntRect to teach him how to debug, they're all in
DebugHelpers.cpp/.h. This code is also protected by ENABLE(DEBUG_HELPERS)
so people could keep things untouched if they want to.

Instead of putting it in WTF like the original proposal, I've put into
WebCore. The reasoning behind it was a cyclic dependency over
WTF and WebCore that would be introduced if I've tried to isolate things in
a single place in WTF (for example, there in WTF I would need to include
WebCore's IntRect, which is most likely wrong).

Regards,

-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-11-09 Thread Rafael Brandao
You're right. Do you have any consensus of which approach is the best?
I'd go with the overloads in a single file, as each one of them are likely
inline, and  this would make easier to add overloads.

On Fri, Nov 9, 2012 at 2:33 PM, Maciej Stachowiak m...@apple.com wrote:


 You could either put the code in the headers for the relevant classes, or
 the base mechanism in WTF and specific overloads in a catchall header for
 WebCore. You don't have to put the basic mechanism in WebCore just to have
 overloads for WebCore types.

  - Maciej


 On Nov 9, 2012, at 9:29 AM, Rafael Brandao rafael.l...@openbossa.org
 wrote:

 I was just trying to avoid adding code on other places, and it seemed
 wrong to include WebCore files inside WTF.
 If there's no problem on changing other files (like IntRect, IntSize,
 etc.), I have no problem with moving the appropriate overload around
 ENABLE(DEBUG_HELPERS).

 Regards,

 On Fri, Nov 9, 2012 at 2:19 PM, Filip Pizlo fpi...@apple.com wrote:

 I like this patch.

 But I don't quite see why this couldn't live in WTF.  It would certainly
 be useful from places in JSC and WTF, so it would be unfortunate if this
 was WebCore-only.  And I don't see the circular dependency.  And if you
 wanted to have a wtfPrint() for IntRect, then couldn't you put the
 appropriate overload(s) in IntRect's header file?

 -F



 On Nov 9, 2012, at 6:18 AM, Rafael Brandao rafael.l...@openbossa.org
 wrote:

 I've just submitted a patch for this issue (bug 
 90823https://bugs.webkit.org/show_bug.cgi?id=90823).
 I'm also a shameless printfer and I believe the project could benefit with
 such debugging helpers.
 I've decided to isolate the debug definitions in a single place, so
 instead of adding alien code on IntRect to teach him how to debug, they're
 all in
 DebugHelpers.cpp/.h. This code is also protected by ENABLE(DEBUG_HELPERS)
 so people could keep things untouched if they want to.

 Instead of putting it in WTF like the original proposal, I've put into
 WebCore. The reasoning behind it was a cyclic dependency over
 WTF and WebCore that would be introduced if I've tried to isolate things
 in a single place in WTF (for example, there in WTF I would need to include
 WebCore's IntRect, which is most likely wrong).

 Regards,

 --
 Rafael Brandao @ INdT
  ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev





 --
 Rafael Brandao @ INdT
  ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev





-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] New WebKit Reviewer: Caio Marcelo de Oliveira Filho

2012-10-08 Thread Rafael Brandao
Congratulations Caio! :-)

Regards,
Rafael

On Mon, Oct 8, 2012 at 6:20 PM, noam.rosent...@nokia.com wrote:

 I am pleased to announce that Caio (@cmarcelo) is now a WebKit reviewer.
 Caio has been working in many areas in the past years, starting with focus
 on the Qt port with improvements to the Qt/JS bridge, font test results and
 render-theme.
 More recently has also work on the UndoManager and other aspects of
 editing code and CSS parsing, his latest contributions being around WTF
 HashMap iterators.
 Since Caio has been involved in so many parts of WebKit, I'm probably
 forgetting a few other contributions...

 Please join me in congratulating Caio for his new reviewer status!
 No'am
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] trac.webkit.org timeline broken

2012-07-30 Thread Rafael Brandao
I've just got it with http://trac.webkit.org/changeset/124114 - it says No
changeset 124114 in the repository.
I've never seen this before.

On Mon, Jul 30, 2012 at 5:49 PM, Ryosuke Niwa rn...@webkit.org wrote:

 It appears that this error occurs when you access the revision that's yet
 to be included by trac. Try accessing a revision immediately after it's
 committed (~10 seconds).


 On Mon, Jul 30, 2012 at 1:45 PM, William Siegrist wsiegr...@apple.comwrote:

 Are you still getting these? I've yet to reproduce it and I am not seeing
 much in the logs.

 -Bill


 On Jul 29, 2012, at 3:04 PM, Ryosuke Niwa rn...@webkit.org wrote:

  Now I'm getting errors like the one below:
  Traceback (most recent call last):
File /usr/lib/python2.6/site-packages/trac/web/api.py, line 441, in
 send_error
  data, 'text/html')
File /usr/lib/python2.6/site-packages/trac/web/chrome.py, line 828,
 in render_template
  message = req.session.pop('chrome.%s.%d' % (type_, i))
File /usr/lib/python2.6/site-packages/trac/web/api.py, line 216, in
 __getattr__
  value = self.callbacks[name](self)
File /usr/lib/python2.6/site-packages/trac/web/main.py, line 309,
 in _get_session
  return Session(self.env, req)
File /usr/lib/python2.6/site-packages/trac/web/session.py, line
 212, in __init__
  self.get_session(req.authname, authenticated=True)
File /usr/lib/python2.6/site-packages/trac/web/session.py, line
 228, in get_session
  super(Session, self).get_session(sid, authenticated)
File /usr/lib/python2.6/site-packages/trac/web/session.py, line 62,
 in get_session
  cursor = db.cursor()
File /usr/lib/python2.6/site-packages/trac/db/postgres_backend.py,
 line 258, in cursor
  return IterableCursor(self.cnx.cursor(), self.log)
  InterfaceError: connection already closed
 
 
 
  On Sat, Jul 28, 2012 at 5:40 PM, William Siegrist wsiegr...@apple.com
 wrote:
  Its fixed.
 
  -Bill
 
 
  On Jul 28, 2012, at 5:37 PM, Simon Fraser simon.fra...@apple.com
 wrote:
 
  I sent email to Bill Siegrist about this earlier.
 
  Simon
 
  On Jul 28, 2012, at 5:24 PM, Peter Kasting wrote:
 
  The Trac timeline doesn't seem to have updated since last night.
  It's missing about 15 commits right now.  Trying to link to one of these
 -- e.g. http://trac.webkit.org/changeset/123971 -- doesn't work.
 
  Not sure to whom to direct this problem.
 
  PK
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo/webkit-dev
 
 



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] can we stop using Skipped files?

2012-06-08 Thread Rafael Brandao
I'm all for getting rid of ORWT. I've observed some wrong code paths there
that are probably not even used anymore. It makes more difficult to hack on
a code which almost nobody uses and whose part of it is wrong and
misleading.

NRWT is not that easy thought, but I see the unittests as an improvement.
So we can keep the same standard of the rest of webkit contributions of
writing a test to keep the behavior you're introducing.

I would like to help on removing qt dependency of ORWT.

Regards,

On Fri, Jun 8, 2012 at 4:15 PM, Dirk Pranke dpra...@chromium.org wrote:

 Hi Ossy,

 Thanks for your reply ...

 On Fri, Jun 8, 2012 at 12:46 AM, Osztrogonac Csaba o...@inf.u-szeged.hu
 wrote:
  Hi,
 
  Dirk Pranke írta:
 
  I believe most if not all of the ports have started using either
  TestExpectations files or a combination of TestExpectations files
  (except for the Apple Win port).
 
  Can we explicitly switch to the TestExpectations files at this point
  and drop support for Skipped files on the other ports (and perhaps
  disable old-run-webkit-tests for all but apple win)?
 
 
  Until NRWT can't handle cascaded TestExpectations -
  https://bugs.webkit.org/show_bug.cgi?id=65834,
  Qt port can't drop supporting Skipped files. We have many tests skipped
 in
  qt-5.0, qt-5.0-wk1,
  qt-5.0-wk2, wk2 Skipped lists. We can't migrate all of them to the only
 one
  TestExpectations.
 

 Sorry, you're right, I should have mentioned that we would need to
 support cascaded files before we can do anything. As Ojan mentioned, I
 am actively working on that.

 One thing that would be helpful would be to how each port would like
 to support using cascading files and modifiers. Assuming each of you
 is free to do as you like, you can pick from several paths, e.g. you
 could use one file, or one file per operating system, or one file per
 os plus one file per version plus maybe a webkit-2 specific file
 (roughly what most ports do today, I think), or something else?


  And I disagree with disabling ORWT at all. Qt port still support using
 ORWT
  locally.
  It is better for gardening than NRWT. NRWT regularly has problems with
  generating
  new results for a given platform dir (qt,qt-5.0,qt-5.0-wk1,...), it
 doesn't
  support
  the good --skipped=only option .

 I am not aware of these issues ... can you explain further, or file
 bugs? In particular, I'm not sure I fully understand how all of the
 different Qt version/platform combinations work, so maybe there are
 issues there that can be improved?

 If ORWT is easier for you to use than NRWT, I would love to understand
 why, so that hopefully I can improve NRWT for you as well.

  If folks don't want to use it, just not use, but disabling for everyone
 by fiat isn't a friendly thing.

 I'm sorry, I was under the impression that no one (apart from Apple
 Win) was using ORWT any more, and I thought we had reached feature
 parity between the two tools (or at least that NRWT supported
 everything that ORWT did, obviously ORWT doesn't support reftests or a
 bunch of other things that NRWT does).

 I'm not about to remove a tool that people are still using :). That
 said, having two tools that are both widely used and do essentially
 the same thing is unfortunate, so it would be good to converge
 where/when/if we can, I think.

 -- Dirk
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev