Yeah, I think it's important to clarify that nobody is "using non-Unified-Source building for their development", at least to my knowledge. Being broken by the shifting sands of unified sources is an everybody problem (or at the very least an "everybody that builds via CMake problem", which is ultimately an everybody problem).
Ross ________________________________ From: Alex Christensen via webkit-dev <webkit-dev@lists.webkit.org> Sent: Thursday, April 29, 2021 11:03 AM To: Darin Adler <da...@apple.com> Cc: webkit-dev@lists.webkit.org <webkit-dev@lists.webkit.org> Subject: Re: [webkit-dev] New EWS Non-Unified builder I don’t see the goal as “keep non-Unified-Source building” but rather “prevent unrelated build fixes when we add another file later”. Right now when we add a new file we often have to sprinkle includes, declarations, and other build fixes in files unrelated to the current change. If we had a bot building without unification we would be informed at the time we write the problematic code. > On Apr 29, 2021, at 9:55 AM, Darin Adler via webkit-dev > <webkit-dev@lists.webkit.org> wrote: > > Given the issue is that there are people that are using non-Unified-Source > building for their development, the best fix is to add post-commit and EWS > builders for one of those platforms. I do not support the idea of adding an > additional builder just to “keep non-Unified-Source building” if no > actively-supported platform is not choosing that build style. > > Specifically, if Sony people are most affected by this, I suggest we find a > way to add Sony PlayStation post-commit and EWS builders. > > I am not convinced that we should add some kind of abstract “correct > compilation” that is a separate builder. > > — Darin > _______________________________________________ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev _______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
