Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Ryan Haddad

> On Jun 18, 2020, at 9:44 AM, Alex Christensen  wrote:
> 
> It sounds to me like Mark’s suggestion does not lose anything.  It’s just for 
> JSC “Debug”

The post-commit JSC bots use the same build products as the other debug 
testers, so with our current setup it would have to apply to other queues as 
well.

Ryan

> which currently is not running because it’s too slow.  If he called it 
> “ReleaseWithAssert” it would make it more clear what is going on and we would 
> all appreciate the additional information those bots provide.
> 
>> On Jun 17, 2020, at 9:48 PM, Simon Fraser > > wrote:
>> 
>> I also object to losing good stack traces for crashes on Debug bots.
>> 
>> Also, I don't think Debug bots should build something different from what I 
>> build at my desk.
>> 
>> Simon
>> 
>>> On Jun 17, 2020, at 1:36 PM, Mark Lam >> > wrote:
>>> 
>>> Hi folks,
>>> 
>>> We're planning to switch the JSC EWS bot and build.webkit.org 
>>>  Debug build and test bots to building with the 
>>> following set first:
>>> ./Tools/Scripts/set-webkit-configuration --force-opt=O3
>>> 
>>> This means the Debug builds will be built with optimization level forced to 
>>> O3.
>>> 
>>> Why are we doing this?
>>> 1. So that the JSC EWS will start catching ASSERT failures.
>>> 2. JSC stress test Debug bots have been timing out and not running tests at 
>>> all.  Hopefully, this change will fix this issue.
>>> 3. Tests will run to completion faster and we’ll catch regressions sooner.
>>> 
>>> The downside: crash stack traces will be like Release build stack traces.  
>>> But I don’t think we should let this deter us.  It’s not like there’s no 
>>> stack information.  And just as we do with debugging Release build test 
>>> failures, we can always do a Debug build locally to do our debugging.
>>> 
>>> We would like to apply this change to all Debug build and test bots, not 
>>> just the JSC ones.  Does anyone strongly object to this change?
>>> 
>>> Thanks.
>>> 
>>> Cheers,
>>> Mark
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org 
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] EWS down, investigating in progress

2019-03-28 Thread Ryan Haddad
Service has been restored. Please let us know if you continue to experience any 
issues.

Ryan

> On Mar 28, 2019, at 7:58 AM, Lucas Forschler  wrote:
> 
> https://webkit-queues.webkit.org  appears 
> to be offline. We are investigating.
> 
> Lucas
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-06 Thread Ryan Haddad
Chris,

I'm assuming that this is in reference to the patch in 
https://bugs.webkit.org/show_bug.cgi?id=192373 
. My guess is that something 
about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing 
an issue with unified sources.

The commit-queue itself has been landing other patches without issue and the 
build isn't broken on trunk bots. CC'ing Tim in case he can help point out the 
issue.

Ryan

> On Dec 6, 2018, at 3:55 PM, Chris Fleizach  wrote:
> 
> Hi
> 
> Looks like Commit Queue is blocked on processing patches because of a build 
> failure that's been there for a day
> 
> --
> https://webkit-queues.webkit.org/results/10296999 
> 
> In file included from 
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
> In file included from 
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:27:
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:229:40: 
> error: unknown type name 'SafeBrowsingWarning'; did you mean 
> 'WKSafeBrowsingWarning'?
> void showSafeBrowsingWarning(const SafeBrowsingWarning&, 
> CompletionHandler&&)>&&);
>^~~
>WKSafeBrowsingWarning
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:56:12: 
> note: 'WKSafeBrowsingWarning' declared here
> OBJC_CLASS WKSafeBrowsingWarning;
>^
> In file included from 
> /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1619:19:
>  error: out-of-line definition of 'showSafeBrowsingWarning' does not match 
> any declaration in 'WebKit::WebViewImpl'
> void WebViewImpl::showSafeBrowsingWarning(const SafeBrowsingWarning& warning, 
> CompletionHandler&&)>&& 
> completionHandler)
>   ^~~
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2801:22:
>  error: instance method '-dismiss' not found (return type defaults to 'id') 
> [-Werror,-Wobjc-method-access]
> [_shareSheet dismiss];
>  ^~~
> -
> 
> Filed a bug to track: https://bugs.webkit.org/show_bug.cgi?id=192479 
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] EWS queue "mac" seems stuck

2017-11-22 Thread Ryan Haddad
I got a couple of them back online. They are working through the backlog now.

Ryan

> On Nov 22, 2017, at 9:47 AM, Darin Adler  wrote:
> 
> Does anyone know how to get the “mac” EWS queue unstuck? It does not seem to 
> be processing patches.
> 
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev