Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

2022-11-17 Thread Ryosuke Niwa via webkit-dev
> On Nov 17, 2022, at 2:46 PM, Michael Catanzaro wrote: > > On Thu, Nov 17 2022 at 02:41:35 PM -0800, Ryosuke Niwa > wrote: >> We don´t want a description of what PR is; that´s obvious from diff. We want >> a description of why that PR fixes the bug. > > Probl

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

2022-11-17 Thread Ryosuke Niwa via webkit-dev
> On Nov 17, 2022, at 2:37 PM, Michael Catanzaro via webkit-dev > wrote: > > On Thu, Nov 17 2022 at 12:23:54 PM -0800, David Kilzer via webkit-dev > wrote: >> Any feedback on this change? > > We could alternatively say "Explanation of this change (OOPS!)" or > "Explanation of this commit

Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

2022-11-17 Thread Ryosuke Niwa via webkit-dev
> On Nov 17, 2022, at 12:23 PM, David Kilzer via webkit-dev > wrote: > > The following PR adds placeholder text in the commit log template to remind > authors to explain why a change fixes a bug: > > Bug 248012: Update commit message template to request a brief explanation of > why a PR

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

2022-10-05 Thread Ryosuke Niwa via webkit-dev
I do prefer for (;;) because of less typing but if the existing code mostly uses while (true) then we should go with it. > On Oct 5, 2022, at 8:58 PM, Yusuke Suzuki via webkit-dev > wrote: > > +1 > > -Yusuke > >> On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev >> wrote: >> >> Hi

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

2022-09-29 Thread Ryosuke Niwa via webkit-dev
> On Sep 29, 2022, at 5:26 PM, Jonathan Bedard wrote: > >> On Sep 29, 2022, at 4:28 PM, Ryosuke Niwa wrote: >> >>> On Sep 29, 2022, at 11:48 AM, Jonathan Bedard via webkit-dev >>> mailto:webkit-dev@lists.webkit.org>> wrote: >>>

Re: [webkit-dev] webkit-dev Digest, Vol 208, Issue 5

2022-09-29 Thread Ryosuke Niwa via webkit-dev
> On Sep 29, 2022, at 11:48 AM, Jonathan Bedard via webkit-dev > wrote: > > >>> On Sep 20, 2022, at 1:52 PM, Brent Fulgham wrote: >>> >>>> On Sep 20, 2022, at 1:16 AM, Ryosuke Niwa via webkit-dev >>>> wrote: >>>>

Re: [webkit-dev] WebKit Documentation

2022-09-21 Thread Ryosuke Niwa via webkit-dev
> On Sep 21, 2022, at 6:50 AM, Michael Catanzaro wrote: > > On Tue, Sep 20 2022 at 08:03:12 PM -0700, Ryosuke Niwa via webkit-dev > wrote: >> (2) is particularly important because many people who are new to WebKit >> often don´t know what they don´t know. This is

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Ryosuke Niwa via webkit-dev
> On Sep 20, 2022, at 1:52 PM, Brent Fulgham wrote: > >> On Sep 20, 2022, at 1:16 AM, Ryosuke Niwa via webkit-dev >> wrote: >> >>> On Sep 19, 2022, at 2:28 PM, Brandon Stewart via webkit-dev >>> mailto:webkit-dev@lists.webkit.org>> wrote: &g

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Ryosuke Niwa via webkit-dev
> On Sep 20, 2022, at 6:04 AM, Michael Catanzaro wrote: > > On Tue, Sep 20 2022 at 01:16:53 AM -0700, Ryosuke Niwa via webkit-dev > wrote: >> I´ve been working on >> https://github.com/WebKit/WebKit/blob/main/Introduction.md for the past >> couple of years

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Ryosuke Niwa via webkit-dev
> On Sep 19, 2022, at 2:58 PM, Michael Catanzaro via webkit-dev > wrote: > > Why not double-down on the GitHub wiki? It's very easy to learn to use, and > there are edit buttons everywhere so there is no "distance" between the docs > and the ability to edit them. The easier it is to edit

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Ryosuke Niwa via webkit-dev
> On Sep 19, 2022, at 2:28 PM, Brandon Stewart via webkit-dev > wrote: > > Documentation is an important part of any open source project, especially for > a larger project like WebKit. Being able to ramp up during the onboarding > process, reading up on architectural decisions, and learning

Re: [webkit-dev] WebKit Documentation

2022-09-20 Thread Ryosuke Niwa via webkit-dev
> On Sep 19, 2022, at 4:48 PM, Fujii Hironori via webkit-dev > wrote: > > Why not double-down on WebKit Git repository? > The closer the document is to the source code, the easier to keep them > up-to-date. > We can modify both the source code and the document in a single commit > through

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-09-08 Thread Ryosuke Niwa via webkit-dev
> On Sep 8, 2022, at 5:41 AM, Adrian Perez de Castro via webkit-dev > wrote: > On Thu, 08 Sep 2022 02:27:53 + Alexey Proskuryakov via webkit-dev > wrote: >> Without non-unified EWS, or anyone fixing non-unified build manually: >> - a smaller number of patches gets rejected for breaking

[webkit-dev] Goal of Fixing non-Unified Build Failures (Was Deployment of new EWS Non-Unified builder)

2022-09-07 Thread Ryosuke Niwa via webkit-dev
> There is no such thing as "not maintaining the non-unified build"; there > never has been. We have covered that this is an *inherent* problem in a > unified build mechanism and that this would be an issue even if Mac were the > only platform. It appears to me that we’re lacking the clarify

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-02 Thread Ryosuke Niwa via webkit-dev
On Thu, Jun 2, 2022 at 4:28 AM Claudio Saavedra via webkit-dev wrote: > > On Wed, 2022-06-01 at 16:39 -0700, Ryosuke Niwa via webkit-dev wrote: > > One day per month for one beginner sounds like a really low > > maintenance cost compared to having every WebKit developer fi

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-01 Thread Ryosuke Niwa via webkit-dev
On Wed, Jun 1, 2022 at 16:10 Kirsling, Ross via webkit-dev < webkit-dev@lists.webkit.org> wrote: > I feel like this has been discussed adequately in the past, but one more > time for good measure: > > Any two platforms which don't build the exact same set of files will > undergo unification

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Ryosuke Niwa via webkit-dev
On Wed, May 11, 2022 at 08:12 Chris Dumez wrote: > > On May 11, 2022, at 12:13 AM, Ryosuke Niwa via webkit-dev < > webkit-dev@lists.webkit.org> wrote: > > On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote: > > > > On Tue, May 10, 2022 at 20:36 Chris Dumez wrot

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Ryosuke Niwa via webkit-dev
On Tue, May 10, 2022 at 10:04 PM Chris Dumez wrote: > > On May 10, 2022, at 9:27 PM, Ryosuke Niwa wrote: >> >> Well, that's precisely my use case. I don't even write a patch in a pure >> Subversion checkout anymore these days. > > Also, I didn’t fully underst

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-11 Thread Ryosuke Niwa via webkit-dev
On Tue, May 10, 2022 at 9:27 PM Ryosuke Niwa wrote: > > > On Tue, May 10, 2022 at 20:36 Chris Dumez wrote: >> >> [Not sure why Apple Mail sent Ryosuke’s replies to the Junk folder but I >> finally noticed.] > > > It's something to do with @webkit.org not bein

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-10 Thread Ryosuke Niwa via webkit-dev
On Tue, May 10, 2022 at 3:01 PM Jonathan Bedard via webkit-dev wrote: > > > On May 10, 2022, at 2:46 PM, Geoffrey Garen wrote: > > > > Do I undertand correctly that the proposal here is > > > > (a) Immediately Deprecate ChangeLogs > > Yes > > > (b) Immediately end support for posting

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

2022-05-10 Thread Ryosuke Niwa via webkit-dev
I don't think we should this. We haven't even had enough discussions about whether we want to deprecate change logs or not. On Tue, May 10, 2022 at 13:32 Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > A few weeks ago, I started a discussion about deprecating ChangeLogs.

Re: [webkit-dev] Introduction.md: JS wrapper & Node lifecycle management

2022-05-07 Thread Ryosuke Niwa via webkit-dev
Sorry, I broke the link for DOM nodes due to a typo. See https://github.com/WebKit/WebKit/blob/main/Introduction.md#reference-counting-of-dom-nodes On Sat, May 7, 2022 at 11:05 AM Ryosuke Niwa wrote: > > Hi all, > > I've recently written up an overview of how the lifecycle of

[webkit-dev] Introduction.md: JS wrapper & Node lifecycle management

2022-05-07 Thread Ryosuke Niwa via webkit-dev
Hi all, I've recently written up an overview of how the lifecycle of JS wrappers and DOM nodes are managed in

Re: [webkit-dev] ChangeLog Deprecation Plan

2022-04-25 Thread Ryosuke Niwa via webkit-dev
On Mon, Apr 25, 2022 at 9:49 AM Jonathan Bedard via webkit-dev wrote: > > .. or robust solution. Bots need maintenance and intervention, and a bot with > commit access has another set of issues. Repository admins occasionally > rotating ChangeLogs is going to be less expensive than a bot doing

Re: [webkit-dev] ChangeLog Deprecation Plan

2022-04-19 Thread Ryosuke Niwa via webkit-dev
On Tue, Apr 19, 2022 at 9:33 AM Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > > To: Jonathan Bedard > > Cc: WebKit Development > > Subject: Re: [webkit-dev] ChangeLog Deprecation Plans > > Message-ID: > > <

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-18 Thread Ryosuke Niwa via webkit-dev
On Mon, Apr 18, 2022 at 18:50 Fujii Hironori via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > On Tue, Apr 19, 2022 at 6:55 AM Yusuke Suzuki via webkit-dev < > webkit-dev@lists.webkit.org> wrote: > >> I think this is important. We are using commit message / ChangeLog as a >> document tied

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-18 Thread Ryosuke Niwa via webkit-dev
On Mon, Apr 18, 2022 at 13:34 Ryosuke Niwa wrote: > > On Mon, Apr 18, 2022 at 08:30 Jonathan Bedard via webkit-dev < > webkit-dev@lists.webkit.org> wrote: > >> As we migrate WebKit from Subversion to git, I would like to migrate the >> project aw

Re: [webkit-dev] ChangeLog Deprecation Plans

2022-04-18 Thread Ryosuke Niwa via webkit-dev
On Mon, Apr 18, 2022 at 8:30 AM Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > As we migrate WebKit from Subversion to git, I would like to migrate the > project away from ChangeLogs. The reason for this is that ChangeLogs make > some of the features of git hard to use,

Re: [webkit-dev] GitHub Labels

2022-03-10 Thread Ryosuke Niwa via webkit-dev
On Thu, Mar 10, 2022 at 10:49 AM Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > Hey folks, > > We’re in the final stage of bringing up support for GitHub pull-requests. > To support this effort, we’re starting to add labels to our project. We > intend to use labels as a

Re: [webkit-dev] Great function for Cocoa platform, bridge_cast

2022-02-16 Thread Ryosuke Niwa via webkit-dev
On Wed, Feb 16, 2022 at 6:13 AM Darin Adler wrote: > I think of it as following the same naming pattern as downcast<> or > static_cast<>, but you don’t have to specify a template argument since it > infers it for you. > I guess the closer analogy might be with const_cast, which does the "right

Re: [webkit-dev] Great function for Cocoa platform, bridge_cast

2022-02-15 Thread Ryosuke Niwa via webkit-dev
On Tue, Feb 15, 2022 at 9:44 AM Darin Adler via webkit-dev < webkit-dev@lists.webkit.org> wrote: > For those of you doing work with Objective-C on Cocoa platforms, I want to > draw your attention to a great new idiom. Back in October, David Kilzer > added bridge_cast, a type-safe set of functions

Re: [webkit-dev] OK to flatten WTF's header directory?

2022-02-01 Thread Ryosuke Niwa via webkit-dev
On Tue, Feb 1, 2022 at 12:30 PM Elliott Williams via webkit-dev < webkit-dev@lists.webkit.org> wrote: > I’m working on fixing some ambiguities in our Xcode projects to permit > adoption of Xcode’s new build system and better parallelize our builds. I > noticed that WTF’s headers

Re: [webkit-dev] WPT first test policy proposal

2021-11-23 Thread Ryosuke Niwa via webkit-dev
On Fri, Nov 19, 2021 at 1:06 PM Tim Nguyen via webkit-dev < webkit-dev@lists.webkit.org> wrote: > Hello everyone, > > I would like to start a discussion on a policy to enforce WPT usage as a > first choice, that would be enforced via check-webkit-style on Changelog > files. > > *Why use WPT?* > >

Re: [webkit-dev] Raw string literals

2021-11-17 Thread Ryosuke Niwa via webkit-dev
On Wed, Nov 17, 2021 at 2:59 PM Alex Christensen via webkit-dev < webkit-dev@lists.webkit.org> wrote: > Right now, our style checker disapproves of raw string literals, which > were introduced in C++11. It complains with this message: > > Multi-line string ("...") found. This lint script

Re: [webkit-dev] Fuzzy Reftest Plans, and Metadata Locations

2021-10-30 Thread Ryosuke Niwa via webkit-dev
On Thu, Oct 28, 2021 at 10:24 AM Sam Sneddon via webkit-dev < webkit-dev@lists.webkit.org> wrote: > As part of the ongoing work on GPU Process, we’re interested in adding > support for reftest fuzzy matching (i.e., allowing a certain amount of > tolerance when comparing the generated images). > >

Re: [webkit-dev] -Wreturn-type and -Wredundant-move reminders

2021-10-19 Thread Ryosuke Niwa via webkit-dev
On Tue, Oct 19, 2021 at 1:15 PM Michael Catanzaro via webkit-dev < webkit-dev@lists.webkit.org> wrote: > A reminder about this common idiom: > > switch (...) { > case Foo: > return ...; > case Bar: > return ...; > } > RELEASE_ASSERT_NOT_REACHED(); > > When it's intended that the code

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Ryosuke Niwa via webkit-dev
On Mon, Aug 30, 2021 at 2:58 AM Thomas Steiner wrote: > On Mon, Aug 30, 2021 at 11:06 AM Ryosuke Niwa wrote: > >> On Mon, Aug 30, 2021 at 1:17 AM Thomas Steiner wrote: >> >>> On Sun, Aug 29, 2021 at 1:00 AM Ryosuke Niwa wrote: >>> >>>> I do

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-30 Thread Ryosuke Niwa via webkit-dev
On Mon, Aug 30, 2021 at 1:17 AM Thomas Steiner wrote: > On Sun, Aug 29, 2021 at 1:00 AM Ryosuke Niwa wrote: > >> I don't think exposing the information about whether the connection is >> metered or not is acceptable from the privacy standpoint. Based on the IP &g

Re: [webkit-dev] Network Information API reboot: request for early feedback

2021-08-28 Thread Ryosuke Niwa via webkit-dev
I don't think exposing the information about whether the connection is metered or not is acceptable from the privacy standpoint. Based on the IP address of a user & this metered status, a website may even be able to tell what kind of carrier plan a given user is in. - R. Niwa On Fri, Aug 20,

Re: [webkit-dev] Identifiers in Log and Blame

2021-08-17 Thread Ryosuke Niwa via webkit-dev
Seems like a good improvement but I really don't use command line tools to see my blame. What I need is this getting applied to online tools like trac and GitHub. - R. Niwa On Tue, Aug 17, 2021 at 10:57 AM Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > Hi folks, > > As

[webkit-dev] content-visibility (Was Re: Request For Position on CSS containment)

2021-06-24 Thread Ryosuke Niwa via webkit-dev
Please rename the subject when you're going to discuss the work on a new feature. On Thu, Jun 24, 2021 at 9:44 AM cathiechen via webkit-dev < webkit-dev@lists.webkit.org> wrote: > We made a lot of progress regarding CSS containment [1]. > Rob and I have finished the layout containment and size

[webkit-dev] WeakHashMap

2021-06-11 Thread Ryosuke Niwa via webkit-dev
Hi all, I've added WeakHashMap to WTF in https://commits.webkit.org/r278803, which allows the use of WeakPtr as keys. Like WeakHashSet, WeakHashMap does not immediately delete the key or the value when the object pointed by WeakPtr goes away (i.e. WeakPtrImpl::m_ptr becomes nullptr). Instead, it

Re: [webkit-dev] Request for Position: Compute Pressure API

2021-05-06 Thread Ryosuke Niwa via webkit-dev
On Thu, May 6, 2021 at 10:55 AM Olivier Yiptong wrote: > > Hi, and thank you for your prompt response. Replies inline. >> >>1. CPU utilization isn't something which can be easily computed or >>reasoned on asymmetric multi-core CPUs, not to mention the dynamic >>adjustment of CPU

Re: [webkit-dev] Request for Position: Compute Pressure API

2021-05-05 Thread Ryosuke Niwa via webkit-dev
On Wed, May 5, 2021 at 11:37 AM Olivier Yiptong via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > We propose a new API that conveys the utilization of CPU resources on the > user's device. This API targets applications that can trade off CPU > resources for an improved user experience. For

Re: [webkit-dev] New EWS Non-Unified builder

2021-05-01 Thread Ryosuke Niwa via webkit-dev
On Fri, Apr 30, 2021 at 10:16 AM Alexey Proskuryakov via webkit-dev < webkit-dev@lists.webkit.org> wrote: > These points from my yesterday email remain without responses: > > 1. Cannot have an EWS without corresponding post-commit queue. > Yeah, we should first add a bot. 2. It doesn't appear

Re: [webkit-dev] New EWS Non-Unified builder

2021-05-01 Thread Ryosuke Niwa via webkit-dev
On Thu, Apr 29, 2021 at 9:18 PM Darin Adler via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > On Apr 29, 2021, at 9:06 PM, Tim Horton via webkit-dev < > webkit-dev@lists.webkit.org> wrote: > > > > it is definitely highly annoying > > It’s possible that where my thinking differs from others

Re: [webkit-dev] Request for position on First-Party Sets

2021-04-14 Thread Ryosuke Niwa via webkit-dev
On Tue, Apr 13, 2021 at 1:52 PM Kaustubha Govind via webkit-dev wrote: > > [Resending after subscribing to webkit-dev, since my previous message bounced > back] > > On Tue, Apr 13, 2021 at 4:47 PM Kaustubha Govind > wrote: >> >> Hi Maciej, Webkit team, >> >> Now that First-Party Sets has been

Re: [webkit-dev] Request for position: Aligning high-resolution timer granularity to cross-origin isolated capability

2021-03-18 Thread Ryosuke Niwa via webkit-dev
On Thu, Mar 18, 2021 at 12:26 AM Yoav Weiss via webkit-dev wrote: > > On Wed, Mar 17, 2021 at 5:51 PM Geoff Garen wrote: >> >> For the 100 microsecond value — our research suggests that you need a much >> higher value in vulnerable contexts. >> >> For the guaranteed isolated case — have you

Re: [webkit-dev] Request for Position on Sanitizer API

2021-03-15 Thread Ryosuke Niwa via webkit-dev
On Mon, Mar 15, 2021 at 7:32 AM Daniel Vogelheim via webkit-dev wrote: > > I'd like to request a position statement on the proposed Sanitizer API. > > The Sanitizer API wants to build an HTML Sanitizer right into the web > platform. The goal is to make it easier to build XSS-free web

Re: [webkit-dev] Position on emerging standard: Declarative Shadow DOM

2021-02-23 Thread Ryosuke Niwa via webkit-dev
On Tue, Feb 23, 2021 at 5:06 PM Mason Freed via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > On Fri Feb 19 20:36:12 PST 2021 Ryosuke Niwa via webkit-dev < > > webkit-dev at lists.webkit.org> wrote: > > > > I replied in the issues directly so that people

Re: [webkit-dev] Position on emerging standard: Declarative Shadow DOM

2021-02-19 Thread Ryosuke Niwa via webkit-dev
On Fri, Feb 19, 2021 at 2:38 PM Mason Freed via webkit-dev < webkit-dev@lists.webkit.org> wrote: > On Thu Feb 18 17:08:18 PST 2021 Ryosuke Niwa via webkit-dev < > webkit-dev at lists.webkit.org> wrote: > > > The latest proposal does solve much of the problems we've i

Re: [webkit-dev] Position on emerging standard: Declarative Shadow DOM

2021-02-18 Thread Ryosuke Niwa via webkit-dev
On Thu, Feb 18, 2021 at 3:17 PM Mason Freed via webkit-dev < webkit-dev@lists.webkit.org> wrote: > I just wanted to send a final heads-up that Chromium is intending to ship > the Declarative Shadow DOM feature. We haven't heard much back from WebKit > in the last 5 months or so, but in the

Re: [webkit-dev] Identifier Conversion Tooling

2021-02-12 Thread Ryosuke Niwa via webkit-dev
On Fri, Feb 12, 2021 at 2:58 PM Jonathan Bedard via webkit-dev < webkit-dev@lists.webkit.org> wrote: > Hello contributors, > > As we move forward with the transition to GitHub, we are starting to adopt > identifiers in tooling > and

Re: [webkit-dev] Request for position: Critical-CH response header, part of Client Hints Reliability proposal

2021-01-28 Thread Ryosuke Niwa via webkit-dev
uot;incomplete" request > > This would *not* override potential mitigations or reductions in > fingerprinting surfaces imposed by the browser. Any headers that would be > blocked would still be silently dropped. > > (cc davidben, mjs who I forgot to CC the first time) > >

Re: [webkit-dev] Request for position: Critical-CH response header, part of Client Hints Reliability proposal

2021-01-28 Thread Ryosuke Niwa via webkit-dev
What's the point of specifying Critical-CH as opposed to relying on CH provided by the browser? Is the idea that some browsers may decide to hide some client hints to reduce the fingerprinting surface? If so, then this new header seems to just defeat that because a website can specify all the

Re: [webkit-dev] Github mirror is not updating

2020-11-30 Thread Ryosuke Niwa via webkit-dev
On Thu, Nov 26, 2020 at 11:33 PM Adrien Destugues via webkit-dev < webkit-dev@lists.webkit.org> wrote: > > I noticed that the github mirror at https://github.com/webkit/webkit is > not getting > the latest commits from WebKit (it is now about a month behind). Is that > intentional? > We're

Re: [webkit-dev] Request for position on Element Timing

2020-11-26 Thread Ryosuke Niwa via webkit-dev
e, Nov 24, 2020 at 1:41 PM Ryosuke Niwa wrote: > >> >> On Tue, Nov 24, 2020 at 8:23 AM Nicolás Peña Moreno >> wrote: >> >>> Thanks for taking the time to review. I received this on my spam folder >>> for some reason so apologies for the delay in replying

Re: [webkit-dev] Request for position on Element Timing

2020-11-24 Thread Ryosuke Niwa via webkit-dev
On Tue, Nov 24, 2020 at 8:23 AM Nicolás Peña Moreno wrote: > Thanks for taking the time to review. I received this on my spam folder > for some reason so apologies for the delay in replying. > > On Tue, Nov 3, 2020 at 3:31 AM Ryosuke Niwa wrote: > >> On Fri, Oct 30, 2020 at

Re: [webkit-dev] Request for position on Element Timing

2020-11-11 Thread Ryosuke Niwa
On Fri, Oct 30, 2020 at 1:58 PM Nicolás Peña Moreno wrote: > > Hi, I'd like to request WebKit's position on the Element Timing API, which lets web developers annotate images or text whose performance they care about. They can then obtain rendering timestamps from the PerformanceObserver. For

Re: [webkit-dev] Embedding Identifiers in Commit Messages

2020-11-02 Thread Ryosuke Niwa
On Mon, Nov 2, 2020 at 2:04 PM Jonathan Bedard wrote: > > We appreciate everyone’s feedback on transitioning away from Subversion to > Git, I’ll be releasing an expected timeline of up-coming changes in the next > week before the contributors meeting. > > In the mean time, we’re preparing on

Re: [webkit-dev] Request for a position on the Idle Detection API

2020-10-29 Thread Ryosuke Niwa
On Thu, Oct 29, 2020 at 12:54 PM Reilly Grant wrote: > > On Wed, Oct 28, 2020 at 9:20 PM Ryosuke Niwa wrote: > > > > On Wed, Oct 28, 2020 at 4:56 PM Reilly Grant wrote: > >> > >> I would like to request an official position from the WebKit team on t

Re: [webkit-dev] Request for a position on the Idle Detection API

2020-10-28 Thread Ryosuke Niwa
On Wed, Oct 28, 2020 at 4:56 PM Reilly Grant wrote: > I would like to request an official position from the WebKit team on the > emerging Idle Detection API > specification. > I am aware that this API was included in a list of APIs >

Re: [webkit-dev] Request for position on import maps

2020-10-27 Thread Ryosuke Niwa
On Tue, Oct 27, 2020 at 2:23 PM Domenic Denicola wrote: > > For the last couple of years myself some other Chrome folks have been working > on the import maps proposal. This allows controlling the behavior of > JavaScript import statements and import() expressions, in particular by > allowing

Re: [webkit-dev] Request for position on Event Timing

2020-10-22 Thread Ryosuke Niwa
icolás Peña Moreno: > > I've written a doc to explain our perspective on the use-cases of these two > APIs: > https://docs.google.com/document/d/1UrPQD0lOhHKgQy1oy1Cs0F9AsBb83q_bx8cAvu_sKrI. > > > On Tue, Sep 29, 2020 at 5:16 PM Yoav Weiss wrote: >> >> +

[webkit-dev] Shrinking Git clone size (WebKit Transition to Git)

2020-10-18 Thread Ryosuke Niwa
Hi all, While we're making the transition to Git, I think we should try to shrink the Git clone size. Right now, it's 10GB and I suspect we can cut it down quite a bit without sacrificing much. For example, we can exclude any history for LayoutTests/platform/chromium* and

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Ryosuke Niwa
On Sat, Oct 17, 2020 at 10:00 AM Sam Weinig wrote: > > Hi webkit-dev, > > I’d like to propose, and gauge feedback on, reducing (with the goal of > ultimately removing) the use of Makefile based DerivedSources.make. > > My understanding is that currently only the Xcode based ports still use >

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 4:12 PM Konstantin Tokarev wrote: > > > > 14.10.2020, 02:01, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 3:53 PM Konstantin Tokarev > > wrote: > >> 14.10.2020, 01:45, "Ryosuke Niwa" : > >> >

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 3:53 PM Konstantin Tokarev wrote: > > > 14.10.2020, 01:45, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev > > wrote: > >> 14.10.2020, 01:30, "Ryosuke Niwa" : > >> > O

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 3:19 PM Michael Catanzaro wrote: > > Detailed descriptions are very important. I don't think function-level > changelogs are; documenting changes in individual functions is > generally busywork to say what you can plainly see by just looking at > the diff. They certainly

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 3:40 PM Konstantin Tokarev wrote: > > 14.10.2020, 01:30, "Ryosuke Niwa" : > > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev > > wrote: > >> 13.10.2020, 22:33, "Maciej Stachowiak" : > >> >&g

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 3:19 PM Michael Catanzaro wrote: > > I suppose what I'm describing is Konstantin's Workflow 2, which is > overwhelmingly popular. > > On Tue, Oct 13, 2020 at 2:19 pm, Ryosuke Niwa wrote: > > Not squashing only helps if each commit can stand on its o

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev wrote: > > > 13.10.2020, 22:33, "Maciej Stachowiak" : > >> On Oct 2, 2020, at 10:59 AM, Michael Catanzaro > >> wrote: > >> > >> On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand wrote: > >>> Would you also consider preventing merge commits

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Ryosuke Niwa
On Tue, Oct 13, 2020 at 1:57 PM Michael Catanzaro wrote: > > On Tue, Oct 13, 2020 at 12:32 pm, Maciej Stachowiak > wrote: > > I’m assuming your objection is to regular merges, but how do you > > feel about squash merges? Or do you think all PRs should be landed by > > rebasing? > > If we want a

Re: [webkit-dev] WebKit Transition to Git

2020-10-06 Thread Ryosuke Niwa
On Mon, Oct 5, 2020 at 5:13 PM Konstantin Tokarev wrote: > > > 05.10.2020, 23:41, "Yusuke Suzuki" : > > I think security component is special in terms of how to handle it already > > (e.g. not posting a test with the patch etc.) > > To me, handling non-security issues in GitHub and security

Re: [webkit-dev] WebKit Transition to Git

2020-10-04 Thread Ryosuke Niwa
On Sun, Oct 4, 2020 at 2:41 PM Konstantin Tokarev wrote: > > 02.10.2020, 19:46, "Jonathan Bedard" : > > Monotonic Commit Identifiers > > Of great interest to Apple’s engineers has been retaining some kind of > > ordered tag we can use to refer to commits to make defending CI and > > bisection

Re: [webkit-dev] WebKit Transition to Git

2020-10-03 Thread Ryosuke Niwa
On Sat, Oct 3, 2020 at 2:25 AM Adrien Destugues wrote: > > On Fri, Oct 02, 2020 at 07:05:21PM -0500, Michael Catanzaro wrote: > > > I realize that Gerrit might not integrate at all with hosting the repo > > > on Github, but has any thought been given to this aspect of the > > > transition? > > >

Re: [webkit-dev] Issue reports, merge requests, etc. (was: WebKit Transition to Git)

2020-10-02 Thread Ryosuke Niwa
I feel like I should write longer replies but here we go. On Fri, Oct 2, 2020 at 12:53 PM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 11:51 am, Ryosuke Niwa wrote: > > Since Igalia has a lot > > more experience working with other open source projects, do you have &g

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Ryosuke Niwa
On Fri, Oct 2, 2020 at 5:06 PM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 13:48, Ken Russell wrote: > > Github's code review UI has a couple of feature gaps in my opinion. > > It's difficult to look at earlier versions of the pull request, in > > particular to verify that issues found

Re: [webkit-dev] WebKit Transition to Git

2020-10-02 Thread Ryosuke Niwa
On Fri, Oct 2, 2020 at 11:00 AM Michael Catanzaro wrote: > > On Fri, Oct 2, 2020 at 6:36 pm, Philippe Normand > wrote: > > Would you also consider preventing merge commits in order to keep a > > clean mainline branch? > > Big +1 to blocking merge commits. Merge commits in a huge project like >

Re: [webkit-dev] Request for position on isInputPending

2020-09-29 Thread Ryosuke Niwa
On Tue, Sep 29, 2020 at 1:44 PM Andrew Comminos wrote: > Thanks for the response Ryosuke, comments inline. > > On 9/23/20 12:37 AM, Ryosuke Niwa wrote: > > As we have discussed in other avenues, we're skeptical that this API is > > needed given native apps on iOS and macOS d

Re: [webkit-dev] Implementing MathML stylistic attributes in WebKit

2020-09-28 Thread Ryosuke Niwa
On Fri, Sep 25, 2020 at 12:47 AM Frédéric Wang wrote: > On 02/09/2019 16:11, Frédéric Wang wrote: > > Hello, > > Currently MathML attributes mathvariant, displaystyle and scriptlevel [1] > [2] are implemented in WebKit using custom "style resolution" and > "one-glyph rendering" inside the MathML

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-24 Thread Ryosuke Niwa
On Thu, Sep 24, 2020 at 8:19 AM David Bokan wrote: > Can you clarify what question you’re looking to have answered? Are you >> asking for a new standards position in light of the replies below? >> > > There are two specific points: > > - As I understand it, HTML requires multi-vendor interest

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Wed, Sep 23, 2020 at 10:32 AM Darin Adler wrote: > On Sep 16, 2020, at 11:32 PM, Ryosuke Niwa wrote: > >1. Every data member to a ref counted object must use either Ref, >RefPtr, or WeakPtr. webkit.NoUncountedMemberChecker > > <https://github.com/llvm/llv

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Thu, Sep 17, 2020 at 2:51 AM Emilio Cobos Álvarez wrote: > Interesting. This looks fairly similar to some of the checkers we use in > mozilla-central, fwiw. > > One interesting difference is that we opted for explicitly annotating > the functions that can run script (think

Re: [webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-23 Thread Ryosuke Niwa
On Thu, Sep 17, 2020 at 2:11 AM Konstantin Tokarev wrote: > > Sounds great! A few questions: > * Do I understand correctly that analyzer is a part of upstream clang and > can work on any platform? > Yes. * Does it require WebKit trunk or can work with older branches? It should work with

Re: [webkit-dev] Request for position on isInputPending

2020-09-23 Thread Ryosuke Niwa
On Fri, Sep 18, 2020 at 11:56 AM Andrew Comminos wrote: > We're looking to gather a position from WebKit folks on isInputPending, > an API to query for the presence of pending input events. It allows > sites to reduce event latency by yielding during longer computational > tasks, without

Re: [webkit-dev] Feedback on Blink's text fragment directive proposal

2020-09-23 Thread Ryosuke Niwa
On Fri, Sep 18, 2020 at 7:35 AM David Bokan wrote: > Friendly ping to get an answer here. > > Do my answers above address those points or is there anything else I can > clarify? > > Thanks, > David > > On Mon, Aug 31, 2020 at 1:42 PM David Bokan wrote: > >> [sending (again, sorry) from correct

[webkit-dev] Smart Pointer Analysis Tool for WebKit

2020-09-17 Thread Ryosuke Niwa
Hi all, I’ve been working with Geoff (ggaren) and Jan Korous from Apple's compiler team to create a static analyzer which detects dangerous use of ref counted objects, and we’re looking for folks who are interested in trying out this tool and helping us refine the tool. Please let me know if

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-04 Thread Ryosuke Niwa
On Thu, Sep 3, 2020 at 11:15 PM Fujii Hironori wrote: > > On Fri, Sep 4, 2020 at 2:56 PM Ryosuke Niwa wrote: > >> On Thu, Sep 3, 2020 at 10:11 PM Fujii Hironori >> wrote: >> >>> >>> On Fri, Sep 4, 2020 at 1:31 PM Ryosuke Niwa wrote: >>&

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-03 Thread Ryosuke Niwa
On Thu, Sep 3, 2020 at 10:11 PM Fujii Hironori wrote: > > On Fri, Sep 4, 2020 at 1:31 PM Ryosuke Niwa wrote: > >> Consecutive bit fields must use the same type. >> > > RenderLayer is mixing bool and unsigned in the consecutive bit fields. > They should use

Re: [webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

2020-09-03 Thread Ryosuke Niwa
; } struct C { uint32_t foo : 30; uint8_t bar : 2; } - R. Niwa On Thu, Mar 29, 2012 at 1:21 AM Ryosuke Niwa wrote: > Hi, > > Unlike gcc and clang, MSVC pads each consecutive member variables of the > same type in bitfields. e.g. if you have: > struct AB { > unsigned m_

Re: [webkit-dev] Request for position on hasDroppedEntry in PerformanceObserverCallback

2020-08-31 Thread Ryosuke Niwa
This seems fine to me. On Mon, Aug 31, 2020 at 9:09 AM Nicolás Peña wrote: > > Hi, > > We'd like to request an official position on a very small addition to > PerformanceTimeline specification. We've added a hasDroppedEntry parameter to > PerformanceObserverCallback, which is in >

Re: [webkit-dev] Request for position on Cookie Store API

2020-08-27 Thread Ryosuke Niwa
Hi, On Thu, Aug 27, 2020 at 12:02 PM Ayu Ishii wrote: > > We would like to ask for WebKit's official position on the Cookie Store API. > Cookie Store API aims to improve the complexity and performance issues of > cookies today by providing an asynchronous alternative to document.cookie and >

Re: [webkit-dev] Requesting a position on Document Policy

2020-08-25 Thread Ryosuke Niwa
Sorry for the late reply. We're going to review this feature. - R. Niwa On Tue, Jul 28, 2020 at 7:02 AM Ian Clelland wrote: > > Hi WebKit! > > I'm building out the infrastructure in Blink for Document Policy, and would > like to ship at least part of it in Chrome for developers to take

Re: [webkit-dev] Request for Position on Native File System API

2020-08-25 Thread Ryosuke Niwa
On Mon, Aug 17, 2020 at 10:38 AM Marijn Kruisselbrink wrote: > > We would like to get an official position from webkit for the Native File > System API (spec, explainer), a API that enables developers to build powerful > web apps that interact with files on the user’s local device. It builds on

Re: [webkit-dev] Status of custom paint?

2020-08-25 Thread Ryosuke Niwa
Our intern worked on the feature but I don't think anyone is actively maintaining or developing the feature at the moment. I don't think it's accurate to say it's mostly implemented. We got the basics working but there is quite a bit of work left to get to a feature complete / shippable state. -

Re: [webkit-dev] Request for position on the Origin-Isolation header

2020-08-20 Thread Ryosuke Niwa
Hi, On Thu, Aug 20, 2020 at 8:51 AM Domenic Denicola wrote: > > Hello webkit-dev, > > I've been working on a new header called Origin-Isolation, which is a way of > allowing origins to opt-out of using document.domain and cross-origin > sharing of WebAssembly.Module, and thus allowing the

Re: [webkit-dev] Request for position on content-visibility

2020-08-14 Thread Ryosuke Niwa
Hi, Sorry for the late reply. We're still reviewing this. - R. Niwa On Tue, May 26, 2020 at 12:00 PM Vladimir Levin wrote: > > Hi, > > I'm asking for WebKit's position on CSS property content-visibility (spec > draft: https://drafts.csswg.org/css-contain-2/#content-visibility). > > We're

Re: [webkit-dev] debug-test-runner: Timed out waiting for notifyDone to be called

2020-08-13 Thread Ryosuke Niwa
On Thu, Aug 13, 2020 at 9:42 AM Benjamin King wrote: > > Hi, > > I’m trying to run a LayoutTest case in the debugger using `debug-test-runner` > and it fails by timing out, see below. However, if I run `run-webkit-test` it > works. I read the WebKit wiki on debugging and searched google to no

Re: [webkit-dev] Request for feedback on CompressionStream and DecompressionStream

2020-08-12 Thread Ryosuke Niwa
Hi all, This is a very belated reply but what's being proposed seems reasonable to us (Apple's WebKit team). We would like to know more about use cases, and how they might be deployed in real websites / use cases but we don't see any major issues with it. - R. Niwa On Wed, Nov 27, 2019 at 11:18

  1   2   3   4   5   6   7   8   9   10   >