Re: [webkit-dev] Request for position on Event Timing

2020-08-06 Thread Simon Fraser
Our feedback is that this API seems reasonable, but that there's overlap with the "long tasks" API, and it's not clear if we need both. Simon > On Aug 6, 2020, at 10:43 AM, Rob Buis wrote: > > Hi Webkit-Dev, > > I would like to get an official position from Webkit on the Event Timing Web >

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-14 Thread Simon Fraser
Could someone educate me about ? When should I use this instead of individual wtf headers? Simon > On Jul 14, 2020, at 2:32 PM, Sam Weinig wrote: > > While I don’t want to take away from what Darin is saying here about correct > usage of forward declaration and , I’d like to understand why

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-17 Thread Simon Fraser
I also object to losing good stack traces for crashes on Debug bots. Also, I don't think Debug bots should build something different from what I build at my desk. Simon > On Jun 17, 2020, at 1:36 PM, Mark Lam wrote: > > Hi folks, > > We're planning to switch the JSC EWS bot and

Re: [webkit-dev] Request for position on removing 'no-preference' for prefers-color-scheme media feature

2020-06-08 Thread Simon Fraser
Thanks. I filed https://bugs.webkit.org/show_bug.cgi?id=212952 for the webkit fix. Simon > On Jun 8, 2020, at 6:35 AM, Rune Lillesveen wrote: > > Hi, > > Per CSSWG resolution [1], 'no-preference' has been removed from the Media > Queries

Re: [webkit-dev] Position on emerging standard: Scroll-linked Animations

2020-06-04 Thread Simon Fraser
We support the proposal in general. We think it's a good starting point for more complex scroll-linked effects, and look forward to discussing ways to achieve more rich scrolling-triggered behaviors in future. Simon > On Jun 3, 2020, at 5:08 PM, Majid Valipour wrote: > > Hi, > > I like to

Re: [webkit-dev] WebKit's position on @property

2020-04-23 Thread Simon Fraser
In general we are supporting. We've given some feedback here: > Simon > On Apr 23, 2020, at 2:44 AM, Anders Hartvoll Ruud > wrote: > > Hi, > > In Blink there's currently an intent to

Re: [webkit-dev] Is anyone maintaining Nicosia scrolling code?

2020-02-26 Thread Simon Fraser
> On Feb 23, 2019, at 3:29 AM, z...@falconsigh.net wrote: > > On Sat, Feb 23, 2019, at 2:47 AM, Simon Fraser wrote: >> There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that >> I keep breaking with scrolling tree refactoring. Most of it it stubs. >

Re: [webkit-dev] Naming convention for static member variables

2020-02-19 Thread Simon Fraser
Thank you. I filed https://bugs.webkit.org/show_bug.cgi?id=207961 <https://bugs.webkit.org/show_bug.cgi?id=207961> Simon > On Feb 19, 2020, at 11:39 AM, Konstantin Tokarev wrote: > > > > 19.02.2020, 22:31, "Simon Fraser" : >> class Foo { >&g

[webkit-dev] Naming convention for static member variables

2020-02-19 Thread Simon Fraser
class Foo { static bool thing. }; What's the naming convention for static member variables like this? I've seen m_foo, which seems positively harmful. I've seen s_foo, which I like. There are 165 instances of s_ that I can find in the project. There are 17 instances of static m_. Simon

Re: [webkit-dev] Position on emerging standard: video.requestAnimationFrame()

2020-02-05 Thread Simon Fraser
> On Feb 5, 2020, at 4:52 PM, Thomas Guilbert wrote: > > I am moving the execution of the video.rAF callbacks to be part of the > rendering steps. This should guarantee that "changes made inside the callback > appear at the same time as other changes in the same event loop cycle". > I don't

Re: [webkit-dev] Position on emerging standard: video.requestAnimationFrame()

2020-02-03 Thread Simon Fraser
ot; variant be called? > > Can you file an issue in https://github.com/WICG/video-raf/issues > <https://github.com/WICG/video-raf/issues> if you see a good alternative? > > Also curious if +Eric Carlson <mailto:eric.carl...@apple.com> has any > feedback on this

Re: [webkit-dev] Position on emerging standard: video.requestAnimationFrame()

2020-01-22 Thread Simon Fraser
on-screen in the same frame as other changes in the same event loop cycle, and that requestAnimationFrame won't be called more often than is necessary to update the screen at the appropriate frame rate. Simon > > On Tue, Jan 21, 2020 at 1:01 PM Simon Fraser <mailto:simon.fra...@apple.

Re: [webkit-dev] Position on emerging standard: video.requestAnimationFrame()

2020-01-21 Thread Simon Fraser
> On Jan 21, 2020, at 12:37 PM, Thomas Guilbert wrote: > > Hello, > I'm reaching out to see if webkit would like to weigh in on the following > proposal: > https://discourse.wicg.io/t/proposal-video-requestanimationframe/3691 >

Re: [webkit-dev] Supporting for finding ref tests

2019-11-12 Thread Simon Fraser
> On Nov 12, 2019, at 4:52 AM, Frédéric Wang wrote: > > On 09/11/2019 04:02, Ryosuke Niwa wrote: >> > - Requires us modifying each port's DRT to support this format > > No, it just requires webkitpy hacking which I've done in the patch. I'm not certain writing a bunch of

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
> On Nov 8, 2019, at 2:15 PM, Robert Ma wrote: > > WPT has recently passed an RFC > > trying to simplify the reftest graph (although it has not been implemented > yet), which eliminates a lot of the

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
> On Nov 8, 2019, at 2:07 PM, Ryosuke Niwa wrote: > > On Fri, Nov 8, 2019 at 2:01 PM Simon Fraser wrote: >> >> I'd like to land a patch to support finding test references via > rel="match/mismatch">: >> https://bugs.webkit.org/show_bug.cgi?id=2

[webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Simon Fraser
I'd like to land a patch to support finding test references via : https://bugs.webkit.org/show_bug.cgi?id=203784 There has been some discussion about this in the past: https://lists.webkit.org/pipermail/webkit-dev/2011-November/018470.html

Re: [webkit-dev] Lazy loading

2019-10-28 Thread Simon Fraser
> On Oct 28, 2019, at 11:39 AM, Rob Buis wrote: > > Hi, > > I made a lazy image loading prototype earlier this year > (https://bugs.webkit.org/show_bug.cgi?id=196698) and have been splitting it > up into reviewable patches. The main implementation part landed recently so I > am wondering

Re: [webkit-dev] Unprefix -webkit-clip-path

2019-10-28 Thread Simon Fraser
I support unprefixing! Simon > On Oct 28, 2019, at 11:55 AM, Dirk Schulze wrote: > > Hi, > > I didn’t hear any objections to unprefix -webkit-clip-path. Unless no new > concerns get raised, I’ll land the patch later this week. > > Greetings, > Dirk > >> On 21. Oct 2019, at 13:01, Dirk

Re: [webkit-dev] What to do about scroll anchoring?

2019-09-29 Thread Simon Fraser
> On Sep 27, 2019, at 10:08 PM, Emilio Cobos Álvarez wrote: > > And, to be clear, we _can_ fix these compat issues, some way or another. > > One thought is to limit the amount of scroll adjustments without user > scrolling or stuff like that, which would prevent the "you get stuck on the >

Re: [webkit-dev] Planned EWS improvements

2019-09-28 Thread Simon Fraser
> On Sep 27, 2019, at 10:27 PM, Konstantin Tokarev wrote: > > 27.09.2019, 08:15, "Simon Fraser" : >>> On Sep 27, 2019, at 3:27 AM, Aakash Jain wrote: >>> >>> Hi Everyone, >>> >>> I have been making number of improvements to EWS

Re: [webkit-dev] Planned EWS improvements

2019-09-26 Thread Simon Fraser
> On Sep 27, 2019, at 3:27 AM, Aakash Jain wrote: > > Hi Everyone, > > I have been making number of improvements to EWS. I also have various planned > improvements to EWS. I wanted to reach out to you guys to see if anyone Not everyone on this list is a guy. > wants me to prioritize any

Re: [webkit-dev] [webkit-help] ResizeObserver

2019-04-01 Thread Simon Fraser
>> Will do. >>> >>> Might be worth mentioning this feature on https://webkit.org/status ... ? >>> >>> On Tue, Jan 22, 2019 at 2:57 PM Simon Fraser wrote: >>>> On Jan 22, 2019, at 11:46 AM, Eric Gorr wrote: >>>> >>>&g

Re: [webkit-dev] Style guideline on initializing non-POD types via member initialization

2019-03-20 Thread Simon Fraser
Simon > > -Filip > >> On Mar 14, 2019, at 12:59 PM, Simon Fraser wrote: >> >> I've seen some code recently that initializes non-POD members via >> initializers. For example, SVGAElement has: >> >> AttributeOwnerProxy m_attributeOwnerProxy {

[webkit-dev] Style guideline on initializing non-POD types via member initialization

2019-03-14 Thread Simon Fraser
I've seen some code recently that initializes non-POD members via initializers. For example, SVGAElement has: AttributeOwnerProxy m_attributeOwnerProxy { *this }; I find this a little disorientating, and would normally expect to see this in the constructor as m_attributeOwnerProxy(*this),

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Simon Fraser
Or use LOG_WITH_STREAM() where I presume << pageID() << does the right thing. We’d need some new RELEASE_LOG_ macros for that. Simon > On Feb 27, 2019, at 2:47 PM, Ryosuke Niwa wrote: > > We should probably stop using these formatting strings in favor of makeString > by making *LOG*

[webkit-dev] Is anyone maintaining Nicosia scrolling code?

2019-02-22 Thread Simon Fraser
There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that I keep breaking with scrolling tree refactoring. Most of it it stubs. Is anyone maintaining this code, because it obviously doesn’t work, and I’d like to remove the maintenance burden. Simon

Re: [webkit-dev] Moving to Git

2019-02-21 Thread Simon Fraser
> On Feb 21, 2019, at 12:18 AM, Bug Tracker > wrote: > > Thank you all very much for your help! I really appreciate it. :-) > > P.S.: I decided to start learning git-svn. https://trac.webkit.org/wiki/UsingGitWithWebKit has the information you

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Simon Fraser
Are you a WebKit developer? I can't tell from your email. Simon > On Feb 20, 2019, at 8:27 AM, Bug Tracker > wrote: > > Hi, > > I was curious about the status of the proposal for migrating from SVN to Git > (https://trac.webkit.org/wiki/Moving%20to%20Git >

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Simon Fraser
I find it mind bending. It makes me wonder if the author made a coding error. Simon > On Feb 20, 2019, at 7:48 AM, Daniel Bates wrote: > > Thanks for the opinion! > > Dan > > On Feb 20, 2019, at 7:26 AM, Saam Barati > wrote: > >> I prefer it as well. >> >> - Saam

Re: [webkit-dev] Experimental features review

2019-02-13 Thread Simon Fraser
> On Feb 13, 2019, at 11:32 AM, Michael Catanzaro wrote: > > Hi, > > Last year, we cleaned up experimental features in WebPreferences.yaml to > ensure no experimental features were enabled by default. Since then we have > regressed a bit when enabling cool new web features. :) Currently we

Re: [webkit-dev] the name "AtomicString"

2018-12-19 Thread Simon Fraser
> On Dec 19, 2018, at 12:33 PM, Michael Catanzaro wrote: > > On Tue, Dec 18, 2018 at 9:31 PM, Darin Adler wrote: >> I’ve gotten used to the name AtomicString over the years, but I wouldn’t >> strongly object to changing it if other programmers are often confused by >> it’s similarity to the

Re: [webkit-dev] Clarifying feature flags

2018-11-05 Thread Simon Fraser
> On Nov 5, 2018, at 6:01 PM, don.olmst...@sony.com wrote: > > I'm really interested in other people's thoughts on this. > Agreed that this would be great to clean up. We’ve accrued a lot of junk in this area. Simon ___ webkit-dev mailing list

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Simon Fraser
od by reading the script's code, it is directly calling > into the lldb binding to dump the class layout, and it's failing inside. > > As I've said before, the error it gives me implies that the provided > framework/class pair has not been found in the image, even though I am sure &

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Simon Fraser
Dump-class-layout uses the lldb python bindings. Maybe those are not available on your platform? I think we’ve only ever tried it on macOS. What platform are you trying on? Simon > On Nov 4, 2018, at 12:43 PM, Frank Jaeger wrote: > > Hello. First of all I'm really sorry if this is the wrong

[webkit-dev] Does any platform set acceleratedCompositingForOverflowScrollEnabled?

2018-09-20 Thread Simon Fraser
I'd like to remove the code related to acceleratedCompositingForOverflowScrollEnabled; it complicates RenderLayer z-order code, and is not sufficient for our desires of being able to accelerate all overflow-scrolls, not just those that can be made stacking context without affecting z-order.

[webkit-dev] Unified sources have broken our #include hygiene

2018-09-01 Thread Simon Fraser
Unified sources allow you to get away without #including all the files you need in a .cpp file, because some earlier file in the group has probably already included them for you. This means that when you add a new file to the build, and the unified sources get shuffled around, you end up with

[webkit-dev] Introducing the GC Heap Inspector

2018-08-24 Thread Simon Fraser
Yesterday I landed support for a way to dump and inspect a GC heap snapshot. This work was motivated by the need to have easier ways to debug Document leaks, especially those involving GC. The basic idea is that you do some steps that trigger a document leak, then get a heap dump. Typically

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-08 Thread Simon Fraser
This plan sounds great! Thanks for working on this. Simon > On Aug 8, 2018, at 9:53 AM, Oriol Brufau wrote: > > https://drafts.csswg.org/css-logical-1/ > defines properties and values to > control layout > through logical, rather than physical,

Re: [webkit-dev] Update WebKit style to better accommodate accepted Obj-C block syntax

2017-10-04 Thread Simon Fraser
+1 for no space between ^ and { Simon > On Oct 3, 2017, at 4:51 PM, Megan Gardner wrote: > > > Currently, the webkit style checker does not allow ^{ at the beginning of > Obj-C blocks. It demands that there is a space between the ^ and the {. This > is not how obj-c

Re: [webkit-dev] web-bluetooth

2017-09-27 Thread Simon Fraser
> On Sep 27, 2017, at 10:47 AM, Jonathan Ruiz > wrote: > > > Hi All, > > is there any plan to implement web-bluetooth or is it completely discarded? > >

[webkit-dev] Breakpoints in #included .cpp files [Was: Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)]

2017-08-29 Thread Simon Fraser
> On Aug 28, 2017, at 9:46 PM, Geoffrey Garen wrote: > >> The line numbers and filenames will be total nonsense if we just concatenate >> multiple source files together. But that's very easy to fix if the script >> that concatenates the sources also adds a #line statement

Re: [webkit-dev] Fail to execute setup-git-clone

2017-08-15 Thread Simon Fraser
I would suggest checking out WebKit into a directory that doesn't have any non-ASCII characters in the path (sorry!). Simon > On Aug 15, 2017, at 6:01 PM, 于晶彬 wrote: > > Hello, > I'm trying to configure git to track the Subversion repository, using the > command shown in

Re: [webkit-dev] Intent to remove: ENABLE_PROXIMITY_EVENTS

2017-08-14 Thread Simon Fraser
> On Aug 11, 2017, at 3:31 PM, Simon Fraser <simon.fra...@apple.com> wrote: > > Does any platform care about the code protected by ENABLE_PROXIMITY_EVENTS? > It was added in 2015 via webkit.org/b/102658 but as far as I can tell, no > platform uses it. Removal bug is ht

[webkit-dev] Intent to remove: ENABLE_REQUEST_AUTOCOMPLETE

2017-08-11 Thread Simon Fraser
ENABLE_REQUEST_AUTOCOMPLETE and its AutocompleteErrorEvent was added via webkit.org/b/105568 for https://wiki.whatwg.org/wiki/RequestAutocomplete but as far as I can see that never made it into the HTML spec, and the code wasn't enabled anywhere. Speak up if you don't want this code removed.

[webkit-dev] Intent to remove: ENABLE_PROXIMITY_EVENTS

2017-08-11 Thread Simon Fraser
Does any platform care about the code protected by ENABLE_PROXIMITY_EVENTS? It was added in 2015 via webkit.org/b/102658 but as far as I can tell, no platform uses it. Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Simon Fraser
> On May 12, 2017, at 12:04 PM, Alexey Proskuryakov wrote: > > >> 12 мая 2017 г., в 11:52, Ben Kelly > > написал(а): >> >> On Fri, May 12, 2017 at 2:26 PM, Rick Byers > >

Re: [webkit-dev] Another WPT bite

2017-05-11 Thread Simon Fraser
> On May 11, 2017, at 9:30 PM, Anne van Kesteren <ann...@annevk.nl> wrote: > > On Tue, May 9, 2017 at 8:27 PM, Simon Fraser <simon.fra...@apple.com> wrote: >> I'm also concerned that with 4 vendors upstreaming their WPT tests, the WPT >> repo will just become

Re: [webkit-dev] !!Tests for equality comparison

2017-04-27 Thread Simon Fraser
+1 for ! liking ! when testing numeric values against zero. Simon > On Apr 27, 2017, at 4:33 PM, Chris Dumez wrote: > > I also do not like this rule when it comes to integers. > > I personally think JF’s proposal to allow == 0 sounds nice. I don’t think JF > was suggesting

Re: [webkit-dev] SVN trouble

2017-02-25 Thread Simon Fraser
EWS is still down. Do we have an ETA? Simon > On Feb 24, 2017, at 10:25 PM, Alexey Proskuryakov wrote: > > >> 24 февр. 2017 г., в 19:50, Chris Dumez > > написал(а): >> >> >> >> >>> On Feb 24, 2017, at 11:41 AM, Alexey

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Simon Fraser
What WebKit revision are your sources based on? It's quite likely the this bug has been fixed. Simon > On Feb 9, 2017, at 4:09 AM, Atul Sowani wrote: > > Finally I zeroed in on 3 "calc" candidates from the stylesheet which are > causing the CSS parser to fail: > >

Re: [webkit-dev] Settings and Testing (Settings, RuntimeEnabledFeatures, WebPreferences)

2017-01-21 Thread Simon Fraser
> On Jan 21, 2017, at 12:56 AM, Ryosuke Niwa wrote: > > I'd be strongly opposed to adding yet another file that configures how > tests are run. Even today, it's impossible to reason about whether a > given test is expected to pass or fail because there are multiple >

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Simon Fraser
> On Jan 10, 2017, at 9:03 PM, Darin Adler wrote: > > This kind of discussion should be on webkit-dev, not webkit-reviewers. While > the reviewers may have more standing to decide about such things, we normally > want to discuss them in the open. Agreed. Moving there. > If

[webkit-dev] Enabling visual viewports by default

2016-12-05 Thread Simon Fraser
Hi floks! I plan to enable visual viewports by default in WK1 and WK2 in the near future. "visual viewports" is new behavior for position:fixed and sticky elements under page zoom; they lay out relative to a "layout viewport" (which is the size of the initial containing block), while the user

Re: [webkit-dev] What happened to WKR and webkitbot?

2016-11-17 Thread Simon Fraser
> On Nov 17, 2016, at 10:21 AM, Osztrogonác Csaba wrote: > > Hi, > > it seems WKR and webkitbot left #webkit IRC channel > on 4th Nov and we can't see them since then. > > It would be great if somebody could > find and ask them to come back. Top people are working on

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-11-02 Thread Simon Fraser
Added to features.json as "Removed". https://trac.webkit.org/changeset/208303 People, don't be shy in filling out features.json for things you're working on, or know are either done, or have outside interest. Simon > On Nov 2, 2016, at 2:11 PM,

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-10-30 Thread Simon Fraser
I support the proposal to remove. Simon > On Oct 30, 2016, at 5:14 PM, Brady Eidson wrote: > > > There's code in the tree to support the W3C Battery Status API. > > A recent study showed the extent of the risk (discussion and link to study >

Re: [webkit-dev] Inactive Committers and Reviewers

2016-10-11 Thread Simon Fraser
A provisional list of the list of committers and reviewers who will become inactive is in https://bugs.webkit.org/show_bug.cgi?id=163318 <https://bugs.webkit.org/show_bug.cgi?id=163318> Simon > On Oct 9, 2016, at 5:57 PM, Simon Fraser <simon.fra...@apple.com> wrote: > >

Re: [webkit-dev] Inactive Committers and Reviewers

2016-10-09 Thread Simon Fraser
I plan to implement these changes, via additions to contributors.json, in the near future, by making inactive any committer/reviewer who has not exercised their privilege in the past year. There will be a few VIPs who retain their commit and/or review rights. I do not intend to email people

[webkit-dev] iPad tests are now possible

2016-08-15 Thread Simon Fraser
With https://trac.webkit.org/changeset/204477 and some earlier groundwork, it's now possible to add iPad-specific tests. Any test in a directory with an "ipad" suffix will be run in an iPad Air simulator, both with DumpRenderTree and WebKitTestRunner. When combined with "", the test will run

Re: [webkit-dev] Strange result in fast/backgrounds/mask-composite.html

2016-07-22 Thread Simon Fraser
> On Jul 22, 2016, at 4:20 PM, Konstantin Tokarev wrote: > > Hello, > > I'm getting attached result for fast/backgrounds/mask-composite.html, while > in the tree expected result looks like > >

Re: [webkit-dev] canvas and sRGB

2016-05-02 Thread Simon Fraser
> On May 2, 2016, at 2:59 PM, Dean Jackson <d...@apple.com> wrote: > > >> On 3 May 2016, at 7:04 AM, Rik Cabanier <caban...@gmail.com >> <mailto:caban...@gmail.com>> wrote: >> >> >> >> On Mon, May 2, 2016 at 1:58 PM, Simon Fr

Re: [webkit-dev] canvas and sRGB

2016-05-02 Thread Simon Fraser
> On May 2, 2016, at 1:45 PM, Rik Cabanier wrote: > > All, > > with the release of DCI-P3 screen, WebKit began supporting the display of > high gamut images. > Specifically, if you have an image with a DCI-P3 profile, its pixels render > untouched on the new displays. > >

Re: [webkit-dev] About unprefixing CSS Grid Layout (implementation status summary included)

2016-04-27 Thread Simon Fraser
> On Apr 27, 2016, at 4:39 AM, Manuel Rego Casasnovas wrote: > > Hi, > > as announced yesterday it seems that the WebKit prefixing policy has > been updated [1]. > > Right now CSS Grid Layout implementation is prefixed in WebKit and > behind a compilation flag. > We'd like to

Re: [webkit-dev] Memory leak tracking in WebKit

2016-01-05 Thread Simon Fraser
This sounds like a bug that would affect all WebKit ports. Can you file a bugs.webkit.org bug, and continue investigation there? Simon > On Jan 5, 2016, at 12:03 PM, Vienneau, Christopher wrote: > > Hi, > > I’ve resumed the memory leak tracking I was doing last year, I

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

2015-11-18 Thread Simon Fraser
> On Nov 18, 2015, at 9:04 AM, Darin Adler wrote: > >> On Nov 18, 2015, at 4:36 AM, Carlos Alberto Lopez Perez >> wrote: >> >> Some reference tests give a 1-pixel or very few pixel differences [1]. > > Why? We need to understand why. > >> Should we

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

2015-11-02 Thread Simon Fraser
> On Nov 1, 2015, at 7:40 PM, Darin Adler wrote: > > Hi folks. > > Our engine supports alpha values from 0-255. But when we serialize them, we > turn them into floating point values. When we do that, we include way too > many digits of precision. For example, the alpha value

Re: [webkit-dev] Improved CrashLog collection in Webkit Tests

2015-10-27 Thread Simon Fraser
> On Oct 27, 2015, at 3:09 PM, Aakash Jain wrote: > > Hi All, > > In the webkit test results page, we have added a section "Other Crashes" > (through https://bugs.webkit.org/show_bug.cgi?id=150056). After the tests are > complete, we go through the crashlog directory on

Re: [webkit-dev] WebCore crashes calling layout code on wrong thread (iOS 9 SDK only)

2015-10-26 Thread Simon Fraser
We’re tracking an issue similar to this internally. Could you please file a bug report at bug reporter.apple.com, with a copy of the app and steps to reproduce? Thanks Simon > On Oct 26, 2015, at 11:05 AM, Ian Ragsdale wrote: > > Hi all, I'm running into a strange

[webkit-dev] New iOS testing functionality

2015-09-30 Thread Simon Fraser
I’ve recently landed a string of patches which enable new WK2 testing functionality, particularly for iOS. These consist of a new function on TestRunner, testrunner.runUIScript(), and the creation of a JS context in the UI process which runs script that can call into UIScriptController. There

[webkit-dev] Implementing CSS will-change

2015-08-15 Thread Simon Fraser
I intend to implement the CSS will-change property, as specified here: http://www.w3.org/TR/css-will-change-1/ http://www.w3.org/TR/css-will-change-1/ Since this is already supported unperfected by Firefox and Chrome, I will implement it unprefixed, and without an ENABLE flag. Work will be

[webkit-dev] New tool to show class or struct padding

2015-08-12 Thread Simon Fraser
I just landed a new script called 'dump-class-layout' in http://trac.webkit.org/changeset/188350 that shows class and struct padding. This script uses lldb Python bindings to collect information about the data member layout, which can be used to look for padding holes to reduce class size. It

[webkit-dev] Moving tests out of platform directories

2015-08-03 Thread Simon Fraser
Starting this week, I plan to move layout tests out of the LayoutTests/platform directories. The goal is to have the LayoutTests/platform directories contain only results (and TestExpectation files). This avoids the creation of test results in directories like platform/mac/platform/mac. The

Re: [webkit-dev] maximalOutlineSize inflate all RenderLayers

2015-07-06 Thread Simon Fraser
This is a well-known issue. Ideally outline size would be factored into visual overflow, but that’s a bit tricky because outline is weird and crosses between RenderObjects. https://bugs.webkit.org/show_bug.cgi?id=106397 https://bugs.webkit.org/show_bug.cgi?id=106397 On Jul 6, 2015, at 9:26

Re: [webkit-dev] Mac EWS failures

2015-07-01 Thread Simon Fraser
This is my fault; I’ll look at this today. Simon On Jul 1, 2015, at 8:30 AM, svillar svil...@igalia.com wrote: Hi, it seems that both Mac EWS and Mac WK2 EWS are reporting this failure Regressions: Unexpected image-only failures (1) compositing/masks/compositing-clip-path-origin.html

Re: [webkit-dev] build.webkit.org issue

2015-06-08 Thread Simon Fraser
On Jun 8, 2015, at 2:12 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: it seems build.webkit.org is unavailabe since yesterday 23:13:00 (UTC). It would be great if somebody can check what happened. Thanks. We’re looking into it. Thanks Simon ___

Re: [webkit-dev] Content-DPR header

2015-05-29 Thread Simon Fraser
On May 29, 2015, at 2:11 PM, Yoav Weiss y...@yoav.ws wrote: On Fri, May 29, 2015 at 8:34 PM, Sam Weinig wei...@apple.com mailto:wei...@apple.com wrote: Hi Yoav, Can you give a concrete example of when this will be used? I’m having trouble understanding when an author will want to

Re: [webkit-dev] Clarifying 3D feature defines

2015-04-23 Thread Simon Fraser
On Apr 23, 2015, at 4:39 PM, Martin Robinson mrobin...@webkit.org wrote: In the process of cleaning up and dusting off the GTK+ cmake build system, we have rediscovered the pair of somewhat confusing feature defines WTF_USE_3D_GRAPHICS and ENABLE_3D_RENDERING. From a brief audit, it appears

Re: [webkit-dev] run-webkit-tests and run-perf-tests scripts now use WebKitTestRunner by default

2015-04-12 Thread Simon Fraser
On Mar 5, 2015, at 12:14 PM, Chris Dumez cdu...@apple.com wrote: Hi, I just wanted to let you know that run-webkit-tests and run-perf-tests now use WebKitTestRunner by default after [1]. Passing —webkit-test-runner or -2 to these scripts is no longer needed (and no longer works). If

Re: [webkit-dev] WebCore/platform standalone library

2015-03-20 Thread Simon Fraser
On Mar 20, 2015, at 11:03 AM, Edward O'Connor eocon...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object

Re: [webkit-dev] WebCore/platform standalone library

2015-03-20 Thread Simon Fraser
On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a

Re: [webkit-dev] WebKit debugging on OSX and ~/.lldbinit

2015-02-24 Thread Simon Fraser
On Feb 24, 2015, at 3:10 PM, Sylvain Galineau galin...@adobe.com wrote: I’ve recently found myself in the following situation while debugging WebKit: the debugger (Xcode) would hit a breakpoint, I would place a new breakpoint in a method up the current call stack, re-run my test and

Re: [webkit-dev] WebKit debugging on OSX and ~/.lldbinit

2015-02-24 Thread Simon Fraser
On Feb 24, 2015, at 3:29 PM, Sylvain Galineau galin...@adobe.com wrote: From: Simon Fraser Date: Tuesday, February 24, 2015 at 3:19 PM To: Adobe Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] WebKit debugging on OSX and ~/.lldbinit On Feb 24, 2015, at 3:10 PM, Sylvain

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-23 Thread Simon Fraser
On Jan 23, 2015, at 10:01 AM, Ryosuke Niwa rn...@webkit.org wrote: On Friday, January 23, 2015, Darin Adler da...@apple.com mailto:da...@apple.com wrote: On Jan 22, 2015, at 10:36 PM, Alexey Proskuryakov a...@webkit.org javascript:; wrote: 22 янв. 2015 г., в 17:57, Darin Adler

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

2015-01-22 Thread Simon Fraser
On Jan 22, 2015, at 8:44 AM, Darin Adler da...@apple.com wrote: I noticed that when running tests I get messages like this: svg/css/svg-resource-fragment-identifier-img-src.html - ref test hashes didn't match but diff passed I understand that we can have hash mismatches in actual

[webkit-dev] Myles Maxfield is now a WebKit reviewer

2015-01-07 Thread Simon Fraser
It is with great pleasure that I announce that Myles Maxfield is now a WebKit reviewer! Myles has been doing stellar work in the text and fonts code, particularly in cleaning up SVG fonts and improving our underline rendering, and is quickly becoming an expert in more areas. I look forward to

Re: [webkit-dev] enhancement - html hole element

2014-09-18 Thread Simon Fraser
On Sep 18, 2014, at 9:22 AM, Julien Isorce j.iso...@samsung.com wrote: Hi, A typical scenario when running WebKit in an embedded environment like a TV or STB is to punch through graphics to the video plane. At Samsung Research UK we have developed a new hole element that acts much

Re: [webkit-dev] FFT normalization in RealtimeAnalyser

2014-08-15 Thread Simon Fraser
Please file a bug at bugs.webkit.org. Simon On Aug 15, 2014, at 1:56 AM, Info i...@wothke.ch wrote: This seems to be a bug... that has been fixed in Chromium: see chromium\src\third_party\WebKit\Source\modules\webaudio Zitat von Info i...@wothke.ch: In order to understand the idiotic

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, This is a friendly remainder that you should comment on the associated bug email the patch author and the reviewer who reviewed the patch before rolling out / reverting a patch. If you use webkitbot to roll out, is

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
With any waiting period before actually rolling out? Simon On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa rn...@webkit.org wrote: Yes. The point is to do these things before telling webkitbot to rollout a patch. - R. Niwa On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser simon.fra

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson beid...@apple.com wrote: On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton timothy_hor...@apple.com wrote: On Jul 9,

[webkit-dev] PSA: please sort WebCore.exp.in when you change it

2014-07-07 Thread Simon Fraser
We have a handy script that sorts the export file; please use it whenever you modify WebCore.exp.in: ./Tools/Scripts/sort-export-file Source/WebCore/WebCore.exp.in It’s smart enough to understand #ifdef groupings and everything! Simon ___ webkit-dev

Re: [webkit-dev] CSS values and multiple backgrounds

2014-06-27 Thread Simon Fraser
On Jun 27, 2014, at 11:26 AM, Daniel Weber dan.j.we...@gmail.com wrote: I’m running into some trouble developing an app that needs to parse multiple CSS background values. The problem is that WebKit isn’t returning the same number of values for “background-image”, “background-position”,

[webkit-dev] Zalan Bujtas is now a WebKit reviewer

2014-06-17 Thread Simon Fraser
Hi floks! It is with great pleasure that I announce that Zalan is now a WebKit reviewer. He’s our resident subpixel expert, and in fixing many subpixel issues in layout and rendering code, has gained an extensive knowledge of the codebase, which he can now apply to reviewing your patches!

Re: [webkit-dev] Proposal: Remove ENABLE(CSS_STICKY_POSITION) guards

2014-05-16 Thread Simon Fraser
On May 14, 2014, at 4:04 AM, Mészáros Tibor mti...@inf.u-szeged.hu wrote: Hi Everyone, I’d like to propose removing ENABLE(CSS_STICKY_POSITION) guards, because all ports already enabled it by default. You can find here the original discussion about it:

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-05 Thread Simon Fraser
It allows attackers to know even more about my system, exposing more data for fingerprinting. Do you really want a page to know that you have a fancy-pants 24-core Mac Pro rather than a little Mac mini? Simon On May 5, 2014, at 4:58 PM, Filip Pizlo fpi...@apple.com wrote: I like this.

[webkit-dev] Remove USE_DYNAMIC_ANNOTATIONS?

2014-04-16 Thread Simon Fraser
Does any port define USE_DYNAMIC_ANNOTATIONS? It’s adding header pollution and no-one seems to use it. Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Make accelerated compositing mandatory

2014-02-05 Thread Simon Fraser
There’s nothing in the Accelerated Compositing code path that assumes that you are using the GPU. You just have provide a GraphicsLayer implementation. Simon On Feb 5, 2014, at 6:41 PM, Chen Zhixiang che...@cn.fujitsu.com wrote: I’d been working on enabling 3d perspective transform in

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Simon Fraser
On Jan 28, 2014, at 10:47 AM, Martin Robinson mrobin...@webkit.org wrote: On Tue, Jan 28, 2014 at 10:33 AM, Anders Carlsson ander...@apple.com wrote: I’m not a layout and rendering person, but I suspect that the burden lies in that part of WebCore. I also don’t think building with accelerated

[webkit-dev] Remove the WinCE bot?

2014-01-04 Thread Simon Fraser
The WinCE bot has been dead for almost a month: http://build.webkit.org/builders/WinCE%20Release%20%28Build%29 I propose we remove it from the waterfall. WinCairo is also in a pretty bad, non-building state. Simon ___ webkit-dev mailing list

  1   2   3   >