Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

+1! The bugzilla-style “unofficial r=me” comment was much clearer for exactly these reasons. > On Nov 28, 2023, at 10:27 AM, Chris Dumez via webkit-dev > wrote: > > Hi, > > Back in the Bugzilla days, only reviewers were allowed to r+ or r- patches. > Non-reviewers were - of course -

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:39 PM, Ryosuke Niwa wrote: > > >> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: >> >> >>> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >>> wrote: >>> >>>> One subtle thing is that even

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:34 PM, Darin Adler wrote: > > >> On Aug 21, 2023, at 4:31 PM, Tim Horton via webkit-dev >> wrote: >> >>> One subtle thing is that even when a member variable is already Ref / >>> RefPtr / CheckedRef / CheckedPtr, we

Re: [webkit-dev] Smart Pointers Usage Guidelines

> On Aug 21, 2023, at 4:25 PM, Ryosuke Niwa via webkit-dev > wrote: > > Hi all, > > It has been a while since I last announced the plan to adopt smart pointers > using clang static analyzer: > https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html > > Here are some

Re: [webkit-dev] OK to flatten WTF's header directory?

> On Feb 1, 2022, at 12:30 PM, Elliott Williams via webkit-dev > wrote: > > Hi webkit-dev, > > I’m working on fixing some ambiguities in our Xcode projects to permit > adoption of Xcode’s new build system and better parallelize our builds. I > noticed that WTF’s headers

[webkit-dev] Aditya Keerthi is now a WebKit reviewer!

Hello! I am delighted to announce that Aditya Keerthi is now a WebKit reviewer. Now it's time for all of you to send him tricky patches and see how he does :) Congratulations, Aditya! --Tim ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] New EWS Non-Unified builder

> On Apr 29, 2021, at 9:02 PM, Darin Adler wrote: > >> On Apr 29, 2021, at 9:01 PM, Tim Horton wrote: >> >> This is a huge problem for people on the Apple platforms using the Xcode >> projects. Nearly every time someone adds a file they have to add random >> headers to unrelated code. > >

Re: [webkit-dev] New EWS Non-Unified builder

> On Apr 29, 2021, at 7:15 PM, Darin Adler via webkit-dev > wrote: > >> On Apr 29, 2021, at 12:04 PM, Ross Kirsling via webkit-dev >> wrote: >> >> Yeah, I think it's important to clarify that nobody is "using >> non-Unified-Source building for their development", at least to my >>