Re: [webkit-dev] build.webkit.org down

2013-01-25 Thread Tony Chang
On Fri, Jan 25, 2013 at 9:30 AM, William Siegrist wsiegr...@apple.comwrote: Here are the largest results sets on the master in GB. We currently store 6.8TB of total results, going back 14 months, and 1.1TB of archives going back 1 week. 1500Apple MountainLion (Leaks) 1018Chromium

Re: [webkit-dev] Commit queue stopped working

2013-01-24 Thread Tony Chang
If Chromium DRT crashes, it will leak temp files. Maybe run-webkit-tests should try to clean these up? On Thu, Jan 24, 2013 at 10:15 AM, Adam Barth aba...@webkit.org wrote: Thanks for the note. We seem to have a temp file leak in run-webkit-tests. I'm rebuilding the machines now. Adam

Re: [webkit-dev] generic test expectations?

2012-11-13 Thread Tony Chang
On Tue, Nov 13, 2012 at 11:35 AM, Dirk Pranke dpra...@chromium.org wrote: On Tue, Nov 13, 2012 at 11:29 AM, Glenn Adams gl...@skynav.com wrote: On Tue, Nov 13, 2012 at 12:09 PM, Dirk Pranke dpra...@chromium.org wrote: We don't currently support port-specific reftests (or at least, not

Re: [webkit-dev] generic test expectations?

2012-11-13 Thread Tony Chang
On Tue, Nov 13, 2012 at 12:04 PM, Darin Adler da...@apple.com wrote: On Nov 13, 2012, at 12:02 PM, Tony Chang t...@chromium.org wrote: I don't think we should support port specific ref test results. That kind of misses the point of using a ref test in the first place. I mean, you may

Re: [webkit-dev] Settings and Preferences in layout tests

2012-09-26 Thread Tony Chang
On Wed, Sep 26, 2012 at 2:35 PM, Brady Eidson beid...@apple.com wrote: On Sep 26, 2012, at 2:05 PM, Adam Barth aba...@webkit.org wrote: [re-sent from the proper address] On Wed, Sep 26, 2012 at 2:00 PM, Adam Barth abarth@nowhere wrote: On Wed, Sep 26, 2012 at 1:53 PM, Brady Eidson

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Tony Chang
On Thu, Jul 19, 2012 at 11:35 AM, Oliver Buchtala oliver.bucht...@googlemail.com wrote: On 19.07.2012 20:26, Maciej Stachowiak wrote: On Jul 19, 2012, at 11:01 AM, Oliver Buchtala oliver.buchtala@googlemail.**com oliver.bucht...@googlemail.com wrote: FWIW, there is a gdb python API for

Re: [webkit-dev] How to specify the window size in DumpRenderTree?

2012-02-24 Thread Tony Chang
In your test case, you should be able to use window.resizeTo to change the size of the window. On Fri, Feb 24, 2012 at 5:01 AM, Mayur K emineme...@gmail.com wrote: Hi, I want to specify the window size/view size in DumpRenderTree, so that rendertree, can reflect the structure according to the

Re: [webkit-dev] Style bot complains of missing binary data in diff when deleting .png test results

2011-12-01 Thread Tony Chang
The change you suggest for VCSUtils.pm seems fine to me, but if you use 'webkit-patch upload', it'll generate a diff that svn-apply can successfully apply. On Wed, Nov 30, 2011 at 5:42 PM, Alan Stearns stea...@adobe.com wrote: David, This is a bug where I accidentally turned on a pixel

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-18 Thread Tony Chang
PM, Dirk Pranke dpra...@chromium.org wrote: On Thu, Nov 17, 2011 at 5:06 PM, Eric Seidel e...@webkit.org wrote: On Thu, Nov 17, 2011 at 4:53 PM, Tony Chang t...@chromium.org wrote: new-run-webkit-httpd imports common/host.py which imports lots of stuff including common/net/buildbot.py, which

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-17 Thread Tony Chang
Only new-run-webkit-tests uses python 2.7 on the leopard bots. There are other bot steps in chromium that would break. I mention a couple cases here: http://code.google.com/p/chromium/issues/detail?id=103266#c6 Alternately, we could try to fully switch the leopard bots to 2.7 (

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-17 Thread Tony Chang
what breaks. We can always roll it out if things are really bad. I'll prepare an updated patch. -eric On Thu, Nov 17, 2011 at 4:37 PM, Tony Chang t...@chromium.org wrote: Only new-run-webkit-tests uses python 2.7 on the leopard bots. There are other bot steps in chromium

Re: [webkit-dev] Tools/Scripts/webkit-patch rebaseline-expectations does not launch html comparison page?

2011-11-08 Thread Tony Chang
On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger epo...@chromium.org wrote: Perhaps I should approach this from a different angle: What is the recommended procedure for: - generating new baseline images for a few dozen failing tests, on various platforms webkit-patch rebaseline-expectations

Re: [webkit-dev] Removing Support for Python 2.5

2011-11-04 Thread Tony Chang
Are you sure? This output has references to System/Library/Frameworks/Python.framework/Versions/2.5. I also thought that's why NRWT was slow on the Leopard bots: python 2.5 doesn't have the multiprocess module.

Re: [webkit-dev] Best practices for failing a flaky tests (was Re: Switching to new-run-webkit-tests)

2011-07-07 Thread Tony Chang
One difference with the chromium port is that we try to use a single test_expectations.txt that covers all platforms and OS versions (win xp, vista, 7, mac leopard, snow leopard, linux 32, 64, GPU vs CPU, Debug vs Release). The tokens to the left of the test name specify what configuration the

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-13 Thread Tony Chang
-ordinal stuff is very slow, etc. I think some of the bugs you tried to fix already should inform this somewhat. Definitely keep rendering experts in the loop on this and have fun implementing! Dave On Jun 8, 2011, at 10:57 AM, Tony Chang wrote: Hi webkit-dev, I wanted to let you know

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-13 Thread Tony Chang
Err, ENABLE_NEW_FLEXBOX. On Mon, Jun 13, 2011 at 9:37 AM, Tony Chang t...@chromium.org wrote: Sure, no problem. I'll rename it to ENALBE_NEW_FLEXBOX. On Fri, Jun 10, 2011 at 6:12 PM, Sam Weinig wei...@apple.com wrote: Since it is confusing to me (and may be to others), perhaps a different

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-10 Thread Tony Chang
On Thu, Jun 9, 2011 at 3:55 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 9, 2011, at 3:00 PM, Tony Chang wrote: On Thu, Jun 9, 2011 at 1:19 PM, Sam Weinig wei...@apple.com wrote: If the issue is the syntax for describing flexing, perhaps the spec should be written in a backwards

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-09 Thread Tony Chang
syntax. I think it's possible to implement the old flexbox on top of the new flexbox implementation and that seems like a worthwhile goal, but it'll probably easier to see the similarities for refactoring after the code has been written. On Jun 8, 2011, at 10:57 AM, Tony Chang wrote: Hi webkit

[webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-08 Thread Tony Chang
Hi webkit-dev, I wanted to let you know that Ojan and I plan to add flexbox layout support to WebCore. WebCore already supports an older flexbox implementation (display: box), but the new spec is designed to be easier for developers to understand and more powerful. The old flexbox will still

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-08 Thread Tony Chang
ports and use the regular bots? Adam On Wed, Jun 8, 2011 at 10:57 AM, Tony Chang t...@chromium.org wrote: Hi webkit-dev, I wanted to let you know that Ojan and I plan to add flexbox layout support to WebCore. WebCore already supports an older flexbox implementation

Re: [webkit-dev] Adding ENABLE_FLEXBOX to WebCore

2011-06-08 Thread Tony Chang
we just define ENABLE_FLEXBOX on one or more of the commonly used ports and use the regular bots? Adam On Wed, Jun 8, 2011 at 10:57 AM, Tony Chang t...@chromium.org wrote: Hi webkit-dev, I wanted to let you know that Ojan and I plan to add flexbox layout support

Re: [webkit-dev] Cross-platform fonts for Layout Tests

2011-06-02 Thread Tony Chang
Perhaps, but in practice, it's not enough. Here's an ahem pixel test that is slightly different on Mac and Chromium Linux: http://trac.webkit.org/browser/trunk/LayoutTests/platform/mac/fast/block/basic/010-expected.png

[webkit-dev] checksum files are no longer used by layout tests

2011-04-21 Thread Tony Chang
I've just committed the change to run-webkit-tests (old and new) to have it ignore .checksum files and instead read image checksums from png files. This is why there were big checkouts during the last few days as I was updating the old .png files to have checksums embedded. I'll be doing a

[webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Tony Chang
I propose that we move away from checking in separate .checksum files for pixel tests and instead embed the checksum in the .png file as a comment. There are two main benefits of doing this: 1) Less files in the tree - faster git/svn operations. Currently, in LayoutTests, 32,650 out of 141,170

Re: [webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Tony Chang
Yes, reading the checksum is the same speed as before. We write the png comment at the beginning of the file and only scan the first 2k of the file for the checksum. I also tried converting about 200 tests to use embedded checksums and found no speed difference. I've already updated

Re: [webkit-dev] Supporting css ime-mode property

2010-10-05 Thread Tony Chang
On Tue, Oct 5, 2010 at 9:27 AM, Alexey Proskuryakov a...@webkit.org wrote: So far, the only accurate use case that I've seen was developing a UI for a back-end that doesn't support non-ASCII characters in some fields. I don't think we should extend the Web platform just to support apps that

Re: [webkit-dev] deduplicate-results

2010-09-03 Thread Tony Chang
I removed all of chromium's duplicate results, which was a bulk of the duplicates. I think there were a total of about 670 duplicate files and I deleted about 500 or so. The remaining duplicates are mostly cases where the same result file is in mac and mac-leopard. I can delete those on Monday.

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-09-03 Thread Tony Chang
Hi Chris, I'm curious what elements the UIRequestEvents apply to. Does it fire at the document level or does it fire for specific elements like textareas? The addition of undo/redo is similar to the proposal to add this to the textInput event. There was some discussion of that here:

Re: [webkit-dev] [webkit-changes] [61728] trunk

2010-06-24 Thread Tony Chang
Yes: https://bugs.webkit.org/show_bug.cgi?id=31387 . I will update the Skipped file to include a link to the bug. On Fri, Jun 25, 2010 at 2:14 AM, Alexey Proskuryakov a...@webkit.org wrote: 23.06.2010, в 19:54, t...@chromium.org написал(а): --- trunk/LayoutTests/platform/mac/Skipped