[webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Tony Payne
I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference are 20% red and large differences are 100% red. Looking at the code for CG,

Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Tony Payne
On Fri, Jun 15, 2012 at 4:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-12 Thread Tony Payne
On Wed, Apr 11, 2012 at 4:58 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 11, 2012 at 4:56 PM, Tony Payne tpa...@chromium.org wrote: Some of these test result changes turn out to be the effect of incorrect test cases. For example, compositing/color-matching/image-color

[webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
Given the recent discussion on test_expectations.txt, perhaps the answer to my question is still up in the air. I'm working on a change that I expect to require changing the expectations for about 75 tests on chromium win and linux. https://trac.webkit.org/wiki/Rebaseline seems to only cover the

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
All code I'm changing is inside of #if PLATFORM(CHROMIUM) blocks. Thanks for the quick answer. Tony On Wed, Apr 11, 2012 at 2:03 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Apr 11, 2012 at 1:57 PM, Tony Payne tpa...@chromium.org wrote: Given the recent discussion

Re: [webkit-dev] Process for making changes that affect layout test results

2012-04-11 Thread Tony Payne
working on Chromium Linux or Win, you'd include the new expected results for that platform in your initial commit/code-review as well. On Wed, Apr 11, 2012 at 2:09 PM, Tony Payne tpa...@chromium.org wrote: All code I'm changing is inside of #if PLATFORM(CHROMIUM) blocks. Thanks for the quick

[webkit-dev] Fwd: Please add EditBugs to my account

2012-03-26 Thread Tony Payne
Error message in webkit-patch upload says to email webkit-committers, but that message is not going through and I've been told this is the proper list to request the EditBugs permission. Thanks, Tony -- Forwarded message -- From: Tony Payne tpa...@chromium.org Date: Thu, Mar 22