Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote: I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary library. I'm not sure where this weird idea of developing a closed

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Geoffrey Garen gga...@apple.com wrote: I'm not really interested in helping with the dubiously legal task of taking JavaScriptCore, which is an OpenSource library, and turning it into a closed, proprietary library. I've talked to my client, and he's told me

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Jeremy Orlow jor...@chromium.org wrote: IANAL (and correct me if I'm wrong), but 1) Parts of WebKit are licensed under the LGPL 2) Even if you're not modifying (or copying code from) files licensed under the LGPL, any files linked to those LGPL files are governed by

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-17 Thread Toshiyasu Morita
kenneth.christian...@openbossa.org wrote: That doesn't mean that you cannot develop it in the open. We can integrate the code once you are ready to do so. Kenneth You're preaching to the choir. It's not my decision to make. Toshi

[webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-16 Thread Toshiyasu Morita
I've gotten the MIPS port up to where it can compile and execute through about 9 functions of a testcase before it crashes. The reason for the crash appears to be related to op_put_by_id. When this opcode is compiled, the JIT executes: void JIT::compilePutByIdSlowCase(int baseVReg, Identifier*

Re: [webkit-dev] MIPS port problem - cti_op_put_by_id slow case problem

2009-06-16 Thread Toshiyasu Morita
case problem To: Toshiyasu Morita tm_web...@yahoo.com Cc: webkit-dev@lists.webkit.org Date: Wednesday, June 17, 2009, 12:02 AM It's cool that you are working on a MIPS port of the JIT. However, it's somewhat off-topic to ask for help with private ports here. There's also not much we can do to help

Re: [webkit-dev] ARM JIT and related issues

2009-06-16 Thread Toshiyasu Morita
--- On Wed, 6/17/09, Maciej Stachowiak m...@apple.com wrote: 5) Gavin has been a strong proponent of using MacroAssembler as the primary CPU abstraction layer, and that approach has worked reasonably well so far. However, it seems at least to me that CPUs with very different instruction sets may

Re: [webkit-dev] arm jit

2009-06-11 Thread Toshiyasu Morita
--- On Wed, 6/10/09, Gavin Barraclough barraclo...@apple.com wrote:   If you consider calling a JS function with too few arguments as being akin to = invoking a C++ method with some defaulted parameters not-provided, then it is also the responsibility of code generated for the call to such

[webkit-dev] Trampoline problem

2009-06-11 Thread Toshiyasu Morita
I've tracked down a crash in our JIT port to a problem with the trampoline generation. The symptom of the crash is: the ScopeChain becomes corrupted and acquires the value of 1. void JIT::privateCompileCTIMachineTrampolines(RefPtrExecutablePool* executablePool, void**

Re: [webkit-dev] arm jit

2009-06-10 Thread Toshiyasu Morita
Gavin Barraclough barraclo...@apple.com wrote: We were (and remain) reluctant to accept a duplicate of the JIT into the tree, rather than a port of the existing JIT utilizing the MacroAssembler abstraction.  We are concerned that it would be extremely difficult to continue to maintain such

Re: [webkit-dev] arm jit

2009-06-10 Thread Toshiyasu Morita
--- On Wed, 6/10/09, Geoffrey Garen gga...@apple.com wrote: I'm having a hard time understanding from your comment what optimization changes you think are appropriate, but if you can produce a patch that implements your idea, and shows a benefit on a benchmark, I'd be happy to review it.

Re: [webkit-dev] arm jit

2009-06-10 Thread Toshiyasu Morita
...@apple.com wrote: From: Geoffrey Garen gga...@apple.com Subject: Re: [webkit-dev] arm jit To: Oliver Hunt oli...@apple.com Cc: Toshiyasu Morita tm_web...@yahoo.com, WebKit Development webkit-dev@lists.webkit.org Date: Wednesday, June 10, 2009, 9:14 PM It could be worth trying a stub function

Re: [webkit-dev] arm jit

2009-06-10 Thread Toshiyasu Morita
--- On Wed, 6/10/09, Oliver Hunt oli...@apple.com wrote:   I doubt that eager compilation would be a good strategy for the web, though, since web pages tend to load very large libraries of functions, while only calling a small percentage of those functions. Turbo C compiled about 10,000

[webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
I don't understand this code in JITStubs::cti_op_call_arityCheck():     ASSERT(argCount != newCodeBlock-m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could understand if it was ensuring the argCount was the same,

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Toshiyasu Morita
Thanks guys. One request - please write more comments in the code to clarify situations like this. Toshi --- On Thu, 6/4/09, Darin Adler da...@apple.com wrote: From: Darin Adler da...@apple.com Subject: Re: [webkit-dev] cti_op_call_ArityCheck question To: Toshiyasu Morita tm_web...@yahoo.com