[webkit-dev] virtual destructor annotations in subclasses

2019-10-08 Thread Yury Semikhatsky
Hi all, This question came up in a code review where I annotated subclass's destructor with 'override': class SuperClass { public: virtual ~SuperClass() {} }; class Subclass : public SuperClass { public: ~Subclass() *override*; }; The style guide recommends

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Yury Semikhatsky
On Tue, Jul 24, 2012 at 12:47 AM, Maciej Stachowiak m...@apple.com wrote: On Jul 23, 2012, at 8:09 AM, Yury Semikhatsky yu...@chromium.org wrote: * First option we consider is to define a class with the same set of fields as the instrumented one, then have a compile time assert that size

[webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
*Hi WebKit, Almost all developers would like to know why the render process takes so much memory. We are trying to address this problem by providing an information on how much memory is consumed by some high-level WebKit parts(DOM, CSS, JavaScript etc) . Currently there is a real-time chart in

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
On Mon, Jul 23, 2012 at 8:07 PM, Zoltan Horvath zol...@webkit.org wrote: Hi there, On Mon, 23 Jul 2012 17:09:19 +0200, Yury Semikhatsky yu...@chromium.org wrote: *Hi WebKit, Almost all developers would like to know why the render process takes so much memory. We are trying to address

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Yury Semikhatsky
On Mon, Jul 23, 2012 at 11:21 PM, Ryosuke Niwa rn...@webkit.org wrote: This is somewhat tangential but once we've solved this problem, can we expose the data via testRunner or internals object so that we may use it in our performance tests? It'll be very valuable to be able to monitor changes

Re: [webkit-dev] Single location for people wanting to learn to use dev tools WAS: Blog post draft: dealing with exceptions using Web Inspector

2011-04-14 Thread Yury Semikhatsky
site. it contains links to all Web Inspector blog posts. On Wed, Apr 13, 2011 at 2:02 AM, Yury Semikhatsky yu...@chromium.orgwrote: Including the draft content inline for those who don't have post permissions. Thanks, Yury Web Inspector: Understanding Stack Traceshttp://www.webkit.org

Re: [webkit-dev] Single location for people wanting to learn to use dev tools WAS: Blog post draft: dealing with exceptions using Web Inspector

2011-04-14 Thread Yury Semikhatsky
, 2011 at 2:02 AM, Yury Semikhatsky yu...@chromium.orgwrote: I don't see this stack trace in the inspector when i try it :-/ Good point, I should have probably added a notice that I used a slightly modified version of the hovercard example from the Closure library to get the errors in a real code

Re: [webkit-dev] Blog post draft: dealing with exceptions using Web Inspector

2011-04-13 Thread Yury Semikhatsky
Including the draft content inline for those who don't have post permissions. Thanks, Yury Web Inspector: Understanding Stack Traceshttp://www.webkit.org/blog/?p=1544Posted by *Yury Semikhatsky* on Wednesday, April 13th, 2011 at 1:44 am Finding errors in JavaScript code both during

Re: [webkit-dev] WebCore: Exposing exceptions through WebFrameImpl::executeScriptAndReturnValue and ScriptController::executeScript.

2010-12-22 Thread Yury Semikhatsky
=5l=260 Not sure what this conversion is used for. Yury On Wed, Dec 22, 2010 at 2:35 PM, Yury Semikhatsky yu...@chromium.org wrote: Hi Tom, In case of uncaught JS exception returned v8::Handle will always be empty (v8::Handlev8::Value::IsEmpty() will return true) while in case

Re: [webkit-dev] WebCore: Exposing exceptions through WebFrameImpl::executeScriptAndReturnValue and ScriptController::executeScript.

2010-12-22 Thread Yury Semikhatsky
, this looks like a bug and proper fix would be to remove this conversion from that place. We need to double check that this won't break Chromium's code. On Wed, Dec 22, 2010 at 4:41 PM, Yury Semikhatsky yu...@chromium.org wrote: On Wed, Dec 22, 2010 at 7:22 PM, Tom Rathbone tom.rathb

Re: [webkit-dev] !ENABLE(INSPECTOR)

2010-11-13 Thread Yury Semikhatsky
I don't think there is a particular person who maintains that option. Instead if you cannot find the change which broke it and file a bug against the author you could file a bug against the web inspector component( webkit.org/new-inspector-bug) and we'll take care of it. In this particular case

Re: [webkit-dev] InspectorDebuggerAgent::didPause function

2010-10-19 Thread Yury Semikhatsky
Hi Tomasz, There is no need to differentiate between pause due to an exception and due to a breakpoint hit and there are no means to determine that in InspectorDebuggerAgent::didPause. Detailed information about the break event is available in