[webkit-dev] onselectionchange when clicked on img

2013-02-15 Thread vineeth
Hello,
I have a usecase in which I need document.onselectionchange to be fired
when I click on an img, the way it happens for text nodes. Can someone pls
help the function/class to look into. I am currently going through
EventHandler.cpp and
EventHandler::updateSelectionForMouseDownDispatchingSelectStart but haven't
made much progress.

Thanks.
--Vineeth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] onselectionchange when clicked on img

2013-02-15 Thread vineeth
Hi,
Thanks for your reply. I think selectionchange isn't getting fired. I
created a simple page with some text and some images and added this event
handler:
document.onselectionchange=function(){ console.log('sel changed'); }

Now when I click anywhere on a text region this function is called. However
clicking on a image isn't firing this event. I tried the above experiment
on chrome  24.0.1312.57 m

Is this a bug and should I file a bug report for this?
If I need to add this behavior which classes should I look into?

Thanks.

--Vineeth


On Fri, Feb 15, 2013 at 3:42 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We should be firing selectionchange event. It's fired in
 FrameSelection::setSelection but our implementation of selectionchange
 event is asynchronous.

 On Fri, Feb 15, 2013 at 2:07 AM, vineeth nvine...@gmail.com wrote:

 Hello,
 I have a usecase in which I need document.onselectionchange to be fired
 when I click on an img, the way it happens for text nodes. Can someone pls
 help the function/class to look into. I am currently going through
 EventHandler.cpp and
 EventHandler::updateSelectionForMouseDownDispatchingSelectStart but
 haven't made much progress.

 Thanks.
 --Vineeth

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] onselectionchange when clicked on img

2013-02-15 Thread vineeth
I have filed the bug https://bugs.webkit.org/show_bug.cgi?id=110004
Thanks.

--Vineeth


On Fri, Feb 15, 2013 at 11:41 PM, Ryosuke Niwa rn...@webkit.org wrote:

 Possibly. Please file a bug with a reduction (simplest HTML where this
 bug/behavior is observable) and cc me.


 On Fri, Feb 15, 2013 at 3:22 AM, vineeth nvine...@gmail.com wrote:

 Hi,
 Thanks for your reply. I think selectionchange isn't getting fired. I
 created a simple page with some text and some images and added this event
 handler:
 document.onselectionchange=function(){ console.log('sel changed'); }

 Now when I click anywhere on a text region this function is called.
 However clicking on a image isn't firing this event. I tried the above
 experiment on chrome  24.0.1312.57 m

 Is this a bug and should I file a bug report for this?
 If I need to add this behavior which classes should I look into?

 Thanks.

 --Vineeth


 On Fri, Feb 15, 2013 at 3:42 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We should be firing selectionchange event. It's fired in
 FrameSelection::setSelection but our implementation of selectionchange
 event is asynchronous.

 On Fri, Feb 15, 2013 at 2:07 AM, vineeth nvine...@gmail.com wrote:

 Hello,
 I have a usecase in which I need document.onselectionchange to be
 fired when I click on an img, the way it happens for text nodes. Can
 someone pls help the function/class to look into. I am currently going
 through EventHandler.cpp and
 EventHandler::updateSelectionForMouseDownDispatchingSelectStart but
 haven't made much progress.

 Thanks.
 --Vineeth

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] FrameView::setBaseBackgroundColor

2012-10-26 Thread vineeth
Hi all,
  I had a doubt regardingFrameView::setBaseBackgroundColor. Is it used to
set the default background color of the web page? say for example if
background css property is not preset, I can use this API is override the
default white color?
Thanks,
--Vineeth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] developing for web inspector

2012-09-08 Thread vineeth
Hi all,
  I was interested to add features for web inspector and do some
hacking. I wanted to know from where should I get started. I believe
that the src code of webkit is pretty big, so is it possible to
download a test app which comes with web inspector files and start
working on the web inspector? I tried with the Chromium canary build,
but couldn't find the web inspector files in the installation
(probably packaged in some dll?). Can someone pls guide me about
getting started?
Thanks.
Br,
--Vineeth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] developing for web inspector

2012-09-08 Thread vineeth
Found it here : http://trac.webkit.org/wiki/HackingWebInspector
Thanks,
--Vineeth


On Sat, Sep 8, 2012 at 2:28 PM, vineeth nvine...@gmail.com wrote:
 Hi all,
   I was interested to add features for web inspector and do some
 hacking. I wanted to know from where should I get started. I believe
 that the src code of webkit is pretty big, so is it possible to
 download a test app which comes with web inspector files and start
 working on the web inspector? I tried with the Chromium canary build,
 but couldn't find the web inspector files in the installation
 (probably packaged in some dll?). Can someone pls guide me about
 getting started?
 Thanks.
 Br,
 --Vineeth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] inspecting the web inspector

2012-09-08 Thread vineeth
Hi all,
I followed the steps listed here :
http://trac.webkit.org/wiki/HackingWebInspector , however I am unable
to get the Inspect element in the web inspector panel as shown in
this figure : 
http://trac.webkit.org/attachment/wiki/HackingWebInspector/inspect.png
Am I missing something? My webkit nightly build is WebKit r127963 and
safari version is 5.1.7 and OS is Windows 7
Also the changes made in
WebKit-r127963\WebKit.resources\inspector\inspectorSyntaxHighlight.css
are not getting reflected. ( I tried refreshing and then restarting
the test app in nightly build, but of no help)
Can somebody pls guide me in this.
Thanks,
--Vineeth
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev