[webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/ScriptElement.h (96818 = 96819) --- trunk/Source/WebCore/dom/ScriptElement.h 2011-10-06 16:37:35 UTC (rev 96818) +++ trunk/Source/WebCore/dom/ScriptElement.h 2011-10-06 16:40:47 UTC (rev 96819)

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread 蓋文彼德斯
Dan, You're right. I'm adding #if PLATFORM(CHROMIUM) to this change shortly. - Gavin On 6 October 2011 13:07, Dan Bernstein m...@apple.com wrote: On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: Modified: trunk/Source/WebCore/dom/ScriptElement.h (96818 = 96819) ---

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Darin Fisher
I agree that this seems like something to #ifdef. Out of curiosity, did you just stumble upon this, or did you actually notice a measurable performance regression from this? -Darin On Thu, Oct 6, 2011 at 10:07 AM, Dan Bernstein m...@apple.com wrote: On Oct 6, 2011, at 9:40 AM,

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
On Oct 6, 2011, at 10:12 AM, Darin Fisher wrote: I agree that this seems like something to #ifdef. Out of curiosity, did you just stumble upon this, or did you actually notice a measurable performance regression from this? I just noticed the patch go by. -Darin On Thu, Oct 6,

Re: [webkit-dev] Always-on diagnostic code Re: [webkit-changes] [96819] trunk/Source/WebCore

2011-10-06 Thread Dan Bernstein
On Oct 6, 2011, at 10:11 AM, Gavin Peters (蓋文彼德斯) wrote: Dan, You're right. I'm adding #if PLATFORM(CHROMIUM) to this change shortly. Thank you. - Gavin On 6 October 2011 13:07, Dan Bernstein m...@apple.com wrote: On Oct 6, 2011, at 9:40 AM, gav...@chromium.org wrote: