Re: [webkit-dev] Can we remove ENABLE_STREAMS_API compile flag?
There are no objections after 5 business days. I'll start to work this in https://bugs.webkit.org/show_bug.cgi?id=213728 -- Tetsuharu OHZEKI tetsuharu.ohz...@gmail.com On Fri, Jun 19, 2020 at 4:21 PM youenn fablet wrote: > > This would be a nice simplification. > > Le ven. 19 juin 2020 à 01:02, Tetsuharu OHZEKI > a écrit : > > > > Hi WebKitten, > > > > As I see the following codes and grep, I seem today's all (?) ports of > > WebKit > > have enabled ENABLE_STREAMS_API flag by default. > > > > - > > https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466 > > - > > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104 > > - > > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58 > > - > > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87 > > - > > https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210 > > - > > https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276 > > > > If my assumption is right, I'd like to propose to remove this > > `ENABLE_STREAMS_API` flag. > > > > What do you think about this? > > If I missed some ports, please tell me about them. > > > > -- > > Tetsuharu OHZEKI > > tetsuharu.ohz...@gmail.com > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Can we remove ENABLE_STREAMS_API compile flag?
This would be a nice simplification. Le ven. 19 juin 2020 à 01:02, Tetsuharu OHZEKI a écrit : > > Hi WebKitten, > > As I see the following codes and grep, I seem today's all (?) ports of WebKit > have enabled ENABLE_STREAMS_API flag by default. > > - > https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466 > - > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104 > - > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58 > - > https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87 > - > https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210 > - > https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276 > > If my assumption is right, I'd like to propose to remove this > `ENABLE_STREAMS_API` flag. > > What do you think about this? > If I missed some ports, please tell me about them. > > -- > Tetsuharu OHZEKI > tetsuharu.ohz...@gmail.com > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Can we remove ENABLE_STREAMS_API compile flag?
Hi WebKitten, As I see the following codes and grep, I seem today's all (?) ports of WebKit have enabled ENABLE_STREAMS_API flag by default. - https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466 - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104 - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58 - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87 - https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210 - https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276 If my assumption is right, I'd like to propose to remove this `ENABLE_STREAMS_API` flag. What do you think about this? If I missed some ports, please tell me about them. -- Tetsuharu OHZEKI tetsuharu.ohz...@gmail.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
