Re: [webkit-dev] Documenting common null pointer errors
On Tue, Oct 6, 2009 at 2:49 PM, Jeremy Orlow jor...@chromium.org wrote: Did this ever get linked from the home page? Nope. The web site is in SVN. Go ahead and file a bug and attach a patch. :) Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Documenting common null pointer errors
k On Tue, Oct 6, 2009 at 3:00 PM, Adam Barth aba...@webkit.org wrote: On Tue, Oct 6, 2009 at 2:49 PM, Jeremy Orlow jor...@chromium.org wrote: Did this ever get linked from the home page? Nope. The web site is in SVN. Go ahead and file a bug and attach a patch. :) Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Documenting common null pointer errors
Adam Barth wrote: This is now up on the site: http://webkit.org/coding/major-objects.html It's not linked from anywhere yet. It might be a good idea for a couple of folks to look at it. It reflects my understanding of how things work, which might well be wrong. NULL after navigation could be clearer - it suggests that DOMWindow and everything below it only exists if you type the URL, but not if a page is loaded by clicking a link, which can't be true. Does it mean that it's NULL immediately after navigation, while waiting for the load, and is replaced by a valid pointer after loading? Joe ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Documenting common null pointer errors
On Tue, Aug 11, 2009 at 3:59 PM, Eric Seidel e...@webkit.org wrote: Didn't we just have a thread about this a couple weeks ago, and decided that it's better if the Compiler checked/documented this sort of thing? Oliver had worked on some classes to enforce null checking iirc... This is related but different. It's more about documenting the dependencies and how/when things become null rather than whether they _can_ become null. Speaking of which, is anyone working on that other idea? J ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Documenting common null pointer errors
Ok, here's my lame attempt at ASCII art: https://bugs.webkit.org/show_bug.cgi?id=28210 Adam On Tue, Aug 11, 2009 at 3:55 PM, Maciej Stachowiakm...@apple.com wrote: On Aug 11, 2009, at 3:03 PM, Adam Barth wrote: In reviewing patches, I feel like I'm commonly pointing out DOMWindow::frame and Document::frame, etc, can be null in some circumstances. Would it be useful to have a diagram of the major objects (Page, Frame, DOMWindow, Document, etc) somewhere on webkit.org that shows their relation, which links can be null, and which objects change / are preserved during navigation? If so, I'm happy to create this with my current knowledge, and hopefully folks with more experience will add parts that I don't know. What's the best medium to make this easy to update in the future? SVG? ASCII art? It would be useful to make such a diagram. Also hard to make it accurate! I'd be happy to provide information and advice to anyone working on this. I'm not sure what format to use to capture the data. In the abstract, my preference would be a plain text file that could be transformed into diagrams in various chosen formats, but that depends on what kind of data we capture. Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
