Re: [webkit-dev] LayoutTest results choose from which folder?
On Sun, Aug 23, 2009 at 12:23 PM, Dan Bernsteinm...@apple.com wrote: On Aug 23, 2009, at 11:28 AM, Dirk Pranke wrote: Hi Chris, In layout test results, we make the latest Mac OS X version the rule, and earlier versions the exception. Tiger will look for results in mac-tiger first, then in mac-leopard, then in mac-snowleopard, then in mac, then finally in cross-platform results. Leopard will begin the search in mac-leopard, continue to mac-snowleopard, then mac, the cross-platform. As you can see, there are no expected results in mac-snowleopard (other than the ones you just added), because it’s the latest Mac OS X version. We will only start putting expected results in mac-snowleopard when the “latest” version (for which we put results in mac) will be something different. You should put the expected results for Snow Leopard in platform/mac (or, if they are cross-platform, alongside the test), and you should put the results for Leopard and earlier in platform/mac-leopard. —Dan Does this imply that if you've moved results from 'platform/mac' to 'platform/mac-leopard' when you switched from 10.5 to 10.6? (Since, presumable, some results that were in platform/mac were actually specific to 10.5?) Yes, when the expected results of an existing test change under a new version of Mac OS X, legacy expected results are moved from platform/mac to platform/mac-last version with legacy behavior and current expected results are put in platform/mac. http://trac.webkit.org/changeset/47052 is an example. Hi Dan, Thanks for the explanation, that definitely helps. Out of curiosity, when do you make the platform switch? For example, when did mac stop equalling leopard and start equaling snowleopard? It looks like we will adopt the same convention as you, for consistency's sake, and so I'd like to mirror it as closely as possible. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] LayoutTest results choose from which folder?
On Aug 25, 2009, at 4:38 PM, Dirk Pranke wrote: On Sun, Aug 23, 2009 at 12:23 PM, Dan Bernsteinm...@apple.com wrote: On Aug 23, 2009, at 11:28 AM, Dirk Pranke wrote: Hi Chris, In layout test results, we make the latest Mac OS X version the rule, and earlier versions the exception. Tiger will look for results in mac-tiger first, then in mac-leopard, then in mac-snowleopard, then in mac, then finally in cross-platform results. Leopard will begin the search in mac-leopard, continue to mac-snowleopard, then mac, the cross- platform. As you can see, there are no expected results in mac-snowleopard (other than the ones you just added), because it’s the latest Mac OS X version. We will only start putting expected results in mac-snowleopard when the “latest” version (for which we put results in mac) will be something different. You should put the expected results for Snow Leopard in platform/ mac (or, if they are cross-platform, alongside the test), and you should put the results for Leopard and earlier in platform/mac-leopard. —Dan Does this imply that if you've moved results from 'platform/mac' to 'platform/mac-leopard' when you switched from 10.5 to 10.6? (Since, presumable, some results that were in platform/mac were actually specific to 10.5?) Yes, when the expected results of an existing test change under a new version of Mac OS X, legacy expected results are moved from platform/mac to platform/mac-last version with legacy behavior and current expected results are put in platform/mac. http://trac.webkit.org/changeset/47052 is an example. Hi Dan, Thanks for the explanation, that definitely helps. Out of curiosity, when do you make the platform switch? For example, when did mac stop equalling leopard and start equaling snowleopard? The platform/mac-snowleopard directory was created in r41710 on 2009-03-14, and the required changes to the expected result search order were made in r41956 on 2009-03-24. It looks like we will adopt the same convention as you, for consistency's sake, and so I'd like to mirror it as closely as possible. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] LayoutTest results choose from which folder?
Hi Chris, In layout test results, we make the latest Mac OS X version the rule, and earlier versions the exception. Tiger will look for results in mac-tiger first, then in mac-leopard, then in mac-snowleopard, then in mac, then finally in cross-platform results. Leopard will begin the search in mac-leopard, continue to mac-snowleopard, then mac, the cross-platform. As you can see, there are no expected results in mac-snowleopard (other than the ones you just added), because it’s the latest Mac OS X version. We will only start putting expected results in mac-snowleopard when the “latest” version (for which we put results in mac) will be something different. You should put the expected results for Snow Leopard in platform/mac (or, if they are cross-platform, alongside the test), and you should put the results for Leopard and earlier in platform/mac-leopard. —Dan Does this imply that if you've moved results from 'platform/mac' to 'platform/mac-leopard' when you switched from 10.5 to 10.6? (Since, presumable, some results that were in platform/mac were actually specific to 10.5?) I would've expected a different model, where if the output differed by version, then you had results in 'mac-leopard' and 'mac-snowleopard', and the presence in 'mac' meant it should be the same across both (this was the approach I was planning to use for Chromium, which is just starting to run into this problem with XP/Vista/Win 7). I can see some advantages to your approach, but it seems more confusing in the long run. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] LayoutTest results choose from which folder?
I just committed http://trac.webkit.org/changeset/47675 which affects LayoutTest/accessibility/aria-roles.html The result is different on SnowLeopard than it is on Tiger/Leopard To account for this difference, I have an -expected file in platform/ mac-snowleopard where the line is This test PASSES in DumpRenderTree. The role is AXRole: AXList There is an existing file in platform/mac/ where the line is This test PASSES in DumpRenderTree. The role is AXRole: AXGroup --- Now after committing, Tiger/Leopard are complaining and saying http://build.webkit.org/results/Tiger%20Intel%20Release/r47675%20(3758)/accessibility/aria-roles-pretty-diff.html that it is expecting my the expected file from mac-snowleopard instead of platform/mac My question is, why does Tiger/Leopard expect the file in the mac- snowleopard folder http://build.webkit.org/results/Tiger%20Intel%20Release/r47675%20(3758)/accessibility/aria-roles-expected.txt ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
