Re: [webkit-dev] Patch for compilation error while building with gcc 4.x compilers on latest nightlies
Thanks Darin David for inputs.
Patches for review should go in bugs.webkit.org, but I think it's worth
mentioning a couple problems I see immediately.
This incorrectly removes the protected for non-GCC compilers and in fact
may not even compile there because __GNUC__ is not defined and there's no
check of it. And the check here says 4, which means the protected is
included only for GCC 5 and newer.
-- Darin
I have logged this issue here:
https://bugs.webkit.org/show_bug.cgi?id=18507
Please review the attached patch file contents:
--- a/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-12
04:28:00.0 +0530
+++ b/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-14
19:04:26.0 +0530
@@ -207,7 +207,9 @@
// Used to optimize those nodes that do extra work when returning a
result, even if the result has no semantic relevance
virtual void optimizeForUnnecessaryResult() { }
+#if !COMPILER(GCC) || (COMPILER(GCC) __GNUC__ = 4)
protected:
+#endif
typedef enum { EvalOperator, FunctionCall } CallerType;
template CallerType, bool inline JSValue*
resolveAndCall(ExecState*, const Identifier, ArgumentsNode*, size_t = 0);
};
regards,
Srinivas Rao. M
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Patch for compilation error while building with gcc 4.x compilers on latest nightlies
Hi, For my compilation using arm-linux-gcc (GCC) 3.4.6, while trying to build WebKit-r31848 on Gtk DirectFB, I am getting the following compilation error. This error gets fixed after commenting out the line containing protected: at *JavaScriptCore/kjs/nodes.h:210*. I have attached this patch for your review. Please include this in the coming builds so that the compilation goes through for less than gcc 4.x.x compilers arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-JSGlobalObject.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Tpo -c ../JavaScriptCore/kjs/JSGlobalObject.cpp -fPIC -DPIC -o JavaScriptCore/kjs/.libs/libJavaScriptCore_la-JSGlobalObject.o mv -f JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Tpo JavaScriptCore/kjs/.deps/libJavaScriptCore_la-JSGlobalObject.Plo /bin/sh ./libtool --tag=CXX --mode=compile arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-AllInOneFile.Tpo -c -o JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo `test -f 'JavaScriptCore/kjs/AllInOneFile.cpp' || echo '../'`JavaScriptCore/kjs/AllInOneFile.cpp arm-linux-g++ -DHAVE_CONFIG_H -I. -I.. -DWTF_USE_ICU_UNICODE=1 -DBUILDING_GTK__=1 -DWTF_CHANGES -DNDEBUG -DENABLE_ICONDATABASE=0 -I../JavaScriptCore -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf -I../JavaScriptCore/kjs -I./DerivedSources -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf/unicode -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -pthread -I/home/srinirao/webkit/myprefix/include/glib-2.0 -I/home/srinirao/webkit/myprefix/lib/glib-2.0/include -I/home/srinirao/webkit/myprefix/include -I/home/srinirao/webkit/myprefix/../../../libs/libjpeg -I/home/srinirao/webkit/myprefix/include/freetype2 -I/home/srinirao/webkit/myprefix/include/readline -D_REENTRANT -I/home/srinirao/webkit/myprefix/include -fno-strict-aliasing -O2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-AllInOneFile.Tpo -c ../JavaScriptCore/kjs/AllInOneFile.cpp -fPIC -DPIC -o JavaScriptCore/kjs/.libs/libJavaScriptCore_la-AllInOneFile.o In file included from ../JavaScriptCore/kjs/AllInOneFile.cpp:40: ../JavaScriptCore/kjs/dtoa.cpp: In function `void kjs_freedtoa(char*)': ../JavaScriptCore/kjs/dtoa.cpp:2259: warning: cast from `char*' to `int*'
Re: [webkit-dev] Patch for compilation error while building with gcc 4.x compilers on latest nightlies
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote: For my compilation using arm-linux-gcc (GCC) 3.4.6, while trying to build WebKit-r31848 on Gtk DirectFB, I am getting the following compilation error. This error gets fixed after commenting out the line containing protected: at *JavaScriptCore/kjs/nodes.h:210*. I have attached this patch for your review. Please include this in the coming builds so that the compilation goes through for less than gcc 4.x.x compilers The accepted process for patch review and committing is to open a bug on https://bugs.webkit.org/ and attach the patch with the review+ flag set. Please create a bug and attach the patch there. In file included from ../JavaScriptCore/kjs/AllInOneFile.cpp:40: ../JavaScriptCore/kjs/dtoa.cpp: In function `void kjs_freedtoa(char*)': ../JavaScriptCore/kjs/dtoa.cpp:2259: warning: cast from `char*' to `int*' increases required alignment of target type You may want to fix this as well as it could cause crashes later. Please file a separate bug for this issue. Thanks! Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
