Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Sam Weinig
> On Jul 28, 2017, at 11:13 AM, Maciej Stachowiak wrote: > > > >> On Jul 28, 2017, at 10:58 AM, Sam Weinig > > wrote: >> >> >> >>> On Jul 28, 2017, at 10:31 AM, JF Bastien >> >

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Maciej Stachowiak
> On Jul 28, 2017, at 10:58 AM, Sam Weinig wrote: > > > >> On Jul 28, 2017, at 10:31 AM, JF Bastien > > wrote: >> >> >> >>> On Jul 28, 2017, at 10:29, Sam Weinig >> > wrote:

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Sam Weinig
> On Jul 28, 2017, at 10:57 AM, Brady Eidson wrote: > >> >> On Jul 28, 2017, at 10:29 AM, Sam Weinig > > wrote: >> >> For some generic programming, this form can be dramatically shorter: >> >> e.g. >> >> template>

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread JF Bastien
> On Jul 28, 2017, at 10:58, Sam Weinig wrote: > > > >> On Jul 28, 2017, at 10:31 AM, JF Bastien > > wrote: >> >> >> >>> On Jul 28, 2017, at 10:29, Sam Weinig >> > wrote: >>>

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Sam Weinig
> On Jul 28, 2017, at 10:31 AM, JF Bastien wrote: > > > >> On Jul 28, 2017, at 10:29, Sam Weinig > > wrote: >> >> For some generic programming, this form can be dramatically shorter: >> >> e.g. >> >> template>

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Brady Eidson
> On Jul 28, 2017, at 10:29 AM, Sam Weinig wrote: > > For some generic programming, this form can be dramatically shorter: > > e.g. > > template KeyTraitsArg, typename MappedTraitsArg> > template > ALWAYS_INLINE auto HashMap

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread JF Bastien
> On Jul 28, 2017, at 10:29, Sam Weinig wrote: > > For some generic programming, this form can be dramatically shorter: > > e.g. > > template KeyTraitsArg, typename MappedTraitsArg> > template > ALWAYS_INLINE auto HashMap

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Sam Weinig
For some generic programming, this form can be dramatically shorter: e.g. template template ALWAYS_INLINE auto HashMap::inlineAdd(K&& key, V&& value) -> AddResult { return m_impl.template add

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread JF Bastien
https://bugs.webkit.org/show_bug.cgi?id=174930 I’ll trade this C++ fix for ES6 functions getting parsed properly too :D > On Jul 27, 2017, at 23:06, Brady Eidson wrote: > > I just noticed this tonight. When a change is made

[webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Brady Eidson
I just noticed this tonight. When a change is made to one of these functions, prepare-ChangeLog doesn't log the functions that changed. I have a question and a request. Question: The functions in question where I noticed this: auto WebURLSchemeTask::didComplete(const ResourceError& error) ->