Re: [webkit-dev] change in behavior of review page in bugzilla

2010-11-10 Thread Adam Barth 
Yeah, Darin and Alexey asked for this change.  I thought about
emailing webkit-dev, but I was worried that would have been too spamy.
 Hopefully the new behavior works for everyone.

Adam


On Wed, Nov 10, 2010 at 6:36 AM, David Levin le...@chromium.org wrote:
 (Single) Click on the line numbers to leave comments. Not the lines in the
 code review.
 I'm just pointing this out because I only just noticed and thought it was
 broken when I couldn't double click lines. (There is text at the top of the
 page but I claim to have banner blindness.)
 dave

 -- Forwarded message --
 From: aba...@webkit.org
 Date: Mon, Nov 8, 2010 at 2:18 PM
 Subject: [webkit-changes] [71570] trunk/BugsSite
 To: webkit-chan...@lists.webkit.org


 Revision 71570 Author aba...@webkit.org Date 2010-11-08 14:18:05 -0800 (Mon,
 08 Nov 2010)

 Log Message

 2010-11-08  Adam Barth  aba...@webkit.org

 Reviewed by Eric Seidel.

 Restore normal meaning of double-click on patch review page?
 https://bugs.webkit.org/show_bug.cgi?id=47641

 After this patch, you need to click on the line numbers to add a
 comment.

 * PrettyPatch/PrettyPatch.rb:
 * code-review.js:

 Modified Paths

 trunk/BugsSite/ChangeLog
 trunk/BugsSite/PrettyPatch/PrettyPatch.rb
 trunk/BugsSite/code-review.js

 Diff

 Modified: trunk/BugsSite/ChangeLog (71569 = 71570)

 --- trunk/BugsSite/ChangeLog  2010-11-08 22:10:51 UTC (rev 71569)
 +++ trunk/BugsSite/ChangeLog  2010-11-08 22:18:05 UTC (rev 71570)
 @@ -1,3 +1,16 @@
 +2010-11-08  Adam Barth  aba...@webkit.org
 +
 +Reviewed by Eric Seidel.
 +
 +Restore normal meaning of double-click on patch review page?
 +https://bugs.webkit.org/show_bug.cgi?id=47641
 +
 +After this patch, you need to click on the line numbers to add a
 +comment.
 +
 +* PrettyPatch/PrettyPatch.rb:
 +* code-review.js:
 +
  2010-10-09  Adam Barth  aba...@webkit.org

  Reviewed by Alexey Proskuryakov.

 Modified: trunk/BugsSite/PrettyPatch/PrettyPatch.rb (71569 = 71570)

 --- trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:10:51 UTC (rev
 71569)
 +++ trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:18:05 UTC (rev
 71570)
 @@ -312,7 +312,7 @@
  }
  /style
  script
 src=https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js;/script
 -script src=code-review.js?version=13/script
 +script src=code-review.js?version=14/script
  EOF

  def self.revisionOrDescription(string)

 Modified: trunk/BugsSite/code-review.js (71569 = 71570)

 --- trunk/BugsSite/code-review.js 2010-11-08 22:10:51 UTC (rev 71569)
 +++ trunk/BugsSite/code-review.js 2010-11-08 22:18:05 UTC (rev 71570)
 @@ -253,7 +253,7 @@
}

function crawlDiff() {
 -$('.Line').each(idify).each(hoverify).dblclick(addCommentField);
 +$('.Line').each(idify).each(hoverify);
  $('.FileDiff').each(function() {
var file_name = $(this).children('h1').text();
files[file_name] = this;

 ___
 webkit-changes mailing list
 webkit-chan...@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] change in behavior of review page in bugzilla

2010-11-10 Thread Ryosuke Niwa 
I frequently copy  paste function names, variable names, etc... into my
comment so I like the new behavior.

- Ryosuke

On Wed, Nov 10, 2010 at 10:18 AM, Adam Barth aba...@webkit.org wrote:

 Yeah, Darin and Alexey asked for this change.  I thought about
 emailing webkit-dev, but I was worried that would have been too spamy.
  Hopefully the new behavior works for everyone.

 Adam


 On Wed, Nov 10, 2010 at 6:36 AM, David Levin le...@chromium.org wrote:
  (Single) Click on the line numbers to leave comments. Not the lines in
 the
  code review.
  I'm just pointing this out because I only just noticed and thought it was
  broken when I couldn't double click lines. (There is text at the top of
 the
  page but I claim to have banner blindness.)
  dave
 
  -- Forwarded message --
  From: aba...@webkit.org
  Date: Mon, Nov 8, 2010 at 2:18 PM
  Subject: [webkit-changes] [71570] trunk/BugsSite
  To: webkit-chan...@lists.webkit.org
 
 
  Revision 71570 Author aba...@webkit.org Date 2010-11-08 14:18:05 -0800
 (Mon,
  08 Nov 2010)
 
  Log Message
 
  2010-11-08  Adam Barth  aba...@webkit.org
 
  Reviewed by Eric Seidel.
 
  Restore normal meaning of double-click on patch review page?
  https://bugs.webkit.org/show_bug.cgi?id=47641
 
  After this patch, you need to click on the line numbers to add a
  comment.
 
  * PrettyPatch/PrettyPatch.rb:
  * code-review.js:
 
  Modified Paths
 
  trunk/BugsSite/ChangeLog
  trunk/BugsSite/PrettyPatch/PrettyPatch.rb
  trunk/BugsSite/code-review.js
 
  Diff
 
  Modified: trunk/BugsSite/ChangeLog (71569 = 71570)
 
  --- trunk/BugsSite/ChangeLog  2010-11-08 22:10:51 UTC (rev 71569)
  +++ trunk/BugsSite/ChangeLog  2010-11-08 22:18:05 UTC (rev 71570)
  @@ -1,3 +1,16 @@
  +2010-11-08  Adam Barth  aba...@webkit.org
  +
  +Reviewed by Eric Seidel.
  +
  +Restore normal meaning of double-click on patch review page?
  +https://bugs.webkit.org/show_bug.cgi?id=47641
  +
  +After this patch, you need to click on the line numbers to add a
  +comment.
  +
  +* PrettyPatch/PrettyPatch.rb:
  +* code-review.js:
  +
   2010-10-09  Adam Barth  aba...@webkit.org
 
   Reviewed by Alexey Proskuryakov.
 
  Modified: trunk/BugsSite/PrettyPatch/PrettyPatch.rb (71569 = 71570)
 
  --- trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:10:51 UTC
 (rev
  71569)
  +++ trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:18:05 UTC
 (rev
  71570)
  @@ -312,7 +312,7 @@
   }
   /style
   script
  src=https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js
 /script
  -script src=code-review.js?version=13/script
  +script src=code-review.js?version=14/script
   EOF
 
   def self.revisionOrDescription(string)
 
  Modified: trunk/BugsSite/code-review.js (71569 = 71570)
 
  --- trunk/BugsSite/code-review.js 2010-11-08 22:10:51 UTC (rev 71569)
  +++ trunk/BugsSite/code-review.js 2010-11-08 22:18:05 UTC (rev 71570)
  @@ -253,7 +253,7 @@
 }
 
 function crawlDiff() {
  -$('.Line').each(idify).each(hoverify).dblclick(addCommentField);
  +$('.Line').each(idify).each(hoverify);
   $('.FileDiff').each(function() {
 var file_name = $(this).children('h1').text();
 files[file_name] = this;
 
  ___
  webkit-changes mailing list
  webkit-chan...@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
 
 
 
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev