Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-19 Thread Alec Flett
So this thread kinda died. Anyone have any suggestions? Where is JSC's SerializedScriptValue consistency tested? Alec On Tue, Sep 18, 2012 at 1:22 PM, Alec Flett alecfl...@chromium.org wrote: Sorry I totally left out the I expose this through Internals - and adam has explained the rationale

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-19 Thread Oliver Hunt
It isn't, it's never been a concern as our serialisation format is simple enough to be hard to break. That said tests would be fine, i'm just not sure how you would do them nicely. --Oliver On Sep 19, 2012, at 1:50 PM, Alec Flett alecfl...@chromium.org wrote: So this thread kinda died.

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-19 Thread Adam Barth
My suggestion is to write a unit test in Chromium's webkit_unit_test framework. Adam On Wed, Sep 19, 2012 at 1:50 PM, Alec Flett alecfl...@chromium.org wrote: So this thread kinda died. Anyone have any suggestions? Where is JSC's SerializedScriptValue consistency tested? Alec On Tue, Sep

[webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Alec Flett
Background: some of the storage systems use SerializedScriptValue to persist structured-clonable objects ( http://www.w3.org/TR/html5/common-dom-interfaces.html#safe-passing-of-structured-data) - most of this is implemented in a V8 or JSC-specific implementation of SerializedScriptValue. I'm

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Adam Barth
This is an interesting case because it's important for the serialization format to be consistent across time (so that an IndexedDB created at one point in time can work at another point in time), but it's not important to be consistent across embedders (because IndexedDB created by Safari don't

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Oliver Hunt
JSC's SerializedScriptValue has always been versioned (having learned the horror of no versioning with localStorage :( ) Newer formats (obviously) can't be read by older clients, but the serialisation is intentionally forwards compatible. --Oliver On Sep 18, 2012, at 12:36 PM, Adam Barth

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Oliver Hunt
What exactly are you trying to test here? The internal serialisation format isn't exposed anywhere (nor should it be). By definition newer formats won't be backwards compatible, or are you trying to ensure that newer deserialisers will be able to continue to deserialise old content? --Oliver

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Adam Barth
Where do you test that property? Adam On Tue, Sep 18, 2012 at 12:43 PM, Oliver Hunt oli...@apple.com wrote: JSC's SerializedScriptValue has always been versioned (having learned the horror of no versioning with localStorage :( ) Newer formats (obviously) can't be read by older clients, but

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Alec Flett
Sorry I totally left out the I expose this through Internals - and adam has explained the rationale On Tue, Sep 18, 2012 at 12:46 PM, Oliver Hunt oli...@apple.com wrote: What exactly are you trying to test here? The internal serialisation format isn't exposed anywhere (nor should it be). By