Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-08 Thread Ryosuke Niwa
There has been no more votes either way so no space wins. Here's a patch to codify it in our code style guidelines: https://bugs.webkit.org/show_bug.cgi?id=204021 - R. Niwa On Sat, Nov 2, 2019 at 8:26 PM Ryosuke Niwa wrote: > On Sat, Nov 2, 2019 at 10:16 AM Caitlin Potter wrote: > >> Not that

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Caitlin Potter
Not that anybody asked me, but I also prefer to not include a space between captures and parameter, for similar reasons. If I’m not mistaken, v8/chromium tends to omit the space as well. If that’s still true and WebKit adopted that style, context switching between both codebases would be

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Antti Koivisto
On Fri, Nov 1, 2019 at 10:50 PM Yusuke Suzuki wrote: > > > On Nov 1, 2019, at 11:53, Michael Catanzaro > wrote: > > > > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: > >> Namely, some people write a lambda as: > >> auto x = [] () { } > >> with a space between [] and () while others

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Yusuke Suzuki
> On Nov 1, 2019, at 11:53, Michael Catanzaro wrote: > > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: >> Namely, some people write a lambda as: >> auto x = [] () { } >> with a space between [] and () while others would write it as: >> auto x = []() { } > > : I omit the () when there

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Michael Catanzaro
On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa wrote: Namely, some people write a lambda as: auto x = [] () { } with a space between [] and () while others would write it as: auto x = []() { } : I omit the () when there are no parameters, as in these examples. No preference on spacing.

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Ryosuke Niwa
On Fri, Nov 1, 2019 at 11:19 AM Ryosuke Niwa wrote: > Hi all, > > There seems to be inconsistency in our coding style with regards to > spacing in lambdas. > > Namely, some people write a lambda as: > auto x = [] () { } > > with a space between [] and () while others would write it as: > > auto

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Chris Dumez
I mildly prefer without the space :) --  Chris Dumez > On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote: > > Hi all, > > There seems to be inconsistency in our coding style with regards to spacing > in lambdas. > > Namely, some people write a lambda as: > auto x = [] () { } > > with a

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Saam Barati
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote: > > Hi all, > > There seems to be inconsistency in our coding style with regards to spacing > in lambdas. I've noticed this too and the lack of consistency slightly annoys me. > > Namely, some people write a lambda as: > auto x = [] () {