Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 1:13 PM, Maciej Stachowiak wrote: std::array is fixed size. Er, yeah, oops. Size must be known at compile time, so it can't be used to replace a VLA. Vector it is ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Maciej Stachowiak
> On Jan 17, 2019, at 10:15 AM, Michael Catanzaro wrote: > > > > On Thu, Jan 17, 2019 at 11:12 AM, Darin Adler wrote: >> Vector’s inline capacity feature was originally created as an alternative to >> variable length arrays for most of the purposes people would want to put >> them. > >

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 11:12 AM, Darin Adler wrote: Vector’s inline capacity feature was originally created as an alternative to variable length arrays for most of the purposes people would want to put them. Any advantages of this over std::array (which is widely-used in WebKit)?

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Darin Adler
Vector’s inline capacity feature was originally created as an alternative to variable length arrays for most of the purposes people would want to put them. Imagine, for example, that you need a variable length buffer of characters that is almost always going to be less then 32 bytes. You write

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Michael Catanzaro
On Thu, Jan 17, 2019 at 2:27 AM, Salisbury, Mark wrote: Thanks Tim! I didn’t know about C++ variable length arrays. That makes perfect sense now. Looks like people have been requesting Visual Studio add support for VLAs; there are no indications they will be supported. We shouldn't

Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp

2019-01-17 Thread Salisbury, Mark
, Mark Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Compile error in WebGL2RenderingContext.cpp On Jan 16, 2019, at 20:56, Salisbury, Mark mailto:mark.salisb...@hp.com>> wrote: Hello, Hello! I’m working on rebasing our downstream webkit port; I just pulled down recent