Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-27 Thread Alex Christensen
WKProcessID is only used in 2 functions that are only used for testing, so it’s probably not too important as long as your tests work. Also, earlier you said "Our uint32_t is a signed integer.” If that’s true, you’re going to have some bigger problems. > On Feb 26, 2019, at 11:47 PM,

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-26 Thread Rajagopalan Gangadharan
WTF::ProcessID and WKProcessID are supposed to be of same type right? As different types create ambiguity . As sam Weining suggested we made WTF::ProcessID to be int32_t but WKProcessID is pid_t so can we also explicitly make WKProcessID to be int32_t (will it conform to the current webkit

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-24 Thread Sam Weinig
> On Feb 24, 2019, at 11:55 AM, Adrien Destugues > wrote: > > On Sun, Feb 24, 2019 at 10:52:53AM -0800, Sam Weinig wrote: >> Hi Adrien, >> >> Would you mind adding the compiler output when this happens? I’d like to see >> exactly what the error you are seeing is. > > Sorry, here is the

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-24 Thread Adrien Destugues
On Sun, Feb 24, 2019 at 10:52:53AM -0800, Sam Weinig wrote: > Hi Adrien, > > Would you mind adding the compiler output when this happens? I’d like to see > exactly what the error you are seeing is. Sorry, here is the compiler output: http://paste.debian.net/1069971 In file included from

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-24 Thread Sam Weinig
Hi Adrien, Would you mind adding the compiler output when this happens? I’d like to see exactly what the error you are seeing is. - Sam > On Feb 24, 2019, at 9:54 AM, Adrien Destugues > wrote: > > Hi there, > > We are finally starting to look into moving the Haiku port to WebKit2. > >

Re: [webkit-dev] Encoding and decoding ProcessID

2019-02-24 Thread Ryosuke Niwa
On Sun, Feb 24, 2019 at 9:55 AM Adrien Destugues wrote: > We are finally starting to look into moving the Haiku port to WebKit2. > > We have hit one little problem I'm not sure how to solve. Our pid_t on > 32bit Haiku is declared as a signed long integer (this is for legacy > reasons and not