Re: [webkit-dev] 194 bugs in pending-commit

2011-06-20 Thread Mustafizur Rahaman
On a similar note of bug cleanup, I have also seen lot of issues which are still in Unconfirmed state, even though the bug analysis says either the issue is not reproducible etc etc. So, Is there a way to clean up such bugs so that they don't unnecessarily come up in queries. What is the

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-20 Thread Dirk Pranke
I had one of the bugs in this state, and I had not landed it because I had been meaning to do some more testing to see if it caused regressions. However, someone CQ+'ed it over the weekend, and it was committed w/o my involvement. Fortunately, it did not appear to cause massive regressions

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-20 Thread Eric Seidel
In general it's pretty safe to cq+ a patch, especially an old one. Since the cq + EWS tests patches better than just about any committer ever does manually. :) We built infrastructure to have the sherriff-bot auto-rollout patches which caused any tree redness. If folks want, we could turn that

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Peter Kasting
On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth aba...@webkit.org wrote: 2) Mark the patch as obsolete / clear the review flag if we're not going to land the patch. Does the slash mean do both? I have https://bugs.webkit.org/show_bug.cgi?id=47036 on that list and the only r+ed patch on it is

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Adam Barth
On Fri, Jun 17, 2011 at 11:13 PM, Peter Kasting pkast...@chromium.org wrote: On Fri, Jun 17, 2011 at 10:56 PM, Adam Barth aba...@webkit.org wrote: 2) Mark the patch as obsolete / clear the review flag if we're not going to land the patch. Does the slash mean do both?  I have 

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Antonio Gomes
IIRC, Mozilla's bugzilla can hide obsolete patches (?). If so, why can not webkit's bugzilla? I actually do not like the way the review flags are cleared today only in order to make the tools and pending-xxx pages happier. IMO the review flags give much about the history of the bug. In that

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Eric Seidel
webkit-patch upload clears all flags when obsoleting a patch. We could make it not clear r- if you like. I know of no way to construct a query like http://webkit.org/pending-commit in our current bugzilla without clearing r+ on obsolete patches/closed bugs. We clear flags (specifically r+) to

[webkit-dev] 194 bugs in pending-commit

2011-06-17 Thread Adam Barth
There are a 194 open bugs with an R+ patches attached to them: