Re: [webkit-dev] A proposal for Platform Mechanisms

2010-08-17 Thread Balazs Kelemen
On 06/17/2010 02:30 AM, Anders Carlsson wrote: Hi everyone, We've now reached the point in WebKit2 development where we need to be able to override some global calls in WebCore so that we can funnel them through to another process, in a similar way to what Chromium does. We also need to

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-19 Thread Jakob Petsovits
On June 18, 2010, Anders Carlsson wrote: On Jun 17, 2010, at 2:04 PM, Jeremy Orlow wrote: Overall, looks great!! On Wed, Jun 16, 2010 at 6:05 PM, Anders Carlsson ander...@apple.com wrote: Also, PlatformMechanism is a Factory, and should be named accordingly. Or maybe it's a Source

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-19 Thread Mike Marchywka
From: jpe...@gmx.at To: webkit-dev@lists.webkit.org Date: Sat, 19 Jun 2010 11:35:28 -0400 Subject: Re: [webkit-dev] A proposal for Platform Mechanisms On June 18, 2010, Anders Carlsson wrote: On Jun 17, 2010, at 2:04 PM, Jeremy Orlow wrote

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-18 Thread Anders Carlsson
On Jun 17, 2010, at 2:04 PM, Jeremy Orlow wrote: Overall, looks great!! On Wed, Jun 16, 2010 at 6:05 PM, Anders Carlsson ander...@apple.com wrote: Also, PlatformMechanism is a Factory, and should be named accordingly. Or maybe it's a Source of clients/mechanisms. Good point, it

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-17 Thread Mike Marchywka
From: da...@apple.com Date: Wed, 16 Jun 2010 17:55:10 -0700 To: ander...@apple.com CC: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] A proposal for Platform Mechanisms Sounds reasonable to me. We already follow pointers and use

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-17 Thread Anders Carlsson
On Jun 16, 2010, at 8:34 PM, Darin Fisher wrote: Hi, this is of course a very interesting topic! Yes, and I really appreciate your feedback on this! Some comments: 1- Why do you see the need for these interfaces to be virtual? Will there be multiple implementations? Some possible

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-17 Thread Darin Fisher
On Thu, Jun 17, 2010 at 9:47 AM, Anders Carlsson ander...@apple.com wrote: On Jun 16, 2010, at 8:34 PM, Darin Fisher wrote: Hi, this is of course a very interesting topic! Yes, and I really appreciate your feedback on this! Some comments: 1- Why do you see the need for these

[webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Anders Carlsson
Hi everyone, We've now reached the point in WebKit2 development where we need to be able to override some global calls in WebCore so that we can funnel them through to another process, in a similar way to what Chromium does. We also need to be able to override the calls at run-time, so that we

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Kenneth Christiansen
Hi there Anders, I think this sounds pretty fine at least from a Qt perspective; and it will also easily enable us to let some of our platforms override the implementation using a plugin system. We already have such a system in place (PlatformPlugin) so that platforms can re-implement the

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Darin Adler
Sounds reasonable to me. We already follow pointers and use virtual functions for all these things, so I don’t see them adding a lot of overhead. Would these Mechanism classes replace all the current Client classes? Would the mechanism objects be obtained once and cached globally? How is the

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Simon Fraser
On Jun 16, 2010, at 5:30 PM, Anders Carlsson wrote: Hi everyone, We've now reached the point in WebKit2 development where we need to be able to override some global calls in WebCore so that we can funnel them through to another process, in a similar way to what Chromium does. We also need

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Anders Carlsson
On Jun 16, 2010, at 5:55 PM, Darin Adler wrote: Sounds reasonable to me. We already follow pointers and use virtual functions for all these things, so I don’t see them adding a lot of overhead. Would these Mechanism classes replace all the current Client classes? Like Kenneth said, these

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Darin Fisher
Hi, this is of course a very interesting topic! Some comments: 1- Why do you see the need for these interfaces to be virtual? Will there be multiple implementations? Some possible answers that come to mind: a) Yes, there could be a proxy implementation used to marshal calls to the real