Re: [webkit-dev] About USE(CROSS_PLATFORM_CONTEXT_MENUS)

2013-03-08 Thread Jesus Sanchez-Palencia
Hi, 2013/2/25 Adam Roben aro...@webkit.org: I was having a look at our Context Menu design when this USE flag got my attention. Can someone help me clarify the motivation for it? The motivation is explained pretty well in the ChangeLog for r73802, which introduced this flag. I'll try to

Re: [webkit-dev] About USE(CROSS_PLATFORM_CONTEXT_MENUS)

2013-02-25 Thread Adam Roben
I was having a look at our Context Menu design when this USE flag got my attention. Can someone help me clarify the motivation for it? The motivation is explained pretty well in the ChangeLog for r73802, which introduced this flag. I'll try to give a little explanation here too.

Re: [webkit-dev] About USE(CROSS_PLATFORM_CONTEXT_MENUS)

2013-02-22 Thread Jesus Sanchez-Palencia
Hi again, It's been 2 days since the first email on this thread. Should I assume that no one is then relying on this USE flag? It adds quite a fair amount of code to all ContextMenu related files and I could clean that up if necessary. Cheers, jesus 2013/2/20 Jesus Sanchez-Palencia

[webkit-dev] About USE(CROSS_PLATFORM_CONTEXT_MENUS)

2013-02-20 Thread Jesus Sanchez-Palencia
Hello, I was having a look at our Context Menu design when this USE flag got my attention. Can someone help me clarify the motivation for it? It seems that only PLATFORM(WIN) is using it, but I'm not sure if for both WK1 and WK2... Also, is there any other port using it? Cheers, jesus