[webkit-dev] Adding ENABLE_GESTURE_MANAGER
Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Patch https://bugs.webkit.org/show_bug.cgi?id=54417 and its successors will add a progressively more useful gesture recognizer implementation to the Chromium platform. All code in this feature will be exercised by the Chromium buildbots. Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
I'm mostly ignorant of how touch works, but would it make sense for the gesture recognition engine to be part of WebCore or is this functionality that's usually provided by the platform? Adam On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Patch https://bugs.webkit.org/show_bug.cgi?id=54417 and its successors will add a progressively more useful gesture recognizer implementation to the Chromium platform. All code in this feature will be exercised by the Chromium buildbots. Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
Nice discussion! I see the value of a cross-platform gesture implementation, but for the touch interaction models I've seen out there, they are too different from each other in many aspects, so maybe giving each platform its own spot to implement it also makes sense. On Mon, May 9, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: I'm mostly ignorant of how touch works, but would it make sense for the gesture recognition engine to be part of WebCore or is this functionality that's usually provided by the platform? Adam On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Patch https://bugs.webkit.org/show_bug.cgi?id=54417 and its successors will add a progressively more useful gesture recognizer implementation to the Chromium platform. All code in this feature will be exercised by the Chromium buildbots. Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.orgwrote: As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Can't we just reuse ENABLE(TOUCH_EVENTS) and implement some client interface? - Rysouke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
Hi Adam, On Mon, May 9, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: I'm mostly ignorant of how touch works, but would it make sense for the gesture recognition engine to be part of WebCore or is this functionality that's usually provided by the platform? In current platforms (iOS, Android), each platform has its own gesture recognizer. Discussion with reviewers (Antonio Gomes, Benjamin Poulain) led me to add a platform-independent hook that could invoke platform-specific code. Chrome (in particular ChromeOS) has no gesture recognizer and needs one. Placing the Chrome gesture recognizer in the Chrome platform makes it efficient for delivering the synthesized events without additional IPC or external libraries. Rob. Adam On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Patch https://bugs.webkit.org/show_bug.cgi?id=54417 and its successors will add a progressively more useful gesture recognizer implementation to the Chromium platform. All code in this feature will be exercised by the Chromium buildbots. Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
Hi, On Mon, May 9, 2011 at 3:03 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Can't we just reuse ENABLE(TOUCH_EVENTS) and implement some client interface? The reviewers suggested that a new ENABLE_ was desirable. I would tend to agree because several important platforms (iOS, Android) enable TOUCH_EVENTS but do gesture recognition in a quite different fashion. I'd be happy to strip the extra ENABLE_ in a future CL when the chrome gesture recognizer has been shown to be working well. - Rysouke Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER
Some platforms implement touch recognition at a higher level than WebKit, so I don't think it necessarily make senes to re-use the TOUCH_EVENTS feature since you can have touch events in WebKit without a touch manager implemented there... But I also don't see the need for this to live in WebCore. On Mon, May 9, 2011 at 12:06 PM, Robert Kroeger rjkro...@chromium.orgwrote: Hi Adam, On Mon, May 9, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: I'm mostly ignorant of how touch works, but would it make sense for the gesture recognition engine to be part of WebCore or is this functionality that's usually provided by the platform? In current platforms (iOS, Android), each platform has its own gesture recognizer. Discussion with reviewers (Antonio Gomes, Benjamin Poulain) led me to add a platform-independent hook that could invoke platform-specific code. Chrome (in particular ChromeOS) has no gesture recognizer and needs one. Placing the Chrome gesture recognizer in the Chrome platform makes it efficient for delivering the synthesized events without additional IPC or external libraries. Rob. Adam On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is https://bugs.webkit.org/show_bug.cgi?id=49345. This patch adds a hook to WebCore to pass touch events to an optional platform-specific gesture recognition engine. The code is turned off by default except in the Chromium port where it is enabled with ENABLE_GESTURE_MANAGER. Patch https://bugs.webkit.org/show_bug.cgi?id=54417 and its successors will add a progressively more useful gesture recognizer implementation to the Chromium platform. All code in this feature will be exercised by the Chromium buildbots. Rob. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
