Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-21 Thread Satish Sampath
On a related note, there are a few features such as geolocation, device orientation and speech which require input from hardware devices. To test these using layout tests, we are considering passing mock objects to WebCore and the mocks would either give fake device data or just verify the

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-21 Thread Hajime Morita
Hi folks, I posted a patch: https://bugs.webkit.org/show_bug.cgi?id=42612 Any feedbacks are appreciated. -- morita On Wed, Jul 21, 2010 at 2:33 PM, Hajime Morita morr...@google.com wrote: Hi Maciej, thanks much for sharing your thought. Overall, it totally makes sense. And we need an action

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-20 Thread Hajime Morita
Hi Maciej, thanks much for sharing your thought. Overall, it totally makes sense. And we need an action as Ojan mentioned. Here is some ideas; (1) It seems a little odd that we'll end up with two different objects that have similar names and a very similar purpose, but just differ in how they

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-19 Thread Ojan Vafai
Let me summarize to make sure I understand the proposal: Expose a new object to layout tests that is entirely in WebCore instead of in the DRT layer. Then, only put things in layoutTestController that need to be at the WebKit layer, e.g. notifyDone, waitUntilDone, etc. APIs that only need to touch

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-19 Thread Hajime Morita
Hi Ojan, thank you for the response! Let me summarize to make sure I understand the proposal: Expose a new object to layout tests that is entirely in WebCore instead of in the DRT layer. Then, only put things in layoutTestController that need to be at the WebKit layer, e.g. notifyDone,

Re: [webkit-dev] Adding window.layoutTestInspector

2010-07-19 Thread Maciej Stachowiak
Darin and I discussed this proposal, and we had a few thoughts to share: (1) It seems a little odd that we'll end up with two different objects that have similar names and a very similar purpose, but just differ in how they are implemented. Maybe there's a way to define layoutTestController in

[webkit-dev] Adding window.layoutTestInspector

2010-07-14 Thread Hajime Morita
Hi WebKit folks, I'm planning to add window.layoutTestInspector or something like that to DRT. And I'd like to hear your opinions. Background: Adding new method to LayoutTestController is hard. It - requires to add new WebKit API to each ports, when the method is to access WebCore. - requires