Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
On Fri, Apr 9, 2010 at 2:09 PM, Stephan Assmus wrote: >> - Ursprüngliche Nachricht - >> Von: Adam Barth >> Gesendet: 09.04.10 23:26 Uhr >> An: webkit-...@lists.webkit.org >> Betreff: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz) > >> >> Is the Haiku port actively maintained? >> >> http://trac.webkit.org/browser/trunk/WebKit/haiku/ >> >> Looking at the ChangeLog, I don't see any real activity: >> >> http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog >> >> Maybe we should archive it? I certainly don't want to exclude Haiku >> from the community. Ideally, we'd make it easy to unarchive it if >> folks appear who want to work on it again. > > I am actively working on the Haiku port. I have submitted a number of patches, but since the review process takes _very_ long (no offense intended) I am careful to only submit patches when I don't anticipate changes to the files in the near future. A few of my patches still just sit there in bugzilla. Some got reviewed, the last activity was on a patch to ImageBufferHaiku.cpp, where the reviewer gave an r- because I removed the original copyright. Myself and Maxime Simone (original copyright holder) explained the issue and why it was correct to remove it. However, no response from the reviewer since then. > > I have a *huge* number of additional patches, since I am writing a WebKit browser for Haiku, completing the port, the Haiku WebKit API and the browser. Many of the patches would simply not be small, and to be frank, the review process has so far discouraged me from even trying to submit any of the bigger stuff. Especially the stuff I am working on all the time. > > I can certainly prepare updated patches and new patches in the next days, but it takes careful preparation and if those patches just sit there in bugzilla and receive no further feedback after initial review... it is just not motivating if the initial review came after about 10 days in the first place. > > The problem is of course that there are no dedicated Haiku reviewers. Other ports have their own number of reviewers and people interested in getting patches for their ports landed. With Haiku it's a chicken and egg problem. As long as I don't get a significant amount of patches landed, I won't even become committer. > > I don't really know what a solution could be. The Haiku port touches no other code, it's pretty self-contained. In that respect the chances are very low to affect other ports/people. I don't know if that could be an argument for just rubber stamping a lot of patches until the Haiku code in the official repo includes most of my stuff. What do you guys think? IMHO, the problem with the Haiku port is certainly not that it is not actively maintained, I work many hours on it each day, the problem is how to get the patches into SVN smoothly. Unfortunately this review issue is also adding huge latency to WebKit-EFL, that we're trying to introduce. Some patches are quickly reviewed with r-, then we try to fix the issue by providing more patches but they lag behind. We all know that reviewing other port is not the most interesting stuff in the world, particularly those that you cannot or do not have interest in testing, but it would be good if at least the initial landing was bit faster so we can have buildable systems :-) BR, -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
> > I've already upgraded one of my repositories to the latest SVN and resolved > the conflicts and incorporated the changes. I just need to merge that with > some changes in my other repository, but it's not a problem and won't take > long. > > I'm glad to hear that. I thought it would be harder (as the last time with the gnu_inline stuff). > In fact, our community is really interested on this port but having > > a web browser seems to be of greater priority. > > I've been improving the port as well as working on the browser. A lot of > work had to be done in the WebKit support layer and the Haiku WebKit API, > it's just that the patches are mostly more than 20K per individual file I > reckon... > > I know you worked on the port, that's why I said you did a really good job. It's both impressive and esteemed. I was just speaking for the community, and actually having a great web browser was the finality of porting WebKit. As for the patches, I can help you. I know how awful and boring it can be. But I already have many patches landed on the tree. The WebCoreSupport code is already in the tree, but none of the API. It may require some explanations from us (and specially you, as most of the code is yours). Bye, -- Maxime ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
Hi, On 2010-04-10 at 00:26:36 [+0200], Maxime Simon wrote: > I'm "officially" the main maintainer of the Haiku port. But > considering my university course I have little time to work on it. > (I had plan to do so next summer though.) Another Haiku developer, > Stephan Assmus, did lately some great improvements on the port, > but is now focused on the web browser and keeps a not up-to-date > version of WebKit for his work. I've already upgraded one of my repositories to the latest SVN and resolved the conflicts and incorporated the changes. I just need to merge that with some changes in my other repository, but it's not a problem and won't take long. > In fact, our community is really interested on this port but having > a web browser seems to be of greater priority. I've been improving the port as well as working on the browser. A lot of work had to be done in the WebKit support layer and the Haiku WebKit API, it's just that the patches are mostly more than 20K per individual file I reckon... Best regards, -Stephan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
Hi, I'm "officially" the main maintainer of the Haiku port. But considering my university course I have little time to work on it. (I had plan to do so next summer though.) Another Haiku developer, Stephan Assmus, did lately some great improvements on the port, but is now focused on the web browser and keeps a not up-to-date version of WebKit for his work. In fact, our community is really interested on this port but having a web browser seems to be of greater priority. Our maintainers are using a subversion repository to work on the port, but it has to be a temporary solution. And as I saw Stephan recent work I think we should move on, re update our repo to a newer version, propose patches to move the code on the WebKit repository. I think it would be a mess to waste the work done last summer and recently. (I know it would be put in another branch, but it's kinda lose for us.) But it's also my fault for not trying to propose new patches from Stephan's work. PS: Sorry Stephan, you have been quicker than me to reply. :-) PPS: Adam, we aren't offended, just showing that we are still alive. Regards, -- Maxime ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
Woah, ok. It seems there is still significant interest in the Haiku port. No offense intended. Adam On Fri, Apr 9, 2010 at 3:09 PM, Stephan Assmus wrote: >> - Ursprüngliche Nachricht - >> Von: Adam Barth >> Gesendet: 09.04.10 23:26 Uhr > >> An: webkit-...@lists.webkit.org >> Betreff: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz) >> >> Is the Haiku port actively maintained? >> >> http://trac.webkit.org/browser/trunk/WebKit/haiku/ >> >> Looking at the ChangeLog, I don't see any real activity: >> >> http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog >> >> Maybe we should archive it? I certainly don't want to exclude Haiku >> from the community. Ideally, we'd make it easy to unarchive it if >> folks appear who want to work on it again. > > I am actively working on the Haiku port. I have submitted a number of patches, but since the review process takes _very_ long (no offense intended) I am careful to only submit patches when I don't anticipate changes to the files in the near future. A few of my patches still just sit there in bugzilla. Some got reviewed, the last activity was on a patch to ImageBufferHaiku.cpp, where the reviewer gave an r- because I removed the original copyright. Myself and Maxime Simone (original copyright holder) explained the issue and why it was correct to remove it. However, no response from the reviewer since then. > > I have a *huge* number of additional patches, since I am writing a WebKit browser for Haiku, completing the port, the Haiku WebKit API and the browser. Many of the patches would simply not be small, and to be frank, the review process has so far discouraged me from even trying to submit any of the bigger stuff. Especially the stuff I am working on all the time. > > I can certainly prepare updated patches and new patches in the next days, but it takes careful preparation and if those patches just sit there in bugzilla and receive no further feedback after initial review... it is just not motivating if the initial review came after about 10 days in the first place. > > The problem is of course that there are no dedicated Haiku reviewers. Other ports have their own number of reviewers and people interested in getting patches for their ports landed. With Haiku it's a chicken and egg problem. As long as I don't get a significant amount of patches landed, I won't even become committer. > > I don't really know what a solution could be. The Haiku port touches no other code, it's pretty self-contained. In that respect the chances are very low to affect other ports/people. I don't know if that could be an argument for just rubber stamping a lot of patches until the Haiku code in the official repo includes most of my stuff. What do you guys think? IMHO, the problem with the Haiku port is certainly not that it is not actively maintained, I work many hours on it each day, the problem is how to get the patches into SVN smoothly. > > Best regards, > -Stephan > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
> - Ursprüngliche Nachricht - > Von: Adam Barth > Gesendet: 09.04.10 23:26 Uhr > An: webkit-dev@lists.webkit.org > Betreff: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that > jazz) > > Is the Haiku port actively maintained? > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ > > Looking at the ChangeLog, I don't see any real activity: > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog > > Maybe we should archive it? I certainly don't want to exclude Haiku > from the community. Ideally, we'd make it easy to unarchive it if > folks appear who want to work on it again. I am actively working on the Haiku port. I have submitted a number of patches, but since the review process takes _very_ long (no offense intended) I am careful to only submit patches when I don't anticipate changes to the files in the near future. A few of my patches still just sit there in bugzilla. Some got reviewed, the last activity was on a patch to ImageBufferHaiku.cpp, where the reviewer gave an r- because I removed the original copyright. Myself and Maxime Simone (original copyright holder) explained the issue and why it was correct to remove it. However, no response from the reviewer since then. I have a *huge* number of additional patches, since I am writing a WebKit browser for Haiku, completing the port, the Haiku WebKit API and the browser. Many of the patches would simply not be small, and to be frank, the review process has so far discouraged me from even trying to submit any of the bigger stuff. Especially the stuff I am working on all the time. I can certainly prepare updated patches and new patches in the next days, but it takes careful preparation and if those patches just sit there in bugzilla and receive no further feedback after initial review... it is just not motivating if the initial review came after about 10 days in the first place. The problem is of course that there are no dedicated Haiku reviewers. Other ports have their own number of reviewers and people interested in getting patches for their ports landed. With Haiku it's a chicken and egg problem. As long as I don't get a significant amount of patches landed, I won't even become committer. I don't really know what a solution could be. The Haiku port touches no other code, it's pretty self-contained. In that respect the chances are very low to affect other ports/people. I don't know if that could be an argument for just rubber stamping a lot of patches until the Haiku code in the official repo includes most of my stuff. What do you guys think? IMHO, the problem with the Haiku port is certainly not that it is not actively maintained, I work many hours on it each day, the problem is how to get the patches into SVN smoothly. Best regards, -Stephan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
- Ursprüngliche Nachricht - Von: Kenneth Christiansen Gesendet: 09.04.10 23:52 Uhr An: Adam Barth Betreff: Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz) Last I looked there are still patches up for review for Haiku. It would be nice to know why it is not being maintained. Is that due to having no interest from their community or due to the fact that noone are reviewing the patches? Some people do review the patches, but the initial reviews appear usually days after I submitted a patch and sometimes there is no reaction after I update the patch or explain things. It is totally understandable... I don't mean to complain about reviewers, they are probably overwhelmed in work. However, this has resulted in me being reluctant about posting new patches. I would have a lot more patches in the pipe, but very few patches that would be about 20K or less. It has been expressed very clearly to me that only small patches are prefered. However, I have completely redesigned the Haiku WebKit API, implemented a great deal more code to expose additional WebCore features, done a lot of changes to the GraphicsContext implementation... I am under the impression that I would have to somehow fake individual changes to the files to somehow extract smaller patches. Like revert to the original file, add code back piece by piece while creating patches to keep them small. You can imagine it's a lot of additional work and overhead. I hope you guys understand that I've been reluctant to even try to get this stuff commited with how the review process went for me so far. However, I am willing to give it a try once more, if there are people interested in reviewing my patches and to keep the Haiku port going. It is certainly actively maintained. Best regards, -Stephan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
Last I looked there are still patches up for review for Haiku. It would be nice to know why it is not being maintained. Is that due to having no interest from their community or due to the fact that noone are reviewing the patches? Kenneth On Fri, Apr 9, 2010 at 6:26 PM, Adam Barth wrote: > Is the Haiku port actively maintained? > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ > > Looking at the ChangeLog, I don't see any real activity: > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog > > Maybe we should archive it? I certainly don't want to exclude Haiku > from the community. Ideally, we'd make it easy to unarchive it if > folks appear who want to work on it again. > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- Kenneth Rohde Christiansen Technical Lead / Senior Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
SVN already is an "archive". Were we to archive a port, we would just remove the ifdefs and associated files. We already have scripts for doing this (buried in bugzilla, or in WebKitTools/Scripts). -eric On Fri, Apr 9, 2010 at 2:26 PM, Adam Barth wrote: > Is the Haiku port actively maintained? > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ > > Looking at the ChangeLog, I don't see any real activity: > > http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog > > Maybe we should archive it? I certainly don't want to exclude Haiku > from the community. Ideally, we'd make it easy to unarchive it if > folks appear who want to work on it again. > > Adam > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)
Is the Haiku port actively maintained? http://trac.webkit.org/browser/trunk/WebKit/haiku/ Looking at the ChangeLog, I don't see any real activity: http://trac.webkit.org/browser/trunk/WebKit/haiku/ChangeLog Maybe we should archive it? I certainly don't want to exclude Haiku from the community. Ideally, we'd make it easy to unarchive it if folks appear who want to work on it again. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
