Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-14 Thread Sam Weinig

On Apr 13, 2013, at 1:55 AM, Carlos Garcia Campos carlo...@webkit.org wrote:

 
 El vie, 12-04-2013 a las 18:15 -0700, Maciej Stachowiak escribió:
 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote:
 
 
 Of course, I understand that. But there is a huge opportunity cost to 
 webkit.
 The c++11 standard also rewrites the entire standard library. I have been 
 using
 g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have tested 
 is
 performing nearly like c code. If you take advantage of the performance 
 enhancements
 in C++11, then you can realize impressive performance gains.
 
 I do understand the nature of the business. And I also understand that 
 performance
 is huge moving forward, where resource constrained mobile platforms are 
 significantly
 affected by performance issues. I suggest you'll see Blink moving 
 aggressively to
 support C++11 moving forward. And I suggest it is in WebKit's long term 
 interest to
 do so as well.
 
 As others have said, we are definitely eager to use C++11 across the board 
 but are limited by compiler support requirements.
 
 One thing that it would be useful to know: what are the compilers and 
 minimum required versions used for in-tree ports? Perhaps we could record 
 this so we can regularly evaluate which features are safe to use and what 
 the blockers are to wholesale adoption, if any.
 
 The GTK+ port now requires gcc = 4.7 and clang = 3. We also added the
 -stdc++11 where possible. See
 https://bugs.webkit.org/show_bug.cgi?id=109932

That's awesome!  

-Sam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-13 Thread Carlos Garcia Campos

El vie, 12-04-2013 a las 18:15 -0700, Maciej Stachowiak escribió:
 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote:
 
  
  Of course, I understand that. But there is a huge opportunity cost to 
  webkit.
  The c++11 standard also rewrites the entire standard library. I have been 
  using
  g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have tested 
  is
  performing nearly like c code. If you take advantage of the performance 
  enhancements
  in C++11, then you can realize impressive performance gains.
  
  I do understand the nature of the business. And I also understand that 
  performance
  is huge moving forward, where resource constrained mobile platforms are 
  significantly
  affected by performance issues. I suggest you'll see Blink moving 
  aggressively to
  support C++11 moving forward. And I suggest it is in WebKit's long term 
  interest to
  do so as well.
 
 As others have said, we are definitely eager to use C++11 across the board 
 but are limited by compiler support requirements.
 
 One thing that it would be useful to know: what are the compilers and minimum 
 required versions used for in-tree ports? Perhaps we could record this so we 
 can regularly evaluate which features are safe to use and what the blockers 
 are to wholesale adoption, if any.

The GTK+ port now requires gcc = 4.7 and clang = 3. We also added the
-stdc++11 where possible. See
https://bugs.webkit.org/show_bug.cgi?id=109932

 Regards,
 Maciej
 
 
 
 
 
 
 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com
 wrote:
 
  
  Of course, I understand that. But there is a huge opportunity cost
  to webkit.
  The c++11 standard also rewrites the entire standard library. I have
  been using
  g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have
  tested is
  performing nearly like c code. If you take advantage of the
  performance enhancements
  in C++11, then you can realize impressive performance gains.
  
  I do understand the nature of the business. And I also understand
  that performance
  is huge moving forward, where resource constrained mobile platforms
  are significantly
  affected by performance issues. I suggest you'll see Blink moving
  aggressively to
  support C++11 moving forward. And I suggest it is in WebKit's long
  term interest to
  do so as well.
  
 
 As others have said, we are definitely eager to use C++11 across the
 board but are limited by compiler support requirements.
 
 
 One thing that it would be useful to know: what are the compilers and
 minimum required versions used for in-tree ports? Perhaps we could
 record this so we can regularly evaluate which features are safe to
 use and what the blockers are to wholesale adoption, if any.
 
 
 Regards,
 Maciej
 
 
 
 
 
 
 
 
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=getsearch=0xF3D322D0EC4582C3


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Maciej Stachowiak

On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote:

 
 Of course, I understand that. But there is a huge opportunity cost to webkit.
 The c++11 standard also rewrites the entire standard library. I have been 
 using
 g++ 4.7.2 using -stdc++11 in my work with linux. And the code I have tested is
 performing nearly like c code. If you take advantage of the performance 
 enhancements
 in C++11, then you can realize impressive performance gains.
 
 I do understand the nature of the business. And I also understand that 
 performance
 is huge moving forward, where resource constrained mobile platforms are 
 significantly
 affected by performance issues. I suggest you'll see Blink moving 
 aggressively to
 support C++11 moving forward. And I suggest it is in WebKit's long term 
 interest to
 do so as well.

As others have said, we are definitely eager to use C++11 across the board but 
are limited by compiler support requirements.

One thing that it would be useful to know: what are the compilers and minimum 
required versions used for in-tree ports? Perhaps we could record this so we 
can regularly evaluate which features are safe to use and what the blockers are 
to wholesale adoption, if any.

Regards,
Maciej





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Benjamin Poulain
On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak m...@apple.com wrote:

 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com
 wrote:

 As others have said, we are definitely eager to use C++11 across the board
 but are limited by compiler support requirements.

 One thing that it would be useful to know: what are the compilers and
 minimum required versions used for in-tree ports? Perhaps we could record
 this so we can regularly evaluate which features are safe to use and what
 the blockers are to wholesale adoption, if any.


I think the worse thing we support right now is supporting MSVC 2005 (for
compiler support) and Windows XP (for library support).

From the CMake thread, I got that MSVC 2010 will soon be the oldest version
supported. Is that correct?

Benjamin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Roger Fong

 From the CMake thread, I got that MSVC 2010 will soon be the oldest version 
 supported. Is that correct?
 

It looks like that might be the case although I still need to test cmake on the 
AppleWin port to confirm that’s it’s okay.

Assuming that we do make use of cmake I’m still not quite sure yet about the 
“soon”.
We have one issue with the pthreads library being compiled in VS2005 that was 
blocking us from switching to VS2010 entirely.

We have a resolution for that issue on its way but it will be some time yet 
before it gets pushed out.
In the cmake thread, Patrick said that he had managed to get rid of the need 
for pthreads entirely to workaround that issue. 
If we can do that then yes I think “soon” would be accurate, but I’ll need to 
figure out what the impact of getting rid of pthreads is first.

Roger


On Apr 12, 2013, at 6:22 PM, Benjamin Poulain benja...@webkit.org wrote:

 On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak m...@apple.com wrote:
 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote:
 
 As others have said, we are definitely eager to use C++11 across the board 
 but are limited by compiler support requirements.
 
 One thing that it would be useful to know: what are the compilers and minimum 
 required versions used for in-tree ports? Perhaps we could record this so we 
 can regularly evaluate which features are safe to use and what the blockers 
 are to wholesale adoption, if any.
 
 I think the worse thing we support right now is supporting MSVC 2005 (for 
 compiler support) and Windows XP (for library support). 
 
 From the CMake thread, I got that MSVC 2010 will soon be the oldest version 
 supported. Is that correct?
 
 Benjamin
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] C++11 (was Re: on coding-style)

2013-04-12 Thread Patrick Gansterer
Am 13.04.2013 um 03:22 schrieb Benjamin Poulain:

 On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak m...@apple.com wrote:
 On Apr 12, 2013, at 4:09 PM, Karen Shaeffer shaef...@neuralscape.com wrote:
 
 As others have said, we are definitely eager to use C++11 across the board 
 but are limited by compiler support requirements.
 
 One thing that it would be useful to know: what are the compilers and minimum 
 required versions used for in-tree ports? Perhaps we could record this so we 
 can regularly evaluate which features are safe to use and what the blockers 
 are to wholesale adoption, if any.
 
 I think the worse thing we support right now is supporting MSVC 2005 (for 
 compiler support) and Windows XP (for library support). 
 
 From the CMake thread, I got that MSVC 2010 will soon be the oldest version 
 supported. Is that correct?

The oldest support compiler (with the most bugs) with an buildslave is the cl 
14 for ARM. It comes from Visual Studio 2005 for Windwos CE.
It would be great if we can try to keep it compiling with it until a newer 
version is available. The next version should support all C++11 features 
available in the desktop version [1] and will be available with Windows 
Embedded 2013 in Q2 [2].
I already try to keep the impact at an minimum for the trunk, but it's hard if 
you have a very bad compiler. E.g. the current trunk does not compile [3] due 
to a compiler bug (some problems with resolving friend classes correctly).

[1] 
http://blogs.msdn.com/b/windows-embedded/archive/2012/11/14/windows-embedded-compact-v-next-uncovered.aspx
[2] 
http://www.blogcdn.com/www.engadget.com/media/2012/11/windowsembeddedrolloutroadmapweb.jpg
[3] 
http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/33715/steps/compile-webkit/logs/stdio

-- Patrick
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev