Re: [webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

2011-10-25 Thread Edward O'Connor
Hi Fady,

You wrote:
 I've uploaded the parsing stage for the -webkit-aspect-ratio property
 that was proposed here:

 http://www.xanthir.com/blog/b4810
[…]
 I was wondering if anyone would be interested in reviewing this and
 getting this incorporated into WebKit?

I think we should wait until the aspect-ratio property is incorporated
into an Editor's Draft in the CSS WG before exposing an implementation
of it to Web content. Also, the CSS Image Values and Replaced Content
module already has an object-fit property[1] which WebKit doesn't yet
implement. We should probably make a pass at that before having a go at
something similar that's not even in an ED.


Ted

1. http://dev.w3.org/csswg/css3-images/#object-fit
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

2011-10-25 Thread Fady Samuel
Hi Edward,

Object fit doesn't solve quite the same problem. This property is meant to
work with all kinds of boxes, except table cells.

Fady

On Tue, Oct 25, 2011 at 2:23 PM, Edward O'Connor eocon...@apple.com wrote:

 Hi Fady,

 You wrote:
  I've uploaded the parsing stage for the -webkit-aspect-ratio property
  that was proposed here:
 
  http://www.xanthir.com/blog/b4810
 […]
  I was wondering if anyone would be interested in reviewing this and
  getting this incorporated into WebKit?

 I think we should wait until the aspect-ratio property is incorporated
 into an Editor's Draft in the CSS WG before exposing an implementation
 of it to Web content. Also, the CSS Image Values and Replaced Content
 module already has an object-fit property[1] which WebKit doesn't yet
 implement. We should probably make a pass at that before having a go at
 something similar that's not even in an ED.


 Ted

 1. http://dev.w3.org/csswg/css3-images/#object-fit
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

2011-10-23 Thread Fady Samuel
Hi all,

I've uploaded the parsing stage for the -webkit-aspect-ratio property that
was proposed here:

http://www.xanthir.com/blog/b4810

The parsing implementation can be found here:

https://bugs.webkit.org/show_bug.cgi?id=70707

An old, experimental implementation of the entire feature was uploaded last
year:

https://bugs.webkit.org/show_bug.cgi?id=47738

and discussed here:

http://lists.w3.org/Archives/Public/www-style/2010Oct/0046.html

http://lists.w3.org/Archives/Public/www-style/2011Oct/0550.html

I was wondering if anyone would be interested in reviewing this and getting
this incorporated into WebKit?

Thanks,

Fady
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev