Re: [webkit-dev] CSS Parse error in element.

2017-02-21 Thread Atul Sowani
I compared the code of TP5 with the code of default qtwebkit in PhantomJS and did not find any difference. So I think PhantomJS is making use of the latest version of QtWebKit. On Fri, Feb 17, 2017 at 4:04 PM, Konstantin Tokarev wrote: > > > 17.02.2017, 12:19, "Atul Sowani"

Re: [webkit-dev] CSS Parse error in element.

2017-02-17 Thread Konstantin Tokarev
17.02.2017, 12:19, "Atul Sowani" : > I built the debug-mode binary and verified on x86_64 that I am seeing exactly > the same crashes (due to enabled asserts) as seen on ppc64le. That's what I've expected. > > On ppc64le, on the other hand, with release-mode binary, webpage

Re: [webkit-dev] CSS Parse error in element.

2017-02-17 Thread Atul Sowani
I built the debug-mode binary and verified on x86_64 that I am seeing exactly the same crashes (due to enabled asserts) as seen on ppc64le. On ppc64le, on the other hand, with release-mode binary, webpage is loaded without issues. Only difference in behavior is seen in winding down of heap

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Konstantin Tokarev
  15.02.2017, 11:40, "Atul Sowani" :Hi, I am wondering about the behavioural difference of the same code on two different platforms, under same conditions. For example, consider following code in css/CSSCalculationValue.cpp (under class CSSCalcBinaryOperation): static

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Atul Sowani
Hi, I am wondering about the behavioural difference of the same code on two different platforms, under same conditions. For example, consider following code in css/CSSCalculationValue.cpp (under class CSSCalcBinaryOperation): static PassRefPtr create(PassRefPtr leftSide, PassRefPtr

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
@Konstantin Thanks for the update and it is definitely relieving to know that those were known issues and have been fixed in later version of QtWebKit. I will work with PhantomJS maintainers to get the QtWebKit version upgraded in the latest PhantomJS version. Thanks! On Mon, Feb 13, 2017 at

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Konstantin Tokarev
13.02.2017, 11:52, "Atul Sowani" : > I am using Qt 5.5.1. It ships with obsolete WebKit version based on trunk from 2013. Indeed it is known to have assertion failures related to calc like those you've posted, which were fixed since that times. Please upgrade to QtWebKit

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
I have been debugging on the CSS Parser issue and what I observed is similar to issue described at http://stackoverflow.com/questions/27256849/it-is-possible-to-use-vh-minus-pixels-in-a-css-calc For example, the CSS parser is crashing while processing following: height:calc(100vh - 200px) I

Re: [webkit-dev] CSS Parse error in element.

2017-02-13 Thread Atul Sowani
I am using Qt 5.5.1. On Thu, Feb 9, 2017 at 10:15 PM, Simon Fraser wrote: > What WebKit revision are your sources based on? It's quite likely the this > bug has been fixed. > > Simon > > On Feb 9, 2017, at 4:09 AM, Atul Sowani wrote: > > Finally I

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Simon Fraser
What WebKit revision are your sources based on? It's quite likely the this bug has been fixed. Simon > On Feb 9, 2017, at 4:09 AM, Atul Sowani wrote: > > Finally I zeroed in on 3 "calc" candidates from the stylesheet which are > causing the CSS parser to fail: > >

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Atul Sowani
Finally I zeroed in on 3 "calc" candidates from the stylesheet which are causing the CSS parser to fail: height:calc(100vh - 200px) height:calc(100vh - 230px) max-height:calc(100vh - 200px) I think it is the very first one and the remaining two never get processed. I put in some debug

Re: [webkit-dev] CSS Parse error in element.

2017-02-09 Thread Atul Sowani
@Konstantin thanks for the suggestions. I disabled CSS JIT on x85 but there was no negative impact on the results on x86. So I guess the issue is a genuine ppc64le problem. I have picked up the starting points mentioned in this thread earlier and debugging the issue. I have also isolated the issue

Re: [webkit-dev] CSS Parse error in element.

2017-02-07 Thread Konstantin Tokarev
07.02.2017, 12:55, "Atul Sowani" : > Thanks Geoffrey, Alex, Yoav for the debugging pointer. I am debugging the > issue further using this information and will most likely need some more help > in immediate future as well. > > Unfortunately, I don't have a stand-alone test

Re: [webkit-dev] CSS Parse error in element.

2017-02-07 Thread Atul Sowani
Thanks Geoffrey, Alex, Yoav for the debugging pointer. I am debugging the issue further using this information and will most likely need some more help in immediate future as well. Unfortunately, I don't have a stand-alone test case which can be tested with qtwebkit. I am trying to load a page

Re: [webkit-dev] CSS Parse error in element.

2017-02-06 Thread Yoav Weiss
Hi Atul, I second Alex's suggestion (perhaps followed by HTMLLinkElement::process() and other places in that file that refer to `hrefAttr`). If you have a test case online, I could try to take a look and maybe provide more guidance. Cheers :) Yoav On Fri, Feb 3, 2017 at 9:19 PM Alex Christensen

Re: [webkit-dev] CSS Parse error in element.

2017-02-03 Thread Alex Christensen
I would start looking at HTMLLinkElement::parseAttribute. LinkHeader.cpp contains parsers for link headers, which are related. Yoav knows more about those. Those parsers ought to be united more. > On Feb 3, 2017, at 1:17 AM, Atul Sowani wrote: > > At present I am focusing

Re: [webkit-dev] CSS Parse error in element.

2017-02-03 Thread Geoffrey Garen
+Alex > On Feb 3, 2017, at 1:17 AM, Atul Sowani wrote: > > At present I am focusing on CSSParser::findURI() particularly and > CSSParser::realLex() other related functionality in CSSParser.cpp - hope I am > on right track. ;-) > > Please let me know if I should be looking

Re: [webkit-dev] CSS Parse error in element.

2017-02-03 Thread Atul Sowani
At present I am focusing on CSSParser::findURI() particularly and CSSParser::realLex() other related functionality in CSSParser.cpp - hope I am on right track. ;-) Please let me know if I should be looking at some other functionality as well to resolve this issue. Thanks! Atul. On Fri, Feb 3,

[webkit-dev] CSS Parse error in element.

2017-02-03 Thread Atul Sowani
Hi, I came across an issue in qtwebkit CSS parser while working on a PhantomJS crash. The issue seems to be with parsing of type elements in an HTML page. What I observed is that the parser is trying to interpret the value for href given inside double-quotes. The value contains a "-" (e.g.