Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-02 Thread Ryosuke Niwa
On Fri, Apr 1, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: Can we show the list of failing layout tests in buildbot's waterfall display so we don't have to click through to the results.html file? Also, can we change the [view results] link so that it goes directly to results.html

Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-02 Thread Adam Roben
On Apr 2, 2011, at 4:59 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 1, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: Can we show the list of failing layout tests in buildbot's waterfall display so we don't have to click through to the results.html file? Also, can we change

Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-02 Thread Osztrogonac Csaba
Ryosuke Niwa írta: What if DRT was killed and there was no result.html? (e.g. if more than 20+ tests crash, we bail out early and there won't be result.html). old-run-webkit-tests always generates results.html even if DRT crashes. br, Ossy ___

[webkit-dev] Can we show failing test list on waterfall?

2011-04-01 Thread Adam Barth
Hi Bill, Can we show the list of failing layout tests in buildbot's waterfall display so we don't have to click through to the results.html file? Also, can we change the [view results] link so that it goes directly to results.html instead of the directory listing? Personally, I always click

Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-01 Thread Osztrogonac Csaba
Hi Adam, I think it is a good idea. I always check results.html too, so I'd would be great if we had to click only once. ;) It is a very simple patch to fix the url: (master.cfg) -url = self.build.getProperties().render(self.resultDirectory).replace(public_html/, /) +url =

Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-01 Thread Osztrogonac Csaba
Adam Barth írta: Cool. Looks like Ossy is going to write a patch. Yes sir, I filed a bug report, and uploaded the proposed patch: https://bugs.webkit.org/show_bug.cgi?id=57671 br, Ossy ___ webkit-dev mailing list webkit-dev@lists.webkit.org